)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"87d9a33587b452cb8434e474cd3f46e877861a7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da960407_a21c3f38","updated":"2026-03-25 21:33:50.000000000","message":"Looks good for the most part - One comment inline, please take a look at it :)","commit_id":"d8620442c2acaaf137aeec24c6bcfe63d8ba52b0"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"0cedcc566c74b07d2ccb0ca45aa12b1531ed7e3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f653b788_63ae7908","updated":"2026-03-25 10:02:16.000000000","message":"run-NetApp CI","commit_id":"d8620442c2acaaf137aeec24c6bcfe63d8ba52b0"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"e68711fe3b33b27b7f84515a930e3dc9a9cb67d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ed89a4c_78714b9f","updated":"2026-03-30 11:10:44.000000000","message":"Hi Carlos and Goutham,  \n\nJust following up on this patch. I’ve addressed the previous comment and uploaded patch set 2. I’d appreciate your feedback when you have a moment or let me know if there’s anything else I should update.  \n\nThanks!","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"650f2d8dd14d064901ebe908f4d5bed87bbe98b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bf3e4f49_d8e18c21","updated":"2026-03-26 05:17:09.000000000","message":"Thank you for the review. I\u0027ve addressed the comment. Please take another look when you get a chance.","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"d87f64452990a9cf730c481c0b04ffcc06cdda00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"40ebc8c0_19b8096f","updated":"2026-04-02 18:42:48.000000000","message":"run-NetApp CI","commit_id":"65e0f6a5a7ad0e2cf0932cef0155c3fac9940b0f"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"905c7e109062fed4effb4cb937702bddfe38c69b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6dca5984_4c81119c","updated":"2026-04-13 16:06:41.000000000","message":"run-NetApp CI","commit_id":"226fc7e0a5c4d19112f9ca0c6a160cc7c08e997d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3c629c5ec21004bd5932b407cd84ff05955506c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e7bd9a6e_d221ab78","updated":"2026-07-15 15:29:16.000000000","message":"LGTM, thanks Silvia. One comment inline, please take a look","commit_id":"71702d399332cf60c0dcc063f8a82f0c5a03325f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2bbe266d19467d2ec764bb2ab08416b0a06d635","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c178f6a9_b2f26d69","updated":"2026-07-15 15:28:26.000000000","message":"this has a merge conflict with: https://review.opendev.org/c/openstack/manila/+/984020 - I do favor this change though","commit_id":"71702d399332cf60c0dcc063f8a82f0c5a03325f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"815d2e195bfe58d06494dafde984faf7860c4d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa408d6c_a2d72231","updated":"2026-07-15 19:40:23.000000000","message":"LGTM, thanks Silvia!","commit_id":"da2b0d8f9f3be83be26d384ba29b13a6a280aba4"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"1e18d6b98b1558954bf834086f8638696e3abe96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"85633fcd_376a8fec","updated":"2026-07-15 19:34:09.000000000","message":"Looks good, and thank you for adding the missing subnet metadata field.","commit_id":"da2b0d8f9f3be83be26d384ba29b13a6a280aba4"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"87d9a33587b452cb8434e474cd3f46e877861a7c","unresolved":true,"context_lines":[{"line_number":3603,"context_line":"  type: integer"},{"line_number":3604,"context_line":"share_network_subnet_metadata:"},{"line_number":3605,"context_line":"  description: |"},{"line_number":3606,"context_line":"    One or more metadata key and value pairs as a dictionary of strings available from v2.78+"},{"line_number":3607,"context_line":"  in: body"},{"line_number":3608,"context_line":"  required: false"},{"line_number":3609,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1737e552_5c05cac7","line":3606,"range":{"start_line":3606,"start_character":72,"end_line":3606,"end_character":93},"updated":"2026-03-25 21:33:50.000000000","message":"nit: please wrap this in 79 characters per line, but this is not necessary in the text. The min_version should do it","commit_id":"d8620442c2acaaf137aeec24c6bcfe63d8ba52b0"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"e68711fe3b33b27b7f84515a930e3dc9a9cb67d4","unresolved":false,"context_lines":[{"line_number":3603,"context_line":"  type: integer"},{"line_number":3604,"context_line":"share_network_subnet_metadata:"},{"line_number":3605,"context_line":"  description: |"},{"line_number":3606,"context_line":"    One or more metadata key and value pairs as a dictionary of strings available from v2.78+"},{"line_number":3607,"context_line":"  in: body"},{"line_number":3608,"context_line":"  required: false"},{"line_number":3609,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cadb3050_6711b19d","line":3606,"range":{"start_line":3606,"start_character":72,"end_line":3606,"end_character":93},"in_reply_to":"10a3a5ae_8c97818c","updated":"2026-03-30 11:10:44.000000000","message":"Done","commit_id":"d8620442c2acaaf137aeec24c6bcfe63d8ba52b0"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"650f2d8dd14d064901ebe908f4d5bed87bbe98b6","unresolved":true,"context_lines":[{"line_number":3603,"context_line":"  type: integer"},{"line_number":3604,"context_line":"share_network_subnet_metadata:"},{"line_number":3605,"context_line":"  description: |"},{"line_number":3606,"context_line":"    One or more metadata key and value pairs as a dictionary of strings available from v2.78+"},{"line_number":3607,"context_line":"  in: body"},{"line_number":3608,"context_line":"  required: false"},{"line_number":3609,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"10a3a5ae_8c97818c","line":3606,"range":{"start_line":3606,"start_character":72,"end_line":3606,"end_character":93},"in_reply_to":"1737e552_5c05cac7","updated":"2026-03-26 05:17:09.000000000","message":"Done, thank you!","commit_id":"d8620442c2acaaf137aeec24c6bcfe63d8ba52b0"}],"api-ref/source/samples/share-network-add-security-service-response-with-subnets.json":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3c629c5ec21004bd5932b407cd84ff05955506c","unresolved":true,"context_lines":[{"line_number":20,"context_line":"                \"network_type\": \"flat\","},{"line_number":21,"context_line":"                \"mtu\": 1500,"},{"line_number":22,"context_line":"                \"gateway\": \"172.24.5.1\","},{"line_number":23,"context_line":"                \"metadata\": {}"},{"line_number":24,"context_line":"            }"},{"line_number":25,"context_line":"        ]"},{"line_number":26,"context_line":"    }"}],"source_content_type":"application/json","patch_set":5,"id":"4c2b64f9_ef7c79dc","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":30},"updated":"2026-07-15 15:29:16.000000000","message":"maybe we could add a key value inside the dict for the reference?","commit_id":"71702d399332cf60c0dcc063f8a82f0c5a03325f"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"d37a52e99dc075b5b2dff01537365ee1160d86ec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"                \"network_type\": \"flat\","},{"line_number":21,"context_line":"                \"mtu\": 1500,"},{"line_number":22,"context_line":"                \"gateway\": \"172.24.5.1\","},{"line_number":23,"context_line":"                \"metadata\": {}"},{"line_number":24,"context_line":"            }"},{"line_number":25,"context_line":"        ]"},{"line_number":26,"context_line":"    }"}],"source_content_type":"application/json","patch_set":5,"id":"3723a190_18570468","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":30},"in_reply_to":"4c2b64f9_ef7c79dc","updated":"2026-07-15 17:14:20.000000000","message":"I\u0027ve updated the metadata field to include an example key-value pair ({\"key1\": \"value1\"})","commit_id":"71702d399332cf60c0dcc063f8a82f0c5a03325f"}],"api-ref/source/share-network-subnets.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7ed9f4192e04c9ca8f3f62766376592f92db0b34","unresolved":true,"context_lines":[{"line_number":90,"context_line":"   - network_type: share_network_subnet_network_type"},{"line_number":91,"context_line":"   - gateway: share_network_subnet_gateway"},{"line_number":92,"context_line":"   - mtu: share_network_subnet_mtu"},{"line_number":93,"context_line":"   - metadata: share_network_subnet_metadata"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Response example"},{"line_number":96,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"92ed6ff6_d18845fa","line":93,"updated":"2026-07-13 16:23:13.000000000","message":"The `metadata` parameter is listed in the response parameters here, but the corresponding sample JSON files don\u0027t include it:\n\n- `samples/share-network-subnet-list-response.json`\n- `samples/share-network-subnet-show-response.json`\n- `samples/share-network-subnet-create-response.json`\n\nPlease add `\"metadata\": {}` to the subnet objects in these 3 files, matching what was done for the 6 share-network response samples.","commit_id":"226fc7e0a5c4d19112f9ca0c6a160cc7c08e997d"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"20fbe7b68701f2a69562b1a92a0896cde1d683d9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"   - network_type: share_network_subnet_network_type"},{"line_number":91,"context_line":"   - gateway: share_network_subnet_gateway"},{"line_number":92,"context_line":"   - mtu: share_network_subnet_mtu"},{"line_number":93,"context_line":"   - metadata: share_network_subnet_metadata"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Response example"},{"line_number":96,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"fbc5e5bf_5b711a79","line":93,"in_reply_to":"92ed6ff6_d18845fa","updated":"2026-07-15 16:39:09.000000000","message":"Hi Goutham I\u0027ve added \"metadata\": {} to the subnet objects in all three files.","commit_id":"226fc7e0a5c4d19112f9ca0c6a160cc7c08e997d"}],"api-ref/source/share-networks.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0dccc24b618e91cba1e425238c018a9055a82ed","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"d1d9123e_fc0f05f5","line":1,"updated":"2026-03-31 21:15:49.000000000","message":"The metadata field is not a top-level share network response field.\nIt is nested inside each subnet object within the\nshare_network_subnets array (see manila/api/views/share_networks.py\nadd_subnet_with_metadata). The current documentation placement\nmisrepresents the API structure.","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a0dccc24b618e91cba1e425238c018a9055a82ed","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"4f3bce59_33bc2aac","line":1,"updated":"2026-03-31 21:15:49.000000000","message":"The sample response JSON files (e.g. share-network-show-response-with-subnets.json)\nalso need \"metadata\": {} added inside each subnet object to match the\nactual API response.","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"636dc528a84bb033b855ce51404923894d103094","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"b082c3e1_2a2558cc","line":1,"in_reply_to":"4f3bce59_33bc2aac","updated":"2026-03-31 23:58:08.000000000","message":"Hi Goutham, I\u0027ve removed the metadata field from the top-level share network response and added it to share-network-subnets.inc instead, but I\u0027m getting a \u0027Parameters file not found\u0027 build error. Could you advise on the correct approach?","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"2ca5b497c2dee1ad0658e19fd81ba933f1ec5330","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"e4056bca_c0c719f1","line":1,"in_reply_to":"b082c3e1_2a2558cc","updated":"2026-04-02 18:29:06.000000000","message":"Resolved — the build error was caused by a wrong parameter key name and a blank line breaking the RST directive. Both are fixed in patchset 3.","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"2ca5b497c2dee1ad0658e19fd81ba933f1ec5330","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"a5e976ba_f9fbb828","line":1,"in_reply_to":"b3d66532_24ce2838","updated":"2026-04-02 18:29:06.000000000","message":"Done","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"b6c0b793c677d3ef498eaa3135cc73bf5a9f0393","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"b3d66532_24ce2838","line":1,"in_reply_to":"d1d9123e_fc0f05f5","updated":"2026-04-02 18:27:33.000000000","message":"Fixed in patchset 3 — \"metadata\": {} has been added inside each subnet object in all 6 sample JSON files.","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"60268c02b0e90172c6cd82948752a97c572b6298","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Share networks"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"cc63a1e8_4718969a","line":1,"in_reply_to":"e4056bca_c0c719f1","updated":"2026-04-02 18:29:19.000000000","message":"Done","commit_id":"acc11aa4cf8aeef86e8626fffa10cbcf50528e72"}]}