)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b8486c0fd37548924a02552f6096ceb12fe11850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d91888ce_2efd0957","updated":"2026-03-26 19:58:51.000000000","message":"Thanks for the review, please take another look :)","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e2aef6a6848c2f0ed47bf10a075adc5757901921","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"252f4fd1_90e71066","updated":"2026-03-26 19:18:20.000000000","message":"please also add a reno with your next patch","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa57fc5505fed301b1c3e1c49f0da16a57a4b92b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0760f21_f227cef3","updated":"2026-03-26 20:01:01.000000000","message":"LGTM, thanks Carlos!","commit_id":"5736aa98b684165b90ea76c14bab6816775a44d3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cfba10fe53ce0366e8d4767f1a52a648bc8e300c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d250cee_4d2a2d45","updated":"2026-03-26 20:20:09.000000000","message":"LGTM, thank you","commit_id":"26c4245b328ccd91ad269c9dd215170ebc65b1e2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c3daea33fc7d0351bb5ad7841def3f4d4c8913b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ed8b9f3c_fc029cb3","updated":"2026-03-27 16:25:37.000000000","message":"Let\u0027s get this in and unblock CI. Thanks for the reviews!","commit_id":"26c4245b328ccd91ad269c9dd215170ebc65b1e2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"63389a49201786240e8253c440fedcc5683a4503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a947c620_97cd08e1","updated":"2026-03-30 12:19:48.000000000","message":"recheck","commit_id":"26c4245b328ccd91ad269c9dd215170ebc65b1e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab21b620571ef14bf7f170386624662c3a38c1f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"346e474d_2cef985d","updated":"2026-03-27 07:43:28.000000000","message":"recheck\n\nparent updated","commit_id":"26c4245b328ccd91ad269c9dd215170ebc65b1e2"}],"manila/api/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbd48cfa2b04b933ca06ecf59997f44355d7e98b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        status \u003d filters.get(\u0027status\u0027)"},{"line_number":58,"context_line":"        valid_statuses \u003d [constants.STATUS_DISABLED, constants.STATUS_ENABLED]"},{"line_number":59,"context_line":"        if status and status not in valid_statuses:"},{"line_number":60,"context_line":"            # NOTE(carloss): Let\u0027s maintain backwards compatibility. If the"},{"line_number":61,"context_line":"            # status provided doesn\u0027t exist, it is not a bad request, only a"},{"line_number":62,"context_line":"            # user mistake."}],"source_content_type":"text/x-python","patch_set":1,"id":"c5e0e677_bf7b1d49","line":59,"updated":"2026-03-26 19:16:52.000000000","message":"The `support_filtering_by_ensure` parameter is now only used for the `ensuring` filter check on line 54. Consider updating the docstring or adding a brief comment clarifying that this parameter controls only the `ensuring` filter passthrough, not the status validation — since the status branching that previously depended on it has been removed.\n\nNot blocking — just a readability suggestion.","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f806b45910ddae1846e364ad5f4c0785afb3860f","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # NOTE(carloss): Let\u0027s maintain backwards compatibility. If the"},{"line_number":61,"context_line":"            # status provided doesn\u0027t exist, it is not a bad request, only a"},{"line_number":62,"context_line":"            # user mistake."},{"line_number":63,"context_line":"            msg \u003d _(\"An invalid status was provided. Please choose from \""},{"line_number":64,"context_line":"                    \"one of the valid statuses while filtering services: \""},{"line_number":65,"context_line":"                    \"%s.\") % valid_statuses"},{"line_number":66,"context_line":"            LOG.error(msg)"},{"line_number":67,"context_line":"            return self._view_builder.detail_list(req, [])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"c27d1b56_2651bdbb","line":66,"range":{"start_line":63,"start_character":12,"end_line":66,"end_character":26},"updated":"2026-03-26 19:18:09.000000000","message":"don\u0027t know why we\u0027d log this.. Do we expect the admin to do anything about this? maybe debug, or warning level is more appropriate?","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b8486c0fd37548924a02552f6096ceb12fe11850","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            # NOTE(carloss): Let\u0027s maintain backwards compatibility. If the"},{"line_number":61,"context_line":"            # status provided doesn\u0027t exist, it is not a bad request, only a"},{"line_number":62,"context_line":"            # user mistake."},{"line_number":63,"context_line":"            msg \u003d _(\"An invalid status was provided. Please choose from \""},{"line_number":64,"context_line":"                    \"one of the valid statuses while filtering services: \""},{"line_number":65,"context_line":"                    \"%s.\") % valid_statuses"},{"line_number":66,"context_line":"            LOG.error(msg)"},{"line_number":67,"context_line":"            return self._view_builder.detail_list(req, [])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"03b7e592_f0d1274c","line":66,"range":{"start_line":63,"start_character":12,"end_line":66,"end_character":26},"in_reply_to":"c27d1b56_2651bdbb","updated":"2026-03-26 19:58:51.000000000","message":"Yeah, warning is more appropriate. Changed it.","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"}],"manila/tests/api/v2/test_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbd48cfa2b04b933ca06ecf59997f44355d7e98b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":279,"context_line":"            req.environ[\u0027manila.context\u0027], self.resource_name, \u0027index\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @ddt.data((\u0027available\u0027, FILTERING_BY_ENSURE_VERSION),"},{"line_number":282,"context_line":"              (\u0027migrating\u0027, \u00272.85\u0027))"},{"line_number":283,"context_line":"    @ddt.unpack"},{"line_number":284,"context_line":"    def test_services_list_invalid_status(self, status, version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"16901d29_41d36ad2","line":281,"updated":"2026-03-26 19:16:52.000000000","message":"The ddt data covers versions 2.93 (FILTERING_BY_ENSURE_VERSION) and 2.85, which tests both pre- and post-2.93 behavior. Good coverage of the fix. Consider adding a brief inline comment noting that 2.93 is the version where the regression existed, to make the test\u0027s intent clearer to future readers.","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f806b45910ddae1846e364ad5f4c0785afb3860f","unresolved":true,"context_lines":[{"line_number":278,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":279,"context_line":"            req.environ[\u0027manila.context\u0027], self.resource_name, \u0027index\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @ddt.data((\u0027available\u0027, FILTERING_BY_ENSURE_VERSION),"},{"line_number":282,"context_line":"              (\u0027migrating\u0027, \u00272.85\u0027))"},{"line_number":283,"context_line":"    @ddt.unpack"},{"line_number":284,"context_line":"    def test_services_list_invalid_status(self, status, version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"25e25cd0_e49b8442","line":281,"in_reply_to":"16901d29_41d36ad2","updated":"2026-03-26 19:18:09.000000000","message":"or just drop the ddt and set the invalid status directly inline","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b8486c0fd37548924a02552f6096ceb12fe11850","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        self.mock_policy_check.assert_called_once_with("},{"line_number":279,"context_line":"            req.environ[\u0027manila.context\u0027], self.resource_name, \u0027index\u0027)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    @ddt.data((\u0027available\u0027, FILTERING_BY_ENSURE_VERSION),"},{"line_number":282,"context_line":"              (\u0027migrating\u0027, \u00272.85\u0027))"},{"line_number":283,"context_line":"    @ddt.unpack"},{"line_number":284,"context_line":"    def test_services_list_invalid_status(self, status, version):"}],"source_content_type":"text/x-python","patch_set":1,"id":"074f68c1_289f85b4","line":281,"in_reply_to":"25e25cd0_e49b8442","updated":"2026-03-26 19:58:51.000000000","message":"Done","commit_id":"4887d28c6163d75ba9d1e8923ba9e005c605d5d3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa57fc5505fed301b1c3e1c49f0da16a57a4b92b","unresolved":true,"context_lines":[{"line_number":284,"context_line":"    def test_services_list_invalid_status(self, status, version):"},{"line_number":285,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027services?status\u003d%s\u0027 % status,"},{"line_number":286,"context_line":"                                      version\u003dversion)"},{"line_number":287,"context_line":"        # We\u0027ve introduced a regression in API version 2.93, so now we need to"},{"line_number":288,"context_line":"        # ensure that the behavior is unchanged."},{"line_number":289,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d self.context"},{"line_number":290,"context_line":"        mock_log_warning \u003d self.mock_object(services.LOG, \u0027warning\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7292f341_a1bb8959","line":287,"range":{"start_line":287,"start_character":10,"end_line":287,"end_character":15},"updated":"2026-03-26 20:01:01.000000000","message":"```suggestion\n        # We had introduced a regression in API version 2.93, so now we need to\n```","commit_id":"5736aa98b684165b90ea76c14bab6816775a44d3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8689a321e4fa6800cfa8e1ba32270be6ab32e7f3","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    def test_services_list_invalid_status(self, status, version):"},{"line_number":285,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027services?status\u003d%s\u0027 % status,"},{"line_number":286,"context_line":"                                      version\u003dversion)"},{"line_number":287,"context_line":"        # We\u0027ve introduced a regression in API version 2.93, so now we need to"},{"line_number":288,"context_line":"        # ensure that the behavior is unchanged."},{"line_number":289,"context_line":"        req.environ[\u0027manila.context\u0027] \u003d self.context"},{"line_number":290,"context_line":"        mock_log_warning \u003d self.mock_object(services.LOG, \u0027warning\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"92b20cca_2c75e27e","line":287,"range":{"start_line":287,"start_character":10,"end_line":287,"end_character":15},"in_reply_to":"7292f341_a1bb8959","updated":"2026-03-26 20:12:53.000000000","message":"Done","commit_id":"5736aa98b684165b90ea76c14bab6816775a44d3"}]}