)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfa8eda48f33e9c3cf6050aab5160278c1755a99","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test for delete_share unexpected backend exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1989472"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I62bf10c02982371347d4c0ddfeaa7c970239b551"},{"line_number":12,"context_line":"Signed-off-by: olamidepeterojo \u003cpeterojoolamide@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7e322213_45787863","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":6},"updated":"2026-04-06 21:32:01.000000000","message":"Partial-Bug\n\n\nBecause you\u0027re not adding all the remaining test coverage.","commit_id":"139f4b292c70a33196fba9e7196b9a8c9904c316"}],"manila/tests/share/drivers/cephfs/test_driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b73d08c7870cf9177ed90483a5e2f40986d8610","unresolved":true,"context_lines":[{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"            self.assertEqual(\"group-1\", argdict[\"group_name\"])"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def test_raise_unexpected_backend_exception(self):"},{"line_number":1350,"context_line":"        self._driver.volname \u003d \"fsvolume\""},{"line_number":1351,"context_line":"        share \u003d {\"id\": \"share-id\", \"share_group_id\": None}"},{"line_number":1352,"context_line":"        with mock.patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"2e660a2e_9f8d6343","line":1349,"updated":"2026-03-31 21:15:24.000000000","message":"Test name should indicate which method is being tested, consistent\nwith class convention. Suggest: test_delete_share_raises_unexpected_backend_exception","commit_id":"bf93a619f4c14d6c59e39cba2e0f409020ae3fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfa8eda48f33e9c3cf6050aab5160278c1755a99","unresolved":false,"context_lines":[{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"            self.assertEqual(\"group-1\", argdict[\"group_name\"])"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def test_raise_unexpected_backend_exception(self):"},{"line_number":1350,"context_line":"        self._driver.volname \u003d \"fsvolume\""},{"line_number":1351,"context_line":"        share \u003d {\"id\": \"share-id\", \"share_group_id\": None}"},{"line_number":1352,"context_line":"        with mock.patch("}],"source_content_type":"text/x-python","patch_set":4,"id":"37dfac55_00ee71e5","line":1349,"in_reply_to":"2e660a2e_9f8d6343","updated":"2026-04-06 21:32:01.000000000","message":"Done","commit_id":"bf93a619f4c14d6c59e39cba2e0f409020ae3fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b73d08c7870cf9177ed90483a5e2f40986d8610","unresolved":true,"context_lines":[{"line_number":1349,"context_line":"    def test_raise_unexpected_backend_exception(self):"},{"line_number":1350,"context_line":"        self._driver.volname \u003d \"fsvolume\""},{"line_number":1351,"context_line":"        share \u003d {\"id\": \"share-id\", \"share_group_id\": None}"},{"line_number":1352,"context_line":"        with mock.patch("},{"line_number":1353,"context_line":"            \"manila.share.drivers.cephfs.driver.rados\""},{"line_number":1354,"context_line":"        ) as mock_rados_mod, mock.patch.object("},{"line_number":1355,"context_line":"            self._driver, \"_get_subvolume_name\", return_value\u003d\"clone-name\""}],"source_content_type":"text/x-python","patch_set":4,"id":"c4f54bac_928f604b","line":1352,"updated":"2026-03-31 21:15:24.000000000","message":"The mock.patch(\"manila.share.drivers.cephfs.driver.rados\") context\nmanager is unnecessary. setUp already mocks driver.rados with\nMockRadosModule. Since _need_to_cancel_clone is patched to return\nFalse, the except rados.Error branch is never entered. Simplify to\nmatch the pattern used by existing tests like\ntest_delete_share_share_does_not_exist (line 745).","commit_id":"bf93a619f4c14d6c59e39cba2e0f409020ae3fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfa8eda48f33e9c3cf6050aab5160278c1755a99","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"    def test_raise_unexpected_backend_exception(self):"},{"line_number":1350,"context_line":"        self._driver.volname \u003d \"fsvolume\""},{"line_number":1351,"context_line":"        share \u003d {\"id\": \"share-id\", \"share_group_id\": None}"},{"line_number":1352,"context_line":"        with mock.patch("},{"line_number":1353,"context_line":"            \"manila.share.drivers.cephfs.driver.rados\""},{"line_number":1354,"context_line":"        ) as mock_rados_mod, mock.patch.object("},{"line_number":1355,"context_line":"            self._driver, \"_get_subvolume_name\", return_value\u003d\"clone-name\""}],"source_content_type":"text/x-python","patch_set":4,"id":"a3c80d5f_e38cda22","line":1352,"in_reply_to":"c4f54bac_928f604b","updated":"2026-04-06 21:32:01.000000000","message":"Done","commit_id":"bf93a619f4c14d6c59e39cba2e0f409020ae3fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5b73d08c7870cf9177ed90483a5e2f40986d8610","unresolved":true,"context_lines":[{"line_number":1357,"context_line":"            self._driver, \"_need_to_cancel_clone\", return_value\u003dFalse"},{"line_number":1358,"context_line":"        ):"},{"line_number":1359,"context_line":"            mock_rados_mod.Error \u003d Exception"},{"line_number":1360,"context_line":"            driver.rados_command.side_effect \u003d exception.ShareBackendException("},{"line_number":1361,"context_line":"                \"Unexpected error\""},{"line_number":1362,"context_line":"            )"},{"line_number":1363,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4b29bac0_be0f356f","line":1360,"updated":"2026-03-31 21:15:24.000000000","message":"For consistency with existing tests (e.g., line 727), use\nexception.ShareBackendException(msg\u003d\"Unexpected error\") instead\nof the positional form.","commit_id":"bf93a619f4c14d6c59e39cba2e0f409020ae3fe4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dfa8eda48f33e9c3cf6050aab5160278c1755a99","unresolved":false,"context_lines":[{"line_number":1357,"context_line":"            self._driver, \"_need_to_cancel_clone\", return_value\u003dFalse"},{"line_number":1358,"context_line":"        ):"},{"line_number":1359,"context_line":"            mock_rados_mod.Error \u003d Exception"},{"line_number":1360,"context_line":"            driver.rados_command.side_effect \u003d exception.ShareBackendException("},{"line_number":1361,"context_line":"                \"Unexpected error\""},{"line_number":1362,"context_line":"            )"},{"line_number":1363,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1abae14b_6c2ff178","line":1360,"in_reply_to":"4b29bac0_be0f356f","updated":"2026-04-06 21:32:01.000000000","message":"Done","commit_id":"bf93a619f4c14d6c59e39cba2e0f409020ae3fe4"}]}