)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ebb02e0b2f98f8807cb676c12d7cf7d34541a4d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be2424e0_fb980f1a","updated":"2026-04-01 19:39:22.000000000","message":"THanks for the fix!","commit_id":"6140481bd8353ab1e8a06fe66372dee4fedb7ebc"}],"manila/api/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bbfe3fce4cb76db196fe6618fd547057ebb2c010","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        ensuring \u003d filters.get(\u0027ensuring\u0027)"},{"line_number":62,"context_line":"        if ensuring is not None:"},{"line_number":63,"context_line":"            try:"},{"line_number":64,"context_line":"                strutils.bool_from_string(ensuring, strict\u003dTrue)"},{"line_number":65,"context_line":"            except ValueError:"},{"line_number":66,"context_line":"                msg \u003d _(\"An invalid value was provided for \u0027ensuring\u0027. \""},{"line_number":67,"context_line":"                        \"Acceptable values are: \u0027true\u0027 or \u0027false\u0027.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"4d723cc3_2b2db6a7","line":64,"updated":"2026-03-31 05:44:52.000000000","message":"The validated value from `strutils.bool_from_string(ensuring, strict\u003dTrue)` is just checked, and discarded here. The DB layer at `api.py:619` calls `bool_from_string` again (without `strict\u003dTrue`). You could assign the result back into filters to avoid the redundant conversion:\n\n```python\nfilters[\u0027ensuring\u0027] \u003d strutils.bool_from_string(\n    ensuring, strict\u003dTrue)\n```\n\nAnd then update the DB layer to use `strict\u003dTrue` as well, so internal callers also get validation.","commit_id":"eb0001131b0ec9678bc64336128a81115759a2fd"},{"author":{"_account_id":38940,"name":"Oluwasola Akintewe","display_name":"nathan_akin","email":"solaakintewe@gmail.com","username":"nathan_akin"},"change_message_id":"19a3bcff07a31efacb7a83d1aa188cc74b06ce3a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        ensuring \u003d filters.get(\u0027ensuring\u0027)"},{"line_number":62,"context_line":"        if ensuring is not None:"},{"line_number":63,"context_line":"            try:"},{"line_number":64,"context_line":"                strutils.bool_from_string(ensuring, strict\u003dTrue)"},{"line_number":65,"context_line":"            except ValueError:"},{"line_number":66,"context_line":"                msg \u003d _(\"An invalid value was provided for \u0027ensuring\u0027. \""},{"line_number":67,"context_line":"                        \"Acceptable values are: \u0027true\u0027 or \u0027false\u0027.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"83709f32_07e3dc13","line":64,"in_reply_to":"4d723cc3_2b2db6a7","updated":"2026-04-01 10:45:04.000000000","message":"done, assigned the result back into filters and updated the DB layer to use strict\u003dTrue as well. thanks for the info","commit_id":"eb0001131b0ec9678bc64336128a81115759a2fd"}]}
