)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a680048a21220ed8f497af6c758b0067bd8fee4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e3a8a026_6640df1c","updated":"2026-04-02 12:11:53.000000000","message":"recheck","commit_id":"976ca6c2b491635b04549a086bc1da972e3ca5fd"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"ad726db9c84e3c3517a4d5798420d85ad367c0e2","unresolved":true,"context_lines":[{"line_number":3724,"context_line":"    if statuses is not None:"},{"line_number":3725,"context_line":"        query \u003d query.filter(models.ShareSnapshotInstance.status.in_(statuses))"},{"line_number":3726,"context_line":""},{"line_number":3727,"context_line":"    if host is not None:"},{"line_number":3728,"context_line":"        query \u003d query.join("},{"line_number":3729,"context_line":"            models.ShareInstance,"},{"line_number":3730,"context_line":"            models.ShareSnapshotInstance.share_instance_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":4,"id":"9bfe7796_757932d7","line":3727,"range":{"start_line":3727,"start_character":4,"end_line":3727,"end_character":23},"updated":"2026-05-26 15:39:35.000000000","message":"nit: A code comment at this point would be great to explain what the below join does. In first glance it looked complex.","commit_id":"f1647baafee661083124ce4410178e15a28c67fc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"19d026e0972656870e986b9adc44b39e0cdf3134","unresolved":false,"context_lines":[{"line_number":3724,"context_line":"    if statuses is not None:"},{"line_number":3725,"context_line":"        query \u003d query.filter(models.ShareSnapshotInstance.status.in_(statuses))"},{"line_number":3726,"context_line":""},{"line_number":3727,"context_line":"    if host is not None:"},{"line_number":3728,"context_line":"        query \u003d query.join("},{"line_number":3729,"context_line":"            models.ShareInstance,"},{"line_number":3730,"context_line":"            models.ShareSnapshotInstance.share_instance_id \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":4,"id":"10b7a139_71ba3035","line":3727,"range":{"start_line":3727,"start_character":4,"end_line":3727,"end_character":23},"in_reply_to":"9bfe7796_757932d7","updated":"2026-05-26 15:48:49.000000000","message":"The join is already used across share instance functions in same file e.g. _share_instance_get_all, share_instance_get_all_by_host etc.","commit_id":"f1647baafee661083124ce4410178e15a28c67fc"}]}