)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"2addf5a6e6532e9c79a9bd0a2a62b01277ed77e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f485558_e219d4ae","updated":"2026-04-08 06:07:10.000000000","message":"This test previously incurred real delay due to Tenacity’s retry backoff,\nwhich uses sleep between retries.\n\nMocking tenacity.nap.sleep avoids the delay while preserving retry behavior.\n\nFeedback is welcome, especially if there’s a preferred approach for handling\nretry-related delays in tests.","commit_id":"58e1386b756c2ae013ca5832c91e328de5583fa8"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"bf5c9069cb71736d8743d9383d21b7f5973d96ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"293989f1_538316a6","updated":"2026-04-08 08:05:17.000000000","message":"run-NetApp CI","commit_id":"58e1386b756c2ae013ca5832c91e328de5583fa8"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"39fe532185ea8b8e0cc865df716bc25a03ea7f0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e66d64fa_c023e632","updated":"2026-04-10 18:25:43.000000000","message":"run-NetApp CI","commit_id":"58e1386b756c2ae013ca5832c91e328de5583fa8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b52c1413e67c781ccb3e244e5ea693a2559043a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"268a04e7_c8ed74e8","updated":"2026-07-15 13:38:21.000000000","message":"LGTM, thanks Silvia","commit_id":"4d3c134e33b8dbd532d1760b5f9f307a84de02ab"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"d48609661e1e1691f0d8467d7c399e8b532f45f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"546f04ee_69b3cca6","updated":"2026-07-15 11:38:39.000000000","message":"LGTM.","commit_id":"4d3c134e33b8dbd532d1760b5f9f307a84de02ab"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"3d30f2719f8c6ca80a5a1c798b99fb3b329e7e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c34ca6b6_722fe529","updated":"2026-07-15 11:33:48.000000000","message":"Looks good, thanks the change fixes the slow unit test.","commit_id":"4d3c134e33b8dbd532d1760b5f9f307a84de02ab"}],"manila/tests/share/drivers/container/test_security_service_helper.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f1eb295be14617290b644857042fe0c4c215ef3b","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        with mock.patch(\u0027tenacity.nap.sleep\u0027, return_value\u003dNone):"},{"line_number":148,"context_line":"            self.assertRaises("},{"line_number":149,"context_line":"                exception.ShareBackendException,"},{"line_number":150,"context_line":"                self.security_service_helper.ldap_retry_operation,"},{"line_number":151,"context_line":"                mock_cmd,"},{"line_number":152,"context_line":"                run_as_root\u003dFalse,"},{"line_number":153,"context_line":"                timeout\u003d10)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d675dc40_87c673fa","line":150,"range":{"start_line":150,"start_character":45,"end_line":150,"end_character":65},"updated":"2026-04-14 20:52:08.000000000","message":"this operation is being tested in other tests as well, does it make sense to mock it globally?","commit_id":"4d3c134e33b8dbd532d1760b5f9f307a84de02ab"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"0e712151f0fd4d0ff7b94b40e35beaf818fba3a3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        with mock.patch(\u0027tenacity.nap.sleep\u0027, return_value\u003dNone):"},{"line_number":148,"context_line":"            self.assertRaises("},{"line_number":149,"context_line":"                exception.ShareBackendException,"},{"line_number":150,"context_line":"                self.security_service_helper.ldap_retry_operation,"},{"line_number":151,"context_line":"                mock_cmd,"},{"line_number":152,"context_line":"                run_as_root\u003dFalse,"},{"line_number":153,"context_line":"                timeout\u003d10)"}],"source_content_type":"text/x-python","patch_set":2,"id":"aeb87a98_290b7ded","line":150,"range":{"start_line":150,"start_character":45,"end_line":150,"end_character":65},"in_reply_to":"00609764_adb90254","updated":"2026-04-14 21:44:33.000000000","message":"Done","commit_id":"4d3c134e33b8dbd532d1760b5f9f307a84de02ab"},{"author":{"_account_id":38842,"name":"Silvia Wachira","display_name":"Silvia Wachira","email":"wachirasilvia8@gmail.com","username":"Silvia-Wachira"},"change_message_id":"753262a969beb143dc9cbb8c4546d34312ac7ab5","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        with mock.patch(\u0027tenacity.nap.sleep\u0027, return_value\u003dNone):"},{"line_number":148,"context_line":"            self.assertRaises("},{"line_number":149,"context_line":"                exception.ShareBackendException,"},{"line_number":150,"context_line":"                self.security_service_helper.ldap_retry_operation,"},{"line_number":151,"context_line":"                mock_cmd,"},{"line_number":152,"context_line":"                run_as_root\u003dFalse,"},{"line_number":153,"context_line":"                timeout\u003d10)"}],"source_content_type":"text/x-python","patch_set":2,"id":"00609764_adb90254","line":150,"range":{"start_line":150,"start_character":45,"end_line":150,"end_character":65},"in_reply_to":"d675dc40_87c673fa","updated":"2026-04-14 21:43:46.000000000","message":"Not really because the other tests don\u0027t hit tenacity.nap.sleep: test_ldap_retry_operation - command succeeds immediately, no retries test_ldap_retry_operation_invalid_credential - exit_code\u003d49 causes an immediate bail (confirmed by assert_called_once_with), no retry loop So the local mock is in the right place. I therefore think that a global mock here would serve no purpose.","commit_id":"4d3c134e33b8dbd532d1760b5f9f307a84de02ab"}]}