)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"131551845661de4ab5a749a2c9c5ca1a7d70acdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b120b34_97ba02fd","updated":"2026-04-08 13:54:33.000000000","message":"Hi Reviewers/stackers,\n\nI have tested this fix with both RHOSO/DevStack, working as expected. \n\nPlease do review. Thank you!!","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5d61566306d4ba89c56ee4fb61070b53b869b319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"054651ea_b6c07204","updated":"2026-04-08 14:55:36.000000000","message":"LGTM","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"226057a1fd24099de10547198c81e207c876dc83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ead9afea_a2a8df15","updated":"2026-04-08 14:42:19.000000000","message":"LGTM!","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"a568a68f63a95d785309a564014c12161d9d815d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b99543b_7734d65b","updated":"2026-04-10 13:12:43.000000000","message":"I have used get_secret_href method as suggested by Takashi.\n\nTested on both DevStack and RHOSO deployment and working as expected. \n\nTesting info: https://paste.opendev.org/show/b8L3zsa4AuN8lfTgOzL3/","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"c183c0593097611ba296de946f594ee75aaaa17b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"767ca5f4_0b463a8e","updated":"2026-04-15 07:13:15.000000000","message":"LGTM","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1d4dba4df1c0dae3ec49ada67b6403e5b05d9faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0da1bc9_a4b22eb7","updated":"2026-05-07 12:23:20.000000000","message":"Please check the comments once.","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"d7b903b34d5b2cf1fc1e7c4cb1265061eeb0777d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"105f7d79_1de6f347","updated":"2026-05-12 17:18:10.000000000","message":"LGTM","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4ac186a09f84cab6adc2c10696bd89a624aecccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cfac3a64_9e8f6f12","updated":"2026-05-12 13:09:19.000000000","message":"Thank you Anoop for flagging it. Removed the secret logging. Please do review and apporve.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"}],"manila/keymgr/barbican.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"528b339b86bb412d174f161e5f9dbeccc453bbec","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e4d3079_b96daceb","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"updated":"2026-04-08 15:26:00.000000000","message":"I think you should check self.conf.barbican.barbican_endpoint and use it to make the behavior consistent with the key-manager client.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"811ec7965fcd6c6f3e79c75dbac85d82ad3f5334","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f46df837_a75b732b","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"04fe92b2_85f41cb2","updated":"2026-04-08 15:49:20.000000000","message":"I just saw your second comment. My above reply was for only first comment!","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"a568a68f63a95d785309a564014c12161d9d815d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b32446ff_a8c10da7","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"099bfc8f_3592d690","updated":"2026-04-10 13:12:43.000000000","message":"Thank you so much Takashi. Really appreciate your suggestion. \n\nI have used get_secret_href method and was able to get the expected.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7476f92bc43e38daf269128fa08a2a4a63987694","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad0a82b9_c59c6e76","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"9e4d3079_b96daceb","updated":"2026-04-08 15:30:13.000000000","message":"Also, we could probably use context.service_catalog in case barbican_endpoint is missing, once https://review.opendev.org/c/openstack/manila/+/983749 is merged.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"077a2df8be0ef834914f7290e8dbec82cf05b7d7","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"04fe92b2_85f41cb2","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"9e4d3079_b96daceb","updated":"2026-04-08 15:45:23.000000000","message":"Hi Takashi, thanks for the comment! \n\nDoes it mean, we should mandate to have barbican_endpoint field under [barbican] stanza in manila.conf so that we can directly get it using  self.conf.barbican.barbican_endpoint and we will not need client.session.get_endpoint() code anymore. Please correct me if my understanding is wrong.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7636c307ed686c3a6e208ddeb2d288ad9412ece8","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"099bfc8f_3592d690","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"e93f71da_ecb0cf1e","updated":"2026-04-08 16:38:23.000000000","message":"By the way we could probably use get_secret_href instead of discovering endpoint here. The get_secret_href method is used to determine the download url and using the method may be more consistent.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6849a4a0ad846e7901466e283c8abdba0615a7a","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e93f71da_ecb0cf1e","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"f46df837_a75b732b","updated":"2026-04-08 16:30:34.000000000","message":"No you don\u0027t have to mandate but barbican_endpoint but use it and skip endpoint detection if the option is set.\n\nRegarding my version, I noticed it requires additional work so for now I think we can fix and merge the current implementation which requires endpoint url resolutin first and then try merging mine when it\u0027s ready.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1d4dba4df1c0dae3ec49ada67b6403e5b05d9faa","unresolved":true,"context_lines":[{"line_number":191,"context_line":"            raise exception.ManilaBarbicanAppCredsError()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def create_application_credentials(self, context, secret):"},{"line_number":194,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            client \u003d self.client"},{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e30bc134_0ad0099d","line":194,"updated":"2026-05-07 12:23:20.000000000","message":"Should the secret be logged?","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4ac186a09f84cab6adc2c10696bd89a624aecccf","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            raise exception.ManilaBarbicanAppCredsError()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def create_application_credentials(self, context, secret):"},{"line_number":194,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            client \u003d self.client"},{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b19d10fe_c3f89c97","line":194,"in_reply_to":"e30bc134_0ad0099d","updated":"2026-05-12 13:09:19.000000000","message":"Done","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1d4dba4df1c0dae3ec49ada67b6403e5b05d9faa","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"},{"line_number":198,"context_line":"                                          conf\u003dself.conf)"},{"line_number":199,"context_line":"            secret_path \u003d urllib.parse.urlparse(secret_href).path"},{"line_number":200,"context_line":"            LOG.debug(\"Using secret path for access rules: %s\","},{"line_number":201,"context_line":"                      secret_path)"},{"line_number":202,"context_line":"            return client.application_credentials.create("},{"line_number":203,"context_line":"                name\u003d\u0027manila_barbican_\u0027 + uuidutils.generate_uuid(),"},{"line_number":204,"context_line":"                user\u003dclient.session.get_user_id(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7379f94_0c1780c9","line":201,"range":{"start_line":200,"start_character":12,"end_line":201,"end_character":34},"updated":"2026-05-07 12:23:20.000000000","message":"Same comment here. I think we should avoid logging the secret and secret_path in the logger.","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4ac186a09f84cab6adc2c10696bd89a624aecccf","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"},{"line_number":198,"context_line":"                                          conf\u003dself.conf)"},{"line_number":199,"context_line":"            secret_path \u003d urllib.parse.urlparse(secret_href).path"},{"line_number":200,"context_line":"            LOG.debug(\"Using secret path for access rules: %s\","},{"line_number":201,"context_line":"                      secret_path)"},{"line_number":202,"context_line":"            return client.application_credentials.create("},{"line_number":203,"context_line":"                name\u003d\u0027manila_barbican_\u0027 + uuidutils.generate_uuid(),"},{"line_number":204,"context_line":"                user\u003dclient.session.get_user_id(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d8c053f_f0dcbab4","line":201,"range":{"start_line":200,"start_character":12,"end_line":201,"end_character":34},"in_reply_to":"b7379f94_0c1780c9","updated":"2026-05-12 13:09:19.000000000","message":"Done","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"}]}