)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"edeb7dc9407219978bededc32b1154f4103699c2","unresolved":true,"context_lines":[{"line_number":19,"context_line":"Closes-Bug: #2142102"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iccf284bdfa65a50bdc6c3b62d323528b605d9d9a"},{"line_number":22,"context_line":"Signed-off-by: Saikumar Pulluri \u003csaikumar@1016@gmail.com\u003e"},{"line_number":23,"context_line":"Signed-off-by: Saikumar Pulluri \u003csaikumar1016@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e1aec299_a2d409e9","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":2},"updated":"2026-05-19 21:38:08.000000000","message":"actually wrong? :)","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c9fcdb72e1337ee5c80af37f3f3b7dc7b3678638","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Closes-Bug: #2142102"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iccf284bdfa65a50bdc6c3b62d323528b605d9d9a"},{"line_number":22,"context_line":"Signed-off-by: Saikumar Pulluri \u003csaikumar@1016@gmail.com\u003e"},{"line_number":23,"context_line":"Signed-off-by: Saikumar Pulluri \u003csaikumar1016@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"98064cb1_5a7716be","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":2},"in_reply_to":"e1aec299_a2d409e9","updated":"2026-05-20 14:38:07.000000000","message":"Ah thank you Carlos. \nGood catch — fixed.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"131551845661de4ab5a749a2c9c5ca1a7d70acdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b120b34_97ba02fd","updated":"2026-04-08 13:54:33.000000000","message":"Hi Reviewers/stackers,\n\nI have tested this fix with both RHOSO/DevStack, working as expected. \n\nPlease do review. Thank you!!","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5d61566306d4ba89c56ee4fb61070b53b869b319","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"054651ea_b6c07204","updated":"2026-04-08 14:55:36.000000000","message":"LGTM","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"226057a1fd24099de10547198c81e207c876dc83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ead9afea_a2a8df15","updated":"2026-04-08 14:42:19.000000000","message":"LGTM!","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"a568a68f63a95d785309a564014c12161d9d815d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b99543b_7734d65b","updated":"2026-04-10 13:12:43.000000000","message":"I have used get_secret_href method as suggested by Takashi.\n\nTested on both DevStack and RHOSO deployment and working as expected. \n\nTesting info: https://paste.opendev.org/show/b8L3zsa4AuN8lfTgOzL3/","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"c183c0593097611ba296de946f594ee75aaaa17b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"767ca5f4_0b463a8e","updated":"2026-04-15 07:13:15.000000000","message":"LGTM","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1d4dba4df1c0dae3ec49ada67b6403e5b05d9faa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0da1bc9_a4b22eb7","updated":"2026-05-07 12:23:20.000000000","message":"Please check the comments once.","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f266d6a1dcf22e9ed2d548dd81f79d5030641ebe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e818d33_a26a0b8f","updated":"2026-05-20 05:22:34.000000000","message":"Agree with Carlos\u0027 change in the reno.. \n\nand, wanted to note that this fix won\u0027t cleanly apply to stable/2025.2 which has this bug.. c10154bc7 (\"Adopt to new castellan\") restructured the module between 2025.2 and 2026.1, replacing ``get_client_and_href()`` with separate\n``get_client()`` / ``get_secret_href()`` methods. On stable/2025.2, ``get_secret_href`` still delegates to ``get_client_and_href`` which resolves the URL from the service catalog (no extra HTTP call), so the same approach works but\n the patch won\u0027t apply as-is.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"d7b903b34d5b2cf1fc1e7c4cb1265061eeb0777d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"105f7d79_1de6f347","updated":"2026-05-12 17:18:10.000000000","message":"LGTM","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d6a3a05799393d0ea54d8c7f031831dc9f8d0505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eac776b3_23a4bd2a","updated":"2026-05-14 06:47:18.000000000","message":"LGTM ..!","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4ac186a09f84cab6adc2c10696bd89a624aecccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cfac3a64_9e8f6f12","updated":"2026-05-12 13:09:19.000000000","message":"Thank you Anoop for flagging it. Removed the secret logging. Please do review and apporve.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c9fcdb72e1337ee5c80af37f3f3b7dc7b3678638","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7f66e71_803f9918","updated":"2026-05-20 14:38:07.000000000","message":"Thank you so much @ces.eduardo98@gmail.com @gouthampravi@gmail.com for the comments/suggestions. Addressed all of them. \n\nThanks @gouthampravi@gmail.com for the heads-up on stable/2025.2. Understood — this patch won\u0027t cherry-pick cleanly because c10154bc7 (\"Adopt to new castellan\") restructured the module between 2025.2 and 2026.1, replacing get_client_and_href() with separate get_client() / get_secret_href() methods.\n\nPlan for the backport (please correct if you\u0027d prefer otherwise):\n\n1. Land this on master.\n2. Open a separate stable/2025.2 change as a manual cherry-pick, calling out the conflict resolution in the commit message and linking back to this review.\n3. Keep the unit-test additions equivalent in shape (assert on access_rules paths) so behavior coverage matches across branches.\n\nThis functionality is needed on stable/2025.2 for downstream FR6 consumers, so we\u0027d like the master change to land soon and follow up with the backport right after. Does this make sense??\n\nCC: @anoop.shukla@netapp.com @Deepa.Reddy@netapp.com","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"edeb7dc9407219978bededc32b1154f4103699c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"615f977f_2c6f8976","updated":"2026-05-19 21:38:08.000000000","message":"Thanks for working on this change Sai, only a comment for the release note. Please take a look!\n\nAnd thanks folks for the activity on the reviews here :)","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb224bb2a52dd247f0c8bc4143333d9c83f1fb69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82fdc020_472284b8","in_reply_to":"7e818d33_a26a0b8f","updated":"2026-05-21 19:15:09.000000000","message":"Looks like it applies cleanly, thanks for validating and proposing that backport","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"4d2304e2246833fd0fd55448dd6d2c537b3fd675","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7110b90f_95250d03","updated":"2026-05-20 15:03:05.000000000","message":"LGTM","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b5b41aecd1622348fa970707a23aaffe1116822b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e67799ac_74679a18","updated":"2026-05-20 14:54:28.000000000","message":"LGTM","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"436e2c11441ebe75adab6dafc96c7d7b7e3ccdcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"727e161b_bde46d4b","updated":"2026-05-20 16:16:24.000000000","message":"LGTM ..!","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"78d08bfb03f4ea0b8f141172df8716328a7e54d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"97f65c22_ea7365f6","updated":"2026-05-20 17:44:05.000000000","message":"Looks good otherwise, thanks Sai","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f48ca6a4aa340de3d6d7b84d391b06649259092b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f87c1a84_c3de2bac","updated":"2026-05-20 17:43:54.000000000","message":"Only problem with the follow-up for the release notes is that you\u0027d need to squash the two changes in the backport","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d37163c8eea28c18bd71c0d54f6a7e1f61747ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5cb586a_6c66ff07","updated":"2026-05-20 18:00:43.000000000","message":"Please propose the 2026.1 backport when this lands; looking to see the 2025.2 backport too.. thanks @saikumar1016@gmail.com","commit_id":"2959f2018fb60287f2db7c56db9f5a03a31171a4"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"1e887ebda420e52fbaa08ea00fda5b88e6ea2cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2e5f50bb_6912f5a4","updated":"2026-05-20 18:05:02.000000000","message":"Really appreciate quick reviews approvals on this, thanks much reviewers!!","commit_id":"2959f2018fb60287f2db7c56db9f5a03a31171a4"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"1e887ebda420e52fbaa08ea00fda5b88e6ea2cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d971b3c6_d49a4335","in_reply_to":"a5cb586a_6c66ff07","updated":"2026-05-20 18:05:02.000000000","message":"Sure Goutham!! Thank you.","commit_id":"2959f2018fb60287f2db7c56db9f5a03a31171a4"}],"manila/keymgr/barbican.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"528b339b86bb412d174f161e5f9dbeccc453bbec","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9e4d3079_b96daceb","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"updated":"2026-04-08 15:26:00.000000000","message":"I think you should check self.conf.barbican.barbican_endpoint and use it to make the behavior consistent with the key-manager client.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"811ec7965fcd6c6f3e79c75dbac85d82ad3f5334","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f46df837_a75b732b","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"04fe92b2_85f41cb2","updated":"2026-04-08 15:49:20.000000000","message":"I just saw your second comment. My above reply was for only first comment!","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"a568a68f63a95d785309a564014c12161d9d815d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b32446ff_a8c10da7","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"099bfc8f_3592d690","updated":"2026-04-10 13:12:43.000000000","message":"Thank you so much Takashi. Really appreciate your suggestion. \n\nI have used get_secret_href method and was able to get the expected.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7476f92bc43e38daf269128fa08a2a4a63987694","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad0a82b9_c59c6e76","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"9e4d3079_b96daceb","updated":"2026-04-08 15:30:13.000000000","message":"Also, we could probably use context.service_catalog in case barbican_endpoint is missing, once https://review.opendev.org/c/openstack/manila/+/983749 is merged.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"077a2df8be0ef834914f7290e8dbec82cf05b7d7","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"04fe92b2_85f41cb2","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"9e4d3079_b96daceb","updated":"2026-04-08 15:45:23.000000000","message":"Hi Takashi, thanks for the comment! \n\nDoes it mean, we should mandate to have barbican_endpoint field under [barbican] stanza in manila.conf so that we can directly get it using  self.conf.barbican.barbican_endpoint and we will not need client.session.get_endpoint() code anymore. Please correct me if my understanding is wrong.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7636c307ed686c3a6e208ddeb2d288ad9412ece8","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"099bfc8f_3592d690","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"e93f71da_ecb0cf1e","updated":"2026-04-08 16:38:23.000000000","message":"By the way we could probably use get_secret_href instead of discovering endpoint here. The get_secret_href method is used to determine the download url and using the method may be more consistent.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e6849a4a0ad846e7901466e283c8abdba0615a7a","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":196,"context_line":"        try:"},{"line_number":197,"context_line":"            client \u003d self.client"},{"line_number":198,"context_line":"            barbican_endpoint \u003d client.session.get_endpoint("},{"line_number":199,"context_line":"                service_type\u003dSERVICE_TYPE,"},{"line_number":200,"context_line":"                interface\u003dself.conf.barbican.barbican_endpoint_type,"},{"line_number":201,"context_line":"                region_name\u003dself.conf.barbican.region_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e93f71da_ecb0cf1e","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":29},"in_reply_to":"f46df837_a75b732b","updated":"2026-04-08 16:30:34.000000000","message":"No you don\u0027t have to mandate but barbican_endpoint but use it and skip endpoint detection if the option is set.\n\nRegarding my version, I noticed it requires additional work so for now I think we can fix and merge the current implementation which requires endpoint url resolutin first and then try merging mine when it\u0027s ready.","commit_id":"88aa62163855ca29fbeff08240737a7759d33396"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1d4dba4df1c0dae3ec49ada67b6403e5b05d9faa","unresolved":true,"context_lines":[{"line_number":191,"context_line":"            raise exception.ManilaBarbicanAppCredsError()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def create_application_credentials(self, context, secret):"},{"line_number":194,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            client \u003d self.client"},{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e30bc134_0ad0099d","line":194,"updated":"2026-05-07 12:23:20.000000000","message":"Should the secret be logged?","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4ac186a09f84cab6adc2c10696bd89a624aecccf","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            raise exception.ManilaBarbicanAppCredsError()"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def create_application_credentials(self, context, secret):"},{"line_number":194,"context_line":"        LOG.debug(\"Creating application credentials for secret \u0027%s\u0027.\", secret)"},{"line_number":195,"context_line":"        try:"},{"line_number":196,"context_line":"            client \u003d self.client"},{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b19d10fe_c3f89c97","line":194,"in_reply_to":"e30bc134_0ad0099d","updated":"2026-05-12 13:09:19.000000000","message":"Done","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1d4dba4df1c0dae3ec49ada67b6403e5b05d9faa","unresolved":true,"context_lines":[{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"},{"line_number":198,"context_line":"                                          conf\u003dself.conf)"},{"line_number":199,"context_line":"            secret_path \u003d urllib.parse.urlparse(secret_href).path"},{"line_number":200,"context_line":"            LOG.debug(\"Using secret path for access rules: %s\","},{"line_number":201,"context_line":"                      secret_path)"},{"line_number":202,"context_line":"            return client.application_credentials.create("},{"line_number":203,"context_line":"                name\u003d\u0027manila_barbican_\u0027 + uuidutils.generate_uuid(),"},{"line_number":204,"context_line":"                user\u003dclient.session.get_user_id(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"b7379f94_0c1780c9","line":201,"range":{"start_line":200,"start_character":12,"end_line":201,"end_character":34},"updated":"2026-05-07 12:23:20.000000000","message":"Same comment here. I think we should avoid logging the secret and secret_path in the logger.","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4ac186a09f84cab6adc2c10696bd89a624aecccf","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            secret_href \u003d get_secret_href(context, secret,"},{"line_number":198,"context_line":"                                          conf\u003dself.conf)"},{"line_number":199,"context_line":"            secret_path \u003d urllib.parse.urlparse(secret_href).path"},{"line_number":200,"context_line":"            LOG.debug(\"Using secret path for access rules: %s\","},{"line_number":201,"context_line":"                      secret_path)"},{"line_number":202,"context_line":"            return client.application_credentials.create("},{"line_number":203,"context_line":"                name\u003d\u0027manila_barbican_\u0027 + uuidutils.generate_uuid(),"},{"line_number":204,"context_line":"                user\u003dclient.session.get_user_id(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"2d8c053f_f0dcbab4","line":201,"range":{"start_line":200,"start_character":12,"end_line":201,"end_character":34},"in_reply_to":"b7379f94_0c1780c9","updated":"2026-05-12 13:09:19.000000000","message":"Done","commit_id":"b263ff3e8536712dea2c03fc1715025a0ad58191"}],"manila/tests/keymgr/test_barbican.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f266d6a1dcf22e9ed2d548dd81f79d5030641ebe","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        mock_get_href.assert_called_once_with("},{"line_number":120,"context_line":"            self.context, fake_secret, conf\u003dCONF)"},{"line_number":121,"context_line":"        mock_creds \u003d mock_client_instance.application_credentials"},{"line_number":122,"context_line":"        mock_creds.create.assert_called_once()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @mock.patch(\u0027manila.keymgr.barbican.get_secret_href\u0027)"},{"line_number":125,"context_line":"    @mock.patch(\u0027keystoneclient.v3.client.Client\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7516d448_7d59426a","line":122,"range":{"start_line":122,"start_character":26,"end_line":122,"end_character":44},"updated":"2026-05-20 05:22:34.000000000","message":"this is a weak assert... \n\nyou should try and assert with parameters. \n```\n      args, kwargs \u003d mock_creds.create.call_args\n      access_rules \u003d kwargs[\u0027access_rules\u0027]\n      self.assertEqual(\u0027/v1/secrets/\u0027 + fake_secret,\n                       access_rules[0][\u0027path\u0027])\n      self.assertEqual(\u0027/v1/secrets/\u0027 + fake_secret + \u0027/payload\u0027,\n                       access_rules[1][\u0027path\u0027])\n```","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c9fcdb72e1337ee5c80af37f3f3b7dc7b3678638","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        mock_get_href.assert_called_once_with("},{"line_number":120,"context_line":"            self.context, fake_secret, conf\u003dCONF)"},{"line_number":121,"context_line":"        mock_creds \u003d mock_client_instance.application_credentials"},{"line_number":122,"context_line":"        mock_creds.create.assert_called_once()"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @mock.patch(\u0027manila.keymgr.barbican.get_secret_href\u0027)"},{"line_number":125,"context_line":"    @mock.patch(\u0027keystoneclient.v3.client.Client\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba30538f_a9571ed3","line":122,"range":{"start_line":122,"start_character":26,"end_line":122,"end_character":44},"in_reply_to":"7516d448_7d59426a","updated":"2026-05-20 14:38:07.000000000","message":"Done.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"}],"releasenotes/notes/bug-2142102-fix-barbican-endpoint-from-catalog-255cc8c1787b2c6b.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"edeb7dc9407219978bededc32b1154f4103699c2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed Barbican integration for share-server/share encryption where Manila"},{"line_number":5,"context_line":"    hardcoded the ``/key-manager`` URL prefix when constructing the Barbican"},{"line_number":6,"context_line":"    secrets API path. Manila now derives the correct base endpoint from the"},{"line_number":7,"context_line":"    Keystone service catalog and appends the Barbican API path relative to that"},{"line_number":8,"context_line":"    endpoint, so deployments whose Barbican endpoint is published without the"},{"line_number":9,"context_line":"    ``/key-manager`` prefix (for example, RHOSO) work correctly."},{"line_number":10,"context_line":"    For more details, please refer to"},{"line_number":11,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3cf74810_f4c76e63","line":9,"range":{"start_line":4,"start_character":4,"end_line":9,"end_character":64},"updated":"2026-05-19 21:38:08.000000000","message":"If we state we hardcode something, this is pretty much implementation details that end users should not care about.\n```suggestion\n    Fixed an issue that made the Manila integration with Barbican fail due to\n    an internal endpoint misconfiguration. Manila will now fetch Keystone for\n    the correct endpoint and use it while making requests.\n```","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f266d6a1dcf22e9ed2d548dd81f79d5030641ebe","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed Barbican integration for share-server/share encryption where Manila"},{"line_number":5,"context_line":"    hardcoded the ``/key-manager`` URL prefix when constructing the Barbican"},{"line_number":6,"context_line":"    secrets API path. Manila now derives the correct base endpoint from the"},{"line_number":7,"context_line":"    Keystone service catalog and appends the Barbican API path relative to that"},{"line_number":8,"context_line":"    endpoint, so deployments whose Barbican endpoint is published without the"},{"line_number":9,"context_line":"    ``/key-manager`` prefix (for example, RHOSO) work correctly."},{"line_number":10,"context_line":"    For more details, please refer to"},{"line_number":11,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6ba5a76c_d92af1c9","line":9,"range":{"start_line":4,"start_character":4,"end_line":9,"end_character":64},"in_reply_to":"3cf74810_f4c76e63","updated":"2026-05-20 05:22:34.000000000","message":"Manila will now query Keystone for the correct endpoint and use it while making requests.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c9fcdb72e1337ee5c80af37f3f3b7dc7b3678638","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed Barbican integration for share-server/share encryption where Manila"},{"line_number":5,"context_line":"    hardcoded the ``/key-manager`` URL prefix when constructing the Barbican"},{"line_number":6,"context_line":"    secrets API path. Manila now derives the correct base endpoint from the"},{"line_number":7,"context_line":"    Keystone service catalog and appends the Barbican API path relative to that"},{"line_number":8,"context_line":"    endpoint, so deployments whose Barbican endpoint is published without the"},{"line_number":9,"context_line":"    ``/key-manager`` prefix (for example, RHOSO) work correctly."},{"line_number":10,"context_line":"    For more details, please refer to"},{"line_number":11,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"947140ef_c516e3fa","line":9,"range":{"start_line":4,"start_character":4,"end_line":9,"end_character":64},"in_reply_to":"6ba5a76c_d92af1c9","updated":"2026-05-20 14:38:07.000000000","message":"Done.","commit_id":"0d74c6e545d20cd56d01d71d34688259394de021"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1438bdfff22725e5ed8295c3bda9c0dc0bc4f745","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixed an issue that made the Manila integration with Barbican fail due to"},{"line_number":5,"context_line":"    an internal endpoint misconfiguration. Manila will now query Keystone for"},{"line_number":6,"context_line":"    the correct endpoint and use it while making requests."},{"line_number":7,"context_line":"    For more details, see"},{"line_number":8,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3927f403_a10f2b8a","line":8,"range":{"start_line":7,"start_character":22,"end_line":8,"end_character":14},"updated":"2026-05-20 15:49:27.000000000","message":"you need a space between these words","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"86072c101fcb6dc9377491d4b42d6c502cf85d06","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Fixed an issue that made the Manila integration with Barbican fail due to"},{"line_number":5,"context_line":"    an internal endpoint misconfiguration. Manila will now query Keystone for"},{"line_number":6,"context_line":"    the correct endpoint and use it while making requests."},{"line_number":7,"context_line":"    For more details, see"},{"line_number":8,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7eaa5e19_924aadb6","line":8,"range":{"start_line":7,"start_character":22,"end_line":8,"end_character":14},"in_reply_to":"3927f403_a10f2b8a","updated":"2026-05-20 16:25:54.000000000","message":"@gouthampravi@gmail.com Can I submit a follow up for this please?","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"85aa4a6b658fa89a52de065c2557f16ec291aa94","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixed an issue that made the Manila integration with Barbican fail due to"},{"line_number":5,"context_line":"    an internal endpoint misconfiguration. Manila will now query Keystone for"},{"line_number":6,"context_line":"    the correct endpoint and use it while making requests."},{"line_number":7,"context_line":"    For more details, see"},{"line_number":8,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"90a2033f_ad930a2b","line":8,"range":{"start_line":7,"start_character":22,"end_line":8,"end_character":14},"in_reply_to":"7eaa5e19_924aadb6","updated":"2026-05-20 17:58:31.000000000","message":"I don\u0027t see the point..","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"cfb07e3aa48d4698ba2365acaca0637d3c7edf23","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Fixed an issue that made the Manila integration with Barbican fail due to"},{"line_number":5,"context_line":"    an internal endpoint misconfiguration. Manila will now query Keystone for"},{"line_number":6,"context_line":"    the correct endpoint and use it while making requests."},{"line_number":7,"context_line":"    For more details, see"},{"line_number":8,"context_line":"    `Launchpad bug #2142102 \u003chttps://bugs.launchpad.net/manila/+bug/2142102\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4235b15e_2d119657","line":8,"range":{"start_line":7,"start_character":22,"end_line":8,"end_character":14},"in_reply_to":"90a2033f_ad930a2b","updated":"2026-05-20 18:01:39.000000000","message":"Thanks a lot Goutham for publishing the change!!","commit_id":"a0b78f66b613e281fd8ab27131f7810fa6a09fcf"}]}