)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"a2cb8e4ac7a29c04e2fa0efe67f31abc11000a18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c415998f_abccec29","updated":"2026-04-09 08:53:59.000000000","message":"LGTM!","commit_id":"e34736c5b79e0821ce7714cb9ba0a8c63c921a3b"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1b9fde556318278da4522d9a94dc1fc86625950a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"636d9405_51bf51af","updated":"2026-04-09 12:07:43.000000000","message":"Please check the comment.","commit_id":"e34736c5b79e0821ce7714cb9ba0a8c63c921a3b"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"de2dd882ae20cef868d1692b8042720cc007cb36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f2a8474_adb05411","updated":"2026-04-10 08:10:44.000000000","message":"LGTM","commit_id":"30495bd6a391cd2ca6277879d49a6ae1fc1d0afd"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"a4d50344af00e7156dd4e5fa65a9530a66d93598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"44613567_79ef8aef","updated":"2026-04-13 04:55:25.000000000","message":"Please add the release note for this patch","commit_id":"30495bd6a391cd2ca6277879d49a6ae1fc1d0afd"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"5c3ad4f811c18500fa15a95af0081e7deac09435","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f292fe3_65eb9a01","updated":"2026-04-10 03:49:00.000000000","message":"run-NetApp CI","commit_id":"30495bd6a391cd2ca6277879d49a6ae1fc1d0afd"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"47c98ff8a1a0ce3b98756f4800b584921a8ad5c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c03f49c_49163b01","updated":"2026-04-20 04:43:49.000000000","message":"Changes looks good for me provided one minor comment","commit_id":"a1b2cd59de74aca4f5680fe1a6f9c354b552e83b"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"78bb8e3cf3004f080f7a9731ebf9c254be4c1d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f277c7a_3ff66721","updated":"2026-04-14 05:31:48.000000000","message":"LGTM.","commit_id":"a1b2cd59de74aca4f5680fe1a6f9c354b552e83b"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c5cf28664240f85e6e84b9e3823641042d2e6b38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3e550677_a79fdaf1","updated":"2026-04-21 13:42:13.000000000","message":"LGTM","commit_id":"f2f4593953e1522fa0356626e54a47323823c3d2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"1bb35049dfc395c383a393a7a07afa0647dc4290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f2be98e_ea9a4ad3","updated":"2026-04-21 03:46:00.000000000","message":"LGTM ..!","commit_id":"f2f4593953e1522fa0356626e54a47323823c3d2"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"ef6fd8519e485df6618ae21b47a981dca79e700c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3460ab4a_2f45d744","updated":"2026-04-21 14:59:51.000000000","message":"LGTM.","commit_id":"f2f4593953e1522fa0356626e54a47323823c3d2"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1b9fde556318278da4522d9a94dc1fc86625950a","unresolved":true,"context_lines":[{"line_number":4566,"context_line":"                self.send_request(f\u0027/name-services/dns/{svm_uuid}\u0027,"},{"line_number":4567,"context_line":"                                  \u0027patch\u0027, body\u003dbody)"},{"line_number":4568,"context_line":"            else:"},{"line_number":4569,"context_line":"                body[\u0027svm\u0027] \u003d {"},{"line_number":4570,"context_line":"                    \u0027name\u0027: vserver_name if vserver_name else self.vserver,"},{"line_number":4571,"context_line":"                    \u0027uuid\u0027: svm_uuid,"},{"line_number":4572,"context_line":"                }"},{"line_number":4573,"context_line":"                self.send_request(\u0027/name-services/dns\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4574,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4575,"context_line":"            msg \u003d _(\"Failed to configure DNS. %s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"482a6093_c03bd95f","line":4572,"range":{"start_line":4569,"start_character":0,"end_line":4572,"end_character":17},"updated":"2026-04-09 12:07:43.000000000","message":"ONTAP does not require name and uuid both. I think we can just pass the uuid and we do not need the vserver_name. Please check once.\n\nAnother problem is, for name you are checking if a vserver_name is passed, in line 4552 you have already fetched the uuid based on vserver_name. ONTAP will use the uuid over the name passed. So it is redundant to expect both.","commit_id":"e34736c5b79e0821ce7714cb9ba0a8c63c921a3b"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"7a1a4f0c3fb9fa6f601e7f7aa2c10c23a23caa2e","unresolved":false,"context_lines":[{"line_number":4566,"context_line":"                self.send_request(f\u0027/name-services/dns/{svm_uuid}\u0027,"},{"line_number":4567,"context_line":"                                  \u0027patch\u0027, body\u003dbody)"},{"line_number":4568,"context_line":"            else:"},{"line_number":4569,"context_line":"                body[\u0027svm\u0027] \u003d {"},{"line_number":4570,"context_line":"                    \u0027name\u0027: vserver_name if vserver_name else self.vserver,"},{"line_number":4571,"context_line":"                    \u0027uuid\u0027: svm_uuid,"},{"line_number":4572,"context_line":"                }"},{"line_number":4573,"context_line":"                self.send_request(\u0027/name-services/dns\u0027, \u0027post\u0027, body\u003dbody)"},{"line_number":4574,"context_line":"        except netapp_api.api.NaApiError as e:"},{"line_number":4575,"context_line":"            msg \u003d _(\"Failed to configure DNS. %s\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"472b432c_5ed0191d","line":4572,"range":{"start_line":4569,"start_character":0,"end_line":4572,"end_character":17},"in_reply_to":"482a6093_c03bd95f","updated":"2026-04-09 13:58:15.000000000","message":"removed name from body","commit_id":"e34736c5b79e0821ce7714cb9ba0a8c63c921a3b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"47c98ff8a1a0ce3b98756f4800b584921a8ad5c4","unresolved":true,"context_lines":[{"line_number":4460,"context_line":"                                   vserver_name, aes_encryption, smb_signing):"},{"line_number":4461,"context_line":"        \"\"\"Configures AD on Vserver.\"\"\""},{"line_number":4462,"context_line":"        self.configure_dns(security_service, vserver_name\u003dvserver_name)"},{"line_number":4463,"context_line":"        self.configure_cifs_aes_encryption(vserver_name, aes_encryption)"},{"line_number":4464,"context_line":"        self.set_preferred_dc(security_service, vserver_name)"},{"line_number":4465,"context_line":""},{"line_number":4466,"context_line":"        cifs_server \u003d self._get_cifs_server_name(vserver_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba54e112_b7a18322","side":"PARENT","line":4463,"range":{"start_line":4463,"start_character":13,"end_line":4463,"end_character":42},"updated":"2026-04-20 04:43:49.000000000","message":"If you removing this method then ideally you have to remove the definition of configure_cifs_aes_encryption method if it is not using anywhere else.","commit_id":"54ac755d93d6c4128ddb8814b5d7f3906234fff4"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"9b3621d639d5f3db3d799a937453616c91544af4","unresolved":false,"context_lines":[{"line_number":4460,"context_line":"                                   vserver_name, aes_encryption, smb_signing):"},{"line_number":4461,"context_line":"        \"\"\"Configures AD on Vserver.\"\"\""},{"line_number":4462,"context_line":"        self.configure_dns(security_service, vserver_name\u003dvserver_name)"},{"line_number":4463,"context_line":"        self.configure_cifs_aes_encryption(vserver_name, aes_encryption)"},{"line_number":4464,"context_line":"        self.set_preferred_dc(security_service, vserver_name)"},{"line_number":4465,"context_line":""},{"line_number":4466,"context_line":"        cifs_server \u003d self._get_cifs_server_name(vserver_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"811b42e0_e66a5871","side":"PARENT","line":4463,"range":{"start_line":4463,"start_character":13,"end_line":4463,"end_character":42},"in_reply_to":"ba54e112_b7a18322","updated":"2026-04-20 06:09:08.000000000","message":"Done","commit_id":"54ac755d93d6c4128ddb8814b5d7f3906234fff4"}]}