)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3f53f5b45fd706089e9bd86c91c8d28be83635e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32fa8c73_f6d43a9b","updated":"2026-07-15 14:31:01.000000000","message":"Thanks for working on this fix. Please take a look at the comments inline","commit_id":"1c253f399bafc563f443db4c26b991763aa7920a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"706474c4f1fd9b2fb87a8b250fe0ed7d9133f5f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3c3c2f4_958f3cdf","updated":"2026-08-07 19:03:04.000000000","message":"Thank you for applying the changes, have another minor suggestion :)","commit_id":"aa68cf19dfcd4b299ba7d7c4ab769bc28c8075ee"}],"manila/tests/share_group/test_share_group_types.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3f53f5b45fd706089e9bd86c91c8d28be83635e3","unresolved":true,"context_lines":[{"line_number":162,"context_line":"            \u0027fake\u0027, None, \u0027fake\u0027)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_destroy(self):"},{"line_number":165,"context_line":"        share_group_type \u003d share_group_types.create(self.context, \u0027type1\u0027, [])"},{"line_number":166,"context_line":"        share_group_type_id \u003d share_group_type.get(\u0027id\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        share_group_types.destroy(self.context, share_group_type_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fee12892_a35f9b9f","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":78},"updated":"2026-07-15 14:31:01.000000000","message":"we should not be calling this. we should be mocking the share_group_types calls that are not the ones we\u0027re testing in the method. Same applies to all methods below","commit_id":"1c253f399bafc563f443db4c26b991763aa7920a"},{"author":{"_account_id":38471,"name":"Denver Baraka","display_name":"Denver Baraka","email":"denverbaraka@gmail.com","username":"denver-baraka"},"change_message_id":"89b49c9c81ddd5861b2ad2da5022eab55aaeca4f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027fake\u0027, None, \u0027fake\u0027)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def test_destroy(self):"},{"line_number":165,"context_line":"        share_group_type \u003d share_group_types.create(self.context, \u0027type1\u0027, [])"},{"line_number":166,"context_line":"        share_group_type_id \u003d share_group_type.get(\u0027id\u0027)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        share_group_types.destroy(self.context, share_group_type_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef5fd16a_011eaa4a","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":78},"in_reply_to":"fee12892_a35f9b9f","updated":"2026-07-27 17:01:16.000000000","message":"thanks for reviewing,\ndone , mocked db layer directly.","commit_id":"1c253f399bafc563f443db4c26b991763aa7920a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"706474c4f1fd9b2fb87a8b250fe0ed7d9133f5f2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ddt"},{"line_number":20,"context_line":"from oslo_db import exception as db_exception"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manila.common import constants"}],"source_content_type":"text/x-python","patch_set":2,"id":"c59f0fea_88bb6088","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":2},"updated":"2026-08-07 19:03:04.000000000","message":"I liked the older example: the db exception is still being used only in that test, maybe we should maintain it there","commit_id":"aa68cf19dfcd4b299ba7d7c4ab769bc28c8075ee"}]}