)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bec6385225091a7c7b739eb24035d57487f85b16","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Nikita Skakun \u003cnikita.skakun@sap.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-02 12:15:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp replica create for flexgroup share error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- added _wait_for_efficiency_job method which"},{"line_number":10,"context_line":"  wait for efficiency async job to complete,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"bd509936_b42ea49f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":47},"updated":"2026-06-25 23:18:17.000000000","message":"Do you mean:\n\n\n\n```suggestion\n[NetApp] Fix error creating flexgroup share replicas\n```\n\nthe commit message header must be in imperative tone, explaining what the commit does","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bec6385225091a7c7b739eb24035d57487f85b16","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp replica create for flexgroup share error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- added _wait_for_efficiency_job method which"},{"line_number":10,"context_line":"  wait for efficiency async job to complete,"},{"line_number":11,"context_line":"  if job_id exist"},{"line_number":12,"context_line":"- added the boolean `replica` param to"},{"line_number":13,"context_line":"  `_create_flexgroup_share`, which skips"},{"line_number":14,"context_line":"  max_files configuration when"},{"line_number":15,"context_line":"  creating a replica volume, as setting"},{"line_number":16,"context_line":"  these params on a read-only replica"},{"line_number":17,"context_line":"  raises an error from the NetApp API"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #2143199"},{"line_number":20,"context_line":"Change-Id: I4a9983da34ce54607bf206b8b175f0f59fbe413c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"00c7b516_06eefee2","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":37},"updated":"2026-06-25 23:18:17.000000000","message":"In the body of the commit message, you should try and explain _why_ you\u0027re doing something.. not just what; you\u0027ve concentrated on what here. I\u0027ve no clue why the efficiency job fix is related because you\u0027ve not shared that detail.","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1190efb1c65770a51d67d9a5f096a771d5985d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fcaf0606_62e56755","updated":"2026-05-20 10:02:45.000000000","message":"The impl needs to be there for REST client as well. Hence -1 for now.","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"758ee755f01f99c383d277d39042f56f67e19965","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5fe306ee_63744ccb","updated":"2026-06-02 09:52:41.000000000","message":"My last comment is not addressed, otherwise looks good. +1 after rebase.","commit_id":"293a433f8ec49eea51d7f666ac69d6baa5861643"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"9d081ea651b244c7ebf207a413d64a767aa2a79b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1bbf5564_2a74f4ab","in_reply_to":"5fe306ee_63744ccb","updated":"2026-06-02 10:15:49.000000000","message":"Updated commit message","commit_id":"293a433f8ec49eea51d7f666ac69d6baa5861643"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"35e7604f26bef2ba98d0410014ed666495f29e04","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6fec9db2_478fc4ab","updated":"2026-06-02 12:17:43.000000000","message":"As we discussed on launchpad defect, the fix needs to be extended for REST Client as well.","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bec6385225091a7c7b739eb24035d57487f85b16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7009420b_eb0c331c","updated":"2026-06-25 23:18:17.000000000","message":"Hi @nikita.skakun@sap.com:\n\nThis is a bug fix with user-facing impact (FlexGroup replica creation\nwas broken). Please add a release note (`reno new fix-flexgroup-replica-create`)\nwith an appropriate `fixes:` section","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"f6554afa24814025e18c26b90b5d4ee8704457ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"27a6c55d_fc0797c8","updated":"2026-06-02 12:32:59.000000000","message":"LGTM","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"0d96fd86bc33dd1ee07948021504e964f89ec641","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0238cdfc_0d97e253","updated":"2026-06-03 10:23:08.000000000","message":"run-NetApp CI","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"2b7e1547893c5075787ae79024d1f3c51e1eb723","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d83a0054_b83f660f","in_reply_to":"0238cdfc_0d97e253","updated":"2026-06-03 14:20:46.000000000","message":"Done","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a07bacc4eddb51092911faf2ff3f4e98941fd8fe","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"99bbd84f_01905fd9","in_reply_to":"33c63037_762b37c7","updated":"2026-06-02 12:32:09.000000000","message":"Ya I think REST will be handled by the code block, although I am not sure if it was tested. How do we ensure that this would work for REST since we are only testing via ZAPIs?","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"f6554afa24814025e18c26b90b5d4ee8704457ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1ef54002_d7f79fe0","in_reply_to":"33c63037_762b37c7","updated":"2026-06-02 12:32:59.000000000","message":"oh my bad!\nI didn\u0027t go through the resolved comment.\nApologies for the repeated comment.","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f779cee29cb39e1dc653f56de5a0aadd198b5fff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"33c63037_762b37c7","in_reply_to":"6fec9db2_478fc4ab","updated":"2026-06-02 12:21:00.000000000","message":"Nikita has already replied to same query raised by Anoop.  Check here, \nhttps://github.com/openstack/manila/blob/2a78e94a652ddd7e2b666d74967f49122dfe4ba8/manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py#L212-L215","commit_id":"a2ba5b9707a0b256549819fc007a263b4271c128"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4ec8ac17706f4e49f4d243c1c5f716ae0bc8cd53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3e02361c_cc42a346","updated":"2026-06-29 20:56:19.000000000","message":"@anoop.shukla@netapp.com @gawasthi2010@gmail.com @kumart.lead@gmail.com: Can you verify if the NetApp CI issue is related? if not, please review/workflow this","commit_id":"ea09dd565de130704ff212fb76b4433f375f10ac"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"a7dfe575b379222158ae3273284ca29310932a4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5b0459ba_39c99e6e","updated":"2026-06-29 14:49:47.000000000","message":"run-NetApp CI","commit_id":"ea09dd565de130704ff212fb76b4433f375f10ac"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1190efb1c65770a51d67d9a5f096a771d5985d7f","unresolved":true,"context_lines":[{"line_number":2681,"context_line":"        self.send_request(\u0027sis-set-config\u0027, api_args)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"    @na_utils.trace"},{"line_number":2684,"context_line":"    def _wait_for_efficiency_job(self, job_id, volume_name, timeout\u003d300):"},{"line_number":2685,"context_line":"        \"\"\"Wait for efficiency async job to complete.\"\"\""},{"line_number":2686,"context_line":"        interval \u003d 5"},{"line_number":2687,"context_line":"        retries \u003d int(timeout / interval) or 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"7bd9fe10_93827197","line":2684,"updated":"2026-05-20 10:02:45.000000000","message":"This method needs to be added to rest client as well?","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"47c4908919a8805ec53bbac9b9c6f0648febc688","unresolved":true,"context_lines":[{"line_number":2681,"context_line":"        self.send_request(\u0027sis-set-config\u0027, api_args)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"    @na_utils.trace"},{"line_number":2684,"context_line":"    def _wait_for_efficiency_job(self, job_id, volume_name, timeout\u003d300):"},{"line_number":2685,"context_line":"        \"\"\"Wait for efficiency async job to complete.\"\"\""},{"line_number":2686,"context_line":"        interval \u003d 5"},{"line_number":2687,"context_line":"        retries \u003d int(timeout / interval) or 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"80ab300c_c7524a0e","line":2684,"in_reply_to":"135448f7_91addc9f","updated":"2026-05-20 14:03:57.000000000","message":"correct link:\n\nhttps://github.com/openstack/manila/blob/2a78e94a652ddd7e2b666d74967f49122dfe4ba8/manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py#L212-L215","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"bfb66b31cdab4f60a7a8996bf8b29a7840389135","unresolved":true,"context_lines":[{"line_number":2681,"context_line":"        self.send_request(\u0027sis-set-config\u0027, api_args)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"    @na_utils.trace"},{"line_number":2684,"context_line":"    def _wait_for_efficiency_job(self, job_id, volume_name, timeout\u003d300):"},{"line_number":2685,"context_line":"        \"\"\"Wait for efficiency async job to complete.\"\"\""},{"line_number":2686,"context_line":"        interval \u003d 5"},{"line_number":2687,"context_line":"        retries \u003d int(timeout / interval) or 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"135448f7_91addc9f","line":2684,"in_reply_to":"7bd9fe10_93827197","updated":"2026-05-20 13:27:14.000000000","message":"I think REST API already had the similar logic, you can check it here:\n\nhttps://github.com/sapcc/manila/blob/c171e4343592d4cf083ad22b15e9fa47b86634cd/manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py#L199-L202","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"db16684ff6f3f335308ef747470c51271fc1ed84","unresolved":false,"context_lines":[{"line_number":2681,"context_line":"        self.send_request(\u0027sis-set-config\u0027, api_args)"},{"line_number":2682,"context_line":""},{"line_number":2683,"context_line":"    @na_utils.trace"},{"line_number":2684,"context_line":"    def _wait_for_efficiency_job(self, job_id, volume_name, timeout\u003d300):"},{"line_number":2685,"context_line":"        \"\"\"Wait for efficiency async job to complete.\"\"\""},{"line_number":2686,"context_line":"        interval \u003d 5"},{"line_number":2687,"context_line":"        retries \u003d int(timeout / interval) or 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2b923a1_2035dc38","line":2684,"in_reply_to":"80ab300c_c7524a0e","updated":"2026-05-20 19:52:11.000000000","message":"Done","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"97c140c17d7d40d15c243a1c1776cf7d0ad9b9ae","unresolved":true,"context_lines":[{"line_number":1293,"context_line":"                self.configuration.netapp_volume_snapshot_reserve_percent,"},{"line_number":1294,"context_line":"                mount_point_name\u003dmount_point_name,"},{"line_number":1295,"context_line":"                volume_tags\u003dvolume_tags,"},{"line_number":1296,"context_line":"                replica\u003dreplica,"},{"line_number":1297,"context_line":"                **provisioning_options)"},{"line_number":1298,"context_line":"        else:"},{"line_number":1299,"context_line":"            vserver_client.create_volume("}],"source_content_type":"text/x-python","patch_set":5,"id":"9c7e3fb6_749ef938","line":1296,"updated":"2026-05-28 12:20:45.000000000","message":"can you mention in commit message why this replica param is passed to function and what it does ?","commit_id":"a3813987e468663922370d1ae43d8d915040e942"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"be952c5b3458560096fa4df5179ccded3e87c5ec","unresolved":false,"context_lines":[{"line_number":1293,"context_line":"                self.configuration.netapp_volume_snapshot_reserve_percent,"},{"line_number":1294,"context_line":"                mount_point_name\u003dmount_point_name,"},{"line_number":1295,"context_line":"                volume_tags\u003dvolume_tags,"},{"line_number":1296,"context_line":"                replica\u003dreplica,"},{"line_number":1297,"context_line":"                **provisioning_options)"},{"line_number":1298,"context_line":"        else:"},{"line_number":1299,"context_line":"            vserver_client.create_volume("}],"source_content_type":"text/x-python","patch_set":5,"id":"409f392d_3d92ba6f","line":1296,"in_reply_to":"9c7e3fb6_749ef938","updated":"2026-06-02 10:16:56.000000000","message":"Done","commit_id":"a3813987e468663922370d1ae43d8d915040e942"}],"releasenotes/notes/bug-2143199-replica-create-for-flexgroup-share-error-e3dcd090dad366f1.yaml":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"d7ccc6bbd2104965dfdc9332b8dc79899557996c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    added _wait_for_efficiency_job method which"},{"line_number":5,"context_line":"    wait for efficiency async job to complete,"},{"line_number":6,"context_line":"    if job_id exist"},{"line_number":7,"context_line":"    `launchpad bug #2143199 \u003chttps://bugs.launchpad.net/manila/+bug/2143199\u003e`."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"606b5af6_8bb37915","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":19},"updated":"2026-05-19 13:31:41.000000000","message":"The release note is for end users and operators. It should tell something along the lines of: \n\n\u0027fixed a bug in the NetApp driver on replica create, where the driver failed to modify efficiency configuration of a flexgroup volume\u0027","commit_id":"e2de0c59b8b62bcb332d8d1cc4028291ff6e7785"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"dfd9e0c8cc5c7fd0ee1b270d7129df61b51df114","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    added _wait_for_efficiency_job method which"},{"line_number":5,"context_line":"    wait for efficiency async job to complete,"},{"line_number":6,"context_line":"    if job_id exist"},{"line_number":7,"context_line":"    `launchpad bug #2143199 \u003chttps://bugs.launchpad.net/manila/+bug/2143199\u003e`."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2d67dfb8_8315c624","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":19},"in_reply_to":"606b5af6_8bb37915","updated":"2026-05-19 14:13:57.000000000","message":"Done","commit_id":"e2de0c59b8b62bcb332d8d1cc4028291ff6e7785"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"884423b49fbf9150215a07bf117e0b5d0b3da4ca","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    fixed a bug in the NetApp driver on replica create,"},{"line_number":5,"context_line":"    where the driver failed to modify efficiency configuration"},{"line_number":6,"context_line":"    of a flexgroup volume"},{"line_number":7,"context_line":"    `launchpad bug #2143199 \u003chttps://bugs.launchpad.net/manila/+bug/2143199\u003e`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"452d8c4c_6880380a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"updated":"2026-05-20 13:22:05.000000000","message":"```suggestion\n    `Launchpad bug #2143199\n    \u003chttps://bugs.launchpad.net/manila/+bug/2143199\u003e`_.\n```\n\nsee https://60353bc41aaa5f0472ca-4f649288e3ee9adba34390c9b9ac976a.ssl.cf1.rackcdn.com/openstack/705ea3f7166d4c0fbdaff093dbb4ac09/docs/unreleased.html, it is not rendering correctly currently","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bec6385225091a7c7b739eb24035d57487f85b16","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    fixed a bug in the NetApp driver on replica create,"},{"line_number":5,"context_line":"    where the driver failed to modify efficiency configuration"},{"line_number":6,"context_line":"    of a flexgroup volume"},{"line_number":7,"context_line":"    `launchpad bug #2143199 \u003chttps://bugs.launchpad.net/manila/+bug/2143199\u003e`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"25649db1_6bc7df51","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"in_reply_to":"13af6a94_cb6b387a","updated":"2026-06-25 23:18:17.000000000","message":"Marked as unresolved.\n\nThis file got popped off along the way, and needs to be restored","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"},{"author":{"_account_id":38910,"name":"Nikita Skakun","display_name":"Nikita","email":"nikita.skakun@sap.com","username":"nikita-skakun"},"change_message_id":"db16684ff6f3f335308ef747470c51271fc1ed84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    fixed a bug in the NetApp driver on replica create,"},{"line_number":5,"context_line":"    where the driver failed to modify efficiency configuration"},{"line_number":6,"context_line":"    of a flexgroup volume"},{"line_number":7,"context_line":"    `launchpad bug #2143199 \u003chttps://bugs.launchpad.net/manila/+bug/2143199\u003e`."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"13af6a94_cb6b387a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":78},"in_reply_to":"452d8c4c_6880380a","updated":"2026-05-20 19:52:11.000000000","message":"Done","commit_id":"a87c30248758fe833312e7414b22f9d5a825967f"}]}