)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2b8b3323b290ce78238557649fefec7f200a87a4","unresolved":true,"context_lines":[{"line_number":13,"context_line":"the Castellan/barbican plumbing), then illustrate them with a worked"},{"line_number":14,"context_line":"example using the NetApp ONTAP driver."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The NetApp example covers all three modes the driver implements:"},{"line_number":17,"context_line":"NetApp Volume Encryption (NVE) and NetApp Aggregate Encryption (NAE,"},{"line_number":18,"context_line":"2026.1 Gazpacho) for back-end-managed keys, and share-server /"},{"line_number":19,"context_line":"Barbican-managed encryption (2025.2 Flamingo) for tenant-supplied"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2c154595_a3944b27","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":25},"updated":"2026-05-21 15:01:22.000000000","message":"nit: examples cover - grammer","commit_id":"f737ae69e3735e8fe1750787450a73bb09e3537e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2b8b3323b290ce78238557649fefec7f200a87a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bc0187b3_28987b65","updated":"2026-05-21 15:01:22.000000000","message":"Thanks for the well rounded documentation on the encryption in general for NetApp Manila driver Sai. Some minor comments. Will keep it -1 till they are resolved, but otherwise documentation looks good to me.","commit_id":"f737ae69e3735e8fe1750787450a73bb09e3537e"}],"doc/source/admin/shared-file-systems-share-encryption.rst":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2b8b3323b290ce78238557649fefec7f200a87a4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"back end -- Manila does not encrypt data in flight or at rest on its own."},{"line_number":10,"context_line":"What Manila provides is:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* A vocabulary (share-type extra-specs) for an operator to opt a share"},{"line_number":13,"context_line":"  type into a driver\u0027s encryption capability."},{"line_number":14,"context_line":"* A generic API surface for **tenant-supplied** encryption keys, where a"},{"line_number":15,"context_line":"  reference to a secret stored in the OpenStack Key Manager service"}],"source_content_type":"text/x-rst","patch_set":2,"id":"8f6edbe8_d2f711ac","line":12,"range":{"start_line":12,"start_character":4,"end_line":12,"end_character":14},"updated":"2026-05-21 15:01:22.000000000","message":"Not sure if we should consider extra-spec a vocabulary. But parameter to be passed during share creation.","commit_id":"f737ae69e3735e8fe1750787450a73bb09e3537e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2b8b3323b290ce78238557649fefec7f200a87a4","unresolved":true,"context_lines":[{"line_number":38,"context_line":"  change is required; from the tenant\u0027s point of view this is just"},{"line_number":39,"context_line":"  another share type."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"* **Tenant-managed encryption.** The tenant uploads a symmetric key to"},{"line_number":42,"context_line":"  barbican and passes a reference to that secret on share creation via"},{"line_number":43,"context_line":"  ``--encryption-key-ref``. This path uses the generic Manila API"},{"line_number":44,"context_line":"  introduced in microversion 2.90 and requires the share type to declare"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bb927e09_07876170","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":29},"updated":"2026-05-21 15:01:22.000000000","message":"In brackets, can we call it (Bring your own key) type encryption?","commit_id":"f737ae69e3735e8fe1750787450a73bb09e3537e"}],"doc/source/user/barbican-share-encryption.rst":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2b8b3323b290ce78238557649fefec7f200a87a4","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. _user_barbican_share_encryption:"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":"Barbican-managed (tenant-supplied) shares"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e2c4052a_a34733ae","line":1,"updated":"2026-05-21 15:01:22.000000000","message":"Should we also cover limitations of barbican share encryption in the document and whats supported and whats currently not supported?","commit_id":"f737ae69e3735e8fe1750787450a73bb09e3537e"}]}