)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"7c0bd161adb11364818a725bb0b8a5b063d8e550","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42295531_b31cdabd","updated":"2026-05-26 07:36:59.000000000","message":"See some minor remarks inline.\n\nTo me it looks like you may have used AI (no offense), if yes please add \u0027Assisted-By:\u0027 in the commit msg according to https://openinfra.org/legal/ai-policy","commit_id":"f274c1607d5f3b32dc83f42b35b8354b0723f3bc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0d76b93455977887d70594c6a4fd0a1a12449f33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bb6dc5b_14baef80","in_reply_to":"42295531_b31cdabd","updated":"2026-05-26 08:18:42.000000000","message":"yes, AI help was used for comments, test cases etc. Added \u0027Assisted-By\u0027","commit_id":"f274c1607d5f3b32dc83f42b35b8354b0723f3bc"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"4053a96c5939792e98205be63c82a1c7c6382cbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a762c1d7_cab5ccda","updated":"2026-07-17 04:24:28.000000000","message":"release notes are missing. Please add.","commit_id":"072eb41199f5bf57626bf9f81cf423b909e51d94"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f769af5595daa85ba10f47fbea9478faefe0b9af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c46fc4a2_8bf1e58a","in_reply_to":"a762c1d7_cab5ccda","updated":"2026-07-17 10:15:55.000000000","message":"This is not end user facing change, so releasenotes are needed. Also Check https://review.opendev.org/c/openstack/manila/+/989424","commit_id":"072eb41199f5bf57626bf9f81cf423b909e51d94"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"58e8fa7f108d5567288280405500d9e25446d92a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d67620dd_afdb29f8","in_reply_to":"c3b107cd_80907758","updated":"2026-07-17 13:18:51.000000000","message":"ok, added","commit_id":"072eb41199f5bf57626bf9f81cf423b909e51d94"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"71999411b9f6665a938b86a7e4e847963b176412","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3b107cd_80907758","in_reply_to":"c46fc4a2_8bf1e58a","updated":"2026-07-17 13:07:15.000000000","message":"Good catch, Anoop.\n\n\u003e This is not end user facing change\n\nConfig options aren\u0027t either, but we still add it. Please check https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#what-needs-a-release-note\n\nI think this categorizes into: Behavior of an existing feature has changed in a discernible way to an end user or administrator","commit_id":"072eb41199f5bf57626bf9f81cf423b909e51d94"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"608d94c98d127632627f28c57beb4c608d2a7cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9abb91df_4f75f26f","updated":"2026-07-17 17:01:23.000000000","message":"LGTM, thanks Kiran","commit_id":"7c3cb26dd7adc8f6438c63a1b29f60c3fbfe44c0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"31ffbe6bd8a5ad9756876519ddf70e7313d5083e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"506ed9cf_33a5397f","updated":"2026-07-23 13:54:00.000000000","message":"LGTM. Thanks for adding the release notes.","commit_id":"7c3cb26dd7adc8f6438c63a1b29f60c3fbfe44c0"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"7c0bd161adb11364818a725bb0b8a5b063d8e550","unresolved":true,"context_lines":[{"line_number":6730,"context_line":"                context.session.delete(access_map)"},{"line_number":6731,"context_line":"        except db_exc.DBError:"},{"line_number":6732,"context_line":"            LOG.warning("},{"line_number":6733,"context_line":"                \"Deleting soft-deleted resource %s failed, skipping.\","},{"line_number":6734,"context_line":"                access_map,"},{"line_number":6735,"context_line":"            )"},{"line_number":6736,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e907ff36_45eae5eb","line":6733,"updated":"2026-05-26 07:36:59.000000000","message":"We can be more specific in the error message here, instead of \u0027resource\u0027 we can tell that it is about the \u0027access_map\u0027","commit_id":"f274c1607d5f3b32dc83f42b35b8354b0723f3bc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0d76b93455977887d70594c6a4fd0a1a12449f33","unresolved":false,"context_lines":[{"line_number":6730,"context_line":"                context.session.delete(access_map)"},{"line_number":6731,"context_line":"        except db_exc.DBError:"},{"line_number":6732,"context_line":"            LOG.warning("},{"line_number":6733,"context_line":"                \"Deleting soft-deleted resource %s failed, skipping.\","},{"line_number":6734,"context_line":"                access_map,"},{"line_number":6735,"context_line":"            )"},{"line_number":6736,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a55e8d37_dfb1ef5e","line":6733,"in_reply_to":"e907ff36_45eae5eb","updated":"2026-05-26 08:18:42.000000000","message":"Done","commit_id":"f274c1607d5f3b32dc83f42b35b8354b0723f3bc"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"7c0bd161adb11364818a725bb0b8a5b063d8e550","unresolved":true,"context_lines":[{"line_number":6771,"context_line":""},{"line_number":6772,"context_line":"    # Tables handled by dedicated purge helpers above; skip in the main loop"},{"line_number":6773,"context_line":"    # to avoid FK constraint errors from incorrect deletion ordering."},{"line_number":6774,"context_line":"    tables_with_dedicated_purge \u003d {\u0027share_access_map\u0027}"},{"line_number":6775,"context_line":""},{"line_number":6776,"context_line":"    for table in reversed(tables):"},{"line_number":6777,"context_line":"        if \u0027deleted\u0027 not in table.columns.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"62db0375_466bd54a","line":6774,"updated":"2026-05-26 07:36:59.000000000","message":"I think it makes sense to also add \u0027share_network_security_service_association\u0027 here","commit_id":"f274c1607d5f3b32dc83f42b35b8354b0723f3bc"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0d76b93455977887d70594c6a4fd0a1a12449f33","unresolved":false,"context_lines":[{"line_number":6771,"context_line":""},{"line_number":6772,"context_line":"    # Tables handled by dedicated purge helpers above; skip in the main loop"},{"line_number":6773,"context_line":"    # to avoid FK constraint errors from incorrect deletion ordering."},{"line_number":6774,"context_line":"    tables_with_dedicated_purge \u003d {\u0027share_access_map\u0027}"},{"line_number":6775,"context_line":""},{"line_number":6776,"context_line":"    for table in reversed(tables):"},{"line_number":6777,"context_line":"        if \u0027deleted\u0027 not in table.columns.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5037a0b_798a1869","line":6774,"in_reply_to":"62db0375_466bd54a","updated":"2026-05-26 08:18:42.000000000","message":"Done","commit_id":"f274c1607d5f3b32dc83f42b35b8354b0723f3bc"}],"releasenotes/notes/bug-2081827-fix-db-purge-share-access-map-fk-violation-cc0542ab36eb1798.yaml":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f43a97b1d1dbc29c44121ac0f28dbfcf4ce46b94","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed a foreign key constraint violation that occurred during the database"},{"line_number":5,"context_line":"    purge operation. When soft-deleted ``share_access_map`` rows were purged"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"cf215292_5d7f59f3","line":2,"updated":"2026-07-17 15:17:16.000000000","message":"sorry, could you please make this more end-user/admin friendly? feels like too much implementation details. We can try to trim it down to what the end users would see as a result of this bug.","commit_id":"0a65e5892d051ccd8ed0c535080ab9a012396da7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ef3f2d75beed9104ec609f0e10f3aa109e77efc8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed a foreign key constraint violation that occurred during the database"},{"line_number":5,"context_line":"    purge operation. When soft-deleted ``share_access_map`` rows were purged"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7c691773_0d9621c1","line":2,"in_reply_to":"cf215292_5d7f59f3","updated":"2026-07-17 15:35:05.000000000","message":"Done","commit_id":"0a65e5892d051ccd8ed0c535080ab9a012396da7"}]}
