)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"3ab795ba0f99a7dccd5efd32057a377884b6edbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"774ed02e_3d6a9e08","updated":"2026-06-02 14:36:03.000000000","message":"LGTM","commit_id":"777018a8c22240a6e2d2b1585f93e094c814dd07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ebb26283819f9a2df310c256823107581844f54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb285156_1dfaa0f8","updated":"2026-05-29 22:43:25.000000000","message":"LGTM. Thank you @kinpaa@gmail.com","commit_id":"777018a8c22240a6e2d2b1585f93e094c814dd07"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cbbb4c1a19b8bb37f384e27c6af1a793d34b4007","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9d46a83_22f8c027","updated":"2026-06-02 21:40:53.000000000","message":"good to backport to older stable releases. @kinpaa@gmail.com can you?","commit_id":"777018a8c22240a6e2d2b1585f93e094c814dd07"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ca495642b7e162aeb6f99cd68d8823d662135f2","unresolved":true,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    instance_mappings \u003d orm.relationship("},{"line_number":592,"context_line":"        \"ShareInstanceAccessMapping\","},{"line_number":593,"context_line":"        lazy\u003d\u0027subquery\u0027,"},{"line_number":594,"context_line":"        primaryjoin\u003d("},{"line_number":595,"context_line":"            \u0027and_(\u0027"},{"line_number":596,"context_line":"            \u0027ShareAccessMapping.id \u003d\u003d \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"29577357_24e7f40d","line":593,"updated":"2026-05-28 05:29:31.000000000","message":"a thought: `selectin` loading might be better here... `subquery` executes the original finder query as a subquery, while `selectin` does `WHERE id IN (pk1, pk2, ...)` on PKs already in memory.\n\nFor complex list queries and relationships with `join_depth\u003d2`, `selectin` can be more efficient. `subquery` is already a big win over `immediate`.. but we could consider this a pattern to improve on:\n\nWe could test on the devstack VM with SQL query logging:\n\n```\n  # Enable SQL echo temporarily in manila.conf\n  [database]\n  connection_debug \u003d 100\n```\n\nThe test: list snapshots with details on a deployment that has 50+ snapshots across multiple share instances. Compare total query count and wall-clock time between subquery and selectin.","commit_id":"4aeb9f79499949429d772775d3395661900f7079"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ebb26283819f9a2df310c256823107581844f54","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    instance_mappings \u003d orm.relationship("},{"line_number":592,"context_line":"        \"ShareInstanceAccessMapping\","},{"line_number":593,"context_line":"        lazy\u003d\u0027subquery\u0027,"},{"line_number":594,"context_line":"        primaryjoin\u003d("},{"line_number":595,"context_line":"            \u0027and_(\u0027"},{"line_number":596,"context_line":"            \u0027ShareAccessMapping.id \u003d\u003d \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7332cf2_aa4cc280","line":593,"in_reply_to":"1f7b89f5_57e4bc7d","updated":"2026-05-29 22:43:25.000000000","message":"Ack.. this is a good use case for it. And either approach is better than immediate loaning.","commit_id":"4aeb9f79499949429d772775d3395661900f7079"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6d3350f27ee4bca4473e80f7afc32ab5df0c975","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    instance_mappings \u003d orm.relationship("},{"line_number":592,"context_line":"        \"ShareInstanceAccessMapping\","},{"line_number":593,"context_line":"        lazy\u003d\u0027subquery\u0027,"},{"line_number":594,"context_line":"        primaryjoin\u003d("},{"line_number":595,"context_line":"            \u0027and_(\u0027"},{"line_number":596,"context_line":"            \u0027ShareAccessMapping.id \u003d\u003d \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f7b89f5_57e4bc7d","line":593,"in_reply_to":"29577357_24e7f40d","updated":"2026-05-28 10:34:28.000000000","message":"Changed to \"selectin\", I have not experimented but some queries discussed over chatgpt suggest indeed \u0027selectin\u0027 is better than \u0027subquery\u0027 for manila.","commit_id":"4aeb9f79499949429d772775d3395661900f7079"}],"releasenotes/notes/bug-1859785-share-list-speed-6b09e7717624e037.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5ca495642b7e162aeb6f99cd68d8823d662135f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"338d8057_ed4b4f7c","updated":"2026-05-28 05:29:31.000000000","message":"No, can\u0027t edit a release note like this. Please create a new one","commit_id":"4aeb9f79499949429d772775d3395661900f7079"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"f6d3350f27ee4bca4473e80f7afc32ab5df0c975","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2a55c2b_a9a24a46","in_reply_to":"338d8057_ed4b4f7c","updated":"2026-05-28 10:34:28.000000000","message":"Done","commit_id":"4aeb9f79499949429d772775d3395661900f7079"}]}