)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"67c09ee9ed80e42d75da4370b8da5339644415d9","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     medhac \u003cmedhac@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-03 01:09:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp Rest implementation for get_cluster_peers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id13654c899b796837a75060812ef483a4851d12b"},{"line_number":10,"context_line":"Signed-off-by: medhac \u003cmedhac@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf409a87_02871376","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"updated":"2026-06-03 12:27:19.000000000","message":"Please add release notes as well.","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"},{"author":{"_account_id":39161,"name":"Medha Choudhary (netapp)","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"a8d17b4e655c5fe2d6e96f610575bd261350b1e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     medhac \u003cmedhac@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-03 01:09:31 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp Rest implementation for get_cluster_peers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id13654c899b796837a75060812ef483a4851d12b"},{"line_number":10,"context_line":"Signed-off-by: medhac \u003cmedhac@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cc6bb57b_a81721b8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":48},"in_reply_to":"bf409a87_02871376","updated":"2026-06-04 10:48:58.000000000","message":"Done","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"7b2a74f7cfefa4f2fdc6b728e6265bea8b75b621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73c4698a_7e6dafa6","updated":"2026-06-03 12:51:24.000000000","message":"Changes looks good to me, resolve the comment provided by Anoop and add ther release note.","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"f3e7709366193ee698a20bb108b38b50d5a9a8d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0407ecb8_1f56ee93","updated":"2026-06-03 06:22:45.000000000","message":"LGTM.","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"67c09ee9ed80e42d75da4370b8da5339644415d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"125f86cd_09bcd142","updated":"2026-06-03 12:27:19.000000000","message":"Please take a look at the comments.","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e0f88ed3965da8a5679777d5f64d332f6ab47aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"961fb780_2950e3e1","updated":"2026-06-04 11:19:26.000000000","message":"LGTM","commit_id":"df22526acac478625993d60a4193d60fbeb6a979"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"00571bc2cb31265c2fbee225c8a2b2dad84d1117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"71594ef0_2682a0a0","updated":"2026-06-04 05:26:11.000000000","message":"LGTM.","commit_id":"df22526acac478625993d60a4193d60fbeb6a979"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e16f5dcc4da280d9a7e932eef7f0b723f176fbec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3aa8e712_6afff311","updated":"2026-06-04 13:02:28.000000000","message":"LGTM. I am not sure about releasenotes as its not feature neither bug fix. End user is not going to affect directly, so we can remove it.","commit_id":"df22526acac478625993d60a4193d60fbeb6a979"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"f38875cfcbb8e690dd2dc2732a6ed956ec4f9765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"609b8a56_367b08d1","updated":"2026-06-04 15:40:44.000000000","message":"same like Kiran\n\nalso I noted REST implementation omits the `timeout` field that ZAPI returns, but that field is never read by calling code, so it is okay for me","commit_id":"df22526acac478625993d60a4193d60fbeb6a979"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"7be96ae001e38f75dbabc3b47caedf3f7b3eea73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3454918f_3c8e3a1e","in_reply_to":"3aa8e712_6afff311","updated":"2026-06-05 05:18:18.000000000","message":"This is a feature as we are removing the dependencies on ZAPIs. So all the changes related to the ZAPI-\u003eREST gap fills IMO should be treated as enhancements to existing code base.","commit_id":"df22526acac478625993d60a4193d60fbeb6a979"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"a1ca893dce4cb78946165442bbedc1e809cfb722","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9fc7a1b4_5ad3dd41","updated":"2026-06-05 06:48:10.000000000","message":"LGTM.","commit_id":"22b182c32df7ee6b442c5ae634190ec61c241e64"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"7be96ae001e38f75dbabc3b47caedf3f7b3eea73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a205a38e_dbf556e4","updated":"2026-06-05 05:18:18.000000000","message":"LGTM.","commit_id":"22b182c32df7ee6b442c5ae634190ec61c241e64"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"00e9552211df983377dcabae14dc2d7701d00704","unresolved":true,"context_lines":[{"line_number":4099,"context_line":"                      \u0027remote.ip_addresses,remote.serial_number\u0027,"},{"line_number":4100,"context_line":"        }"},{"line_number":4101,"context_line":"        if remote_cluster_name:"},{"line_number":4102,"context_line":"            query[\u0027name\u0027] \u003d remote_cluster_name"},{"line_number":4103,"context_line":""},{"line_number":4104,"context_line":"        result \u003d self.get_records("},{"line_number":4105,"context_line":"            \u0027/cluster/peers\u0027, query\u003dquery, enable_tunneling\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a82c8330_493ec5dc","line":4102,"updated":"2026-06-02 12:22:10.000000000","message":"Have you tested this??\n\nCan you verify the ONTAP docs whether name query param is supported on not in ONTAP 9.17.1 or 9.18.1?\n\nI see that this filter params is newly added in 9.20.1 yaml as per https://10.196.34.155/docs/api/#/Cluster/cluster_peer_collection_get","commit_id":"e50b5463488322506049928125c6bffa4c030c17"},{"author":{"_account_id":39161,"name":"Medha Choudhary (netapp)","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"c4f1b746d85a5286feba5218069db40e5bbc1d7c","unresolved":false,"context_lines":[{"line_number":4099,"context_line":"                      \u0027remote.ip_addresses,remote.serial_number\u0027,"},{"line_number":4100,"context_line":"        }"},{"line_number":4101,"context_line":"        if remote_cluster_name:"},{"line_number":4102,"context_line":"            query[\u0027name\u0027] \u003d remote_cluster_name"},{"line_number":4103,"context_line":""},{"line_number":4104,"context_line":"        result \u003d self.get_records("},{"line_number":4105,"context_line":"            \u0027/cluster/peers\u0027, query\u003dquery, enable_tunneling\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"20304d7f_8e01edb3","line":4102,"in_reply_to":"a82c8330_493ec5dc","updated":"2026-06-03 05:16:42.000000000","message":"yes i tested but since cluster had one peer it worked, but you are right that filter is not available in version less than 9.20. So i have removed the server side filter and added it in reponse","commit_id":"e50b5463488322506049928125c6bffa4c030c17"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"67c09ee9ed80e42d75da4370b8da5339644415d9","unresolved":true,"context_lines":[{"line_number":4094,"context_line":"    def get_cluster_peers(self, remote_cluster_name\u003dNone):"},{"line_number":4095,"context_line":"        \"\"\"Gets one or more cluster peer relationships.\"\"\""},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        query \u003d {"},{"line_number":4098,"context_line":"            \u0027fields\u0027: \u0027name,uuid,status.state,ip_addresses,remote.name,\u0027"},{"line_number":4099,"context_line":"                      \u0027remote.ip_addresses,remote.serial_number\u0027,"},{"line_number":4100,"context_line":"        }"},{"line_number":4101,"context_line":""},{"line_number":4102,"context_line":"        result \u003d self.get_records("},{"line_number":4103,"context_line":"            \u0027/cluster/peers\u0027, query\u003dquery, enable_tunneling\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9df5cad8_9e06cc44","line":4100,"range":{"start_line":4097,"start_character":7,"end_line":4100,"end_character":9},"updated":"2026-06-03 12:27:19.000000000","message":"Why dont we pass the remote_cluster_name if we need it to be filtered if its not None here? That way we do not need to loop through all the cluster peers and do the check in line 4112 and its expected to return only one record.","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e0f88ed3965da8a5679777d5f64d332f6ab47aba","unresolved":false,"context_lines":[{"line_number":4094,"context_line":"    def get_cluster_peers(self, remote_cluster_name\u003dNone):"},{"line_number":4095,"context_line":"        \"\"\"Gets one or more cluster peer relationships.\"\"\""},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        query \u003d {"},{"line_number":4098,"context_line":"            \u0027fields\u0027: \u0027name,uuid,status.state,ip_addresses,remote.name,\u0027"},{"line_number":4099,"context_line":"                      \u0027remote.ip_addresses,remote.serial_number\u0027,"},{"line_number":4100,"context_line":"        }"},{"line_number":4101,"context_line":""},{"line_number":4102,"context_line":"        result \u003d self.get_records("},{"line_number":4103,"context_line":"            \u0027/cluster/peers\u0027, query\u003dquery, enable_tunneling\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"02cc9b99_08644891","line":4100,"range":{"start_line":4097,"start_character":7,"end_line":4100,"end_character":9},"in_reply_to":"2f9a939e_6ccc6272","updated":"2026-06-04 11:19:26.000000000","message":"ok acknowledged.","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"d751e76e044b96c17a32efd866732d039827a659","unresolved":false,"context_lines":[{"line_number":4094,"context_line":"    def get_cluster_peers(self, remote_cluster_name\u003dNone):"},{"line_number":4095,"context_line":"        \"\"\"Gets one or more cluster peer relationships.\"\"\""},{"line_number":4096,"context_line":""},{"line_number":4097,"context_line":"        query \u003d {"},{"line_number":4098,"context_line":"            \u0027fields\u0027: \u0027name,uuid,status.state,ip_addresses,remote.name,\u0027"},{"line_number":4099,"context_line":"                      \u0027remote.ip_addresses,remote.serial_number\u0027,"},{"line_number":4100,"context_line":"        }"},{"line_number":4101,"context_line":""},{"line_number":4102,"context_line":"        result \u003d self.get_records("},{"line_number":4103,"context_line":"            \u0027/cluster/peers\u0027, query\u003dquery, enable_tunneling\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f9a939e_6ccc6272","line":4100,"range":{"start_line":4097,"start_character":7,"end_line":4100,"end_character":9},"in_reply_to":"9df5cad8_9e06cc44","updated":"2026-06-04 05:05:36.000000000","message":"name query filter is not available till now, it is getting added in 9.20.1\nRefer below comment for details:\nhttps://review.opendev.org/c/openstack/manila/+/991013/comment/a82c8330_493ec5dc/","commit_id":"428e69b4cc6b7ac0039efffec4a6543b23e1c2e4"}]}