)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"93b0c65503ce1e98238133be1ce2d12cd54475e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67261d18_7adaa3b0","updated":"2026-06-04 10:05:51.000000000","message":"Added few comments","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"14563c50e6e7bb83c41a8433b63a7eb3a8de8fb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de29b28d_c29484a8","updated":"2026-06-04 09:36:05.000000000","message":"Please take a look at the comments.","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"416a030add1ad21408056607870be2fa2311b68b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3c815207_533c9b38","updated":"2026-06-05 06:50:43.000000000","message":"LGTM.","commit_id":"1f249705739d51f9083b5585414025c935d2138a"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"959cbca5a26236a72ee6f5ee755660816dd8457f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d9c9112e_2b190e6a","updated":"2026-06-18 16:28:25.000000000","message":"Please look at the comments.","commit_id":"1f249705739d51f9083b5585414025c935d2138a"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"f5935647c35aada27376a60b3799196e1bdad0ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9d3b89c8_c9d4128c","in_reply_to":"d9c9112e_2b190e6a","updated":"2026-06-24 03:19:02.000000000","message":"Hi Anoop,\nThese are ONTAP\u0027s verbatim error strings — the legacy ZAPI client uses \"Vserver\" while the REST client uses \"SVM\", and the \"IPspace or cluster\" wording comes from ONTAP itself because an SVM name shares that namespace. _get_backup_vserver suppresses the condition by matching the error code, not the message text, so the exact wording is illustrative. Added a NOTE in the test to make this clear.","commit_id":"1f249705739d51f9083b5585414025c935d2138a"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"99eb1078f911e235d8fb4224f76c3a2d949225c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5156c240_8644ce7e","updated":"2026-07-08 13:25:25.000000000","message":"LGTM","commit_id":"d0b6a38690b9d5dbea4ec2df8447693750c61ef1"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"8c0dd70d31cf63002d4e7323d183f276864e0eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1049c708_e12c476e","updated":"2026-06-24 04:15:48.000000000","message":"LGTM.","commit_id":"d0b6a38690b9d5dbea4ec2df8447693750c61ef1"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"14563c50e6e7bb83c41a8433b63a7eb3a8de8fb0","unresolved":true,"context_lines":[{"line_number":2862,"context_line":"            )"},{"line_number":2863,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2864,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":2865,"context_line":"                if \u0027already used\u0027 in e.message or \u0027already in use\u0027 in e.message:"},{"line_number":2866,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":2867,"context_line":"        return des_vserver"},{"line_number":2868,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf6aae29_f90732b3","line":2865,"updated":"2026-06-04 09:36:05.000000000","message":"Can we instead use the error code? If ONTAP changes the message in future, this handling will fail.","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"eb8dbc33af16f553627a1ba1c8d23a8804bf09e5","unresolved":false,"context_lines":[{"line_number":2862,"context_line":"            )"},{"line_number":2863,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2864,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":2865,"context_line":"                if \u0027already used\u0027 in e.message or \u0027already in use\u0027 in e.message:"},{"line_number":2866,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":2867,"context_line":"        return des_vserver"},{"line_number":2868,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4c151c5d_ef64c9af","line":2865,"in_reply_to":"620e62f1_778557cc","updated":"2026-06-04 12:21:22.000000000","message":"Acknowledged","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"14563c50e6e7bb83c41a8433b63a7eb3a8de8fb0","unresolved":true,"context_lines":[{"line_number":2862,"context_line":"            )"},{"line_number":2863,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2864,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":2865,"context_line":"                if \u0027already used\u0027 in e.message or \u0027already in use\u0027 in e.message:"},{"line_number":2866,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":2867,"context_line":"        return des_vserver"},{"line_number":2868,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c3bc151e_841bb2f1","line":2865,"in_reply_to":"8eb4ae57_fb6b9863","updated":"2026-06-04 09:36:05.000000000","message":"\u003e pep8: E501 line too long (80 \u003e 79 characters)\n\nPlease fix.","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"93b0c65503ce1e98238133be1ce2d12cd54475e7","unresolved":true,"context_lines":[{"line_number":2862,"context_line":"            )"},{"line_number":2863,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2864,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":2865,"context_line":"                if \u0027already used\u0027 in e.message or \u0027already in use\u0027 in e.message:"},{"line_number":2866,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":2867,"context_line":"        return des_vserver"},{"line_number":2868,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"620e62f1_778557cc","line":2865,"in_reply_to":"bf6aae29_f90732b3","updated":"2026-06-04 10:05:51.000000000","message":"ZAPI also needs to provide error code, if not keep both with or condition(if errcode or \"already used\". Please verify that aspect.","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"eb8dbc33af16f553627a1ba1c8d23a8804bf09e5","unresolved":false,"context_lines":[{"line_number":2862,"context_line":"            )"},{"line_number":2863,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":2864,"context_line":"            with excutils.save_and_reraise_exception() as exc_context:"},{"line_number":2865,"context_line":"                if \u0027already used\u0027 in e.message or \u0027already in use\u0027 in e.message:"},{"line_number":2866,"context_line":"                    exc_context.reraise \u003d False"},{"line_number":2867,"context_line":"        return des_vserver"},{"line_number":2868,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b1163bef_39ac3499","line":2865,"in_reply_to":"c3bc151e_841bb2f1","updated":"2026-06-04 12:21:22.000000000","message":"Done","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"}],"manila/tests/share/drivers/netapp/dataontap/cluster_mode/test_lib_multi_svm.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"14563c50e6e7bb83c41a8433b63a7eb3a8de8fb0","unresolved":true,"context_lines":[{"line_number":4487,"context_line":"            export_locations\u003dNone)"},{"line_number":4488,"context_line":""},{"line_number":4489,"context_line":"    @ddt.data("},{"line_number":4490,"context_line":"        \u0027Vserver name is already used by another Vserver\u0027,"},{"line_number":4491,"context_line":"        \u0027Invalid SVM name. The name is already in use by another SVM, \u0027"},{"line_number":4492,"context_line":"        \u0027IPspace or cluster.\u0027,"},{"line_number":4493,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"32f42490_af633633","line":4490,"range":{"start_line":4490,"start_character":9,"end_line":4490,"end_character":56},"updated":"2026-06-04 09:36:05.000000000","message":"\"The SVM name is already used.\" Using Vserver and SVM interchangably creates confusion.","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"93b0c65503ce1e98238133be1ce2d12cd54475e7","unresolved":true,"context_lines":[{"line_number":4487,"context_line":"            export_locations\u003dNone)"},{"line_number":4488,"context_line":""},{"line_number":4489,"context_line":"    @ddt.data("},{"line_number":4490,"context_line":"        \u0027Vserver name is already used by another Vserver\u0027,"},{"line_number":4491,"context_line":"        \u0027Invalid SVM name. The name is already in use by another SVM, \u0027"},{"line_number":4492,"context_line":"        \u0027IPspace or cluster.\u0027,"},{"line_number":4493,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"aef921ff_5f506d91","line":4490,"range":{"start_line":4490,"start_character":9,"end_line":4490,"end_character":56},"in_reply_to":"32f42490_af633633","updated":"2026-06-04 10:05:51.000000000","message":"Is this exact error message from ONTAP? \nIf so this should be fine @anoop.shukla@netapp.com for UT","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"eb8dbc33af16f553627a1ba1c8d23a8804bf09e5","unresolved":false,"context_lines":[{"line_number":4487,"context_line":"            export_locations\u003dNone)"},{"line_number":4488,"context_line":""},{"line_number":4489,"context_line":"    @ddt.data("},{"line_number":4490,"context_line":"        \u0027Vserver name is already used by another Vserver\u0027,"},{"line_number":4491,"context_line":"        \u0027Invalid SVM name. The name is already in use by another SVM, \u0027"},{"line_number":4492,"context_line":"        \u0027IPspace or cluster.\u0027,"},{"line_number":4493,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb47c91d_cfec8ff4","line":4490,"range":{"start_line":4490,"start_character":9,"end_line":4490,"end_character":56},"in_reply_to":"aef921ff_5f506d91","updated":"2026-06-04 12:21:22.000000000","message":"added the exact message from zapi and rest","commit_id":"eb230443dada90c37972e047d950e5c587f571d0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"959cbca5a26236a72ee6f5ee755660816dd8457f","unresolved":true,"context_lines":[{"line_number":4494,"context_line":"        # REST client returns error code 13434908 for this condition."},{"line_number":4495,"context_line":"        {\u0027code\u0027: rest_api.EREST_VSERVER_NAME_IN_USE,"},{"line_number":4496,"context_line":"         \u0027message\u0027: \u0027Invalid SVM name. The name is already in use by \u0027"},{"line_number":4497,"context_line":"                    \u0027another SVM, IPspace or cluster.\u0027},"},{"line_number":4498,"context_line":"    )"},{"line_number":4499,"context_line":"    def test__get_backup_vserver(self, api_error):"},{"line_number":4500,"context_line":"        mock_dest_client \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"16e8ee05_921193e9","line":4497,"range":{"start_line":4497,"start_character":34,"end_line":4497,"end_character":52},"updated":"2026-06-18 16:28:25.000000000","message":"Why IPspace or cluster? shouldnt it be just the SVM name that we should keep in the SVM? Also in some places we have used Vserver and other SVM. Please keep a single naming convention as it confuses users.","commit_id":"1f249705739d51f9083b5585414025c935d2138a"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"742de5f0bf5ec2296f810f3d31f15c716242a01d","unresolved":false,"context_lines":[{"line_number":4494,"context_line":"        # REST client returns error code 13434908 for this condition."},{"line_number":4495,"context_line":"        {\u0027code\u0027: rest_api.EREST_VSERVER_NAME_IN_USE,"},{"line_number":4496,"context_line":"         \u0027message\u0027: \u0027Invalid SVM name. The name is already in use by \u0027"},{"line_number":4497,"context_line":"                    \u0027another SVM, IPspace or cluster.\u0027},"},{"line_number":4498,"context_line":"    )"},{"line_number":4499,"context_line":"    def test__get_backup_vserver(self, api_error):"},{"line_number":4500,"context_line":"        mock_dest_client \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"a02ddaf6_8540e6b1","line":4497,"range":{"start_line":4497,"start_character":34,"end_line":4497,"end_character":52},"in_reply_to":"16e8ee05_921193e9","updated":"2026-06-24 03:19:54.000000000","message":"These are ONTAP\u0027s verbatim error strings — the legacy ZAPI client uses \"Vserver\" while the REST client uses \"SVM\", and the \"IPspace or cluster\" wording comes from ONTAP itself because an SVM name shares that namespace. _get_backup_vserver suppresses the condition by matching the error code, not the message text, so the exact wording is illustrative. Added a NOTE in the test to make this clear.","commit_id":"1f249705739d51f9083b5585414025c935d2138a"}]}