)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"ca19989a46b7e6bc1f0131b9901f06a7ed599dee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"02a2a4d0_ec8955d6","updated":"2026-06-09 08:29:06.000000000","message":"please do a review when you get the time.","commit_id":"3082b09263f0376809fe1e42be99414b10d2b156"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a09700e5078062860e1a45e1d92579e00dcaa7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82bde6b8_c95e339f","updated":"2026-08-27 17:48:36.000000000","message":"run-DellEMC PowerStore CI","commit_id":"3082b09263f0376809fe1e42be99414b10d2b156"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"7f0e876d93c2336d279e800e607e19415e2d31ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bfa59d96_e78dfb3b","updated":"2026-06-09 07:27:19.000000000","message":"run-DellEMC PowerStore CI","commit_id":"3082b09263f0376809fe1e42be99414b10d2b156"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"8f548d1ca6d5b2ff1df8d80068abcdb48a5f731e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cac9cb97_9d321555","updated":"2026-08-06 05:52:56.000000000","message":"run-DellEMC PowerStore CI","commit_id":"3082b09263f0376809fe1e42be99414b10d2b156"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"9143336c5122ee82581f3ec5ae77fa21e1cbc665","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fbe5053a_3ec2ffa9","updated":"2026-08-06 06:39:32.000000000","message":"run-DellEMC PowerStore CI","commit_id":"3082b09263f0376809fe1e42be99414b10d2b156"},{"author":{"_account_id":38284,"name":"Prasant Padhi","display_name":"Prasant Padhi","email":"prasant.padhi@dell.com","username":"prasant.padhi@dell.com"},"change_message_id":"46a366f0df04741c9937b80362e062fbda6e8226","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"663fa4f5_5bc13ebf","updated":"2026-09-02 12:52:04.000000000","message":"LGTM!","commit_id":"f195d4ab373bd286792c0405e81f2c584aed623b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"15649aeb0a896a759922930fcff361da87dc634d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d0c6903_6e2b50ad","updated":"2026-09-02 13:53:11.000000000","message":"LGTM, thank you for working on this feature. I\u0027m about to go on PTO, but I\u0027m okay if this change merges with changes other reviewers might request.","commit_id":"f195d4ab373bd286792c0405e81f2c584aed623b"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"d1b711d571d54aa728640c2c9d02b0603b69b0b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ae32a63c_379143c9","updated":"2026-09-03 15:45:32.000000000","message":"Thanks for working on this, changes looks good for me.","commit_id":"f195d4ab373bd286792c0405e81f2c584aed623b"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"509851b34a1ef64bb34c2374da4dd2e5b038ee9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca823654_3c71bad7","updated":"2026-09-04 01:36:29.000000000","message":"recheck","commit_id":"f195d4ab373bd286792c0405e81f2c584aed623b"}],"manila/share/drivers/dell_emc/plugins/powerstore/connection.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"15649aeb0a896a759922930fcff361da87dc634d","unresolved":true,"context_lines":[{"line_number":198,"context_line":"            LOG.error(\"Failed to apply QoS policy to filesystem \""},{"line_number":199,"context_line":"                      \"for share \u0027%s\u0027. Cleaning up filesystem.\","},{"line_number":200,"context_line":"                      share_name)"},{"line_number":201,"context_line":"            self.client.delete_filesystem(filesystem_id)"},{"line_number":202,"context_line":"            raise"},{"line_number":203,"context_line":"        # create a share"},{"line_number":204,"context_line":"        locations \u003d self._create_share_NFS_CIFS(nas_server_id, filesystem_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"40fdd238_5637a5d7","line":201,"range":{"start_line":201,"start_character":12,"end_line":201,"end_character":56},"updated":"2026-09-02 13:53:11.000000000","message":"is it really necessary to delete the filesystem? shouldn\u0027t only the share be errored out?","commit_id":"f195d4ab373bd286792c0405e81f2c584aed623b"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"b52f3a48057f6f7458332ef89cc0b0d58d8b5510","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            LOG.error(\"Failed to apply QoS policy to filesystem \""},{"line_number":199,"context_line":"                      \"for share \u0027%s\u0027. Cleaning up filesystem.\","},{"line_number":200,"context_line":"                      share_name)"},{"line_number":201,"context_line":"            self.client.delete_filesystem(filesystem_id)"},{"line_number":202,"context_line":"            raise"},{"line_number":203,"context_line":"        # create a share"},{"line_number":204,"context_line":"        locations \u003d self._create_share_NFS_CIFS(nas_server_id, filesystem_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"919a6955_16e93154","line":201,"range":{"start_line":201,"start_character":12,"end_line":201,"end_character":56},"in_reply_to":"40fdd238_5637a5d7","updated":"2026-09-03 02:33:18.000000000","message":"At this point in the flow, only the filesystem has been created on the PowerStore backend — the NFS export or SMB share hasn\u0027t been created yet (that happens at line 204). When create_share raises an exception, the Manila share manager only sets the share to error status; it does NOT call delete_share to clean up backend resources. Without this cleanup, the filesystem would be orphaned on the array with no way for Manila to track or delete it. This is also the same pattern used in _create_share_from_snapshot (line 959-963) in this same patch.","commit_id":"f195d4ab373bd286792c0405e81f2c584aed623b"}],"manila/tests/share/drivers/dell_emc/plugins/powerstore/test_connection.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3dae0d14e5c1e4edb3f560ad930c7def4f1754ba","unresolved":false,"context_lines":[{"line_number":2516,"context_line":"            self.storage_connection.extend_share,"},{"line_number":2517,"context_line":"            share, self.SHARE_NEW_SIZE_GB, None"},{"line_number":2518,"context_line":"        )"},{"line_number":2519,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"40c685ae_eafdd84d","line":2519,"updated":"2026-09-01 19:14:02.000000000","message":"pep8: W391 blank line at end of file","commit_id":"4b373c5dfa0ee18c40f17413730b2c2570d44253"}]}
