)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":30,"id":"88ce428e_43a3d362","line":17,"updated":"2026-08-14 19:41:32.000000000","message":"please add a Depends-On to the core change","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"044c6b88c583dc00775dfc74d51708b8f58eaa71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"79663c7f_5cb23be8","updated":"2026-07-16 12:42:55.000000000","message":"run-HPE Storage Manila CI","commit_id":"537378d26050d7c3713040c5d917d96f4f09f0cd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"9b06437e02e06d54ea39c8983f15bd7f4879522a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"848dbb57_9e6136a6","updated":"2026-07-16 09:05:08.000000000","message":"run-HPE Storage Manila CI","commit_id":"537378d26050d7c3713040c5d917d96f4f09f0cd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"d4f133e1f212e16cfdeca7ae07a7da2f1c6553a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"95a3f308_c446c285","updated":"2026-07-16 11:26:11.000000000","message":"run-HPE Storage Manila CI","commit_id":"537378d26050d7c3713040c5d917d96f4f09f0cd"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"e177093f452abbaabb20ec1789d7653a1dd7ba65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5469fb06_8adae769","updated":"2026-07-17 09:25:03.000000000","message":"run-HPE Storage Manila CI","commit_id":"4e45be9a02a40482e29d53cbcc6eb2c173036962"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"9666180a63eb74bb4dc118cb03156ff4246639f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"8c181c01_c33beecd","updated":"2026-08-09 11:14:21.000000000","message":"run-HPE Storage Manila CI","commit_id":"ac5936b6ac633e78e07e5b4e329cba0fd4ecdd77"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"3fcc673631cc33b05799df3804c492f0f89473e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"e3009c89_566fc727","updated":"2026-08-09 10:56:47.000000000","message":"run-HPE Storage Manila CI","commit_id":"ac5936b6ac633e78e07e5b4e329cba0fd4ecdd77"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"81ee2abc7aa36078e0375804f297ba8d1dea3827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"818c5c2b_4e16f5ab","updated":"2026-08-10 05:11:40.000000000","message":"run-HPE Storage Manila CI","commit_id":"c448e2aef3a82f96312b14d39267b457d4759513"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"618b212693dd10e6f51c850c464ef374f8a86c58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5f0c557a_c522fe19","updated":"2026-08-11 13:45:28.000000000","message":"recheck","commit_id":"c2d2035d0fc426ae49956bd615fdeefbc6fd624e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"0f2d570f_b516cfb7","updated":"2026-08-14 19:41:32.000000000","message":"Thank you for working on this change. Please take a look at the comments inline","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"04efef277fc9c4bebaa3752a1b7986d29d6e6e0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"55f49b3e_a287b193","updated":"2026-08-17 05:31:41.000000000","message":"Thanks for the patch Srinesh. Please take a look at the comments. Keeping -1 till Carlos\u0027s comments and these comments are addressed.","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"},{"author":{"_account_id":38607,"name":"Srinesh A R","display_name":"Srinesh A R","email":"srinesh.a-r@hpe.com","username":"srineshar"},"change_message_id":"7aa531343b23f02d0ef2d453a5001a6b969c2db1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"540b5f4d_20a339d8","updated":"2026-08-12 05:00:18.000000000","message":"run-HPE Storage Manila CI","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"doc/source/admin/hpe_alletra_mp_b10000_driver.rst":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"04efef277fc9c4bebaa3752a1b7986d29d6e6e0f","unresolved":true,"context_lines":[{"line_number":366,"context_line":"- Only NFS protocol is supported; CIFS/SMB is not supported"},{"line_number":367,"context_line":"- Share networks are not supported (driver_handles_share_servers must be False)"},{"line_number":368,"context_line":"- Share shrink is not currently supported"},{"line_number":369,"context_line":"- Creating a share from a snapshot is not supported"},{"line_number":370,"context_line":"- Share migration is not supported"},{"line_number":371,"context_line":"- Share replication is not supported"},{"line_number":372,"context_line":"- Share groups and consistency groups are not supported"}],"source_content_type":"text/x-rst","patch_set":30,"id":"9be06f8a_a07e2243","line":369,"updated":"2026-08-17 05:31:41.000000000","message":"Any particular reason creating a share from snapshot is not supported? Is it a platform limitation or a future planned work? The reason for asking is, this is the safest way to get your backups and use them. Other methods like revert-to and mountable snapshots are disruptive and fiddle with the original Volume or the actual backup.","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"manila/share/drivers/hpe/alletra_mp_b10000/fileshare/filesetup_handler.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"04efef277fc9c4bebaa3752a1b7986d29d6e6e0f","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            raise exception.HPEAlletraB10000DriverException(reason\u003dmsg)"},{"line_number":52,"context_line":"        elif len(systems_dict) \u003e 1:"},{"line_number":53,"context_line":"            msg \u003d _(\"BE Systems members field has more than 1 key\")"},{"line_number":54,"context_line":"            LOG.error(msg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        version \u003d None"},{"line_number":57,"context_line":"        for key in systems_dict:"}],"source_content_type":"text/x-python","patch_set":30,"id":"b085261f_b078c72e","line":54,"updated":"2026-08-17 05:31:41.000000000","message":"Missing an exception raise here?","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"manila/share/drivers/hpe/alletra_mp_b10000/fileshare/fileshare_handler.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":true,"context_lines":[{"line_number":402,"context_line":"    def _get_fileshare_by_filesystem_name("},{"line_number":403,"context_line":"            self,"},{"line_number":404,"context_line":"            be_filesystem_name):"},{"line_number":405,"context_line":"        fe_fileshares \u003d self.get_fileshares()"},{"line_number":406,"context_line":"        for fileshare in fe_fileshares:"},{"line_number":407,"context_line":"            if fileshare[\u0027be_filesystem_name\u0027] \u003d\u003d be_filesystem_name:"},{"line_number":408,"context_line":"                # We assume only one share will exist with this condition"}],"source_content_type":"text/x-python","patch_set":30,"id":"0b8601ba_2cf3dca9","line":405,"range":{"start_line":405,"start_character":24,"end_line":405,"end_character":45},"updated":"2026-08-14 19:41:32.000000000","message":"is there a way to query and filter by the name? that would help not iterating through every single filesystem and save some time","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"04efef277fc9c4bebaa3752a1b7986d29d6e6e0f","unresolved":true,"context_lines":[{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        if self.feature_support_handler.check_min_r6_device_version():"},{"line_number":794,"context_line":"            if \u0027detailedState\u0027 not in be_fileshare:"},{"line_number":795,"context_line":"                msg \u003d _(\"Mount path not found in get fileshare by id response\")"},{"line_number":796,"context_line":"                LOG.error(msg)"},{"line_number":797,"context_line":"                raise exception.HPEAlletraB10000DriverException(reason\u003dmsg)"},{"line_number":798,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"b9c2963a_29b174a5","line":795,"range":{"start_line":795,"start_character":25,"end_line":795,"end_character":35},"updated":"2026-08-17 05:31:41.000000000","message":"Log message should reference detailedState?","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"manila/share/drivers/hpe/alletra_mp_b10000/fileshare/helpers.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":true,"context_lines":[{"line_number":96,"context_line":"POLL_RESOURCE_LOOKUP_TIMEOUT \u003d 30"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def poll_for_resource(get_resource, resource_description):"},{"line_number":100,"context_line":"    \"\"\"Poll a backend lookup until it succeeds or times out."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    Works around backend eventual consistency where a just-created"}],"source_content_type":"text/x-python","patch_set":30,"id":"75241c6d_fc97e39b","line":99,"updated":"2026-08-14 19:41:32.000000000","message":"any chance we could use @utils.retry?","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":true,"context_lines":[{"line_number":104,"context_line":"    \"\"\""},{"line_number":105,"context_line":"    def _attempt():"},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            raise loopingcall.LoopingCallDone(get_resource())"},{"line_number":108,"context_line":"        except exception.HPEAlletraB10000DriverException:"},{"line_number":109,"context_line":"            LOG.debug(\"Waiting for %(resource)s to become available on \""},{"line_number":110,"context_line":"                      \"the backend.\", {\u0027resource\u0027: resource_description})"}],"source_content_type":"text/x-python","patch_set":30,"id":"eb0af3b8_0fbf5280","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":61},"updated":"2026-08-14 19:41:32.000000000","message":"maybe there\u0027s a chance that if get_resource() returns None or {} (resource doesn\u0027t exist yet but the lookup doesn\u0027t raise), LoopingCallDone will fire with None as the return value, causing a falsy return","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"manila/share/drivers/hpe/alletra_mp_b10000/fileshare/snapshot_handler.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"c6178c986bc5f457d1e5dda6192efc100fc0fe77","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                        fe_create_snapshot[\u0027id\u0027],"},{"line_number":82,"context_line":"                        fe_snap_fileshare[\u0027be_uid\u0027])"},{"line_number":83,"context_line":"                except Exception as cleanup_error:"},{"line_number":84,"context_line":"                    LOG.error("},{"line_number":85,"context_line":"                        _(\"Failed to clean up snapshot share \u0027%(snap)s\u0027 \""},{"line_number":86,"context_line":"                          \"after snapshot online failure. Manual cleanup may \""},{"line_number":87,"context_line":"                          \"be required. Error: %(error)s\"),"}],"source_content_type":"text/x-python","patch_set":21,"id":"54e60794_8ade1111","line":84,"updated":"2026-08-07 08:39:12.000000000","message":"pep8: M359 Don\u0027t translate log messages!","commit_id":"60f6ff7be1f032fa24935d32e79362c3104f9a84"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                    fe_snap_filesystem[\u0027be_uid\u0027])"},{"line_number":71,"context_line":"            except Exception as e:"},{"line_number":72,"context_line":"                # We were unable to bring the snapshot online."},{"line_number":73,"context_line":"                # Clean up the snapshot fileshare and filesystem"},{"line_number":74,"context_line":"                msg \u003d _(\"Failed to bring snapshot \u0027%(snap)s\u0027 online. \""},{"line_number":75,"context_line":"                        \"Cleaning up the snapshot share and filesystem. \""},{"line_number":76,"context_line":"                        \"Error: %(error)s\") % {"}],"source_content_type":"text/x-python","patch_set":30,"id":"28280db7_072a2c54","line":73,"range":{"start_line":73,"start_character":17,"end_line":73,"end_character":64},"updated":"2026-08-14 19:41:32.000000000","message":"iiuc the code below is only attempting to delete the fileshare, not the filesystem - is that expected?","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a9de3f0ab8c16ea7b05e14564c5db4f806045c0","unresolved":true,"context_lines":[{"line_number":184,"context_line":"                     \"must be a multiple of 1024 MiB (1 GiB).\") % {"},{"line_number":185,"context_line":"                \u0027snap_name\u0027: be_snap_filesystem_name,"},{"line_number":186,"context_line":"                \u0027current_size\u0027: be_filesystem_size_mib,"},{"line_number":187,"context_line":"                \u0027increase_by\u0027: increase_by,"},{"line_number":188,"context_line":"                \u0027next_multiple\u0027: next_multiple,"},{"line_number":189,"context_line":"                \u0027next_multiple_gb\u0027: next_multiple // 1024})"},{"line_number":190,"context_line":"            LOG.error(msg)"},{"line_number":191,"context_line":"            raise exception.HPEAlletraB10000DriverException(reason\u003dmsg)"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"575b107c_0559591a","line":189,"range":{"start_line":187,"start_character":16,"end_line":189,"end_character":58},"updated":"2026-08-14 19:41:32.000000000","message":"these are not used in the message","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"04efef277fc9c4bebaa3752a1b7986d29d6e6e0f","unresolved":true,"context_lines":[{"line_number":200,"context_line":"            be_snap_share_id, be_snap_share_name, be_snap_filesystem_name,"},{"line_number":201,"context_line":"            be_snap_sharesetting_name)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"class SnapshotModelConvert(object):"},{"line_number":205,"context_line":"    def __init__(self, feature_support_handler, **kwargs):"},{"line_number":206,"context_line":"        self.feature_support_handler \u003d feature_support_handler"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"class SnapshotValidator(object):"}],"source_content_type":"text/x-python","patch_set":30,"id":"c059e653_6bbb1d3b","line":206,"range":{"start_line":203,"start_character":0,"end_line":206,"end_character":62},"updated":"2026-08-17 05:31:41.000000000","message":"Is this class used?","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}],"manila/share/drivers/hpe/alletra_mp_b10000/hpe_alletra_driver.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"04efef277fc9c4bebaa3752a1b7986d29d6e6e0f","unresolved":true,"context_lines":[{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        return snapshot[\u0027share\u0027][\u0027size\u0027]"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def snapshot_update_access(self, context, snapshot, access_rules,"},{"line_number":480,"context_line":"                               add_rules\u003dNone, delete_rules\u003dNone,"},{"line_number":481,"context_line":"                               share_server\u003dNone):"},{"line_number":482,"context_line":"        \"\"\"Update access rules for a mountable snapshot.\"\"\""},{"line_number":483,"context_line":"        pass"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def manage_existing_snapshot(self, snapshot, driver_options):"},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"637347a9_978983f1","line":483,"range":{"start_line":479,"start_character":3,"end_line":483,"end_character":12},"updated":"2026-08-17 05:31:41.000000000","message":"Better to add a brief docstring on the driver method explaining that Alletra snapshots always inherit parent share ACLs and independent snapshot access rules are unsupported.","commit_id":"c444a7c9b78aade225d9a9acd5a73ae910b6ae44"}]}