)]}' {"/COMMIT_MSG":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"ea7b2685a647dadce8548ecca7753d68382d4db6","unresolved":true,"context_lines":[{"line_number":19,"context_line":" /storage/volumes/{uuid} on supported ONTAP versions, falling back"},{"line_number":20,"context_line":" to /private/cli/volume on older versions)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Depends-On: Id7f303d3b07c4efb5d345d115069c3f393d33695"},{"line_number":23,"context_line":"Change-Id: Idab63a8ac36bdde13eb8df725b61829ec3dd4a96"},{"line_number":24,"context_line":"Signed-off-by: Medha Choudhary \u003cmedhac@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"a148bb79_98eae924","line":22,"updated":"2026-08-17 08:36:52.000000000","message":"IS this depends-on correct?","commit_id":"48ce26f85ff54f06220a628b07e50cf6d6239e87"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"7462c54b79740d55e02562921e675317b101697a","unresolved":false,"context_lines":[{"line_number":19,"context_line":" /storage/volumes/{uuid} on supported ONTAP versions, falling back"},{"line_number":20,"context_line":" to /private/cli/volume on older versions)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Depends-On: Id7f303d3b07c4efb5d345d115069c3f393d33695"},{"line_number":23,"context_line":"Change-Id: Idab63a8ac36bdde13eb8df725b61829ec3dd4a96"},{"line_number":24,"context_line":"Signed-off-by: Medha Choudhary \u003cmedhac@netapp.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"d2325d6b_451f7329","line":22,"in_reply_to":"a148bb79_98eae924","updated":"2026-08-19 02:48:31.000000000","message":"The other patch is for Netapp CI to pass. That one needs to be merged first.","commit_id":"48ce26f85ff54f06220a628b07e50cf6d6239e87"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"11bcee45fd482d508c9651a9107901c0bce102d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c4510e4_34549864","updated":"2026-06-30 04:13:26.000000000","message":"Thanks Medha for working on this. I have provided few comments, please take a look.","commit_id":"8ffef2dafaae1b79a7498424ac6e714054e036d2"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"556bb98d0cc1ade37a75cc876b3b218d3e33ef20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a68810b_088e68ba","updated":"2026-07-08 03:55:46.000000000","message":"LGTM.","commit_id":"9f138286c0c40917588006489075de9304ab7483"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"80ef8f4347d5dd72906ddd9bea77fc68ef41c4d8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8621c595_13b98ebe","updated":"2026-07-15 11:24:24.000000000","message":"Thanks for working on these gaps Medha. Release notes is missing, please do add.","commit_id":"9f138286c0c40917588006489075de9304ab7483"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"46466820c0553a5e19aedd148d3d22e69887f1df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ec5ccfe_0fafaf87","updated":"2026-07-08 10:31:18.000000000","message":"recheck","commit_id":"9f138286c0c40917588006489075de9304ab7483"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"f0c21ff9078e80cdf883f79b96e4944d73830af1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1b5e9bf_d1706273","updated":"2026-07-14 09:16:28.000000000","message":"recheck","commit_id":"9f138286c0c40917588006489075de9304ab7483"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"f2bc784436b3eb4f682e7381b501959e30221100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f826d2c_70152943","in_reply_to":"8621c595_13b98ebe","updated":"2026-07-16 03:36:41.000000000","message":"Done","commit_id":"9f138286c0c40917588006489075de9304ab7483"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b4852ad376ea5aef08eea9a974546b19ef3c05aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d9f4077_2e1c4243","updated":"2026-07-17 04:34:58.000000000","message":"Please check comments.","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dab8621f_69e2dbb9","updated":"2026-07-21 05:26:19.000000000","message":"Thanks Medha for working on this, added few comments, please take a look.","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cad19a962f7dfa54001a6fee26b6c12f210b790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cb6f6cbf_c59c18d5","updated":"2026-07-27 11:14:25.000000000","message":"Please address the below comments.","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"93669667897dcddcab4508a2b5f5113d6eb670eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a8ca6e70_88d24295","updated":"2026-07-27 09:37:37.000000000","message":"Please check comment.","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"7f57774ee3b1deb4f6c13086bbe08c71c8927622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"61879123_d945b276","updated":"2026-07-29 07:35:28.000000000","message":"LGTM.","commit_id":"de69423d20c2c589b030f90f1ef5035acd74b79d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"3b8d52ceff1a9efe3ba83b93a9ab8cc974db6317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"15d5e9a4_c4b12ff0","updated":"2026-07-29 13:18:38.000000000","message":"Thanks for taking care of the other comments. Can you please check the last comment I have. Rest of the code looks okay to me.","commit_id":"de69423d20c2c589b030f90f1ef5035acd74b79d"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"73f65e1bb324cd5fb7d27d3f54943e420957f0ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a17ab87_d96b862c","updated":"2026-07-29 03:10:16.000000000","message":"recheck","commit_id":"de69423d20c2c589b030f90f1ef5035acd74b79d"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"331f7b999524431329566ec39e0e887f95fbd9f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fb8ed6cf_eabe1da7","updated":"2026-07-30 10:11:49.000000000","message":"LGTM ..!","commit_id":"c01ad671282083be4925be0e40616b1bd1a3dda7"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"985dcca9634e08db6d1431024a5d01824a15ef72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7156a298_a7ad534a","updated":"2026-07-30 10:05:21.000000000","message":"LGTM.","commit_id":"c01ad671282083be4925be0e40616b1bd1a3dda7"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"493f9df15ba902d815f272b6bb455fdea22ff0d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"70df6564_0b18a075","updated":"2026-07-30 10:09:42.000000000","message":"Thanks for addressing the comments. LGTM.","commit_id":"c01ad671282083be4925be0e40616b1bd1a3dda7"},{"author":{"_account_id":39225,"name":"Prudhvi","display_name":"Prudhvi","email":"prudhvi.openstack@gmail.com","username":"Prudhvi"},"change_message_id":"51194ea2439910bc2214b26264d486efebd3e4fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3b97b438_47fd0311","updated":"2026-08-06 12:32:30.000000000","message":"run-NetApp CI","commit_id":"c01ad671282083be4925be0e40616b1bd1a3dda7"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"1d770e029def2cb013adec04c5291bc0fe31a762","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c283ed52_380cfedf","updated":"2026-08-06 08:01:35.000000000","message":"run-NetApp CI","commit_id":"c01ad671282083be4925be0e40616b1bd1a3dda7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a172b2a253df1d2ad0b773baf3576033b0280a90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"518879bd_8680464d","updated":"2026-08-07 19:00:08.000000000","message":"Thank you for working on this change, please take a look at the comments inline","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"27366ffcdfd00169e917491eb5319d191ec3e50d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"34fdea26_2efc5a5b","updated":"2026-08-07 11:25:43.000000000","message":"run-Netapp CI","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"1e1f023abb9c141fa80df0688a6406e9f71f41c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5e52b22e_151b6575","updated":"2026-08-11 10:11:24.000000000","message":"recheck","commit_id":"ef2b40fb73051eae6e3563a4e1ee63ae6767c6cc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"ab6de672919c12fbd8cf8a7d144d49edbd4b11ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"878a929a_2d0a5267","updated":"2026-08-13 05:10:32.000000000","message":"run-netapp ci","commit_id":"ef2b40fb73051eae6e3563a4e1ee63ae6767c6cc"},{"author":{"_account_id":39225,"name":"Prudhvi","display_name":"Prudhvi","email":"prudhvi.openstack@gmail.com","username":"Prudhvi"},"change_message_id":"07a56154ec030834c3833a4f5e4a3854d682f6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"21565adb_3c6de279","updated":"2026-08-13 09:37:47.000000000","message":"run-netapp ci","commit_id":"f7a01168063654a58ddbd73826c9cfb799152d18"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"ea7b2685a647dadce8548ecca7753d68382d4db6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9e203b9b_986bb318","updated":"2026-08-17 08:36:52.000000000","message":"LGTM.","commit_id":"48ce26f85ff54f06220a628b07e50cf6d6239e87"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"4d191c3ab6860d9870cbc166a208a136c04e847b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f5672213_99a3e26e","updated":"2026-08-14 10:30:52.000000000","message":"run-netapp ci","commit_id":"48ce26f85ff54f06220a628b07e50cf6d6239e87"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"11bcee45fd482d508c9651a9107901c0bce102d6","unresolved":true,"context_lines":[{"line_number":137,"context_line":" self.features.add_feature(\u0027VOLUME_TAGS\u0027, supported\u003dontap_9_14_1)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":" @na_utils.trace"},{"line_number":140,"context_line":" def is_svm_dr_supported(self):"},{"line_number":141,"context_line":" \"\"\"Checks if the cluster supports SVM DR.\"\"\""},{"line_number":142,"context_line":" return self.features.SVM_DR"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":" @na_utils.trace"},{"line_number":145,"context_line":" def is_svm_migrate_supported(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d02d3370_ed3340c5","line":142,"range":{"start_line":140,"start_character":7,"end_line":142,"end_character":35},"updated":"2026-06-30 04:13:26.000000000","message":"We are supporting REST from version 9.12.1. If SVM DR support is available in versions earlier than ONTAP 9.12.1, then there is no need to add this check. I believe SVM DR support existed before version 9.12.1. Please check this and make the necessary code changes accordingly.","commit_id":"8ffef2dafaae1b79a7498424ac6e714054e036d2"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"cd2856c7a54df7309beb75541b81da2a24753b32","unresolved":false,"context_lines":[{"line_number":137,"context_line":" self.features.add_feature(\u0027VOLUME_TAGS\u0027, supported\u003dontap_9_14_1)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":" @na_utils.trace"},{"line_number":140,"context_line":" def is_svm_dr_supported(self):"},{"line_number":141,"context_line":" \"\"\"Checks if the cluster supports SVM DR.\"\"\""},{"line_number":142,"context_line":" return self.features.SVM_DR"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":" @na_utils.trace"},{"line_number":145,"context_line":" def is_svm_migrate_supported(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1220d49_016294ab","line":142,"range":{"start_line":140,"start_character":7,"end_line":142,"end_character":35},"in_reply_to":"d02d3370_ed3340c5","updated":"2026-07-08 03:39:01.000000000","message":"Done","commit_id":"8ffef2dafaae1b79a7498424ac6e714054e036d2"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"11bcee45fd482d508c9651a9107901c0bce102d6","unresolved":true,"context_lines":[{"line_number":141,"context_line":" \"\"\"Checks if the cluster supports SVM DR.\"\"\""},{"line_number":142,"context_line":" return self.features.SVM_DR"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":" @na_utils.trace"},{"line_number":145,"context_line":" def is_svm_migrate_supported(self):"},{"line_number":146,"context_line":" \"\"\"Checks if the cluster supports SVM Migrate.\"\"\""},{"line_number":147,"context_line":" return self.features.SVM_MIGRATE"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":" def __getattr__(self, name):"},{"line_number":150,"context_line":" \"\"\"If method is not implemented for REST, try to call the ZAPI.\"\"\""},{"line_number":151,"context_line":" LOG.debug(\"The %s call is not supported for REST, falling back to \""}],"source_content_type":"text/x-python","patch_set":1,"id":"13cb3930_c0574333","line":148,"range":{"start_line":144,"start_character":3,"end_line":148,"end_character":0},"updated":"2026-06-30 04:13:26.000000000","message":"Same as above","commit_id":"8ffef2dafaae1b79a7498424ac6e714054e036d2"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"cd2856c7a54df7309beb75541b81da2a24753b32","unresolved":false,"context_lines":[{"line_number":141,"context_line":" \"\"\"Checks if the cluster supports SVM DR.\"\"\""},{"line_number":142,"context_line":" return self.features.SVM_DR"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":" @na_utils.trace"},{"line_number":145,"context_line":" def is_svm_migrate_supported(self):"},{"line_number":146,"context_line":" \"\"\"Checks if the cluster supports SVM Migrate.\"\"\""},{"line_number":147,"context_line":" return self.features.SVM_MIGRATE"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":" def __getattr__(self, name):"},{"line_number":150,"context_line":" \"\"\"If method is not implemented for REST, try to call the ZAPI.\"\"\""},{"line_number":151,"context_line":" LOG.debug(\"The %s call is not supported for REST, falling back to \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7620a921_d7ae1ec1","line":148,"range":{"start_line":144,"start_character":3,"end_line":148,"end_character":0},"in_reply_to":"13cb3930_c0574333","updated":"2026-07-08 03:39:01.000000000","message":"Done","commit_id":"8ffef2dafaae1b79a7498424ac6e714054e036d2"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b4852ad376ea5aef08eea9a974546b19ef3c05aa","unresolved":true,"context_lines":[{"line_number":4515,"context_line":" \"\"\"Get the data LIF details for each node.\"\"\""},{"line_number":4516,"context_line":" # NOTE: There is no public REST API for data LIF capacity details yet"},{"line_number":4517,"context_line":" # (tracked by CONTAP-408454), so the private CLI endpoint is used as"},{"line_number":4518,"context_line":" # an interim workaround. Some ONTAP versions return underscore field"},{"line_number":4519,"context_line":" # names in JSON output while others return hyphenated names."},{"line_number":4520,"context_line":" query \u003d {"},{"line_number":4521,"context_line":" \u0027fields\u0027: \u0027limit-for-node,count-for-node,node\u0027,"},{"line_number":4522,"context_line":" }"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f26a612_cb77323b","line":4519,"range":{"start_line":4518,"start_character":33,"end_line":4519,"end_character":68},"updated":"2026-07-17 04:34:58.000000000","message":"is it the older version of ONTAP that return underscores? or the vice versa?","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":4515,"context_line":" \"\"\"Get the data LIF details for each node.\"\"\""},{"line_number":4516,"context_line":" # NOTE: There is no public REST API for data LIF capacity details yet"},{"line_number":4517,"context_line":" # (tracked by CONTAP-408454), so the private CLI endpoint is used as"},{"line_number":4518,"context_line":" # an interim workaround. Some ONTAP versions return underscore field"},{"line_number":4519,"context_line":" # names in JSON output while others return hyphenated names."},{"line_number":4520,"context_line":" query \u003d {"},{"line_number":4521,"context_line":" \u0027fields\u0027: \u0027limit-for-node,count-for-node,node\u0027,"},{"line_number":4522,"context_line":" }"}],"source_content_type":"text/x-python","patch_set":3,"id":"f0c3f32d_180c0068","line":4519,"range":{"start_line":4518,"start_character":33,"end_line":4519,"end_character":68},"in_reply_to":"7f26a612_cb77323b","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b4852ad376ea5aef08eea9a974546b19ef3c05aa","unresolved":true,"context_lines":[{"line_number":5120,"context_line":""},{"line_number":5121,"context_line":" @na_utils.trace"},{"line_number":5122,"context_line":" def configure_cifs_options(self, security_service, vserver_name\u003dNone):"},{"line_number":5123,"context_line":" if security_service.get(\u0027server\u0027):"},{"line_number":5124,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: \u0027none\u0027}"},{"line_number":5125,"context_line":" elif security_service.get(\u0027default_ad_site\u0027):"},{"line_number":5126,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: \u0027site\u0027}"},{"line_number":5127,"context_line":" else:"},{"line_number":5128,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: \u0027all\u0027}"},{"line_number":5129,"context_line":""},{"line_number":5130,"context_line":" svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":5131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5c6e85f9_15cf2193","line":5128,"range":{"start_line":5123,"start_character":4,"end_line":5128,"end_character":51},"updated":"2026-07-17 04:34:58.000000000","message":"can be made modular by introducing a new method to get the security service mode.","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":5120,"context_line":""},{"line_number":5121,"context_line":" @na_utils.trace"},{"line_number":5122,"context_line":" def configure_cifs_options(self, security_service, vserver_name\u003dNone):"},{"line_number":5123,"context_line":" if security_service.get(\u0027server\u0027):"},{"line_number":5124,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: \u0027none\u0027}"},{"line_number":5125,"context_line":" elif security_service.get(\u0027default_ad_site\u0027):"},{"line_number":5126,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: \u0027site\u0027}"},{"line_number":5127,"context_line":" else:"},{"line_number":5128,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: \u0027all\u0027}"},{"line_number":5129,"context_line":""},{"line_number":5130,"context_line":" svm_uuid \u003d self._get_unique_svm_by_name(vserver_name)"},{"line_number":5131,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"44981d12_1e6ec1a4","line":5128,"range":{"start_line":5123,"start_character":4,"end_line":5128,"end_character":51},"in_reply_to":"5c6e85f9_15cf2193","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b4852ad376ea5aef08eea9a974546b19ef3c05aa","unresolved":true,"context_lines":[{"line_number":5138,"context_line":" \u0027%(mode)s. Exception: %(exception)s\u0027)"},{"line_number":5139,"context_line":" msg_args \u003d {\u0027mode\u0027: body[\u0027server_discovery_mode\u0027],"},{"line_number":5140,"context_line":" \u0027exception\u0027: e.message}"},{"line_number":5141,"context_line":" LOG.warning(msg, msg_args)"},{"line_number":5142,"context_line":""},{"line_number":5143,"context_line":" @na_utils.trace"},{"line_number":5144,"context_line":" def remove_preferred_dcs(self, security_service, svm_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9dea016b_f3fcb096","line":5141,"updated":"2026-07-17 04:34:58.000000000","message":"why are we not raising the exception here?","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[{"line_number":5138,"context_line":" \u0027%(mode)s. Exception: %(exception)s\u0027)"},{"line_number":5139,"context_line":" msg_args \u003d {\u0027mode\u0027: body[\u0027server_discovery_mode\u0027],"},{"line_number":5140,"context_line":" \u0027exception\u0027: e.message}"},{"line_number":5141,"context_line":" LOG.warning(msg, msg_args)"},{"line_number":5142,"context_line":""},{"line_number":5143,"context_line":" @na_utils.trace"},{"line_number":5144,"context_line":" def remove_preferred_dcs(self, security_service, svm_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f52d75c3_d4a37b13","line":5141,"in_reply_to":"9dea016b_f3fcb096","updated":"2026-07-21 05:26:19.000000000","message":"+1","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":5138,"context_line":" \u0027%(mode)s. Exception: %(exception)s\u0027)"},{"line_number":5139,"context_line":" msg_args \u003d {\u0027mode\u0027: body[\u0027server_discovery_mode\u0027],"},{"line_number":5140,"context_line":" \u0027exception\u0027: e.message}"},{"line_number":5141,"context_line":" LOG.warning(msg, msg_args)"},{"line_number":5142,"context_line":""},{"line_number":5143,"context_line":" @na_utils.trace"},{"line_number":5144,"context_line":" def remove_preferred_dcs(self, security_service, svm_uuid):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e7a8de8e_ae99ac0d","line":5141,"in_reply_to":"f52d75c3_d4a37b13","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b4852ad376ea5aef08eea9a974546b19ef3c05aa","unresolved":true,"context_lines":[{"line_number":6319,"context_line":""},{"line_number":6320,"context_line":" lifs \u003d self.get_network_interfaces(protocols\u003d[\u0027NFS\u0027, \u0027CIFS\u0027])"},{"line_number":6321,"context_line":" if not lifs:"},{"line_number":6322,"context_line":" LOG.debug(\"There are no LIFs configured for this Vserver. \""},{"line_number":6323,"context_line":" \"Kerberos is disabled.\")"},{"line_number":6324,"context_line":" return False"},{"line_number":6325,"context_line":""},{"line_number":6326,"context_line":" for lif in lifs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f7dc63e_48216797","line":6323,"range":{"start_line":6322,"start_character":12,"end_line":6323,"end_character":46},"updated":"2026-07-17 04:34:58.000000000","message":"LOG.warning may be?","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":6319,"context_line":""},{"line_number":6320,"context_line":" lifs \u003d self.get_network_interfaces(protocols\u003d[\u0027NFS\u0027, \u0027CIFS\u0027])"},{"line_number":6321,"context_line":" if not lifs:"},{"line_number":6322,"context_line":" LOG.debug(\"There are no LIFs configured for this Vserver. \""},{"line_number":6323,"context_line":" \"Kerberos is disabled.\")"},{"line_number":6324,"context_line":" return False"},{"line_number":6325,"context_line":""},{"line_number":6326,"context_line":" for lif in lifs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"14f50164_f4f83679","line":6323,"range":{"start_line":6322,"start_character":12,"end_line":6323,"end_character":46},"in_reply_to":"9f7dc63e_48216797","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b4852ad376ea5aef08eea9a974546b19ef3c05aa","unresolved":true,"context_lines":[{"line_number":6333,"context_line":" except netapp_api.api.NaApiError as e:"},{"line_number":6334,"context_line":" if e.code \u003d\u003d netapp_api.EREST_ENTRY_NOT_FOUND:"},{"line_number":6335,"context_line":" return False"},{"line_number":6336,"context_line":" raise"},{"line_number":6337,"context_line":""},{"line_number":6338,"context_line":" if not result.get(\u0027enabled\u0027, False):"},{"line_number":6339,"context_line":" return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"f1839bd5_3ea46930","line":6336,"updated":"2026-07-17 04:34:58.000000000","message":"should we log the error before raising?","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":6333,"context_line":" except netapp_api.api.NaApiError as e:"},{"line_number":6334,"context_line":" if e.code \u003d\u003d netapp_api.EREST_ENTRY_NOT_FOUND:"},{"line_number":6335,"context_line":" return False"},{"line_number":6336,"context_line":" raise"},{"line_number":6337,"context_line":""},{"line_number":6338,"context_line":" if not result.get(\u0027enabled\u0027, False):"},{"line_number":6339,"context_line":" return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e89ad18_c55149df","line":6336,"in_reply_to":"f1839bd5_3ea46930","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"1afc9fc8221b744afa5c63c25b4d6cf7fababed9"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[{"line_number":141,"context_line":" self.features.add_feature(\u0027AUTOSIZE_RESET_REST\u0027,"},{"line_number":142,"context_line":" supported\u003dontap_9_19_1)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":" @na_utils.trace"},{"line_number":145,"context_line":" def is_svm_dr_supported(self):"},{"line_number":146,"context_line":" \"\"\"Checks if the cluster supports SVM DR.\"\"\""},{"line_number":147,"context_line":" # NOTE: SVM DR has been available since ONTAP 8.3 (ONTAP API 1.140),"},{"line_number":148,"context_line":" # which predates the REST client minimum of 9.12.1, so it is always"},{"line_number":149,"context_line":" # supported here."},{"line_number":150,"context_line":" return True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":" @na_utils.trace"},{"line_number":153,"context_line":" def is_svm_migrate_supported(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"885602b0_52eefc06","line":150,"range":{"start_line":144,"start_character":4,"end_line":150,"end_character":19},"updated":"2026-07-21 05:26:19.000000000","message":"Remove this, you already remove the feature flag so this not require.","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":141,"context_line":" self.features.add_feature(\u0027AUTOSIZE_RESET_REST\u0027,"},{"line_number":142,"context_line":" supported\u003dontap_9_19_1)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":" @na_utils.trace"},{"line_number":145,"context_line":" def is_svm_dr_supported(self):"},{"line_number":146,"context_line":" \"\"\"Checks if the cluster supports SVM DR.\"\"\""},{"line_number":147,"context_line":" # NOTE: SVM DR has been available since ONTAP 8.3 (ONTAP API 1.140),"},{"line_number":148,"context_line":" # which predates the REST client minimum of 9.12.1, so it is always"},{"line_number":149,"context_line":" # supported here."},{"line_number":150,"context_line":" return True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":" @na_utils.trace"},{"line_number":153,"context_line":" def is_svm_migrate_supported(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"e4c3994b_d7107da0","line":150,"range":{"start_line":144,"start_character":4,"end_line":150,"end_character":19},"in_reply_to":"885602b0_52eefc06","updated":"2026-07-27 03:28:39.000000000","message":"Explicitly implemented here to avoid falling back to ZAPI once we introduce the zapi disabled flag","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[{"line_number":149,"context_line":" # supported here."},{"line_number":150,"context_line":" return True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":" @na_utils.trace"},{"line_number":153,"context_line":" def is_svm_migrate_supported(self):"},{"line_number":154,"context_line":" \"\"\"Checks if the cluster supports SVM Migrate.\"\"\""},{"line_number":155,"context_line":" # NOTE: SVM Migrate was introduced in ONTAP 9.10.0, which predates"},{"line_number":156,"context_line":" # the REST client minimum of 9.12.1, so it is always supported here."},{"line_number":157,"context_line":" return True"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":" def __getattr__(self, name):"},{"line_number":160,"context_line":" \"\"\"If method is not implemented for REST, try to call the ZAPI.\"\"\""},{"line_number":161,"context_line":" LOG.debug(\"The %s call is not supported for REST, falling back to \""}],"source_content_type":"text/x-python","patch_set":5,"id":"d1c06afa_0ac43e2c","line":158,"range":{"start_line":152,"start_character":4,"end_line":158,"end_character":0},"updated":"2026-07-21 05:26:19.000000000","message":"Same as above, this also not require","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":149,"context_line":" # supported here."},{"line_number":150,"context_line":" return True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":" @na_utils.trace"},{"line_number":153,"context_line":" def is_svm_migrate_supported(self):"},{"line_number":154,"context_line":" \"\"\"Checks if the cluster supports SVM Migrate.\"\"\""},{"line_number":155,"context_line":" # NOTE: SVM Migrate was introduced in ONTAP 9.10.0, which predates"},{"line_number":156,"context_line":" # the REST client minimum of 9.12.1, so it is always supported here."},{"line_number":157,"context_line":" return True"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":" def __getattr__(self, name):"},{"line_number":160,"context_line":" \"\"\"If method is not implemented for REST, try to call the ZAPI.\"\"\""},{"line_number":161,"context_line":" LOG.debug(\"The %s call is not supported for REST, falling back to \""}],"source_content_type":"text/x-python","patch_set":5,"id":"2df7eaa4_dcc9f9a6","line":158,"range":{"start_line":152,"start_character":4,"end_line":158,"end_character":0},"in_reply_to":"d1c06afa_0ac43e2c","updated":"2026-07-27 03:28:39.000000000","message":"Explicitly implemented here to avoid falling back to ZAPI once we introduce the zapi disabled flag","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[{"line_number":4508,"context_line":" response \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":4509,"context_line":" enable_tunneling\u003dFalse)"},{"line_number":4510,"context_line":""},{"line_number":4511,"context_line":" return [svm[\u0027name\u0027] for svm in response.get(\u0027records\u0027, [])]"},{"line_number":4512,"context_line":""},{"line_number":4513,"context_line":" @na_utils.trace"},{"line_number":4514,"context_line":" def get_data_lif_details_for_nodes(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"6b8076c3_0789e28e","line":4511,"range":{"start_line":4511,"start_character":8,"end_line":4511,"end_character":67},"updated":"2026-07-21 05:26:19.000000000","message":"if response.get(\u0027records\u0027, []) this return empty dictionary then svm[\u0027name\u0027] can failed. Can you modify this code if response.get(\u0027records\u0027, []) return empty, return [] otherwise return the valid list of SVM and change svm[\u0027name\u0027] to svm.get(\u0027name\u0027), [])","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":4508,"context_line":" response \u003d self.send_request(\u0027/svm/svms\u0027, \u0027get\u0027, query\u003dquery,"},{"line_number":4509,"context_line":" enable_tunneling\u003dFalse)"},{"line_number":4510,"context_line":""},{"line_number":4511,"context_line":" return [svm[\u0027name\u0027] for svm in response.get(\u0027records\u0027, [])]"},{"line_number":4512,"context_line":""},{"line_number":4513,"context_line":" @na_utils.trace"},{"line_number":4514,"context_line":" def get_data_lif_details_for_nodes(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"97fb105a_b6ee7e47","line":4511,"range":{"start_line":4511,"start_character":8,"end_line":4511,"end_character":67},"in_reply_to":"6b8076c3_0789e28e","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[{"line_number":5124,"context_line":" def _get_cifs_server_discovery_mode(self, security_service):"},{"line_number":5125,"context_line":" \"\"\"Return the CIFS server discovery mode for a security service.\"\"\""},{"line_number":5126,"context_line":" if security_service.get(\u0027server\u0027):"},{"line_number":5127,"context_line":" return \u0027none\u0027"},{"line_number":5128,"context_line":" elif security_service.get(\u0027default_ad_site\u0027):"},{"line_number":5129,"context_line":" return \u0027site\u0027"},{"line_number":5130,"context_line":" return \u0027all\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5390dde5_469bcea0","line":5127,"range":{"start_line":5127,"start_character":20,"end_line":5127,"end_character":24},"updated":"2026-07-21 05:26:19.000000000","message":"Why you are returning \u0027none\u0027 instead of None ..?","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":5124,"context_line":" def _get_cifs_server_discovery_mode(self, security_service):"},{"line_number":5125,"context_line":" \"\"\"Return the CIFS server discovery mode for a security service.\"\"\""},{"line_number":5126,"context_line":" if security_service.get(\u0027server\u0027):"},{"line_number":5127,"context_line":" return \u0027none\u0027"},{"line_number":5128,"context_line":" elif security_service.get(\u0027default_ad_site\u0027):"},{"line_number":5129,"context_line":" return \u0027site\u0027"},{"line_number":5130,"context_line":" return \u0027all\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"4440fc34_9fc0ecdd","line":5127,"range":{"start_line":5127,"start_character":20,"end_line":5127,"end_character":24},"in_reply_to":"5390dde5_469bcea0","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[{"line_number":6344,"context_line":" except netapp_api.api.NaApiError as e:"},{"line_number":6345,"context_line":" if e.code \u003d\u003d netapp_api.EREST_ENTRY_NOT_FOUND:"},{"line_number":6346,"context_line":" return False"},{"line_number":6347,"context_line":" LOG.error(\u0027Failed to check Kerberos status for LIF %s. \u0027"},{"line_number":6348,"context_line":" \u0027Error: %s\u0027, interface_uuid, e.message)"},{"line_number":6349,"context_line":" raise"},{"line_number":6350,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"875d496f_69b7e457","line":6347,"range":{"start_line":6347,"start_character":0,"end_line":6347,"end_character":72},"updated":"2026-07-21 05:26:19.000000000","message":"Change it to LOG.exception","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[{"line_number":6344,"context_line":" except netapp_api.api.NaApiError as e:"},{"line_number":6345,"context_line":" if e.code \u003d\u003d netapp_api.EREST_ENTRY_NOT_FOUND:"},{"line_number":6346,"context_line":" return False"},{"line_number":6347,"context_line":" LOG.error(\u0027Failed to check Kerberos status for LIF %s. \u0027"},{"line_number":6348,"context_line":" \u0027Error: %s\u0027, interface_uuid, e.message)"},{"line_number":6349,"context_line":" raise"},{"line_number":6350,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"13644621_8124e484","line":6347,"range":{"start_line":6347,"start_character":0,"end_line":6347,"end_character":72},"in_reply_to":"875d496f_69b7e457","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cad19a962f7dfa54001a6fee26b6c12f210b790","unresolved":true,"context_lines":[{"line_number":119,"context_line":" supported\u003dTrue)"},{"line_number":120,"context_line":" self.features.add_feature(\u0027KERBEROS_VSERVER\u0027, supported\u003dTrue)"},{"line_number":121,"context_line":" self.features.add_feature(\u0027FLEXVOL_ENCRYPTION\u0027, supported\u003dTrue)"},{"line_number":122,"context_line":" self.features.add_feature(\u0027SVM_DR\u0027, supported\u003dTrue)"},{"line_number":123,"context_line":" self.features.add_feature(\u0027ADAPTIVE_QOS\u0027, supported\u003dTrue)"},{"line_number":124,"context_line":" self.features.add_feature(\u0027TRANSFER_LIMIT_NFS_CONFIG\u0027,"},{"line_number":125,"context_line":" supported\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"874d5396_0c9f04e6","side":"PARENT","line":122,"updated":"2026-07-27 11:14:25.000000000","message":"Revert this change","commit_id":"4d3b1fdac6faec76a758facd52f030cee3f31d96"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"90e93cf2613e9660d35e6208b8dfa456e3353e1d","unresolved":false,"context_lines":[{"line_number":119,"context_line":" supported\u003dTrue)"},{"line_number":120,"context_line":" self.features.add_feature(\u0027KERBEROS_VSERVER\u0027, supported\u003dTrue)"},{"line_number":121,"context_line":" self.features.add_feature(\u0027FLEXVOL_ENCRYPTION\u0027, supported\u003dTrue)"},{"line_number":122,"context_line":" self.features.add_feature(\u0027SVM_DR\u0027, supported\u003dTrue)"},{"line_number":123,"context_line":" self.features.add_feature(\u0027ADAPTIVE_QOS\u0027, supported\u003dTrue)"},{"line_number":124,"context_line":" self.features.add_feature(\u0027TRANSFER_LIMIT_NFS_CONFIG\u0027,"},{"line_number":125,"context_line":" supported\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"83fd9a6f_aa7b4b7b","side":"PARENT","line":122,"in_reply_to":"874d5396_0c9f04e6","updated":"2026-07-28 09:47:32.000000000","message":"Done","commit_id":"4d3b1fdac6faec76a758facd52f030cee3f31d96"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cad19a962f7dfa54001a6fee26b6c12f210b790","unresolved":true,"context_lines":[{"line_number":129,"context_line":" supported\u003dTrue)"},{"line_number":130,"context_line":" self.features.add_feature(\u0027FLEXGROUP\u0027, supported\u003dTrue)"},{"line_number":131,"context_line":" self.features.add_feature(\u0027FLEXGROUP_FAN_OUT\u0027, supported\u003dTrue)"},{"line_number":132,"context_line":" self.features.add_feature(\u0027SVM_MIGRATE\u0027, supported\u003dTrue)"},{"line_number":133,"context_line":" self.features.add_feature(\u0027UNIFIED_AGGR\u0027, supported\u003dTrue)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":" ontap_9_14_1 \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"93492386_0055278b","side":"PARENT","line":132,"updated":"2026-07-27 11:14:25.000000000","message":"Revert this change","commit_id":"4d3b1fdac6faec76a758facd52f030cee3f31d96"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"90e93cf2613e9660d35e6208b8dfa456e3353e1d","unresolved":false,"context_lines":[{"line_number":129,"context_line":" supported\u003dTrue)"},{"line_number":130,"context_line":" self.features.add_feature(\u0027FLEXGROUP\u0027, supported\u003dTrue)"},{"line_number":131,"context_line":" self.features.add_feature(\u0027FLEXGROUP_FAN_OUT\u0027, supported\u003dTrue)"},{"line_number":132,"context_line":" self.features.add_feature(\u0027SVM_MIGRATE\u0027, supported\u003dTrue)"},{"line_number":133,"context_line":" self.features.add_feature(\u0027UNIFIED_AGGR\u0027, supported\u003dTrue)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":" ontap_9_14_1 \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"657c8065_2d7f5f05","side":"PARENT","line":132,"in_reply_to":"93492386_0055278b","updated":"2026-07-28 09:47:32.000000000","message":"Done","commit_id":"4d3b1fdac6faec76a758facd52f030cee3f31d96"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cad19a962f7dfa54001a6fee26b6c12f210b790","unresolved":true,"context_lines":[{"line_number":147,"context_line":" # NOTE: Explicitly implemented here to avoid falling back to ZAPI via"},{"line_number":148,"context_line":" # __getattr__ when ZAPI is disabled. SVM DR requires ONTAP 8.3+, which"},{"line_number":149,"context_line":" # predates the REST client minimum of 9.12.1, so always return True."},{"line_number":150,"context_line":" return True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":" @na_utils.trace"},{"line_number":153,"context_line":" def is_svm_migrate_supported(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"747cce0f_392174eb","line":150,"updated":"2026-07-27 11:14:25.000000000","message":"```suggestion\n return self.feature.SVM_DR\n```","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"dab7c0bb856425bec191b1f8b907d6709e88e4d6","unresolved":false,"context_lines":[{"line_number":147,"context_line":" # NOTE: Explicitly implemented here to avoid falling back to ZAPI via"},{"line_number":148,"context_line":" # __getattr__ when ZAPI is disabled. SVM DR requires ONTAP 8.3+, which"},{"line_number":149,"context_line":" # predates the REST client minimum of 9.12.1, so always return True."},{"line_number":150,"context_line":" return True"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":" @na_utils.trace"},{"line_number":153,"context_line":" def is_svm_migrate_supported(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"24bbf7a4_7fbf5696","line":150,"in_reply_to":"747cce0f_392174eb","updated":"2026-07-28 09:47:42.000000000","message":"Done","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cad19a962f7dfa54001a6fee26b6c12f210b790","unresolved":true,"context_lines":[{"line_number":156,"context_line":" # __getattr__ when ZAPI is disabled. SVM Migrate requires ONTAP"},{"line_number":157,"context_line":" # 9.10.0+, which predates the REST client minimum of 9.12.1, so"},{"line_number":158,"context_line":" # always return True."},{"line_number":159,"context_line":" return True"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":" def __getattr__(self, name):"},{"line_number":162,"context_line":" \"\"\"If method is not implemented for REST, try to call the ZAPI.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"286d143e_eca97fda","line":159,"updated":"2026-07-27 11:14:25.000000000","message":"```suggestion\n return self.feature.SVM_MIGRATE\n```","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"dab7c0bb856425bec191b1f8b907d6709e88e4d6","unresolved":false,"context_lines":[{"line_number":156,"context_line":" # __getattr__ when ZAPI is disabled. SVM Migrate requires ONTAP"},{"line_number":157,"context_line":" # 9.10.0+, which predates the REST client minimum of 9.12.1, so"},{"line_number":158,"context_line":" # always return True."},{"line_number":159,"context_line":" return True"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":" def __getattr__(self, name):"},{"line_number":162,"context_line":" \"\"\"If method is not implemented for REST, try to call the ZAPI.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"8195ed21_306b6850","line":159,"in_reply_to":"286d143e_eca97fda","updated":"2026-07-28 09:47:42.000000000","message":"Done","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"93669667897dcddcab4508a2b5f5113d6eb670eb","unresolved":true,"context_lines":[{"line_number":4499,"context_line":" return [svm[\u0027name\u0027] for svm in response.get(\u0027records\u0027, [])]"},{"line_number":4500,"context_line":""},{"line_number":4501,"context_line":" @na_utils.trace"},{"line_number":4502,"context_line":" def list_vservers(self, vserver_type\u003d\u0027data\u0027):"},{"line_number":4503,"context_line":" \"\"\"Get the names of data vservers present.\"\"\""},{"line_number":4504,"context_line":" # REST \u0027/svm/svms\u0027 exposes only data SVMs and does not support"},{"line_number":4505,"context_line":" # \u0027?type\u003d\u0027 filtering (ONTAP returns \"Unexpected argument\")."}],"source_content_type":"text/x-python","patch_set":6,"id":"9f3049c6_9eb4c41c","line":4502,"updated":"2026-07-27 09:37:37.000000000","message":"ONTAP does not return non data type svms. Instead can we not handle it in the client method? Also, this method can just act as a wrapper to call the _list_vservers(self) method in line 4491.","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"3cad19a962f7dfa54001a6fee26b6c12f210b790","unresolved":true,"context_lines":[{"line_number":4499,"context_line":" return [svm[\u0027name\u0027] for svm in response.get(\u0027records\u0027, [])]"},{"line_number":4500,"context_line":""},{"line_number":4501,"context_line":" @na_utils.trace"},{"line_number":4502,"context_line":" def list_vservers(self, vserver_type\u003d\u0027data\u0027):"},{"line_number":4503,"context_line":" \"\"\"Get the names of data vservers present.\"\"\""},{"line_number":4504,"context_line":" # REST \u0027/svm/svms\u0027 exposes only data SVMs and does not support"},{"line_number":4505,"context_line":" # \u0027?type\u003d\u0027 filtering (ONTAP returns \"Unexpected argument\")."}],"source_content_type":"text/x-python","patch_set":6,"id":"bac052f8_be4a49f5","line":4502,"in_reply_to":"9f3049c6_9eb4c41c","updated":"2026-07-27 11:14:25.000000000","message":"Agree with above comment.","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"90e93cf2613e9660d35e6208b8dfa456e3353e1d","unresolved":false,"context_lines":[{"line_number":4499,"context_line":" return [svm[\u0027name\u0027] for svm in response.get(\u0027records\u0027, [])]"},{"line_number":4500,"context_line":""},{"line_number":4501,"context_line":" @na_utils.trace"},{"line_number":4502,"context_line":" def list_vservers(self, vserver_type\u003d\u0027data\u0027):"},{"line_number":4503,"context_line":" \"\"\"Get the names of data vservers present.\"\"\""},{"line_number":4504,"context_line":" # REST \u0027/svm/svms\u0027 exposes only data SVMs and does not support"},{"line_number":4505,"context_line":" # \u0027?type\u003d\u0027 filtering (ONTAP returns \"Unexpected argument\")."}],"source_content_type":"text/x-python","patch_set":6,"id":"dc3c0ab4_adcbfef9","line":4502,"in_reply_to":"bac052f8_be4a49f5","updated":"2026-07-28 09:47:32.000000000","message":"Done","commit_id":"bf58787cb68943d26cc28ac87a868bd1a1411789"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"3b8d52ceff1a9efe3ba83b93a9ab8cc974db6317","unresolved":true,"context_lines":[{"line_number":6325,"context_line":" \"Kerberos is disabled.\")"},{"line_number":6326,"context_line":" return False"},{"line_number":6327,"context_line":""},{"line_number":6328,"context_line":" for lif in lifs:"},{"line_number":6329,"context_line":" interface_uuid \u003d lif[\u0027uuid\u0027]"},{"line_number":6330,"context_line":""},{"line_number":6331,"context_line":" try:"},{"line_number":6332,"context_line":" result \u003d self.send_request("},{"line_number":6333,"context_line":" f\u0027/protocols/nfs/kerberos/interfaces/{interface_uuid}\u0027,"},{"line_number":6334,"context_line":" \u0027get\u0027)"},{"line_number":6335,"context_line":" except netapp_api.api.NaApiError as e:"},{"line_number":6336,"context_line":" if e.code \u003d\u003d netapp_api.EREST_ENTRY_NOT_FOUND:"},{"line_number":6337,"context_line":" return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"ed70ded3_5e478e3d","line":6334,"range":{"start_line":6328,"start_character":8,"end_line":6334,"end_character":26},"updated":"2026-07-29 13:18:38.000000000","message":"Instead of using the get /protocols/nfs/kerberos/interfaces/{interface_uuid} API, is there a way to pass the UUIDs to the /protocols/nfs/kerberos/interfaces API as param and make a single API call to fetch all relevant records? This may help reducing number of API calls.","commit_id":"de69423d20c2c589b030f90f1ef5035acd74b79d"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"e424a9029a8fd66e03c67bcfdda2a392d74d849c","unresolved":false,"context_lines":[{"line_number":6325,"context_line":" \"Kerberos is disabled.\")"},{"line_number":6326,"context_line":" return False"},{"line_number":6327,"context_line":""},{"line_number":6328,"context_line":" for lif in lifs:"},{"line_number":6329,"context_line":" interface_uuid \u003d lif[\u0027uuid\u0027]"},{"line_number":6330,"context_line":""},{"line_number":6331,"context_line":" try:"},{"line_number":6332,"context_line":" result \u003d self.send_request("},{"line_number":6333,"context_line":" f\u0027/protocols/nfs/kerberos/interfaces/{interface_uuid}\u0027,"},{"line_number":6334,"context_line":" \u0027get\u0027)"},{"line_number":6335,"context_line":" except netapp_api.api.NaApiError as e:"},{"line_number":6336,"context_line":" if e.code \u003d\u003d netapp_api.EREST_ENTRY_NOT_FOUND:"},{"line_number":6337,"context_line":" return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"dc6f0d16_8bf36657","line":6334,"range":{"start_line":6328,"start_character":8,"end_line":6334,"end_character":26},"in_reply_to":"ed70ded3_5e478e3d","updated":"2026-07-30 09:48:06.000000000","message":"Done","commit_id":"de69423d20c2c589b030f90f1ef5035acd74b79d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"99c2a177a55fdd69fc3ee3c235167f109bd20058","unresolved":true,"context_lines":[{"line_number":5145,"context_line":" return \u0027all\u0027"},{"line_number":5146,"context_line":""},{"line_number":5147,"context_line":" @na_utils.trace"},{"line_number":5148,"context_line":" def configure_cifs_options(self, security_service, vserver_name\u003dNone):"},{"line_number":5149,"context_line":" mode \u003d self._get_cifs_server_discovery_mode(security_service)"},{"line_number":5150,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: mode}"},{"line_number":5151,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"97e3649c_b83d5798","line":5148,"updated":"2026-08-07 18:08:27.000000000","message":"The ZAPI `configure_cifs_options` catches `NaApiError` and logs a warning, allowing the caller to proceed even if discovery mode configuration fails. This REST version has no error handling — any failure will propagate upward and crash `_setup_security_services` or `modify_active_directory_security_service`. Was the ZAPI behavior of swallowing this error intentional? If so, please add matching error handling here. If the stricter behavior is preferred, let\u0027s document this in release notes","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"29d799f5c675eb34c5adb12d7ac8d5080afa7f18","unresolved":false,"context_lines":[{"line_number":5145,"context_line":" return \u0027all\u0027"},{"line_number":5146,"context_line":""},{"line_number":5147,"context_line":" @na_utils.trace"},{"line_number":5148,"context_line":" def configure_cifs_options(self, security_service, vserver_name\u003dNone):"},{"line_number":5149,"context_line":" mode \u003d self._get_cifs_server_discovery_mode(security_service)"},{"line_number":5150,"context_line":" body \u003d {\u0027server_discovery_mode\u0027: mode}"},{"line_number":5151,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"66b9e04a_1a08670f","line":5148,"in_reply_to":"97e3649c_b83d5798","updated":"2026-08-10 06:03:56.000000000","message":"Done","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a172b2a253df1d2ad0b773baf3576033b0280a90","unresolved":true,"context_lines":[{"line_number":6340,"context_line":""},{"line_number":6341,"context_line":" lif_uuids \u003d {lif[\u0027uuid\u0027] for lif in lifs}"},{"line_number":6342,"context_line":""},{"line_number":6343,"context_line":" # Fetch Kerberos status for all target LIFs in a single API call,"},{"line_number":6344,"context_line":" # using pipe-separated UUIDs as an OR filter."},{"line_number":6345,"context_line":" query \u003d {"},{"line_number":6346,"context_line":" \u0027interface.uuid\u0027: \u0027|\u0027.join(sorted(lif_uuids)),"},{"line_number":6347,"context_line":" \u0027fields\u0027: \u0027enabled,interface.uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a594e5e_15afa416","line":6344,"range":{"start_line":6343,"start_character":8,"end_line":6344,"end_character":53},"updated":"2026-08-07 19:00:08.000000000","message":"I appreciate the comments, but maybe we can avoid the code self-explanatory comments like the ones on this method (and in other parts of this change) - it\u0027s great to add comments, but we should focus on important notes, todos, etc in my opinion. The code should be readable enough and self explanatory, and we add a note in case we\u0027d like to have people understanding why we took that decision. In this case, the statement following should be self explanatory.","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"29d799f5c675eb34c5adb12d7ac8d5080afa7f18","unresolved":false,"context_lines":[{"line_number":6340,"context_line":""},{"line_number":6341,"context_line":" lif_uuids \u003d {lif[\u0027uuid\u0027] for lif in lifs}"},{"line_number":6342,"context_line":""},{"line_number":6343,"context_line":" # Fetch Kerberos status for all target LIFs in a single API call,"},{"line_number":6344,"context_line":" # using pipe-separated UUIDs as an OR filter."},{"line_number":6345,"context_line":" query \u003d {"},{"line_number":6346,"context_line":" \u0027interface.uuid\u0027: \u0027|\u0027.join(sorted(lif_uuids)),"},{"line_number":6347,"context_line":" \u0027fields\u0027: \u0027enabled,interface.uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbed7b18_4d4c6a6e","line":6344,"range":{"start_line":6343,"start_character":8,"end_line":6344,"end_character":53},"in_reply_to":"5a594e5e_15afa416","updated":"2026-08-10 06:03:56.000000000","message":"Done","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"70cf4d7161e56bafca99091fb0fb5a8246424a7f","unresolved":false,"context_lines":[{"line_number":6354,"context_line":" raise"},{"line_number":6355,"context_line":""},{"line_number":6356,"context_line":" # Build a set of UUIDs that have Kerberos enabled. Any LIF absent"},{"line_number":6357,"context_line":" # from the response has no Kerberos configuration (treated as disabled)."},{"line_number":6358,"context_line":" kerberos_enabled_uuids \u003d {"},{"line_number":6359,"context_line":" r[\u0027interface\u0027][\u0027uuid\u0027]"},{"line_number":6360,"context_line":" for r in result.get(\u0027records\u0027, [])"}],"source_content_type":"text/x-python","patch_set":10,"id":"69027d6d_be41aa33","line":6357,"updated":"2026-08-07 13:15:16.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"}],"manila/tests/share/drivers/netapp/dataontap/client/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"99c2a177a55fdd69fc3ee3c235167f109bd20058","unresolved":true,"context_lines":[{"line_number":1223,"context_line":" },"},{"line_number":1224,"context_line":"]"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"KERBEROS_INTERFACE_ENABLED_REST \u003d {"},{"line_number":1227,"context_line":" \u0027svm\u0027: {"},{"line_number":1228,"context_line":" \u0027name\u0027: VSERVER_NAME,"},{"line_number":1229,"context_line":" },"}],"source_content_type":"text/x-python","patch_set":10,"id":"05afee2a_f4524631","line":1226,"updated":"2026-08-07 18:08:27.000000000","message":"`KERBEROS_INTERFACE_ENABLED_REST` and `KERBEROS_INTERFACE_DISABLED_REST` (lines 1226-1245) are defined but not used in any test.","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"29d799f5c675eb34c5adb12d7ac8d5080afa7f18","unresolved":false,"context_lines":[{"line_number":1223,"context_line":" },"},{"line_number":1224,"context_line":"]"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"KERBEROS_INTERFACE_ENABLED_REST \u003d {"},{"line_number":1227,"context_line":" \u0027svm\u0027: {"},{"line_number":1228,"context_line":" \u0027name\u0027: VSERVER_NAME,"},{"line_number":1229,"context_line":" },"}],"source_content_type":"text/x-python","patch_set":10,"id":"41a22bc6_8c51d0ab","line":1226,"in_reply_to":"05afee2a_f4524631","updated":"2026-08-10 06:03:56.000000000","message":"Done","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"}],"manila/tests/share/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"99c2a177a55fdd69fc3ee3c235167f109bd20058","unresolved":true,"context_lines":[{"line_number":5754,"context_line":" security_service)"},{"line_number":5755,"context_line":""},{"line_number":5756,"context_line":" self.assertEqual(expected_mode, result)"},{"line_number":5757,"context_line":" self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":5758,"context_line":" self.mock_object(self.client, \u0027_get_unique_svm_by_name\u0027,"},{"line_number":5759,"context_line":" mock.Mock(return_value\u003dfake.FAKE_UUID))"},{"line_number":5760,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"2f925f57_29b39104","line":5757,"updated":"2026-08-07 18:08:27.000000000","message":"rebase issue?","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"29d799f5c675eb34c5adb12d7ac8d5080afa7f18","unresolved":false,"context_lines":[{"line_number":5754,"context_line":" security_service)"},{"line_number":5755,"context_line":""},{"line_number":5756,"context_line":" self.assertEqual(expected_mode, result)"},{"line_number":5757,"context_line":" self.mock_object(self.client, \u0027send_request\u0027)"},{"line_number":5758,"context_line":" self.mock_object(self.client, \u0027_get_unique_svm_by_name\u0027,"},{"line_number":5759,"context_line":" mock.Mock(return_value\u003dfake.FAKE_UUID))"},{"line_number":5760,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"22cbd721_1e878cf4","line":5757,"in_reply_to":"2f925f57_29b39104","updated":"2026-08-10 06:03:56.000000000","message":"Done","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"70cf4d7161e56bafca99091fb0fb5a8246424a7f","unresolved":false,"context_lines":[{"line_number":6866,"context_line":" mock.Mock(return_value\u003dfake.NFS_LIFS_REST))"},{"line_number":6867,"context_line":" self.mock_object("},{"line_number":6868,"context_line":" self.client, \u0027send_request\u0027,"},{"line_number":6869,"context_line":" mock.Mock(return_value\u003dfake.KERBEROS_INTERFACES_LIST_ALL_ENABLED_REST))"},{"line_number":6870,"context_line":""},{"line_number":6871,"context_line":" result \u003d self.client.is_kerberos_enabled()"},{"line_number":6872,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"0d071566_b53601ab","line":6869,"updated":"2026-08-07 13:15:16.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"99c2a177a55fdd69fc3ee3c235167f109bd20058","unresolved":true,"context_lines":[{"line_number":7364,"context_line":" \u0027default_ad_site_to_default_ad_site\u0027,"},{"line_number":7365,"context_line":" \u0027default_ad_site_to_server\u0027,"},{"line_number":7366,"context_line":" )"},{"line_number":7367,"context_line":" def test_modify_active_directory_security_service(self, scenario):"},{"line_number":7368,"context_line":" svm_uuid \u003d fake.FAKE_UUID"},{"line_number":7369,"context_line":" sid \u003d fake.FAKE_CIFS_LOCAL_USER[\u0027records\u0027][0][\u0027sid\u0027]"},{"line_number":7370,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"f09a2ae0_5a85a751","line":7367,"updated":"2026-08-07 18:08:27.000000000","message":"Please add a test that includes `\u0027password\u0027` and `\u0027user\u0027` in the differring_keys","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"29d799f5c675eb34c5adb12d7ac8d5080afa7f18","unresolved":false,"context_lines":[{"line_number":7364,"context_line":" \u0027default_ad_site_to_default_ad_site\u0027,"},{"line_number":7365,"context_line":" \u0027default_ad_site_to_server\u0027,"},{"line_number":7366,"context_line":" )"},{"line_number":7367,"context_line":" def test_modify_active_directory_security_service(self, scenario):"},{"line_number":7368,"context_line":" svm_uuid \u003d fake.FAKE_UUID"},{"line_number":7369,"context_line":" sid \u003d fake.FAKE_CIFS_LOCAL_USER[\u0027records\u0027][0][\u0027sid\u0027]"},{"line_number":7370,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6a7de6a8_0789ff39","line":7367,"in_reply_to":"f09a2ae0_5a85a751","updated":"2026-08-10 06:03:56.000000000","message":"Done","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"}],"releasenotes/notes/netapp-zapi-to-rest-gaps-327997cafc6d4ede.yaml":[{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"3a759cf56f33816c55c21b1ead5924d5dd4057d7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3a306dc4_03dd7d27","line":26,"range":{"start_line":4,"start_character":4,"end_line":26,"end_character":0},"updated":"2026-07-21 05:26:19.000000000","message":"Since this release note is for customers, so no need to add full REST details. Include only customer-understandable content. Just list the equivalent REST APIs implemented (as you did in the patch description), and do not mention the private CLI.","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"bc4d9ccf9f512d5409ad7a149f3619130cfc905c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"26bb4a4f_be333e8c","line":26,"range":{"start_line":4,"start_character":4,"end_line":26,"end_character":0},"in_reply_to":"3a306dc4_03dd7d27","updated":"2026-07-27 03:28:39.000000000","message":"Done","commit_id":"6f70a29522e4d502ec43b8fd23b5aeacfbafe2fc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a172b2a253df1d2ad0b773baf3576033b0280a90","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" NetApp ONTAP: Implemented REST equivalents for the following ZAPI-only"},{"line_number":5,"context_line":" methods as part of the ongoing ZAPI-to-REST migration:"},{"line_number":6,"context_line":" ``is_svm_dr_supported``, ``is_svm_migrate_supported``,"},{"line_number":7,"context_line":" ``get_data_lif_details_for_nodes``, ``get_volume_autosize_attributes``,"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e8fab39b_3862af8c","line":4,"updated":"2026-08-07 19:00:08.000000000","message":"Imho we can be more generic about this - these are method names, we should not expose them to end users, which is the audience we\u0027re targeting this release note. Instead, we should focus on the net result: some operations will now use the REST client.","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"29d799f5c675eb34c5adb12d7ac8d5080afa7f18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":" - |"},{"line_number":4,"context_line":" NetApp ONTAP: Implemented REST equivalents for the following ZAPI-only"},{"line_number":5,"context_line":" methods as part of the ongoing ZAPI-to-REST migration:"},{"line_number":6,"context_line":" ``is_svm_dr_supported``, ``is_svm_migrate_supported``,"},{"line_number":7,"context_line":" ``get_data_lif_details_for_nodes``, ``get_volume_autosize_attributes``,"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"304bbcd0_c22f2155","line":4,"in_reply_to":"e8fab39b_3862af8c","updated":"2026-08-10 06:03:56.000000000","message":"Done","commit_id":"a52cc47d072d1ae55d457750dc56b1d3a3165eca"}]}