)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"7c9de04ec02eb516b2ee9280899a8158cbcbcae9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5afea113_bc5c4e7b","updated":"2026-07-17 06:57:28.000000000","message":"And the api-ref should also be updated accordingly (same list appears in 3 blocks):\n- https://opendev.org/openstack/manila/src/commit/369fe49bdbd0d5744a0f96df15a9ab4240bca570/api-ref/source/parameters.yaml#L765\n- https://opendev.org/openstack/manila/src/commit/369fe49bdbd0d5744a0f96df15a9ab4240bca570/api-ref/source/parameters.yaml#L4141\n- https://opendev.org/openstack/manila/src/commit/369fe49bdbd0d5744a0f96df15a9ab4240bca570/api-ref/source/parameters.yaml#L4150","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dcfc2eed6c69673703790595ddad92baed3f4fad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be0a8675_9dc7fc9d","updated":"2026-07-15 19:39:28.000000000","message":"LGTM, thank you!","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"6411623920aff0b940d173c725175b1bdf4f4c2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7fac8c49_12fcaaf1","updated":"2026-07-13 17:01:50.000000000","message":"Looks good, thanks for the change. Please see my comment.","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":35652,"name":"Soyoon Lee","display_name":"soyoon-lee","email":"soyoon.lee@samsung.com","username":"soyoon-lee"},"change_message_id":"8adcd4682639d280b694c4966c8d5b568c06db6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f260a702_ea89fe1a","updated":"2026-07-09 02:52:14.000000000","message":"recheck manila-tempest-plugin-lvm","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ea4b9ec7303e0f92c21ef96e5252ee46ebd5381f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"56dc8dbf_ceb96fa0","updated":"2026-07-15 19:46:32.000000000","message":"you\u0027re missing a status, but, this approach is good, thanks @soyoon.lee@samsung.com","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"39724f2ef4fb5341ab02ac8a25fefa1edaa2ae29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c067e98f_fade2f58","updated":"2026-07-24 05:29:25.000000000","message":"LGTM, thank you @soyoon.lee@samsung.com","commit_id":"0d3ec32b720612a285b857a4168e6cc05441eea2"},{"author":{"_account_id":35652,"name":"Soyoon Lee","display_name":"soyoon-lee","email":"soyoon.lee@samsung.com","username":"soyoon-lee"},"change_message_id":"8550b307c1d0d044b856668f9e8306b5ba77b1bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"219ac5cd_d14e4146","updated":"2026-07-21 12:00:53.000000000","message":"Thanks for the reviews.\nIn patch set 2, I added three additional snapshot statuses (migrating, migrating_to, and restoring) and updated the API reference accordingly.","commit_id":"0d3ec32b720612a285b857a4168e6cc05441eea2"}],"manila/common/constants.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"6411623920aff0b940d173c725175b1bdf4f4c2f","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ea0f6a6c_a457957c","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"updated":"2026-07-13 17:01:50.000000000","message":"May consider adding STATUS_RESETTING to the list, as it is a valid snapshot status covered in the reset flow.","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"7c9de04ec02eb516b2ee9280899a8158cbcbcae9","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec4bbf89_4823bb15","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"in_reply_to":"13c951ef_929be557","updated":"2026-07-17 06:57:28.000000000","message":"Goutham\u0027s comment is really helpful, so I went through all the code that updates snapshot status and found 2 more: \"migrating_to\" and \"restoring\".\n  - migrating_to: https://opendev.org/openstack/manila/src/commit/b45343a91672d7d0c65e17c7fb0d652a887a958b/manila/share/manager.py#L1383-L1387\n  - restoring: https://opendev.org/openstack/manila/src/commit/b45343a91672d7d0c65e17c7fb0d652a887a958b/manila/share/api.py#L1489-L1491\n\nSo 3 statuses should be added: STATUS_MIGRATING, STATUS_MIGRATING_TO, STATUS_RESTORING.","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85f17ebdf0c0b3026dacff2b297a6b6c8b36661d","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"13c951ef_929be557","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"in_reply_to":"579f0adf_82b65e8a","updated":"2026-07-16 10:45:50.000000000","message":"\u003e I\u0027m also a but confusing - the statuses on the list seem accurate though.\n\nwoah, I didn\u0027t re-read before posting, as I rewrote this a couple of times. I meant I\u0027m also a bit confused by the comment.\n\nAnd yes, migrating could be added to the list :)","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ea4b9ec7303e0f92c21ef96e5252ee46ebd5381f","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"579f0adf_82b65e8a","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"in_reply_to":"b4311bf7_66890282","updated":"2026-07-15 19:46:32.000000000","message":"yes, \"resetting\" isn\u0027t a snapshot status, but \"migrating\" is:\n\nhttps://opendev.org/openstack/manila/src/commit/b45343a91672d7d0c65e17c7fb0d652a887a958b/manila/share/manager.py#L1394-L1396","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"e994ae989f5b29ec900b4157aa381f6ada93bbb2","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"faa53c22_386752db","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"in_reply_to":"ea0f6a6c_a457957c","updated":"2026-07-14 14:46:08.000000000","message":"@vhariria@redhat.com Just wondering I couldn\u0027t find STATUS_RESETTING in the Manila code, and the API reference(https://docs.openstack.org/api-ref/shared-file-system/#reset-share-snapshot-state) only lists the statuses added here; could you clarify witch status you meant?","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":35652,"name":"Soyoon Lee","display_name":"soyoon-lee","email":"soyoon.lee@samsung.com","username":"soyoon-lee"},"change_message_id":"8339a08986b820de4f3725af1527de4b66bb87be","unresolved":false,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a0d2668_b25db66e","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"in_reply_to":"ec4bbf89_4823bb15","updated":"2026-07-21 12:07:41.000000000","message":"Thanks for the reviews @vhariria@redhat.com @inyong.hong@samsung.com @ces.eduardo98@gmail.com @gouthampravi@gmail.com\n\nDone in patch set 2.","commit_id":"ec546879121522b42510b9826f53603088d19174"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dcfc2eed6c69673703790595ddad92baed3f4fad","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    STATUS_NETWORK_CHANGE,"},{"line_number":296,"context_line":")"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"SHARE_SNAPSHOT_STATUSES \u003d ("},{"line_number":299,"context_line":"    STATUS_AVAILABLE,"},{"line_number":300,"context_line":"    STATUS_ERROR,"},{"line_number":301,"context_line":"    STATUS_ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b4311bf7_66890282","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":24},"in_reply_to":"faa53c22_386752db","updated":"2026-07-15 19:39:28.000000000","message":"I\u0027m also a but confusing - the statuses on the list seem accurate though.","commit_id":"ec546879121522b42510b9826f53603088d19174"}]}