)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"b8e604e184d81bf58d1abd3fffd1805fa0058fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2756c56b_10685427","updated":"2026-07-27 11:03:01.000000000","message":"Please address the comments.","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"561e1ed08f95579ef4abd58139e817598dd7cb44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"09642d13_5790f6e3","updated":"2026-07-27 14:12:21.000000000","message":"Please take a look at comments from Kumar.","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"2505d05520e0781206f750c29cf8549a7d5d4021","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"895a21c6_c7ad8281","updated":"2026-07-29 07:29:42.000000000","message":"Please address this comment","commit_id":"e10c214eed66984463c7d534e21d42f584d8ec1c"}],"manila/share/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"b8e604e184d81bf58d1abd3fffd1805fa0058fd0","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        self.connection.set_ontap_version(ontap_version)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.zapi_fallback_enabled \u003d kwargs.get(\u0027zapi_fallback_enabled\u0027,"},{"line_number":97,"context_line":"                                                False)"},{"line_number":98,"context_line":"        if self.zapi_fallback_enabled:"},{"line_number":99,"context_line":"            # NOTE(nahimsouza): ZAPI Client is needed to implement the"},{"line_number":100,"context_line":"            # fallback when a REST method is not supported."}],"source_content_type":"text/x-python","patch_set":2,"id":"8bb6ddb2_8498709b","line":97,"updated":"2026-07-27 11:03:01.000000000","message":"Default must be True.","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"08f53dba8a5c52a09775f8d3aa0ba45179ba47f8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.connection.set_ontap_version(ontap_version)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        self.zapi_fallback_enabled \u003d kwargs.get(\u0027zapi_fallback_enabled\u0027,"},{"line_number":97,"context_line":"                                                False)"},{"line_number":98,"context_line":"        if self.zapi_fallback_enabled:"},{"line_number":99,"context_line":"            # NOTE(nahimsouza): ZAPI Client is needed to implement the"},{"line_number":100,"context_line":"            # fallback when a REST method is not supported."}],"source_content_type":"text/x-python","patch_set":2,"id":"76cb7f6b_7de97ef9","line":97,"in_reply_to":"8bb6ddb2_8498709b","updated":"2026-07-29 04:07:03.000000000","message":"Done","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"b8e604e184d81bf58d1abd3fffd1805fa0058fd0","unresolved":true,"context_lines":[{"line_number":1959,"context_line":"            vserver \u003d record.get(\u0027svm\u0027, {}).get(\u0027name\u0027)"},{"line_number":1960,"context_line":""},{"line_number":1961,"context_line":"            client \u003d copy.deepcopy(self)"},{"line_number":1962,"context_line":"            client.connection.set_vserver(vserver)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"            clones \u003d self.get_clones_of_parent_volume("},{"line_number":1965,"context_line":"                vserver, vol_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b767ad61_fc2e33ed","line":1962,"updated":"2026-07-27 11:03:01.000000000","message":"Why this change required?","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"423a233c5728357a271d08e764865549ce099147","unresolved":false,"context_lines":[{"line_number":1959,"context_line":"            vserver \u003d record.get(\u0027svm\u0027, {}).get(\u0027name\u0027)"},{"line_number":1960,"context_line":""},{"line_number":1961,"context_line":"            client \u003d copy.deepcopy(self)"},{"line_number":1962,"context_line":"            client.connection.set_vserver(vserver)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"            clones \u003d self.get_clones_of_parent_volume("},{"line_number":1965,"context_line":"                vserver, vol_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"10637ca7_67f6d0d0","line":1962,"in_reply_to":"b767ad61_fc2e33ed","updated":"2026-07-29 03:24:18.000000000","message":"set_vserver is not a native REST method — calling client.set_vserver() would fall through __getattr__ to the ZAPI client, which only updates the ZAPI client\u0027s vserver, not the REST connection. With the new fallback toggle, if fallback is disabled it would also raise an exception. client.connection.set_vserver() directly sets the vserver on the REST connection, which is what we need here.","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"2505d05520e0781206f750c29cf8549a7d5d4021","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            zapi_fallback_enabled \u003d object.__getattribute__("},{"line_number":155,"context_line":"                self, \u0027zapi_fallback_enabled\u0027)"},{"line_number":156,"context_line":"        except AttributeError:"},{"line_number":157,"context_line":"            zapi_fallback_enabled \u003d False"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if not zapi_fallback_enabled:"},{"line_number":160,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":3,"id":"4992564f_40a92fc6","line":157,"updated":"2026-07-29 07:29:42.000000000","message":"When we make fallback by default as true.\nThis should be changed right?","commit_id":"e10c214eed66984463c7d534e21d42f584d8ec1c"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"37e876d2aa845bd86a5482717b75ecd91186982c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            zapi_fallback_enabled \u003d object.__getattribute__("},{"line_number":155,"context_line":"                self, \u0027zapi_fallback_enabled\u0027)"},{"line_number":156,"context_line":"        except AttributeError:"},{"line_number":157,"context_line":"            zapi_fallback_enabled \u003d False"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if not zapi_fallback_enabled:"},{"line_number":160,"context_line":"            msg \u003d _("}],"source_content_type":"text/x-python","patch_set":3,"id":"d4b4ca6c_bd1d0853","line":157,"in_reply_to":"4992564f_40a92fc6","updated":"2026-07-29 11:58:44.000000000","message":"Done","commit_id":"e10c214eed66984463c7d534e21d42f584d8ec1c"},{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"2505d05520e0781206f750c29cf8549a7d5d4021","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        if not zapi_fallback_enabled:"},{"line_number":160,"context_line":"            msg \u003d _("},{"line_number":161,"context_line":"                \u0027The %(name)s call is not supported for REST and the ZAPI \u0027"},{"line_number":162,"context_line":"                \u0027fallback is disabled. Set \"netapp_allow_zapi_fallback\" \u0027"},{"line_number":163,"context_line":"                \u0027to \"true\" to allow fallback.\u0027)"},{"line_number":164,"context_line":"            LOG.warning(msg, {\u0027name\u0027: name})"},{"line_number":165,"context_line":"            raise exception.NetAppException(msg % {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":3,"id":"5b9bdc78_4f095710","line":162,"updated":"2026-07-29 07:29:42.000000000","message":"When we make fallback by default as true.\nThis message should be changed right?","commit_id":"e10c214eed66984463c7d534e21d42f584d8ec1c"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"37e876d2aa845bd86a5482717b75ecd91186982c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if not zapi_fallback_enabled:"},{"line_number":160,"context_line":"            msg \u003d _("},{"line_number":161,"context_line":"                \u0027The %(name)s call is not supported for REST and the ZAPI \u0027"},{"line_number":162,"context_line":"                \u0027fallback is disabled. Set \"netapp_allow_zapi_fallback\" \u0027"},{"line_number":163,"context_line":"                \u0027to \"true\" to allow fallback.\u0027)"},{"line_number":164,"context_line":"            LOG.warning(msg, {\u0027name\u0027: name})"},{"line_number":165,"context_line":"            raise exception.NetAppException(msg % {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c36cb95_e59a28ff","line":162,"in_reply_to":"5b9bdc78_4f095710","updated":"2026-07-29 11:58:44.000000000","message":"Done","commit_id":"e10c214eed66984463c7d534e21d42f584d8ec1c"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":38371,"name":"Kumar Tadepalli","display_name":"Kumar Tadepalli","email":"kumart.lead@gmail.com","username":"kumart","status":"NetApp"},"change_message_id":"b8e604e184d81bf58d1abd3fffd1805fa0058fd0","unresolved":true,"context_lines":[{"line_number":256,"context_line":"               help\u003d\u0027Sets maximum amount of time in seconds to wait for a \u0027"},{"line_number":257,"context_line":"                    \u0027synchronous ONTAP REST API operation to be completed.\u0027),"},{"line_number":258,"context_line":"    cfg.BoolOpt(\u0027netapp_allow_zapi_fallback\u0027,"},{"line_number":259,"context_line":"                default\u003dFalse,"},{"line_number":260,"context_line":"                help\u003d\u0027This option allows ONTAP REST client methods to \u0027"},{"line_number":261,"context_line":"                     \u0027fallback to ZAPI when a REST method is not \u0027"},{"line_number":262,"context_line":"                     \u0027implemented.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a20180b_60cf2777","line":259,"updated":"2026-07-27 11:03:01.000000000","message":"Default must be True.","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":39161,"name":"Medha Choudhary netapp","display_name":"Medha Choudhary (netapp)","email":"medhac@netapp.com","username":"medhac","status":"Netapp"},"change_message_id":"08f53dba8a5c52a09775f8d3aa0ba45179ba47f8","unresolved":false,"context_lines":[{"line_number":256,"context_line":"               help\u003d\u0027Sets maximum amount of time in seconds to wait for a \u0027"},{"line_number":257,"context_line":"                    \u0027synchronous ONTAP REST API operation to be completed.\u0027),"},{"line_number":258,"context_line":"    cfg.BoolOpt(\u0027netapp_allow_zapi_fallback\u0027,"},{"line_number":259,"context_line":"                default\u003dFalse,"},{"line_number":260,"context_line":"                help\u003d\u0027This option allows ONTAP REST client methods to \u0027"},{"line_number":261,"context_line":"                     \u0027fallback to ZAPI when a REST method is not \u0027"},{"line_number":262,"context_line":"                     \u0027implemented.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"23f419d2_3e3b201c","line":259,"in_reply_to":"3f6b7ed9_af7072ca","updated":"2026-07-29 04:07:03.000000000","message":"Done","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"561e1ed08f95579ef4abd58139e817598dd7cb44","unresolved":true,"context_lines":[{"line_number":256,"context_line":"               help\u003d\u0027Sets maximum amount of time in seconds to wait for a \u0027"},{"line_number":257,"context_line":"                    \u0027synchronous ONTAP REST API operation to be completed.\u0027),"},{"line_number":258,"context_line":"    cfg.BoolOpt(\u0027netapp_allow_zapi_fallback\u0027,"},{"line_number":259,"context_line":"                default\u003dFalse,"},{"line_number":260,"context_line":"                help\u003d\u0027This option allows ONTAP REST client methods to \u0027"},{"line_number":261,"context_line":"                     \u0027fallback to ZAPI when a REST method is not \u0027"},{"line_number":262,"context_line":"                     \u0027implemented.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f6b7ed9_af7072ca","line":259,"in_reply_to":"7a20180b_60cf2777","updated":"2026-07-27 14:12:21.000000000","message":"+1. The default behaviour for zapi fallback should be true.","commit_id":"a1f2ac65adc1b08f0a2d0b7e0c8176eb262a5437"}]}