)]}'
{"id":"openstack%2Fmanila~998745","triplet_id":"openstack%2Fmanila~master~Ie7c73fec7af44e7470125bc2d7e0458681b3848a","project":"openstack/manila","branch":"master","hashtags":[],"change_id":"Ie7c73fec7af44e7470125bc2d7e0458681b3848a","subject":"db: Add missing raise for exception.NotFound()","status":"ABANDONED","created":"2026-07-27 01:45:36.000000000","updated":"2026-07-27 01:46:36.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b0999757da3b15688a3861bd398bf5f6e1732054","_number":998745,"virtual_id_number":998745,"owner":{"_account_id":36739,"name":"HyungJoon Kim","display_name":"hjoon87.kim","email":"hjoon87.kim@samsung.com","username":"hjoon87.kim"},"actions":{},"labels":{"Verified":{"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"f5bcbed8f15b79747715612f375172f1f94a73a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36739,"name":"HyungJoon Kim","display_name":"hjoon87.kim","email":"hjoon87.kim@samsung.com","username":"hjoon87.kim"},"date":"2026-07-27 01:45:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b0999757da3b15688a3861bd398bf5f6e1732054","tag":"autogenerated:gerrit:abandon","author":{"_account_id":36739,"name":"HyungJoon Kim","display_name":"hjoon87.kim","email":"hjoon87.kim@samsung.com","username":"hjoon87.kim"},"date":"2026-07-27 01:46:36.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"126f23ec01e216052d2ed7a05b4d2a7de164f75b","revisions":{"126f23ec01e216052d2ed7a05b4d2a7de164f75b":{"kind":"REWORK","_number":1,"created":"2026-07-27 01:45:36.000000000","uploader":{"_account_id":36739,"name":"HyungJoon Kim","display_name":"hjoon87.kim","email":"hjoon87.kim@samsung.com","username":"hjoon87.kim"},"ref":"refs/changes/45/998745/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/manila","ref":"refs/changes/45/998745/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/manila refs/changes/45/998745/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/manila refs/changes/45/998745/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/manila refs/changes/45/998745/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/manila refs/changes/45/998745/1"}}},"commit":{"parents":[{"commit":"1a3b61838e647d5d9abde344803ec61d79293b2f","subject":"Merge \"Enable SRBAC new defaults by default in devstack\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/1a3b61838e647d5d9abde344803ec61d79293b2f"}]}],"author":{"name":"HyungJoon Kim","email":"hjoon87.kim@samsung.com","date":"2026-07-27 01:01:39.000000000","tz":540},"committer":{"name":"HyungJoon Kim","email":"hjoon87.kim@samsung.com","date":"2026-07-27 01:42:17.000000000","tz":540},"subject":"db: Add missing raise for exception.NotFound()","message":"db: Add missing raise for exception.NotFound()\n\nThree functions in manila/db/sqlalchemy/api.py instantiate\nexception.NotFound() without the raise keyword, so the exception object\nis discarded and execution falls through to code that dereferences the\nobject that was just found to be None. The \"if not \u003cobj\u003e:\" guard is\ntherefore dead code, and a TypeError or AttributeError is raised from\nthe following statement instead of NotFound.\n\nAffected functions:\n* share_instance_access_delete()\n* _share_snapshot_instance_access_delete()\n* _share_snapshot_instance_export_location_delete()\n\nThis change adds the missing raise keyword in all three places.\n\nCloses-Bug: #2161859\nChange-Id: Ie7c73fec7af44e7470125bc2d7e0458681b3848a\nSigned-off-by: HyungJoon Kim \u003chjoon87.kim@samsung.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/126f23ec01e216052d2ed7a05b4d2a7de164f75b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/manila/commit/126f23ec01e216052d2ed7a05b4d2a7de164f75b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}