)]}'
{"masakaridashboard/dashboard.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"a61b8f4792b9c1cfef11428c85cbbb095d074ea4","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        # disable whole dashboard if masakari"},{"line_number":37,"context_line":"        # is not present in the service catalog"},{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            api.openstack_connection(context[\u0027request\u0027])"},{"line_number":40,"context_line":"        except Exception as e:"},{"line_number":41,"context_line":"            LOG.warning(f\"Failed to find suitable endpoint for Instance HA \""},{"line_number":42,"context_line":"                        f\"service, Masakari Dashboard will not be displayed. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"e01776dd_dcd9508e","line":39,"range":{"start_line":39,"start_character":16,"end_line":39,"end_character":36},"updated":"2021-02-24 19:00:51.000000000","message":"It\u0027s not obvious what actually this method does.\n\nPlease, add few words what is it to understand a logic without looking into the code.","commit_id":"9b800be03f6585bf4d136b608e0bb6db867732f0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f217b3421fa06d2f42145a8e2897b632694e6d17","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # disable whole dashboard if masakari"},{"line_number":37,"context_line":"        # is not present in the service catalog"},{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            api.openstack_connection(context[\u0027request\u0027])"},{"line_number":40,"context_line":"        except Exception as e:"},{"line_number":41,"context_line":"            LOG.warning(f\"Failed to find suitable endpoint for Instance HA \""},{"line_number":42,"context_line":"                        f\"service, Masakari Dashboard will not be displayed. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"2b85d862_4dc44055","line":39,"range":{"start_line":39,"start_character":16,"end_line":39,"end_character":36},"in_reply_to":"e01776dd_dcd9508e","updated":"2021-02-25 12:09:52.000000000","message":"Done","commit_id":"9b800be03f6585bf4d136b608e0bb6db867732f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6f617b4b67568144da42200fa3a3f78248bc752","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        # disable whole dashboard if masakari"},{"line_number":37,"context_line":"        # is not present in the service catalog"},{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            # NOTE(pas-ha) this method tries to construct keystoneauth.Adapter"},{"line_number":40,"context_line":"            # for the Instance-HA service,"},{"line_number":41,"context_line":"            # which will fail if the service is absent"},{"line_number":42,"context_line":"            api.openstack_connection(context[\u0027request\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9d65d3a4_3e791553","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":27},"updated":"2021-03-11 18:36:32.000000000","message":"nit: many editors/toolings will not count this NOTE because it lacks a colon after the parens","commit_id":"1a6d07c683863d2a486b46c771c5df78dedb288b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6f617b4b67568144da42200fa3a3f78248bc752","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        except Exception as e:"},{"line_number":44,"context_line":"            # catch all errors and log them,"},{"line_number":45,"context_line":"            # no need to totally fail on e.g. HTTP connect failure"},{"line_number":46,"context_line":"            LOG.warning(f\"Failed to find suitable endpoint for Instance HA \""},{"line_number":47,"context_line":"                        f\"service, Masakari Dashboard will not be displayed. \""},{"line_number":48,"context_line":"                        f\"Error was: {e}\")"},{"line_number":49,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"b11605c2_2d2b9270","line":46,"range":{"start_line":46,"start_character":40,"end_line":46,"end_character":41},"updated":"2021-03-11 18:36:32.000000000","message":"nit: \"a\"","commit_id":"1a6d07c683863d2a486b46c771c5df78dedb288b"}]}
