)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4fbbd50db26eac56027ee8cc42a3afa495575886","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1134fcf_df64e982","updated":"2026-10-19 07:43:51.000000000","message":"Thanks for the bug fix. overall lgtm. -1 is for the config description.","commit_id":"80fa9fa61df85b75c239bb4235f086216cf33137"},{"author":{"_account_id":38176,"name":"Sei Sano","display_name":"say3no","email":"sei.sano@ntt.com","username":"say3no"},"change_message_id":"672e2b37261be5fcde33c575e6701000b3773f84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4593ea5_db9771be","updated":"2026-10-19 08:00:09.000000000","message":"Thanks for the fix. \"hostmonitor never read the cib\" in the commit\nmessage is literally \"never\" - I traced the code and cibadmin is not\ncalled even once in that mode. Let me confirm my understanding of the\nhistory.\n\nOriginally (29d82c3) hostmonitor read only the cib, and got both the host\nstatus and the IPMI params for the power-off check from it. dc9b777 (2019)\nswitched the source of the host status to crm_mon when\nrestrict_to_remotes \u003d True, but _is_poweroff() was left relying on the cib\nparser, which is never populated in that mode (set_cib_xml() is only\ncalled from _check_host_status_by_cibadmin()).\n\nAs a result, with restrict_to_remotes \u003d True:\n\n* disable_ipmi_check \u003d False (default): get_stonith_ipmi_params() hits\n  list(None) and raises TypeError outside the try block of _is_poweroff().\n  It is caught in monitor_hosts(), the host status is never updated, and\n  the same thing happens at every interval. The notification is never\n  sent.\n* disable_ipmi_check \u003d True: the notification is sent with host_status\n  NORMAL as soon as crm_mon reports the remote as offline, which leads to\n  the unsafe evacuation described in the bug.\n\nMy understanding is that this patch fixes the former by replacing the\nIPMI check with the node_fenced attribute in the cib for remote hosts.\nPlease correct me if I\u0027m wrong.\n\nBefore I vote, I\u0027d like to confirm the behavior on a real environment\n(one full cluster node + two pacemaker-remote computes, fenced with\nfence_virsh), both the current master and this patch. I\u0027ll set it up on\nmy side and report back.","commit_id":"80fa9fa61df85b75c239bb4235f086216cf33137"}],"masakarimonitors/conf/host.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4fbbd50db26eac56027ee8cc42a3afa495575886","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"If ipmi RA is not set in pacemaker, this value should be set True."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"When ``restrict_to_remotes`` is True, whether the offline remote host was"},{"line_number":53,"context_line":"fenced is checked by the node_fenced attribute in the cib instead of ipmi."},{"line_number":54,"context_line":"Hostmonitor doesn\u0027t send a notification until the remote host is fenced."},{"line_number":55,"context_line":"\u0027\u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fcb7af6f_7c731cdf","line":52,"updated":"2026-10-19 07:43:51.000000000","message":"It\u0027s a config explanation for the `restrict_to_remotes` not for `disable_ipmi_check`. Please move the docs to the `disable_ipmi_check`.","commit_id":"80fa9fa61df85b75c239bb4235f086216cf33137"}],"masakarimonitors/hostmonitor/host_handler/handle_host.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4fbbd50db26eac56027ee8cc42a3afa495575886","unresolved":true,"context_lines":[{"line_number":363,"context_line":"                continue"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"            if stabilised_status \u003d\u003d \u0027online\u0027:"},{"line_number":366,"context_line":"                self.fence_waiting_hosts.discard(hostname)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"            # If host stabilised status changed, send a notification."},{"line_number":369,"context_line":"            if stabilised_status !\u003d old_status:"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1090079_ee92be2f","line":366,"updated":"2026-10-19 07:43:51.000000000","message":"I prefer to add one log message here because it\u0027s difficult to trace when the host is removed from the fence_waiting_hosts in the log file.","commit_id":"80fa9fa61df85b75c239bb4235f086216cf33137"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"4fbbd50db26eac56027ee8cc42a3afa495575886","unresolved":true,"context_lines":[{"line_number":393,"context_line":"                        else:"},{"line_number":394,"context_line":"                            LOG.warning(\"%s\", msg)"},{"line_number":395,"context_line":"                            self.fence_waiting_hosts.add(hostname)"},{"line_number":396,"context_line":"                        continue"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"                    self.fence_waiting_hosts.discard(hostname)"},{"line_number":399,"context_line":"                    event \u003d self._make_event(hostname, stabilised_status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd82a881_88a5694e","line":396,"updated":"2026-10-19 07:43:51.000000000","message":"`return` ?","commit_id":"80fa9fa61df85b75c239bb4235f086216cf33137"}]}