)]}'
{"masakarimonitors/hostmonitor/host_handler/handle_host.py":[{"author":{"_account_id":32304,"name":"Jegor van Opdorp","email":"jegor@leaf.cloud","username":"jopdorp"},"change_message_id":"f046443935eb8cfb1154aeef433c5ff71b4dd5d1","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Only the sequence of one host status is consistently \u0027offline\u0027,"},{"line_number":81,"context_line":"        # it return \u0027offline\u0027."},{"line_number":82,"context_line":"        if \u0027online\u0027 in health_history:"},{"line_number":83,"context_line":"            return \u0027online\u0027"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            return \u0027offline\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"e38245d6_67b6a4ce","line":82,"updated":"2021-02-23 06:40:18.000000000","message":"I think it would is make more sense to return \u0027None\u0027 when health_status contains multiple different values like [\u0027online\u0027, \u0027offline\u0027] and only return \u0027online\u0027 of \u0027offline for something like [\u0027online\u0027, \u0027online\u0027] or [\u0027offline\u0027, \u0027offline\u0027]\nThe way it works now the system is greedy to switch to the online status again","commit_id":"cec9e42793815551d9cd5475a8dda3df646d66be"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"77385e3f2973f578c1fffe393aa17b2802ca4a58","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Only the sequence of one host status is consistently \u0027offline\u0027,"},{"line_number":81,"context_line":"        # it return \u0027offline\u0027."},{"line_number":82,"context_line":"        if \u0027online\u0027 in health_history:"},{"line_number":83,"context_line":"            return \u0027online\u0027"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            return \u0027offline\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"425be1d7_853a6138","line":82,"in_reply_to":"e38245d6_67b6a4ce","updated":"2021-02-26 08:20:25.000000000","message":"In my opinion, \u0027offline\u0027 is failed status and recovery workflow is risky so it needs more checks to reduce the misjudgment. There is no meaningful workflow when host status changes from \u0027offline\u0027 to \u0027online\u0027. Your opinion is all right, I will respect it.","commit_id":"cec9e42793815551d9cd5475a8dda3df646d66be"}]}