)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"e8b943f0c33bd574f6a3b0fcbcae07c9b0aec6f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"50f23d92_80ba15cd","updated":"2024-05-29 07:09:42.000000000","message":"It is needed to cover the code with unit tests","commit_id":"2ecec29e4ea9a863392545c14002ff1d1d4bf312"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"4f93f64fb4d9c5eb1f49de577c9b67d4bd6e58e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"baa2a554_f1071a55","updated":"2025-03-18 16:03:34.000000000","message":"lgtm","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"db2fd45984b9764bb2947e8b471c41723aee6d26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2f0f1938_e467ad01","updated":"2025-03-21 07:19:23.000000000","message":"It is a new feature. Would you please to provide a releasenote?","commit_id":"0019c72df01aea52c068bfd657c4cba97abe5f3c"},{"author":{"_account_id":36134,"name":"do-gyun kim","display_name":"do-gyun","email":"d0gyun.kim@samsung.com","username":"do-gyun"},"change_message_id":"e275a72685a276206231e4b4f160669860b73458","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f2f8a9e1_c43fcc2a","in_reply_to":"2f0f1938_e467ad01","updated":"2025-03-25 05:07:15.000000000","message":"I checked late because this comment has been resolved. I have added a release note!","commit_id":"0019c72df01aea52c068bfd657c4cba97abe5f3c"},{"author":{"_account_id":36134,"name":"do-gyun kim","display_name":"do-gyun","email":"d0gyun.kim@samsung.com","username":"do-gyun"},"change_message_id":"15a8fc816be21b0233cfa8596fcf5c2d6a3987c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"02905d58_249df77a","in_reply_to":"f2f8a9e1_c43fcc2a","updated":"2025-03-26 01:27:31.000000000","message":"Done","commit_id":"0019c72df01aea52c068bfd657c4cba97abe5f3c"}],"masakarimonitors/hostmonitor/kubernetes_check/manager.py":[{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"2a0dd5af28606a4505ae13bf2e92c2c6dee2a8f6","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                \u0027generated_time\u0027: timeutils.utcnow(),"},{"line_number":90,"context_line":"                \u0027payload\u0027: {"},{"line_number":91,"context_line":"                    \u0027event\u0027: ec.EventConstants.EVENT_STOPPED,"},{"line_number":92,"context_line":"                    \u0027host_status\u0027: ec.EventConstants.HOST_STATUS_NORMAL"},{"line_number":93,"context_line":"                }"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"984e3bda_4f6e651c","line":92,"updated":"2025-03-19 09:30:56.000000000","message":"Field \"host_status\" in the payload is not the proper status when send host failure notification, the same with consul and pacemaker monitor.\nShall we remove the field or add one new \"UNNORMAL\" status?","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":36134,"name":"do-gyun kim","display_name":"do-gyun","email":"d0gyun.kim@samsung.com","username":"do-gyun"},"change_message_id":"6a931b0c852db0096fb50bb9365fce8479744ae2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \u0027generated_time\u0027: timeutils.utcnow(),"},{"line_number":90,"context_line":"                \u0027payload\u0027: {"},{"line_number":91,"context_line":"                    \u0027event\u0027: ec.EventConstants.EVENT_STOPPED,"},{"line_number":92,"context_line":"                    \u0027host_status\u0027: ec.EventConstants.HOST_STATUS_NORMAL"},{"line_number":93,"context_line":"                }"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"ef8d3614_f3a88d44","line":92,"in_reply_to":"4a8cae86_01c028ab","updated":"2025-03-21 07:28:28.000000000","message":"I see","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":36134,"name":"do-gyun kim","display_name":"do-gyun","email":"d0gyun.kim@samsung.com","username":"do-gyun"},"change_message_id":"4c9e740bac0fd3ed11d5eeb604e8aa96003f7b12","unresolved":true,"context_lines":[{"line_number":89,"context_line":"                \u0027generated_time\u0027: timeutils.utcnow(),"},{"line_number":90,"context_line":"                \u0027payload\u0027: {"},{"line_number":91,"context_line":"                    \u0027event\u0027: ec.EventConstants.EVENT_STOPPED,"},{"line_number":92,"context_line":"                    \u0027host_status\u0027: ec.EventConstants.HOST_STATUS_NORMAL"},{"line_number":93,"context_line":"                }"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"fb02d266_f9295e55","line":92,"in_reply_to":"984e3bda_4f6e651c","updated":"2025-03-21 06:48:08.000000000","message":"Since it only send event when the status is bad, How about removing it?","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"db2fd45984b9764bb2947e8b471c41723aee6d26","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                \u0027generated_time\u0027: timeutils.utcnow(),"},{"line_number":90,"context_line":"                \u0027payload\u0027: {"},{"line_number":91,"context_line":"                    \u0027event\u0027: ec.EventConstants.EVENT_STOPPED,"},{"line_number":92,"context_line":"                    \u0027host_status\u0027: ec.EventConstants.HOST_STATUS_NORMAL"},{"line_number":93,"context_line":"                }"},{"line_number":94,"context_line":"            }"},{"line_number":95,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"4a8cae86_01c028ab","line":92,"in_reply_to":"fb02d266_f9295e55","updated":"2025-03-21 07:19:23.000000000","message":"No affect now. If necessary, we can talk about it later.","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"2a0dd5af28606a4505ae13bf2e92c2c6dee2a8f6","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            is_host_alive \u003d \"True\" in health_history"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            if is_host_alive:"},{"line_number":111,"context_line":"                continue"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            event \u003d self._event(host, is_host_alive)"},{"line_number":114,"context_line":"            self.notifier.send_notification("},{"line_number":115,"context_line":"                CONF.host.api_retry_max,"},{"line_number":116,"context_line":"                CONF.host.api_retry_interval,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7879f62a_4de0180e","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":52},"updated":"2025-03-19 09:30:56.000000000","message":"It is better to send a notification only when host status changed.\nIt would lead to unexpected performance if keeping sending notifications. For example, repeating recovery.","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":36134,"name":"do-gyun kim","display_name":"do-gyun","email":"d0gyun.kim@samsung.com","username":"do-gyun"},"change_message_id":"4c9e740bac0fd3ed11d5eeb604e8aa96003f7b12","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            is_host_alive \u003d \"True\" in health_history"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            if is_host_alive:"},{"line_number":111,"context_line":"                continue"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            event \u003d self._event(host, is_host_alive)"},{"line_number":114,"context_line":"            self.notifier.send_notification("},{"line_number":115,"context_line":"                CONF.host.api_retry_max,"},{"line_number":116,"context_line":"                CONF.host.api_retry_interval,"}],"source_content_type":"text/x-python","patch_set":8,"id":"abd01e8d_4d3113f2","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":52},"in_reply_to":"7879f62a_4de0180e","updated":"2025-03-21 06:48:08.000000000","message":"In fact, there were times when too many notifications were sent. I have modified it to trigger only on status changes as you suggested.","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"db2fd45984b9764bb2947e8b471c41723aee6d26","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            is_host_alive \u003d \"True\" in health_history"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"            if is_host_alive:"},{"line_number":111,"context_line":"                continue"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            event \u003d self._event(host, is_host_alive)"},{"line_number":114,"context_line":"            self.notifier.send_notification("},{"line_number":115,"context_line":"                CONF.host.api_retry_max,"},{"line_number":116,"context_line":"                CONF.host.api_retry_interval,"}],"source_content_type":"text/x-python","patch_set":8,"id":"73078ce1_4be62206","line":113,"range":{"start_line":110,"start_character":0,"end_line":113,"end_character":52},"in_reply_to":"abd01e8d_4d3113f2","updated":"2025-03-21 07:19:23.000000000","message":"Done","commit_id":"d5722f7e116e764555b41084e1cfe2afef9e7559"}]}