)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     suzhengwei \u003csugar-2008@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-02-05 15:35:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"enable to segment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I418aaa9c34826dd908363d91e0df718f55721536"},{"line_number":10,"context_line":"Implements: bp enable-to-segment"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1fa4df85_6c08a62b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"updated":"2020-03-02 04:33:13.000000000","message":"Add option to enable/disable segment\n\nThe blueprint proposes enabling/disabling of segment so that any notifications arriving from host assigned to it can be controlled as per the operator\u0027s requirement.","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"47782b5905573e83a731f1c6312f54860a695d7d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     suzhengwei \u003csugar-2008@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-09 01:28:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"spec for add option to enable/disable a segment"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If \u0027enable\u0027 of one failover segment is set False, all notifications"},{"line_number":10,"context_line":"which belong to this failover segment will be ignored, so that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff570b3c_7d11ddaf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":47},"updated":"2020-06-09 04:39:31.000000000","message":"The previous title was ok.\n\nAdd option to enable/disable a segment","commit_id":"d0fe45c9c5634f0a68c56b3322f6244fb4c6f65d"}],"specs/ussuri/approved/enable-to-segment.rst":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sometimes, end users want to disable compute ha temporarily. For example,"},{"line_number":18,"context_line":"it has serveral compute nodes in our cloud env, which are assigned to one"},{"line_number":19,"context_line":"segment. We unregularly pull the latest code or change hardware for test."},{"line_number":20,"context_line":"Every time when updating, we have to kill all masakari services after"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_cc5bda51","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":21},"updated":"2020-03-02 04:33:13.000000000","message":"operators","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sometimes, end users want to disable compute ha temporarily. For example,"},{"line_number":18,"context_line":"it has serveral compute nodes in our cloud env, which are assigned to one"},{"line_number":19,"context_line":"segment. We unregularly pull the latest code or change hardware for test."},{"line_number":20,"context_line":"Every time when updating, we have to kill all masakari services after"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_59c79397","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":21},"in_reply_to":"1fa4df85_cc5bda51","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sometimes, end users want to disable compute ha temporarily. For example,"},{"line_number":18,"context_line":"it has serveral compute nodes in our cloud env, which are assigned to one"},{"line_number":19,"context_line":"segment. We unregularly pull the latest code or change hardware for test."},{"line_number":20,"context_line":"Every time when updating, we have to kill all masakari services after"},{"line_number":21,"context_line":"masakari-monitors, so that it wouldn\u0027t trigger ha recovery workflow."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_8c55e21f","line":18,"range":{"start_line":18,"start_character":7,"end_line":18,"end_character":15},"updated":"2020-03-02 04:33:13.000000000","message":"several","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sometimes, end users want to disable compute ha temporarily. For example,"},{"line_number":18,"context_line":"it has serveral compute nodes in our cloud env, which are assigned to one"},{"line_number":19,"context_line":"segment. We unregularly pull the latest code or change hardware for test."},{"line_number":20,"context_line":"Every time when updating, we have to kill all masakari services after"},{"line_number":21,"context_line":"masakari-monitors, so that it wouldn\u0027t trigger ha recovery workflow."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_79c4cf91","line":18,"range":{"start_line":18,"start_character":7,"end_line":18,"end_character":15},"in_reply_to":"1fa4df85_8c55e21f","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"None"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_cc20bab3","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":4},"updated":"2020-03-02 04:33:13.000000000","message":"The \u0027enable\u0027 field of segment should be returned with failover segment for which you will need to introduce a new microversion and change the related REST API like :-\n1. POST /segments\n2. GET /segments\n3. GET /segment/\u003csegment_uuid\u003e","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"None"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Security impact"},{"line_number":57,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_39bad709","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":4},"in_reply_to":"1fa4df85_cc20bab3","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Notifications impact"},{"line_number":62,"context_line":"--------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Other end user impact"},{"line_number":67,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_8c2ac28d","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":4},"updated":"2020-03-02 04:33:13.000000000","message":"Need changes in notifications as you are adding \u0027enable\u0027 field in segment.\nRefer to docs: https://docs.openstack.org/masakari/latest/user/notifications.html.","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Notifications impact"},{"line_number":62,"context_line":"--------------------"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"None"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Other end user impact"},{"line_number":67,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_b9432713","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":4},"in_reply_to":"1fa4df85_8c2ac28d","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Other end user impact"},{"line_number":67,"context_line":"---------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Performance Impact"},{"line_number":72,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_2c1b8e81","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"updated":"2020-03-02 04:33:13.000000000","message":"changes in python-masakariclient is required. Please highlight those changes here.","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Other end user impact"},{"line_number":67,"context_line":"---------------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Performance Impact"},{"line_number":72,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_d93863a1","line":69,"range":{"start_line":69,"start_character":0,"end_line":69,"end_character":4},"in_reply_to":"1fa4df85_2c1b8e81","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Work Items"},{"line_number":97,"context_line":"----------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"None"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Dependencies"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_ec149650","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":4},"updated":"2020-03-02 04:33:13.000000000","message":"Please refer to the \"Work Items\" section from ussuri-template.rst and add the tasks here.","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":96,"context_line":"Work Items"},{"line_number":97,"context_line":"----------"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"None"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Dependencies"},{"line_number":102,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_993e6b89","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":4},"in_reply_to":"1fa4df85_ec149650","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"a7fe9e8670c87429de1646a08d01c7330ad4c08b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Testing"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Documentation Impact"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_0c18127f","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":4},"updated":"2020-03-02 04:33:13.000000000","message":"Please add scenario how you would like to test this feature.\n\nfor example, Create a new failover segment with enable\u003dFalse, add hosts to it. Create a notification (any type) and confirm that the status of  notification is set as \"IGNORED\".","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"9d3a233d0485786922f9842091a78ac32bc722da","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Testing"},{"line_number":105,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Documentation Impact"},{"line_number":110,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_f93d1f8f","line":107,"range":{"start_line":107,"start_character":0,"end_line":107,"end_character":4},"in_reply_to":"1fa4df85_0c18127f","updated":"2020-03-03 03:23:21.000000000","message":"Done","commit_id":"a6d268046535b5095963cf40c514990e41da9789"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"enable to segment"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/masakari/+spec/enable-to-segment"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_735ec312","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":17},"updated":"2020-03-30 09:33:51.000000000","message":"Add option to enable/disable a segment","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sometimes, operators want to disable compute ha temporarily. For example,"},{"line_number":18,"context_line":"it has several compute nodes in our cloud env, which are assigned to one"},{"line_number":19,"context_line":"segment. We unregularly pull the latest code or change hardware for test."},{"line_number":20,"context_line":"Every time when updating, we have to kill all masakari services after"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_53573f59","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":47},"updated":"2020-03-30 09:33:51.000000000","message":"instance-ha","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Problem description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Sometimes, operators want to disable compute ha temporarily. For example,"},{"line_number":18,"context_line":"it has several compute nodes in our cloud env, which are assigned to one"},{"line_number":19,"context_line":"segment. We unregularly pull the latest code or change hardware for test."},{"line_number":20,"context_line":"Every time when updating, we have to kill all masakari services after"},{"line_number":21,"context_line":"masakari-monitors, so that it wouldn\u0027t trigger ha recovery workflow."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Once upon a time, we forgot to kill all masakari services when updating."},{"line_number":24,"context_line":"The instances evacuted in a mess, which took us hours to make all instances"},{"line_number":25,"context_line":"back to normal."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So we need a solution to simply and easily close and open compute ha in"},{"line_number":28,"context_line":"specific case, such as update or maintenance."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_13b6578b","line":25,"range":{"start_line":17,"start_character":61,"end_line":25,"end_character":15},"updated":"2020-03-30 09:33:51.000000000","message":"For example, When we plan to update the hardware or pull the latest code on the compute nodes where the masakari-monitors are running, we are required to stop masakari-api and masakari-engine services so that it won\u0027t execute any ha recovery workflow. If you forget to stop these services, then it would end up in a mess and you will need to spend lot of your time in recovering instances which are messed up.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":24,"context_line":"The instances evacuted in a mess, which took us hours to make all instances"},{"line_number":25,"context_line":"back to normal."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"So we need a solution to simply and easily close and open compute ha in"},{"line_number":28,"context_line":"specific case, such as update or maintenance."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_33b0bb8a","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":45},"updated":"2020-03-30 09:33:51.000000000","message":"So, we need a simple solution which will allow masakari-api service to discard notifications for a temporarily period upon request without needing operator to stop these services.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Proposed change"},{"line_number":31,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"This spec is mainly to add \u0027enable\u0027 to segment object."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"The \u0027enable\u0027 value can be set by segment api. If admin set the \u0027enable\u0027"},{"line_number":36,"context_line":"value to false, then all notifications of the segment will be discarded,"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_3396fb94","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":54},"updated":"2020-03-30 09:33:51.000000000","message":"Rephrase  as\n\n- Add ``state`` option to a segment.  When you will create a new segment, it will be enabled by default.  State will be of two types: ACTIVE/INACTIVE.\n\n- Allow user to modify ``state`` option using PUT /segment/\u003csegment_uuid\u003e API.\n- Return the ``state`` in the GET /segments and GET /segments/\u003csegment_uuid\u003e APIs.\n\nIf a notification is received by masakari-api from a host belonging to a failover segment whose ``state`` option is set to ``INACTIVE``, then all such notifications will be discarded by masakari-api itself.\n\nAll the above API changes will be done in a new micro-version.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Data model impact"},{"line_number":46,"context_line":"-----------------"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Yes, add a new field \u0027enable\u0027 in segment table:"},{"line_number":49,"context_line":"enable \u003d Column(Boolean, default\u003dTrue)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_f35c93ee","line":49,"range":{"start_line":48,"start_character":1,"end_line":49,"end_character":38},"updated":"2020-03-30 09:33:51.000000000","message":"Add a new db column ``state``to ``failover_segments`` db table.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"To segments api, parameter \u0027enable\u0027 will be add into the request body"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"* POST /segments"},{"line_number":57,"context_line":"* PUT  /segments/{segment_id}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"and the \u0027enable\u0027 field will be return with segment failover objects."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Security impact"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_9300a7ad","line":59,"range":{"start_line":54,"start_character":0,"end_line":59,"end_character":68},"updated":"2020-03-30 09:33:51.000000000","message":"Following changes will be introduced in a new API micro-version.\n\n1. POST /segments\n\u003cAdd request example\u003e\n\u003cAdd response example\u003e\n\n2. PUT  /segments/{segment_id}\n\u003cAdd request example\u003e\n\u003cAdd response example\u003e\n\n3. GET /segments\n\u003cAdd request example\u003e\n\u003cAdd response example\u003e\n\n\n4. GET /segments/\u003csegment_uuid\u003e\n\u003cAdd request example\u003e\n\u003cAdd response example\u003e","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":67,"context_line":"Notifications impact"},{"line_number":68,"context_line":"--------------------"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Field \u0027enable\u0027 will be add into segment in masakari notifications."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Other end user impact"},{"line_number":73,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_f3df7337","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":66},"updated":"2020-03-30 09:33:51.000000000","message":"Mention which notifications will be updated as well.\n\nFor example: create.segment.start, create.segment.end etc.\n\nRefer to the existing versioned notification: https://docs.openstack.org/masakari/latest/user/notifications.html","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"Other end user impact"},{"line_number":73,"context_line":"---------------------"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"The segments api or object in following projects should be adjust."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"* python-masakariclient"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_130c9792","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":66},"updated":"2020-03-30 09:33:51.000000000","message":"The python-masakariclient, masakari-dashboard and openstacksdk will be updated to support ``state`` parameter of the segment in a new micro-version.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"Work Items"},{"line_number":109,"context_line":"----------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"* add enable option to segment in masakari, and documentation update."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"* other projects adjust, such as python-masakariclient, masakari-dashboard,"},{"line_number":114,"context_line":"  and openstacksdk."}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_73d523e5","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":69},"updated":"2020-03-30 09:33:51.000000000","message":"* Create a new API microversion to handle ``state`` parameter in segments.\n* Add unit and functional tests\n* Update API reference documentation\n* Update python-masakariclient, masakari-dashboard  and openstacksdk to manage ``state`` parameter of the segment.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Testing"},{"line_number":122,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Unit and functional test is neccessary."},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"If \u0027enable\u0027 of the failover segment is set False, all notifications"},{"line_number":127,"context_line":"which belong to this failover segment should be ignored."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Documentation Impact"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_d3906f46","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":56},"updated":"2020-03-30 09:33:51.000000000","message":"Add required unit and functional tests which will run in gate.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"b6b88733ae352443664533694de5d339ba11d4fe","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Documentation Impact"},{"line_number":130,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Masakari API reference documentation needs update."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"References"},{"line_number":135,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df33271e_f39bf362","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":50},"updated":"2020-03-30 09:33:51.000000000","message":"Update the api reference to include this change.","commit_id":"80a6b4c11e714f23c432e21f653cc9e84f1bcfb1"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"when we plan to update the hardware or pull the latest code on the compute"},{"line_number":19,"context_line":"nodes where the masakari-monitors are running, we are required to stop"},{"line_number":20,"context_line":"masakari-api and masakari-engine services so that it won\u0027t execute any ha"},{"line_number":21,"context_line":"recovery workflow. If you have forgot to stop these services, then it would"},{"line_number":22,"context_line":"end up in a mess and you will need to spend lot of your time in recovering"},{"line_number":23,"context_line":"instances which are messed up."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ee959588","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":60},"updated":"2020-05-19 06:21:28.000000000","message":"If you forget to stop these services","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":18,"context_line":"when we plan to update the hardware or pull the latest code on the compute"},{"line_number":19,"context_line":"nodes where the masakari-monitors are running, we are required to stop"},{"line_number":20,"context_line":"masakari-api and masakari-engine services so that it won\u0027t execute any ha"},{"line_number":21,"context_line":"recovery workflow. If you have forgot to stop these services, then it would"},{"line_number":22,"context_line":"end up in a mess and you will need to spend lot of your time in recovering"},{"line_number":23,"context_line":"instances which are messed up."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_2d6042a5","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":60},"in_reply_to":"ff570b3c_ee959588","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec is mainly to add option to enable/disable a segment"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4e6121d3","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":61},"updated":"2020-05-19 06:21:28.000000000","message":"This spec is mainly to add an option to enable/disable a segment.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Proposed change"},{"line_number":29,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec is mainly to add option to enable/disable a segment"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_6d56bad0","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":61},"in_reply_to":"ff570b3c_4e6121d3","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec is mainly to add option to enable/disable a segment"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_aea71d0b","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":14},"updated":"2020-05-19 06:21:28.000000000","message":"IMO, it should be enabled.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This spec is mainly to add option to enable/disable a segment"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4d5bf6f4","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":14},"in_reply_to":"ff570b3c_aea71d0b","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"This spec is mainly to add option to enable/disable a segment"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_6ea185f8","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":8},"updated":"2020-05-19 06:21:28.000000000","message":"enabled","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":31,"context_line":"This spec is mainly to add option to enable/disable a segment"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ad73b27f","line":34,"range":{"start_line":34,"start_character":2,"end_line":34,"end_character":8},"in_reply_to":"ff570b3c_6ea185f8","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* User can modify ``enable`` option by PUT /segment/\u003csegment_uuid\u003e API."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ae439d12","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":34},"updated":"2020-05-19 06:21:28.000000000","message":"notifications","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* User can modify ``enable`` option by PUT /segment/\u003csegment_uuid\u003e API."}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_8d706e74","line":35,"range":{"start_line":35,"start_character":21,"end_line":35,"end_character":34},"in_reply_to":"ff570b3c_ae439d12","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* User can modify ``enable`` option by PUT /segment/\u003csegment_uuid\u003e API."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4e52c1df","line":36,"range":{"start_line":36,"start_character":32,"end_line":36,"end_character":45},"updated":"2020-05-19 06:21:28.000000000","message":"notifications","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* Add ``enable`` option to a segment. When creating a new segment, it will be"},{"line_number":34,"context_line":"  enable by default. Option ``enable`` has a boolean value: \u0027True\u0027 means the"},{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* User can modify ``enable`` option by PUT /segment/\u003csegment_uuid\u003e API."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ed692a8c","line":36,"range":{"start_line":36,"start_character":32,"end_line":36,"end_character":45},"in_reply_to":"ff570b3c_4e52c1df","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* User can modify ``enable`` option by PUT /segment/\u003csegment_uuid\u003e API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_eedab575","line":38,"range":{"start_line":38,"start_character":39,"end_line":38,"end_character":66},"updated":"2020-05-19 06:21:28.000000000","message":"``PUT /segment/\u003csegment_uuid\u003e``","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  segment is enable, notificaitons of this segment will be processed; \u0027False\u0027"},{"line_number":36,"context_line":"  means the segment is disable, notificaitons of this segment will be ignored."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"* User can modify ``enable`` option by PUT /segment/\u003csegment_uuid\u003e API."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_cd66e6bb","line":38,"range":{"start_line":38,"start_character":39,"end_line":38,"end_character":66},"in_reply_to":"ff570b3c_eedab575","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Yes, add a new db column ``enable`` to ``failover_segments`` table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ee711578","line":49,"range":{"start_line":49,"start_character":27,"end_line":49,"end_character":33},"updated":"2020-05-19 06:21:28.000000000","message":"Add a new db column ``enabled`` of type ``Boolean`` with default value as ``True`` to ``failover_segments`` table.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":46,"context_line":"Data model impact"},{"line_number":47,"context_line":"-----------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Yes, add a new db column ``enable`` to ``failover_segments`` table."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"REST API impact"},{"line_number":52,"context_line":"---------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4d42d610","line":49,"range":{"start_line":49,"start_character":27,"end_line":49,"end_character":33},"in_reply_to":"ff570b3c_ee711578","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Notifications impact"},{"line_number":151,"context_line":"--------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Field ``enable`` will be add into segment in masakari notifications."},{"line_number":154,"context_line":"For example the wire format of the ``create.segment.start`` notification"},{"line_number":155,"context_line":"looks like the following::"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ce25315e","line":153,"range":{"start_line":153,"start_character":25,"end_line":153,"end_character":28},"updated":"2020-05-19 06:21:28.000000000","message":"added","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":150,"context_line":"Notifications impact"},{"line_number":151,"context_line":"--------------------"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"Field ``enable`` will be add into segment in masakari notifications."},{"line_number":154,"context_line":"For example the wire format of the ``create.segment.start`` notification"},{"line_number":155,"context_line":"looks like the following::"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_6d0b5ad4","line":153,"range":{"start_line":153,"start_character":25,"end_line":153,"end_character":28},"in_reply_to":"ff570b3c_ce25315e","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            },"},{"line_number":169,"context_line":"            \"masakari_object.name\": \"SegmentApiPayload\","},{"line_number":170,"context_line":"            \"masakari_object.namespace\": \"masakari\","},{"line_number":171,"context_line":"            \"masakari_object.version\": \"1.0\""},{"line_number":172,"context_line":"        },"},{"line_number":173,"context_line":"        \"publisher_id\": \"masakari-api:fake-mini\","},{"line_number":174,"context_line":"        \"timestamp\": \"2018-11-22 09:25:12.393979\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_8e2fb93d","line":171,"range":{"start_line":171,"start_character":40,"end_line":171,"end_character":43},"updated":"2020-05-19 06:21:28.000000000","message":"You will need to update the version to the next higher number.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            },"},{"line_number":169,"context_line":"            \"masakari_object.name\": \"SegmentApiPayload\","},{"line_number":170,"context_line":"            \"masakari_object.namespace\": \"masakari\","},{"line_number":171,"context_line":"            \"masakari_object.version\": \"1.0\""},{"line_number":172,"context_line":"        },"},{"line_number":173,"context_line":"        \"publisher_id\": \"masakari-api:fake-mini\","},{"line_number":174,"context_line":"        \"timestamp\": \"2018-11-22 09:25:12.393979\""}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_ed500ad8","line":171,"range":{"start_line":171,"start_character":40,"end_line":171,"end_character":43},"in_reply_to":"ff570b3c_8e2fb93d","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":213,"context_line":"* Update python-masakariclient, masakari-dashboard and openstacksdk to"},{"line_number":214,"context_line":"  manage ``enable`` parameter of the segment.."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"* Add functional tests"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Dependencies"},{"line_number":219,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4e192120","line":216,"range":{"start_line":216,"start_character":2,"end_line":216,"end_character":22},"updated":"2020-05-19 06:21:28.000000000","message":"Add unit and functional tests.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":213,"context_line":"* Update python-masakariclient, masakari-dashboard and openstacksdk to"},{"line_number":214,"context_line":"  manage ``enable`` parameter of the segment.."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"* Add functional tests"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"Dependencies"},{"line_number":219,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_6db23a08","line":216,"range":{"start_line":216,"start_character":2,"end_line":216,"end_character":22},"in_reply_to":"ff570b3c_4e192120","updated":"2020-06-02 12:22:02.000000000","message":"Unit tests is in the first work item. \nBecause Masakari functional tests depend on openstackSDK, so I leave it the last work item. It needs to update openstackSDK to manage \u0027enabled\u0027 parameter of the segment.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"40ffc9ace1ffaf0ceb5859b5f73a2d5ffe1f63fc","unresolved":false,"context_lines":[{"line_number":246,"context_line":"   * - Release Name"},{"line_number":247,"context_line":"     - Description"},{"line_number":248,"context_line":"   * - Ussuri"},{"line_number":249,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4eee41ed","line":249,"updated":"2020-05-19 06:21:28.000000000","message":"re-propose it for Victoria release.","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"3b413d18ed06f55ee159094f0fe5abc4bf0f0b75","unresolved":false,"context_lines":[{"line_number":246,"context_line":"   * - Release Name"},{"line_number":247,"context_line":"     - Description"},{"line_number":248,"context_line":"   * - Ussuri"},{"line_number":249,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":3,"id":"ff570b3c_4db776f6","line":249,"in_reply_to":"ff570b3c_4eee41ed","updated":"2020-06-02 12:22:02.000000000","message":"Done","commit_id":"f7bfbc1aa5a6bdc2c7f41b87590baf69e49c3dce"}],"specs/victoria/approved/enable-to-segment.rst":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"061d312eca039e6efb2b5e3b8efaaea221137801","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Following changes will be introduced in a new API micro-version."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"1.POST /segments"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  request example::"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff570b3c_631030aa","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":16},"updated":"2020-06-08 08:42:44.000000000","message":"In HTML, it\u0027s not rendered properly. You can see a thick vertical grey line.\n\nYou can change it to\n* POST /segments\n\nSame comment for the rest of below APIs.","commit_id":"c22a68fb1cd939cc969b7bd2755b7602ea05e61a"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"a624d87e45f885ba2197f6194f9f7d33a32b8a85","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Following changes will be introduced in a new API micro-version."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"1.POST /segments"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  request example::"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff570b3c_b743946c","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":16},"in_reply_to":"ff570b3c_631030aa","updated":"2020-06-09 01:16:51.000000000","message":"It can\u0027t type this symbol, so I used ‘*’instead.","commit_id":"c22a68fb1cd939cc969b7bd2755b7602ea05e61a"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"47782b5905573e83a731f1c6312f54860a695d7d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Following changes will be introduced in a new API micro-version."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"1.POST /segments"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  request example::"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff570b3c_7d28bded","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":16},"in_reply_to":"ff570b3c_b743946c","updated":"2020-06-09 04:39:31.000000000","message":"\u003e It can\u0027t type this symbol, so I used ‘*’instead.\n\nGood, I meant to say same thing.","commit_id":"c22a68fb1cd939cc969b7bd2755b7602ea05e61a"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"061d312eca039e6efb2b5e3b8efaaea221137801","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"   * - Release Name"},{"line_number":265,"context_line":"     - Description"},{"line_number":266,"context_line":"   * - Victoria"},{"line_number":267,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff570b3c_e31ba0c7","line":267,"range":{"start_line":266,"start_character":1,"end_line":267,"end_character":17},"updated":"2020-06-08 08:42:44.000000000","message":"Since this spec was introduced in last release, you should add Ussuri line as well.\n\n   * - Release Name\n      - Description\n   * - Ussuri\n      - Introduced\n   * - Victoria\n      - Re-proposed","commit_id":"c22a68fb1cd939cc969b7bd2755b7602ea05e61a"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"a624d87e45f885ba2197f6194f9f7d33a32b8a85","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"   * - Release Name"},{"line_number":265,"context_line":"     - Description"},{"line_number":266,"context_line":"   * - Victoria"},{"line_number":267,"context_line":"     - Introduced"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ff570b3c_f75cec4d","line":267,"range":{"start_line":266,"start_character":1,"end_line":267,"end_character":17},"in_reply_to":"ff570b3c_e31ba0c7","updated":"2020-06-09 01:16:51.000000000","message":"Done","commit_id":"c22a68fb1cd939cc969b7bd2755b7602ea05e61a"}]}