)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec introduces a new host monitor by consul. It monitors host"},{"line_number":10,"context_line":"heartbeat via management, tenant and storage connectivity. Only in the"},{"line_number":11,"context_line":"case of defined states, it will trgger host recovery, for example,"},{"line_number":12,"context_line":"storage interface disconnected."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If81a6a9543513acf199afe6a17dceb1544657272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_c7e11a2d","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":38},"updated":"2020-06-10 07:18:25.000000000","message":"trigger","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This spec introduces a new host monitor by consul. It monitors host"},{"line_number":10,"context_line":"heartbeat via management, tenant and storage connectivity. Only in the"},{"line_number":11,"context_line":"case of defined states, it will trgger host recovery, for example,"},{"line_number":12,"context_line":"storage interface disconnected."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If81a6a9543513acf199afe6a17dceb1544657272"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_7a1240b6","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":38},"in_reply_to":"ff570b3c_c7e11a2d","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"}],"doc/source/images/host-monitor-by-consul.png":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bde4774c_a8abd73e","updated":"2021-08-07 13:59:19.000000000","message":"There is one discrepancy between the image and the textual description - there are multiple monitors per node in the image while the text say that one monitor aggregates the info from multiple consul agents.","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab5ca10be6ad5ff86d6d78a36fa32798d99b5d54","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"23262aba_d96ade0e","in_reply_to":"135d5269_5d677fe7","updated":"2021-08-14 19:05:33.000000000","message":"Thanks. Could you update the image to reflect that? The image does not have source code so I can\u0027t help. 😞","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"135d5269_5d677fe7","in_reply_to":"bde4774c_a8abd73e","updated":"2021-08-13 10:23:07.000000000","message":"Yes, there is one hostmonitor per node, not multiple monitors. In the hostmonitor, it monitors multiple consul cluster throug corresponding consul client.","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"}],"specs/victoria/approved/host-monitor-by-consul.rst":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Usually, there are management network, tenant network and storage network"},{"line_number":18,"context_line":"in one cloud platform. The compute nodes may have management, tenant and"},{"line_number":19,"context_line":"storage interface to connect to the three networks."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Currently, Masakari host monitor uses pacemaker and pacemaker-remote to"},{"line_number":22,"context_line":"monitor hosts\u0027 connection. Actually, it is monitoring the hosts heartbeat"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_84ac4036","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":36},"updated":"2020-06-10 07:18:25.000000000","message":"these","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Usually, there are management network, tenant network and storage network"},{"line_number":18,"context_line":"in one cloud platform. The compute nodes may have management, tenant and"},{"line_number":19,"context_line":"storage interface to connect to the three networks."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Currently, Masakari host monitor uses pacemaker and pacemaker-remote to"},{"line_number":22,"context_line":"monitor hosts\u0027 connection. Actually, it is monitoring the hosts heartbeat"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_5a15bc9a","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":36},"in_reply_to":"ff570b3c_84ac4036","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":24,"context_line":"detected down, it will send notification to masakari to trigger host"},{"line_number":25,"context_line":"failure recovery workflow."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This solution is imprecise. When management connectivity is down, while"},{"line_number":28,"context_line":"tenant and storage connectivity is still up, it means the instances on the"},{"line_number":29,"context_line":"host can\u0027t be managed by operator but they are still available to end users."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_244a9482","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"updated":"2020-06-10 07:18:25.000000000","message":"You  can rephrase it as:\n\nThis solution has some flaws especially when ``management`` connectivity is down and while the other two networks ``tenant`` and ``storage`` are up, users can still access their VMs without any interruptions so there is no need to send notification until one or both of these networks are not down.","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":24,"context_line":"detected down, it will send notification to masakari to trigger host"},{"line_number":25,"context_line":"failure recovery workflow."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"This solution is imprecise. When management connectivity is down, while"},{"line_number":28,"context_line":"tenant and storage connectivity is still up, it means the instances on the"},{"line_number":29,"context_line":"host can\u0027t be managed by operator but they are still available to end users."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_fa25b00b","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"in_reply_to":"ff570b3c_244a9482","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":55,"context_line":"event broadcast. Consul use gossip protocol to manage membership. If one agent"},{"line_number":56,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Host-monitor periodically retrive all consul members\u0027 heath data from local"},{"line_number":59,"context_line":"consul agents. It picks out every node\u0027 managent, tenant and storage health"},{"line_number":60,"context_line":"state separately, and combine them together."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_072b1282","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":53},"updated":"2020-06-10 07:18:25.000000000","message":"retreives all consul members","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":55,"context_line":"event broadcast. Consul use gossip protocol to manage membership. If one agent"},{"line_number":56,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Host-monitor periodically retrive all consul members\u0027 heath data from local"},{"line_number":59,"context_line":"consul agents. It picks out every node\u0027 managent, tenant and storage health"},{"line_number":60,"context_line":"state separately, and combine them together."},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_ba0cd894","line":58,"range":{"start_line":58,"start_character":26,"end_line":58,"end_character":53},"in_reply_to":"ff570b3c_072b1282","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":56,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Host-monitor periodically retrive all consul members\u0027 heath data from local"},{"line_number":59,"context_line":"consul agents. It picks out every node\u0027 managent, tenant and storage health"},{"line_number":60,"context_line":"state separately, and combine them together."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Then It will do expected actions depend on defined host states, for example"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_0750320a","line":59,"range":{"start_line":59,"start_character":34,"end_line":59,"end_character":49},"updated":"2020-06-10 07:18:25.000000000","message":"nodes management","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":59,"context_line":"consul agents. It picks out every node\u0027 managent, tenant and storage health"},{"line_number":60,"context_line":"state separately, and combine them together."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Then It will do expected actions depend on defined host states, for example"},{"line_number":63,"context_line":"in the following tables:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_c7459a45","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":62},"updated":"2020-06-10 07:18:25.000000000","message":"Then, it will send notification depending on defined host states as listed below in the table:","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":59,"context_line":"consul agents. It picks out every node\u0027 managent, tenant and storage health"},{"line_number":60,"context_line":"state separately, and combine them together."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Then It will do expected actions depend on defined host states, for example"},{"line_number":63,"context_line":"in the following tables:"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_7a77e009","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":62},"in_reply_to":"ff570b3c_c7459a45","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"- Masakari host-monitor driver based on consul"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- tox and/or tempest test suite updates"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- masakari documentation updates"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_2799f6cf","line":142,"range":{"start_line":142,"start_character":13,"end_line":142,"end_character":20},"updated":"2020-06-10 07:18:25.000000000","message":"Are you planning to add a new CI multi node job to run tempest test suite?","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"- Masakari host-monitor driver based on consul"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"- tox and/or tempest test suite updates"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"- masakari documentation updates"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_7a608036","line":142,"range":{"start_line":142,"start_character":13,"end_line":142,"end_character":20},"in_reply_to":"ff570b3c_2799f6cf","updated":"2020-06-12 02:24:57.000000000","message":"A new CI job will be helpful.\nBut no experience with tempest, remove it temporarily.","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Dependencies"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"- requires that consul agents are installed and running to monitor"},{"line_number":150,"context_line":"  the hosts management, tenant and storage connectivity."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_67a3ee01","line":149,"range":{"start_line":149,"start_character":2,"end_line":149,"end_character":3},"updated":"2020-06-10 07:18:25.000000000","message":"nit: R\nUse a capital letter at the start of a sentence.","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":146,"context_line":"Dependencies"},{"line_number":147,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"- requires that consul agents are installed and running to monitor"},{"line_number":150,"context_line":"  the hosts management, tenant and storage connectivity."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_ba8178c6","line":149,"range":{"start_line":149,"start_character":2,"end_line":149,"end_character":3},"in_reply_to":"ff570b3c_67a3ee01","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Testing"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Unit tests are needed."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_07d5d243","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":22},"updated":"2020-06-10 07:18:25.000000000","message":"Unit tests will be needed.","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":152,"context_line":"Testing"},{"line_number":153,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Unit tests are needed."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_9a8474d5","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":22},"in_reply_to":"ff570b3c_07d5d243","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"284fd4583772a07e0dd3593fa73fcd9ede88e938","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Update user documentations."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"References"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_a7c3468a","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":27},"updated":"2020-06-10 07:18:25.000000000","message":"The admin configuration documentation need to be updated.","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"1c48f5a5187a8ca87ceb9a112749918d4359d643","unresolved":false,"context_lines":[{"line_number":157,"context_line":"Documentation Impact"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"Update user documentations."},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"References"},{"line_number":163,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff570b3c_fa6ad018","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":27},"in_reply_to":"ff570b3c_a7c3468a","updated":"2020-06-12 02:24:57.000000000","message":"Done","commit_id":"a52f2965a384d90cfcd59a9fa60a4ce29cdb49f9"}],"specs/xena/approved/host-monitor-by-consul.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":47,"context_line":"compute nodes."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For example, consul cluster via management connectivity."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"All agents bind management interface, and are responsible for running checks"},{"line_number":52,"context_line":"and keeping services in sync."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"244b732e_4e362c44","line":50,"updated":"2021-08-07 13:59:19.000000000","message":"I guess this empty line should not be here as the next sentence is directly relevant to the one above.","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b40c3ec308543c2d6b25c8a61569e3d709078a5e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"compute nodes."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"For example, consul cluster via management connectivity."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"All agents bind management interface, and are responsible for running checks"},{"line_number":52,"context_line":"and keeping services in sync."},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"a2ad04f6_c2c34a8f","line":50,"in_reply_to":"244b732e_4e362c44","updated":"2021-08-14 19:06:00.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Consul is built on top of Serf which provides a full gossip protocol that is"},{"line_number":55,"context_line":"used for multiple purposes. Serf provides membership, failure detection, and"},{"line_number":56,"context_line":"event broadcast. Consul use gossip protocol to manage membership. If one agent"},{"line_number":57,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Host-monitor periodically retreives all consul members heath data from local"}],"source_content_type":"text/x-rst","patch_set":10,"id":"b22c6aeb_359d2f5a","line":56,"range":{"start_line":56,"start_character":24,"end_line":56,"end_character":28},"updated":"2021-08-07 13:59:19.000000000","message":"uses","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Consul is built on top of Serf which provides a full gossip protocol that is"},{"line_number":55,"context_line":"used for multiple purposes. Serf provides membership, failure detection, and"},{"line_number":56,"context_line":"event broadcast. Consul use gossip protocol to manage membership. If one agent"},{"line_number":57,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Host-monitor periodically retreives all consul members heath data from local"}],"source_content_type":"text/x-rst","patch_set":10,"id":"71138441_668742fd","line":56,"range":{"start_line":56,"start_character":24,"end_line":56,"end_character":28},"in_reply_to":"b22c6aeb_359d2f5a","updated":"2021-08-13 10:23:07.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":56,"context_line":"event broadcast. Consul use gossip protocol to manage membership. If one agent"},{"line_number":57,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Host-monitor periodically retreives all consul members heath data from local"},{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3fad2783_b9b781b7","line":59,"range":{"start_line":59,"start_character":26,"end_line":59,"end_character":36},"updated":"2021-08-07 13:59:19.000000000","message":"retrieves","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"event broadcast. Consul use gossip protocol to manage membership. If one agent"},{"line_number":57,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Host-monitor periodically retreives all consul members heath data from local"},{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"a0af9595_121716f1","line":59,"range":{"start_line":59,"start_character":26,"end_line":59,"end_character":36},"in_reply_to":"3fad2783_b9b781b7","updated":"2021-08-13 10:23:07.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":57,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Host-monitor periodically retreives all consul members heath data from local"},{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "}],"source_content_type":"text/x-rst","patch_set":10,"id":"49734677_cf0fa0ea","line":60,"range":{"start_line":60,"start_character":41,"end_line":60,"end_character":49},"updated":"2021-08-07 13:59:19.000000000","message":"management","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"is found disconnected, it will broadcast messages to the cluster quickly."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Host-monitor periodically retreives all consul members heath data from local"},{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "}],"source_content_type":"text/x-rst","patch_set":10,"id":"969b3b47_28662e9a","line":60,"range":{"start_line":60,"start_character":41,"end_line":60,"end_character":49},"in_reply_to":"49734677_cf0fa0ea","updated":"2021-08-13 10:23:07.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":10,"id":"155bbd18_cbb8d854","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":8},"updated":"2021-08-07 13:59:19.000000000","message":"it","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":10,"id":"f10c64f1_1d708cf6","line":63,"range":{"start_line":63,"start_character":79,"end_line":63,"end_character":80},"updated":"2021-08-07 13:59:19.000000000","message":"needless whitespace","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":10,"id":"2d255c12_965c17d9","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":8},"in_reply_to":"155bbd18_cbb8d854","updated":"2021-08-13 10:23:07.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"consul agents. It picks out every nodes\u0027 managent, tenant and storage health"},{"line_number":61,"context_line":"state separately, and combine them together."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":10,"id":"fead111d_2096f493","line":63,"range":{"start_line":63,"start_character":79,"end_line":63,"end_character":80},"in_reply_to":"f10c64f1_1d708cf6","updated":"2021-08-13 10:23:07.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":67,"context_line":"|   management    |     tenant      |      storage    |     actions      |"},{"line_number":68,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":69,"context_line":"|       up        |       up        |       down      |     recovery     |"},{"line_number":70,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":71,"context_line":"|       up        |       down      |       down      |     recovery     |"},{"line_number":72,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":73,"context_line":"|       down      |       up        |       down      |     recovery     |"},{"line_number":74,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":75,"context_line":"|       down      |       down      |       down      |     recovery     |"},{"line_number":76,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* \u0027up\u0027 represents connectivity up."},{"line_number":79,"context_line":"* \u0027down\u0027 represents connectivity down."},{"line_number":80,"context_line":"* \u0027recovery\u0027 represents host recovery."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1aa98d8f_2d745fcd","line":77,"range":{"start_line":66,"start_character":0,"end_line":77,"end_character":0},"updated":"2021-08-07 13:59:19.000000000","message":"I would say the user should be able to decide on the number of networks and the conditions which should trigger the recovery. This table looks like a sane recommendation but should not be set in stone. I see you have already considered this to some extent in the actual implementation, yet not in spec. Please think about it in this even more general way.\n\nAlso, while we are at it, in the implementation you have also \"degrade\" which I must say I don\u0027t really understand the purpose of.","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab5ca10be6ad5ff86d6d78a36fa32798d99b5d54","unresolved":false,"context_lines":[{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":67,"context_line":"|   management    |     tenant      |      storage    |     actions      |"},{"line_number":68,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":69,"context_line":"|       up        |       up        |       down      |     recovery     |"},{"line_number":70,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":71,"context_line":"|       up        |       down      |       down      |     recovery     |"},{"line_number":72,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":73,"context_line":"|       down      |       up        |       down      |     recovery     |"},{"line_number":74,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":75,"context_line":"|       down      |       down      |       down      |     recovery     |"},{"line_number":76,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* \u0027up\u0027 represents connectivity up."},{"line_number":79,"context_line":"* \u0027down\u0027 represents connectivity down."},{"line_number":80,"context_line":"* \u0027recovery\u0027 represents host recovery."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fabd610d_a2e60e6d","line":77,"range":{"start_line":66,"start_character":0,"end_line":77,"end_character":0},"in_reply_to":"00b4c5a7_d4b01ee4","updated":"2021-08-14 19:05:33.000000000","message":"Thanks for updating and thanks for explaining the \"degrade\". It makes sense, though I believe it makes more sense to just call it \"disable\".","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"Then It will send notification depending on defined host states as listed below "},{"line_number":64,"context_line":"in the table:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":67,"context_line":"|   management    |     tenant      |      storage    |     actions      |"},{"line_number":68,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":69,"context_line":"|       up        |       up        |       down      |     recovery     |"},{"line_number":70,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":71,"context_line":"|       up        |       down      |       down      |     recovery     |"},{"line_number":72,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":73,"context_line":"|       down      |       up        |       down      |     recovery     |"},{"line_number":74,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":75,"context_line":"|       down      |       down      |       down      |     recovery     |"},{"line_number":76,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"* \u0027up\u0027 represents connectivity up."},{"line_number":79,"context_line":"* \u0027down\u0027 represents connectivity down."},{"line_number":80,"context_line":"* \u0027recovery\u0027 represents host recovery."}],"source_content_type":"text/x-rst","patch_set":10,"id":"00b4c5a7_d4b01ee4","line":77,"range":{"start_line":66,"start_character":0,"end_line":77,"end_character":0},"in_reply_to":"1aa98d8f_2d745fcd","updated":"2021-08-13 10:23:07.000000000","message":"I update the description about the HA strategy.\n\nThe \"degrade\" is a feature of our own cloud. For example, if the tenant connectivity is down but storage connectivity is up, it will disable the compute node instead of host failure recovery, so that instances will not evacuate to other nodes and other instances will not be scheduled to this node. I will introduce it at the right time in future.","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a5659c414435862b3ab17f531b98f2fbf0c8598d","unresolved":true,"context_lines":[{"line_number":151,"context_line":"Testing"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Unit tests will be needed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Documentation Impact"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dbcb723a_db05fc2f","line":154,"updated":"2021-08-07 13:59:19.000000000","message":"Hopefully, we can also get some functional tests to cover the consul integration.","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"ec802295e6630915ecd4916b0efb4671f63c1f3b","unresolved":false,"context_lines":[{"line_number":151,"context_line":"Testing"},{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"Unit tests will be needed."},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Documentation Impact"},{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":10,"id":"a42f3f42_470ae7d0","line":154,"in_reply_to":"dbcb723a_db05fc2f","updated":"2021-08-13 10:23:07.000000000","message":"Done","commit_id":"53a7c7273c8ff8f66c3753c3b0fabb6a9744ba67"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab5ca10be6ad5ff86d6d78a36fa32798d99b5d54","unresolved":true,"context_lines":[{"line_number":59,"context_line":"consul agents. It picks out every nodes\u0027 management, tenant and storage health"},{"line_number":60,"context_line":"state separately, and combines them together. Then it will send notification"},{"line_number":61,"context_line":"depending on the HA strategy - host states and the corresponding actions."},{"line_number":62,"context_line":"There will be an config file for user to decide the HA strategy and the"},{"line_number":63,"context_line":"default HA strategy shows as follows:"},{"line_number":64,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":65,"context_line":"|   management    |     tenant      |      storage    |     actions      |"}],"source_content_type":"text/x-rst","patch_set":11,"id":"b9122c8d_bf93714b","line":62,"range":{"start_line":62,"start_character":14,"end_line":62,"end_character":17},"updated":"2021-08-14 19:05:33.000000000","message":"nit: a","commit_id":"48dbaff5e283e53e9a213a509446fb629b28870c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab5ca10be6ad5ff86d6d78a36fa32798d99b5d54","unresolved":true,"context_lines":[{"line_number":60,"context_line":"state separately, and combines them together. Then it will send notification"},{"line_number":61,"context_line":"depending on the HA strategy - host states and the corresponding actions."},{"line_number":62,"context_line":"There will be an config file for user to decide the HA strategy and the"},{"line_number":63,"context_line":"default HA strategy shows as follows:"},{"line_number":64,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":65,"context_line":"|   management    |     tenant      |      storage    |     actions      |"},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"0627a278_92fa5515","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":26},"updated":"2021-08-14 19:05:33.000000000","message":"nit: is","commit_id":"48dbaff5e283e53e9a213a509446fb629b28870c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d3acef8a3de6e7dd1a1caf218cd896511c66b59b","unresolved":true,"context_lines":[{"line_number":61,"context_line":"depending on the HA strategy - host states and the corresponding actions."},{"line_number":62,"context_line":"There will be an config file for user to decide the HA strategy and the"},{"line_number":63,"context_line":"default HA strategy shows as follows:"},{"line_number":64,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":65,"context_line":"|   management    |     tenant      |      storage    |     actions      |"},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":67,"context_line":"|       up        |       up        |       down      |     recovery     |"}],"source_content_type":"text/x-rst","patch_set":11,"id":"e338c16d_f31deb16","line":64,"updated":"2021-08-14 19:13:44.000000000","message":"need an empty line before the table","commit_id":"48dbaff5e283e53e9a213a509446fb629b28870c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab5ca10be6ad5ff86d6d78a36fa32798d99b5d54","unresolved":true,"context_lines":[{"line_number":64,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":65,"context_line":"|   management    |     tenant      |      storage    |     actions      |"},{"line_number":66,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":67,"context_line":"|       up        |       up        |       down      |     recovery     |"},{"line_number":68,"context_line":"+-----------------+-----------------+-----------------+------------------+"},{"line_number":69,"context_line":"|       up        |       down      |       down      |     recovery     |"},{"line_number":70,"context_line":"+-----------------+-----------------+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ac6f45bb_3358e6e0","line":67,"range":{"start_line":67,"start_character":60,"end_line":67,"end_character":73},"updated":"2021-08-14 19:05:33.000000000","message":"I missed this last time but I think we should call it using a verb (as it\u0027s an action) and the action is to \"evacuate\". \"Recovery\" sounds like something good.","commit_id":"48dbaff5e283e53e9a213a509446fb629b28870c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d3acef8a3de6e7dd1a1caf218cd896511c66b59b","unresolved":true,"context_lines":[{"line_number":79,"context_line":"User can define the HA strategy according to the physical environment."},{"line_number":80,"context_line":"For example, if there is only one consul cluster of management, the HA"},{"line_number":81,"context_line":"strategy would be the same as the existing solution based on pacemaker."},{"line_number":82,"context_line":"+-----------------+------------------+"},{"line_number":83,"context_line":"|   management    |     actions      |"},{"line_number":84,"context_line":"+-----------------+------------------+"},{"line_number":85,"context_line":"|       up        |     null         |"}],"source_content_type":"text/x-rst","patch_set":11,"id":"65fa1e8c_893117c8","line":82,"updated":"2021-08-14 19:13:44.000000000","message":"need an empty line before the table","commit_id":"48dbaff5e283e53e9a213a509446fb629b28870c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ab5ca10be6ad5ff86d6d78a36fa32798d99b5d54","unresolved":true,"context_lines":[{"line_number":82,"context_line":"+-----------------+------------------+"},{"line_number":83,"context_line":"|   management    |     actions      |"},{"line_number":84,"context_line":"+-----------------+------------------+"},{"line_number":85,"context_line":"|       up        |     null         |"},{"line_number":86,"context_line":"+-----------------+------------------+"},{"line_number":87,"context_line":"|       down      |     recovery     |"},{"line_number":88,"context_line":"+-----------------+------------------+"}],"source_content_type":"text/x-rst","patch_set":11,"id":"789af8f4_ea893e19","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":38},"updated":"2021-08-14 19:05:33.000000000","message":"I think then the user would not be providing this line as there is no action to take.","commit_id":"48dbaff5e283e53e9a213a509446fb629b28870c"}]}