)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"15cecfc1a09f2bec7b8bf5744104efb4ee1a77db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7030f2d4_7f19515a","updated":"2026-10-09 02:53:58.000000000","message":"Thanks for the eventlet removal support.","commit_id":"e419321aecf9638eeb1447696739481bb8f29519"},{"author":{"_account_id":38176,"name":"Sei Sano","display_name":"say3no","email":"sei.sano@ntt.com","username":"say3no"},"change_message_id":"bce2a884875c03a650ca0713f508896aec6099cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"84541e76_2a2eab08","updated":"2026-10-09 04:02:01.000000000","message":"Thanks for working on this, the eventlet removal direction looks good\nto me. One request and a few follow-ups.\n\nRequest:\nThe release note currently lists only [DEFAULT] use_forwarded_for, but\nthis also removes [wsgi] secure_proxy_ssl_header. Unlike the other\n[wsgi] options, both of these used to take effect under uwsgi too\n(secure_proxy_ssl_header via masakari.api.wsgi.Request, and\nuse_forwarded_for in the auth middleware), so the removal silently\nchanges behavior for deployments behind an SSL-terminating proxy.\nSince oslo.config ignores unknown options, nothing will fail loudly.\nCould you add secure_proxy_ssl_header to the upgrade note and mention\nthat operators should rely on the http_proxy_to_wsgi middleware\n(already in the default api-paste.ini) instead?\n\nFollow-ups (fine in separate changes):\n- The standalone-only [wsgi] options (wsgi_log_format, ssl_ca_file,\n  ssl_cert_file, ssl_key_file, tcp_keepidle, default_pool_size,\n  max_header_line, keep_alive, client_socket_timeout) could also be\n  listed in the note for completeness.\n- [DEFAULT] use_ssl, masakari_api_listen, masakari_api_listen_port and\n  masakari_api_workers are no longer consumed by anything. We should\n  deprecate them, and drop the corresponding iniset in\n  devstack/plugin.sh.\n- README.rst still says \"To run masakari-api simply use following\n  binary: masakari-api\", and the install guide sets\n  masakari_api_workers. Both need an update.\n- The M322 message in masakari/hacking/checks.py and HACKING.rst still\n  points to masakari.utils.spawn(), which no longer exists.\n- The docstring in masakari/api/openstack/common.py refers to\n  masakari.api.wsgi.Request.","commit_id":"e419321aecf9638eeb1447696739481bb8f29519"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f4473842e0291304c7aecaff90402fafb0300854","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a5c3586_a19dafcf","in_reply_to":"84541e76_2a2eab08","updated":"2026-10-13 04:36:55.000000000","message":"I think I addressed most of the comments. Leaving a few notes.\n\n\u003e Could you add secure_proxy_ssl_header to the upgrade note and mention that operators should rely on the http_proxy_to_wsgi middleware (already in the default api-paste.ini) instead?\n\nI find it redundant because we already added the same note there when we deprecated the option.\n\n\u003e The M322 message in masakari/hacking/checks.py and HACKING.rst still points to masakari.utils.spawn(), which no longer exists.\n\nI\u0027ll leave it now until we eventually remove eventlet. If we (by any change) have to add spawn then we should re-add spawn IMHO.","commit_id":"e419321aecf9638eeb1447696739481bb8f29519"}]}