)]}'
{"masakari/api/openstack/ha/versions.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"12e6c57115bbd3b0ba516603811571eafedbc420","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    \"v1.0\": {"},{"line_number":34,"context_line":"        \"id\": \"v1.0\","},{"line_number":35,"context_line":"        \"status\": \"CURRENT\","},{"line_number":36,"context_line":"        \"version\": \"1.1\","},{"line_number":37,"context_line":"        \"min_version\": \"1.0\","},{"line_number":38,"context_line":"        \"updated\": \"2016-07-01T11:33:21Z\","},{"line_number":39,"context_line":"        \"links\": ["}],"source_content_type":"text/x-python","patch_set":4,"id":"cc2c849d_74c1532d","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":23},"updated":"2021-03-11 20:49:41.000000000","message":"this should probably reuse the same var that controls the max api version","commit_id":"d091b9c6c5ebb5c829e0abf4342262357221969d"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"400ac3584a765547131240f689ae585b13d88430","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    \"v1.0\": {"},{"line_number":34,"context_line":"        \"id\": \"v1.0\","},{"line_number":35,"context_line":"        \"status\": \"CURRENT\","},{"line_number":36,"context_line":"        \"version\": \"1.1\","},{"line_number":37,"context_line":"        \"min_version\": \"1.0\","},{"line_number":38,"context_line":"        \"updated\": \"2016-07-01T11:33:21Z\","},{"line_number":39,"context_line":"        \"links\": ["}],"source_content_type":"text/x-python","patch_set":4,"id":"08c3a45e_4e8063d7","line":36,"range":{"start_line":36,"start_character":20,"end_line":36,"end_character":23},"in_reply_to":"cc2c849d_74c1532d","updated":"2021-03-15 01:28:23.000000000","message":"It has shifted to 1.2 because of feature \u0027enable-to-segment\u0027.","commit_id":"d091b9c6c5ebb5c829e0abf4342262357221969d"}],"masakari/api/openstack/ha/versionsV1.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"353ca44df1bc1384f3b369f2db81b02c794655e6","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class VersionsController(wsgi.Controller):"},{"line_number":29,"context_line":"    @extensions.expected_errors(http_client.NOT_FOUND)"},{"line_number":30,"context_line":"    def show(self, req, id\u003d\u0027v1.0\u0027):"},{"line_number":31,"context_line":"        builder \u003d views_versions.get_view_builder(req)"},{"line_number":32,"context_line":"        if id not in versions.VERSIONS:"},{"line_number":33,"context_line":"            raise webob.exc.HTTPNotFound()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_60005803","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":32},"updated":"2020-06-04 06:26:20.000000000","message":"I can see it returns version response for following two cases:-\n\n1. http://\u003cipaddress\u003e/instance-ha/v1/ - This is the real problem you have fixed in this patch.\n2. http://\u003cipaddress\u003e/instance-ha\n\nBut IMO, it should also return version response for below case:\n\nhttp://\u003cipaddress\u003e/instance-ha/v1\n\nAnother point I have noticed is, the version information in the response should include major version 1.1.\n\ni.e. it should include \n\"version\": \"1.1\", \"min_version\": \"1.0\"","commit_id":"01ca5e83087f3a93f771eae8f5a32b7eb49ca141"}]}