)]}'
{"masakari/tests/unit/engine/drivers/taskflow/test_taskflow_driver.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"9e5dd817e69c7ca244eb3a823a34adbe13834d52","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        mock_get_flows_for_book.assert_called_once()"},{"line_number":439,"context_line":"        mock_get_atoms_for_flow.assert_called_once()"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.assertItemsEqual(expected_result[0], progress_details[0])"},{"line_number":442,"context_line":"        self.assertItemsEqual(expected_result[1], progress_details[1])"},{"line_number":443,"context_line":"        self.assertRaises(IndexError, lambda: progress_details[2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e2bcc607","line":442,"range":{"start_line":441,"start_character":8,"end_line":442,"end_character":70},"updated":"2019-08-27 03:57:00.000000000","message":"I think it\u0027s possible to assert using self.assertItemsEqual(expected_result, progress_details)","commit_id":"d58215d1c729b4e906bc69f9c858cf65d6f488ca"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"88d44acccbf196ca0b3cbdab9c0e57222f1757e0","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        mock_get_flows_for_book.assert_called_once()"},{"line_number":439,"context_line":"        mock_get_atoms_for_flow.assert_called_once()"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.assertItemsEqual(expected_result[0], progress_details[0])"},{"line_number":442,"context_line":"        self.assertItemsEqual(expected_result[1], progress_details[1])"},{"line_number":443,"context_line":"        self.assertRaises(IndexError, lambda: progress_details[2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_982222a3","line":442,"range":{"start_line":441,"start_character":8,"end_line":442,"end_character":70},"in_reply_to":"7faddb67_e2bcc607","updated":"2019-08-27 10:42:45.000000000","message":"Done, added assertObjEqual() and assertObjectList() methods in common place at \u0027masakari/test.py\u0027","commit_id":"d58215d1c729b4e906bc69f9c858cf65d6f488ca"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"9e5dd817e69c7ca244eb3a823a34adbe13834d52","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        mock_get_atoms_for_flow.assert_called_once()"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.assertItemsEqual(expected_result[0], progress_details[0])"},{"line_number":442,"context_line":"        self.assertItemsEqual(expected_result[1], progress_details[1])"},{"line_number":443,"context_line":"        self.assertRaises(IndexError, lambda: progress_details[2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_a2348ead","line":443,"range":{"start_line":442,"start_character":70,"end_line":443,"end_character":66},"updated":"2019-08-27 03:57:00.000000000","message":"No need to assert here as it would be taken into account in the above assert.","commit_id":"d58215d1c729b4e906bc69f9c858cf65d6f488ca"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"88d44acccbf196ca0b3cbdab9c0e57222f1757e0","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        mock_get_atoms_for_flow.assert_called_once()"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"        self.assertItemsEqual(expected_result[0], progress_details[0])"},{"line_number":442,"context_line":"        self.assertItemsEqual(expected_result[1], progress_details[1])"},{"line_number":443,"context_line":"        self.assertRaises(IndexError, lambda: progress_details[2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_f83236f2","line":443,"range":{"start_line":442,"start_character":70,"end_line":443,"end_character":66},"in_reply_to":"7faddb67_a2348ead","updated":"2019-08-27 10:42:45.000000000","message":"Keeping here to indicate will raise error if accessed running task.","commit_id":"d58215d1c729b4e906bc69f9c858cf65d6f488ca"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"5c12c6bb233aff21d1c838cd086f68ec318abef6","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        mock_get_atoms_for_flow.assert_called_once()"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        self.assertObjectList(expected_result, progress_details)"},{"line_number":440,"context_line":"        # Since \u0027StartInstanceTask\u0027 is in \u0027RUNNING\u0027 state, progress_details"},{"line_number":441,"context_line":"        # will be empty and will raise error if accessed."},{"line_number":442,"context_line":"        self.assertRaises(IndexError, lambda: progress_details[2])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9960d6a6","line":442,"range":{"start_line":440,"start_character":8,"end_line":442,"end_character":66},"updated":"2019-08-28 00:58:07.000000000","message":"In assertObjectList method, you are already checking len of expected_result and progress_details, so I  don\u0027t think you need to assert for StartInstanceTask separately.","commit_id":"394922e01a1d71568771e98463dbf4fbe17504e2"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"a7a533eded231670c4f2b5b466a35ec72b531457","unresolved":false,"context_lines":[{"line_number":437,"context_line":"        mock_get_atoms_for_flow.assert_called_once()"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        self.assertObjectList(expected_result, progress_details)"},{"line_number":440,"context_line":"        # Since \u0027StartInstanceTask\u0027 is in \u0027RUNNING\u0027 state, progress_details"},{"line_number":441,"context_line":"        # will be empty and will raise error if accessed."},{"line_number":442,"context_line":"        self.assertRaises(IndexError, lambda: progress_details[2])"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_722baf32","line":442,"range":{"start_line":440,"start_character":8,"end_line":442,"end_character":66},"in_reply_to":"7faddb67_9960d6a6","updated":"2019-08-28 06:28:45.000000000","message":"Understood, removed as suggested.","commit_id":"394922e01a1d71568771e98463dbf4fbe17504e2"}]}