)]}'
{"masakari/compute/nova.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"7c293214e1f5eda7a3caf9b7e72ea540e69f0c36","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        LOG.info(msg, {\u0027hypervisor_name\u0027: hypervisor_name})"},{"line_number":254,"context_line":"        try:"},{"line_number":255,"context_line":"            hypervisors_list \u003d nova.hypervisors.search(hypervisor_name)"},{"line_number":256,"context_line":"            if hypervisor_name not in [h"},{"line_number":257,"context_line":"                                       for host in hypervisors_list"},{"line_number":258,"context_line":"                                       for h in ("},{"line_number":259,"context_line":"                                           host.hypervisor_hostname,"},{"line_number":260,"context_line":"                                           host.hypervisor_hostname.split("},{"line_number":261,"context_line":"                                               \u0027.\u0027)[0])"},{"line_number":262,"context_line":"                                       ]:"},{"line_number":263,"context_line":"                raise exception.HypervisorNotFoundByName("},{"line_number":264,"context_line":"                    hypervisor_name\u003dhypervisor_name)"},{"line_number":265,"context_line":"        except nova_exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_913a2232","line":262,"range":{"start_line":256,"start_character":39,"end_line":262,"end_character":41},"updated":"2019-10-03 04:15:38.000000000","message":"When an operator will add a host to a segment, hostname can be  a FQDN or just hostname, for example, juju-f4bd71-zaza-9db566d782a2-18.project.serverstack or juju-f4bd71-zaza-9db566d782a2-18.\n\nIf it\u0027s a FQDN i.e. juju-f4bd71-zaza-9db566d782a2-18.project.serverstack, it will pass the validation becoz of your changes, but when it will be stored in the masakari \u0027host\u0027 db table in \u0027name\u0027 column\u0027 it will be stored as \"juju-f4bd71-zaza-9db566d782a2-18.project.serverstack\" only. \n\nSo now, it will expect masakari-monitor to send notification with \u0027host_name\u0027 parameter as \"juju-f4bd71-zaza-9db566d782a2-18.project.serverstack\" only instead of \"juju-f4bd71-zaza-9db566d782a2-18\". If it\u0027s uses hostname i..e , \"juju-f4bd71-zaza-9db566d782a2-18\", notifications will not be processed.\n\nBut I assume when operator will configure pacemaker and add nodes to it, it will alway be hostname and not FQDN. so in real production, it will always work.\n\nCan you please confirm if my assumption is correct?","commit_id":"161f0a4c569e562858d970cbe749d488b943fbd5"}]}