)]}'
{"masakari/engine/drivers/taskflow/host_failure.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"c766adefb742f9e2b8b8cb2812106210de8a8ea3","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            if (new_vm_state \u003d\u003d \u0027error\u0027 and"},{"line_number":205,"context_line":"                    new_vm_state !\u003d old_vm_state):"},{"line_number":206,"context_line":"                msg \u003d (\"Error to evacuate instance %(instance)s.\") % {"},{"line_number":207,"context_line":"                    \u0027instance\u0027: instance.id"},{"line_number":208,"context_line":"                }"},{"line_number":209,"context_line":"                raise exception.InstanceEvacuateError(message\u003dmsg)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_c9f1c497","line":207,"range":{"start_line":206,"start_character":24,"end_line":207,"end_character":30},"updated":"2020-05-18 08:53:27.000000000","message":"How about adding fault.message and/or fault.details information in the error message?\n\nYou can get the fault information from novaclient.get_server.\n\nSomething like \n\nFailed to evacuate instance %(instance)s. Reason: %(fault_message)s.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c02430aad728cb511e82c5d566444d424da83560","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"            if (new_vm_state \u003d\u003d \u0027error\u0027 and"},{"line_number":205,"context_line":"                    new_vm_state !\u003d old_vm_state):"},{"line_number":206,"context_line":"                msg \u003d (\"Error to evacuate instance %(instance)s.\") % {"},{"line_number":207,"context_line":"                    \u0027instance\u0027: instance.id"},{"line_number":208,"context_line":"                }"},{"line_number":209,"context_line":"                raise exception.InstanceEvacuateError(message\u003dmsg)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_89e4e9e1","line":207,"range":{"start_line":206,"start_character":24,"end_line":207,"end_character":30},"in_reply_to":"ff570b3c_c9f1c497","updated":"2020-05-18 10:12:00.000000000","message":"I think there is no need to add detail failed information. Because the fault information from novaclient.get_server is not enough clear.\nIf instance evacuates failed, it needs to investigate from various perspectives to comprehensively analyze.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"}],"masakari/exception.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"c766adefb742f9e2b8b8cb2812106210de8a8ea3","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                \"\u0027%(segment_uuid)s\u0027 could not be found.\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"class InstanceEvacuateError(MasakariException):"},{"line_number":371,"context_line":"    msg_fmt \u003d _(\"Error when evacuating instance.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a943b0ae","line":370,"range":{"start_line":370,"start_character":6,"end_line":370,"end_character":27},"updated":"2020-05-18 08:53:27.000000000","message":"Rename it to InstanceEvacuationFailed.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c02430aad728cb511e82c5d566444d424da83560","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                \"\u0027%(segment_uuid)s\u0027 could not be found.\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"class InstanceEvacuateError(MasakariException):"},{"line_number":371,"context_line":"    msg_fmt \u003d _(\"Error when evacuating instance.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_c9db81ea","line":370,"range":{"start_line":370,"start_character":6,"end_line":370,"end_character":27},"in_reply_to":"ff570b3c_a943b0ae","updated":"2020-05-18 10:12:00.000000000","message":"Naming difference. I think both is OK.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"}],"masakari/tests/unit/engine/drivers/taskflow/test_host_failure_flow.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"c766adefb742f9e2b8b8cb2812106210de8a8ea3","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":159,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":160,"context_line":"        ]"},{"line_number":161,"context_line":"        task._evacuate_and_confirm(self.ctxt, fake_instance,"},{"line_number":162,"context_line":"                                   self.instance_host,"},{"line_number":163,"context_line":"                                   failed_evacuation_instances)"},{"line_number":164,"context_line":"        self.assertIn(fake_instance.id, failed_evacuation_instances)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_44fe396b","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":34},"updated":"2020-05-18 08:53:27.000000000","message":"This unit test is not invoking the code changes you have made in method _wait_for_evacuation_confirmation.\n\nIt\u0027s raising oslo_config.cfg.NotInitializedError exception when _get_state_and_host_of_instance method is called from  _wait_for_evacuation_confirmation. Please check and fix this unit test.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"9c088e45f9e34828aae099b6858317164d8f98de","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":159,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":160,"context_line":"        ]"},{"line_number":161,"context_line":"        task._evacuate_and_confirm(self.ctxt, fake_instance,"},{"line_number":162,"context_line":"                                   self.instance_host,"},{"line_number":163,"context_line":"                                   failed_evacuation_instances)"},{"line_number":164,"context_line":"        self.assertIn(fake_instance.id, failed_evacuation_instances)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_47922d5a","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":34},"in_reply_to":"ff570b3c_091f39b7","updated":"2020-06-10 01:12:54.000000000","message":"I have uploaded a new PS 5 in which I have the solved the above mentioned unit test issue and also asserted on the warning message that you are logging in case the instance fails during evacuation.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"c02430aad728cb511e82c5d566444d424da83560","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":159,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":160,"context_line":"        ]"},{"line_number":161,"context_line":"        task._evacuate_and_confirm(self.ctxt, fake_instance,"},{"line_number":162,"context_line":"                                   self.instance_host,"},{"line_number":163,"context_line":"                                   failed_evacuation_instances)"},{"line_number":164,"context_line":"        self.assertIn(fake_instance.id, failed_evacuation_instances)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_091f39b7","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":34},"in_reply_to":"ff570b3c_44fe396b","updated":"2020-05-18 10:12:00.000000000","message":"_wait_for_evacuation_confirmation is one inner function of _evacuate_and_confirm. It can\u0027t use _wait_for_evacuation_confirmation in this unit test.\nMoreover, this unit has tested the added logic process, although it doesn\u0027t directly invoking the function _wait_for_evacuation_confirmation.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"376822c3f2f9b7634242c556849c184493f92d69","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":159,"context_line":"            get_fake_server(fake_instance, \u0027error\u0027),"},{"line_number":160,"context_line":"        ]"},{"line_number":161,"context_line":"        task._evacuate_and_confirm(self.ctxt, fake_instance,"},{"line_number":162,"context_line":"                                   self.instance_host,"},{"line_number":163,"context_line":"                                   failed_evacuation_instances)"},{"line_number":164,"context_line":"        self.assertIn(fake_instance.id, failed_evacuation_instances)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_02b4a3f1","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":34},"in_reply_to":"ff570b3c_47922d5a","updated":"2020-06-10 03:01:40.000000000","message":"LGTM.thanks.","commit_id":"d5d4cc3c55f12a41a957949db1d3f32680bd7e2e"}]}