)]}'
{"masakari/ha/api.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"5476dcd0628ddef27056628d47e7d03250702f23","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_segment(self, context, segment_uuid):"},{"line_number":51,"context_line":"        \"\"\"Get a single failover segment with the given segment_uuid.\"\"\""},{"line_number":52,"context_line":"        if uuidutils.is_uuid_like(segment_uuid):"},{"line_number":53,"context_line":"            LOG.debug(\"Fetching failover segment by uuid %s\", segment_uuid)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            segment \u003d objects.FailoverSegment.get_by_uuid(context, segment_uuid"},{"line_number":56,"context_line":"                                                          )"},{"line_number":57,"context_line":"        else:"},{"line_number":58,"context_line":"            LOG.debug(\"Failed to fetch failover \""},{"line_number":59,"context_line":"                      \"segment by uuid %s\", segment_uuid)"},{"line_number":60,"context_line":"            raise exception.FailoverSegmentNotFound(id\u003dsegment_uuid)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        return segment"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_all(self, context, filters\u003dNone, sort_keys\u003dNone,"},{"line_number":65,"context_line":"                sort_dirs\u003dNone, limit\u003dNone, marker\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_752f42f6","line":62,"range":{"start_line":52,"start_character":8,"end_line":62,"end_character":22},"updated":"2020-03-23 06:13:52.000000000","message":"Agree, there is an issue. But I don\u0027t think there is any need of debug log message here as it\u0027s pretty evident from the exception.\n\nSince you have making changes here, I would suggest to rearrange code as below:-\n\nif not uuidutils.is_uuid_like(segment_uuid):\n    raise exception.FailoverSegmentNotFound(id\u003dsegment_uuid)\n\nreturn objects.FailoverSegment.get_by_uuid(context, segment_uuid)","commit_id":"7161cc928396d1131c61308410d525ebf1f8f6d5"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"5476dcd0628ddef27056628d47e7d03250702f23","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def get_host(self, context, segment_uuid, host_uuid):"},{"line_number":156,"context_line":"        \"\"\"Get a host by id\"\"\""},{"line_number":157,"context_line":"        objects.FailoverSegment.get_by_uuid(context, segment_uuid)"},{"line_number":158,"context_line":"        if uuidutils.is_uuid_like(host_uuid):"},{"line_number":159,"context_line":"            LOG.debug(\"Fetching host by uuid %s\", host_uuid)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            host \u003d objects.Host.get_by_uuid(context, host_uuid)"},{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            LOG.debug(\"Failed to fetch host by uuid %s\", host_uuid)"},{"line_number":164,"context_line":"            raise exception.HostNotFound(id\u003dhost_uuid)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return host"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_d50d6e91","line":164,"range":{"start_line":158,"start_character":1,"end_line":164,"end_character":54},"updated":"2020-03-23 06:13:52.000000000","message":"Since you have making changes here, I would suggest to rearrange code as below:-\n\n\nif not uuidutils.is_uuid_like(host_uuid):\n    raise exception.HostNotFound(id\u003dhost_uuid)\n\nreturn objects.Host.get_by_uuid(context, host_uuid)","commit_id":"7161cc928396d1131c61308410d525ebf1f8f6d5"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"5476dcd0628ddef27056628d47e7d03250702f23","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def get_notification(self, context, notification_uuid):"},{"line_number":362,"context_line":"        \"\"\"Get a single notification with the given notification_uuid.\"\"\""},{"line_number":363,"context_line":"        if uuidutils.is_uuid_like(notification_uuid):"},{"line_number":364,"context_line":"            LOG.debug(\"Fetching notification by uuid %s\", notification_uuid)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"            notification \u003d objects.Notification.get_by_uuid(context,"},{"line_number":367,"context_line":"                                                            notification_uuid)"},{"line_number":368,"context_line":"        else:"},{"line_number":369,"context_line":"            LOG.debug(\"Failed to fetch notification by uuid %s\","},{"line_number":370,"context_line":"                      notification_uuid)"},{"line_number":371,"context_line":"            raise exception.NotificationNotFound(id\u003dnotification_uuid)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        return notification"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_1527d614","line":371,"range":{"start_line":363,"start_character":8,"end_line":371,"end_character":70},"updated":"2020-03-23 06:13:52.000000000","message":"Since you have making changes here, I would suggest to rearrange code as below:-\n\n\nif not uuidutils.is_uuid_like(notification_uuid):\n    raise exception.NotificationNotFound(id\u003dnotification_uuid)\n\nreturn objects.Notification.get_by_uuid(context, notification_uuid)","commit_id":"7161cc928396d1131c61308410d525ebf1f8f6d5"}]}