)]}'
{"masakari/service.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"17c45608fe46ec773bbf0cf1970a3df7a679a5fb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"CONF \u003d masakari.conf.CONF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def assert_eventlet_uses_monotonic_clock():"},{"line_number":45,"context_line":"    import eventlet.hubs as hubs"},{"line_number":46,"context_line":"    import monotonic"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    hub \u003d hubs.get_hub()"},{"line_number":49,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":50,"context_line":"        raise RuntimeError("},{"line_number":51,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":52,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_fc44bc1d","side":"PARENT","line":52,"range":{"start_line":44,"start_character":0,"end_line":52,"end_character":72},"updated":"2020-05-05 10:17:12.000000000","message":"eventlet still pull monotonic for it\u0027s own usages [1] so I\u0027m not sure we can drop this part... I don\u0027t seen usages of time.monotonic on eventlet [2] so maybe we should keep this part.\n\nThoughts?\n\n[1] https://github.com/eventlet/eventlet/blob/master/setup.py#L21\n[2] https://github.com/eventlet/eventlet/search?q\u003dmonotonic\u0026unscoped_q\u003dmonotonic","commit_id":"596b3d142eeea935fb2293de5631cd9dd4c191c6"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"e99faad0c184204b6cb92504c52fb6c03b3b315c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"CONF \u003d masakari.conf.CONF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def assert_eventlet_uses_monotonic_clock():"},{"line_number":45,"context_line":"    import eventlet.hubs as hubs"},{"line_number":46,"context_line":"    import monotonic"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    hub \u003d hubs.get_hub()"},{"line_number":49,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":50,"context_line":"        raise RuntimeError("},{"line_number":51,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":52,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0399c2c2","side":"PARENT","line":52,"range":{"start_line":44,"start_character":0,"end_line":52,"end_character":72},"in_reply_to":"1f493fa4_2d79d02e","updated":"2020-05-19 03:04:03.000000000","message":"I don\u0027t see any concern here as in python3.3 and newer, the default clock set in the eventlet/hub/hubs.py-\u003eBaseHub will always be of type monotonic.monotonic.\n\nSo there is no need for explicit assert statement here as we are supporting py36 and above.","commit_id":"596b3d142eeea935fb2293de5631cd9dd4c191c6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"27779b7e5db6f15968a86de7bec1e66e2220d29f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"CONF \u003d masakari.conf.CONF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def assert_eventlet_uses_monotonic_clock():"},{"line_number":45,"context_line":"    import eventlet.hubs as hubs"},{"line_number":46,"context_line":"    import monotonic"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    hub \u003d hubs.get_hub()"},{"line_number":49,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":50,"context_line":"        raise RuntimeError("},{"line_number":51,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":52,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_2d79d02e","side":"PARENT","line":52,"range":{"start_line":44,"start_character":0,"end_line":52,"end_character":72},"in_reply_to":"1f493fa4_fc44bc1d","updated":"2020-05-05 13:32:22.000000000","message":"What is the concern with this?","commit_id":"596b3d142eeea935fb2293de5631cd9dd4c191c6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"91119aee819dd01be6dcdb2a6919c0946125b96c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"CONF \u003d masakari.conf.CONF"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def assert_eventlet_uses_monotonic_clock():"},{"line_number":45,"context_line":"    import eventlet.hubs as hubs"},{"line_number":46,"context_line":"    import monotonic"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    hub \u003d hubs.get_hub()"},{"line_number":49,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":50,"context_line":"        raise RuntimeError("},{"line_number":51,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":52,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_7240bf36","side":"PARENT","line":52,"range":{"start_line":44,"start_character":0,"end_line":52,"end_character":72},"in_reply_to":"ff570b3c_0399c2c2","updated":"2020-06-17 15:16:11.000000000","message":"Sorry for my late response on it, so yes I think you are right, we can continue with these changes.","commit_id":"596b3d142eeea935fb2293de5631cd9dd4c191c6"}]}