)]}'
{"masakari/api/openstack/ha/views/hosts.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2019 NTT Data"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b3650548","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2020-05-18 04:10:35.000000000","message":"2020","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"4ccf8c1cea68ad435a6fc110ddf5e425b21ce0e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2019 NTT Data"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_21e329db","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"in_reply_to":"ff570b3c_b3650548","updated":"2020-05-18 17:40:25.000000000","message":"Done","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"}],"masakari/notifications/objects/notification.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    # Version 1.0: Initial version"},{"line_number":76,"context_line":"    # Version 1.1: Removed \u0027failover_segment_id\u0027 parameter"},{"line_number":77,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":78,"context_line":"    fields \u003d {"},{"line_number":79,"context_line":"        \u0027id\u0027: fields.IntegerField(),"},{"line_number":80,"context_line":"        \u0027uuid\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_13300d9f","line":77,"range":{"start_line":77,"start_character":15,"end_line":77,"end_character":19},"updated":"2020-05-18 04:10:35.000000000","message":"You should update notification docs to reflect this change.","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"d54fe8a201745b7bbd65a7025775e136d9ae251f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    }"},{"line_number":75,"context_line":"    # Version 1.0: Initial version"},{"line_number":76,"context_line":"    # Version 1.1: Removed \u0027failover_segment_id\u0027 parameter"},{"line_number":77,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":78,"context_line":"    fields \u003d {"},{"line_number":79,"context_line":"        \u0027id\u0027: fields.IntegerField(),"},{"line_number":80,"context_line":"        \u0027uuid\u0027: fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_81ce752a","line":77,"range":{"start_line":77,"start_character":15,"end_line":77,"end_character":19},"in_reply_to":"ff570b3c_13300d9f","updated":"2020-05-18 17:41:45.000000000","message":"updated \u0027doc/notification_samples/create-host-start.json\u0027","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"}],"masakari/tests/unit/api/openstack/ha/test_hosts.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        _make_host_obj(a) for a in hosts_list])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"FAILOVER_SEGMENT \u003d {\"name\": \"segment1\", \"id\": \"1\","},{"line_number":52,"context_line":"                    \"service_type\": \"COMPUTE\", \"recovery_method\": \"auto\","},{"line_number":53,"context_line":"                    \"uuid\": uuidsentinel.fake_segment1,"},{"line_number":54,"context_line":"                    \"description\": \"failover_segment for compute\"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_53b445f2","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":16},"updated":"2020-05-18 04:10:35.000000000","message":"Instead of duplicating the test data, let\u0027s move the common data in fakes.py inside \ntacker/tests/unit package.","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"4ccf8c1cea68ad435a6fc110ddf5e425b21ce0e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        _make_host_obj(a) for a in hosts_list])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"FAILOVER_SEGMENT \u003d {\"name\": \"segment1\", \"id\": \"1\","},{"line_number":52,"context_line":"                    \"service_type\": \"COMPUTE\", \"recovery_method\": \"auto\","},{"line_number":53,"context_line":"                    \"uuid\": uuidsentinel.fake_segment1,"},{"line_number":54,"context_line":"                    \"description\": \"failover_segment for compute\"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_01d8a51b","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":16},"in_reply_to":"ff570b3c_53b445f2","updated":"2020-05-18 17:40:25.000000000","message":"Done","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def test_index_valid_on_maintenance(self, mock_get_all, mock_segment):"},{"line_number":132,"context_line":"        mock_segment.return_value \u003d mock.Mock()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        HOST_LIST[0][\u0027on_maintenance\u0027] \u003d True"},{"line_number":135,"context_line":"        HOST_LIST[1][\u0027on_maintenance\u0027] \u003d True"},{"line_number":136,"context_line":"        mock_get_all.return_value \u003d _make_hosts_list(HOST_LIST)"},{"line_number":137,"context_line":"        for parameter in [\u00271\u0027, \u0027t\u0027, \u0027true\u0027, \u0027on\u0027, \u0027y\u0027, \u0027yes\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d3c7b563","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":17},"updated":"2020-05-18 04:10:35.000000000","message":"IMO, you shouldn\u0027t update the global data as it would affect the other unit tests especially when you run the tests concurrency on multiple CPU cores.","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"4ccf8c1cea68ad435a6fc110ddf5e425b21ce0e4","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    def test_index_valid_on_maintenance(self, mock_get_all, mock_segment):"},{"line_number":132,"context_line":"        mock_segment.return_value \u003d mock.Mock()"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        HOST_LIST[0][\u0027on_maintenance\u0027] \u003d True"},{"line_number":135,"context_line":"        HOST_LIST[1][\u0027on_maintenance\u0027] \u003d True"},{"line_number":136,"context_line":"        mock_get_all.return_value \u003d _make_hosts_list(HOST_LIST)"},{"line_number":137,"context_line":"        for parameter in [\u00271\u0027, \u0027t\u0027, \u0027true\u0027, \u0027on\u0027, \u0027y\u0027, \u0027yes\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c13fcd22","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":17},"in_reply_to":"ff570b3c_d3c7b563","updated":"2020-05-18 17:40:25.000000000","message":"moved code to masakari/tests/unit/fakes.py","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"}],"masakari/tests/unit/db/test_db_api.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            \u0027type\u0027: \u0027fake_type\u0027,"},{"line_number":207,"context_line":"            \u0027control_attributes\u0027: \u0027fake_control_attr\u0027,"},{"line_number":208,"context_line":"            \u0027failover_segment\u0027: self.failover_segment,"},{"line_number":209,"context_line":"            \u0027failover_segment_id\u0027: uuidsentinel.failover_segment_id,"},{"line_number":210,"context_line":"            \u0027on_maintenance\u0027: True"},{"line_number":211,"context_line":"        }"},{"line_number":212,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9396dd4b","side":"PARENT","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":68},"updated":"2020-05-18 04:10:35.000000000","message":"I think this should be retained as host should always return failover_segment_id.","commit_id":"b0ab1b46589c470686b7094bbea8c38bc7d2401f"}],"masakari/tests/unit/fakes.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":175,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":176,"context_line":"                     uuid\u003duuidsentinel.fake_host):"},{"line_number":177,"context_line":"    failover_segment \u003d create_fake_failover_segment("},{"line_number":178,"context_line":"        name\u003d\"segment1\", id\u003d1, description\u003d\"something\","},{"line_number":179,"context_line":"        service_type\u003d\"COMPUTE\", recovery_method\u003d\"auto\","},{"line_number":180,"context_line":"        uuid\u003duuidsentinel.fake_segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d34df5c4","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":51},"updated":"2020-05-18 04:10:35.000000000","message":"Pass failover_segment as a parameter to create_fake_host method.","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"4ccf8c1cea68ad435a6fc110ddf5e425b21ce0e4","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":175,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":176,"context_line":"                     uuid\u003duuidsentinel.fake_host):"},{"line_number":177,"context_line":"    failover_segment \u003d create_fake_failover_segment("},{"line_number":178,"context_line":"        name\u003d\"segment1\", id\u003d1, description\u003d\"something\","},{"line_number":179,"context_line":"        service_type\u003d\"COMPUTE\", recovery_method\u003d\"auto\","},{"line_number":180,"context_line":"        uuid\u003duuidsentinel.fake_segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_011f05b7","line":177,"range":{"start_line":177,"start_character":23,"end_line":177,"end_character":51},"in_reply_to":"ff570b3c_d34df5c4","updated":"2020-05-18 17:40:25.000000000","message":"Done","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"5b8f2e0b435f3909249f52ac17b1a4a9177cb250","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_bdec798f","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"updated":"2020-05-19 00:20:53.000000000","message":"Any reason why you want to pass these as parameters?","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"e278388d2fc5bf1dee47d90ecdc77e07b3cef8db","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5b53a217","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_3b334ef8","updated":"2020-05-19 07:59:33.000000000","message":"Why you were not getting this issue before as these parameters were not present since beginning?","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"dc9cc2c090ce52926461fac40f2c1ef78fbc02e8","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_74be5aff","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_3b8fce75","updated":"2020-05-20 05:18:57.000000000","message":"\u003e So IMO i should remove from here. Please confirm.\n\nIt\u0027s needed otherwise you are changing API response.\n\nSince all of the parameters are keyword arguments, I would suggest to simply this method as follows:-\n\n  def create_fake_host(**updates):\n    host \u003d {\n            \u0027name\u0027: \u0027fake_host\u0027, \u0027id\u0027: 1, \u0027reserved\u0027: False,\n            \u0027on_maintenance\u0027: False, \u0027type\u0027: \u0027SSH\u0027,\n            \u0027control_attributes\u0027: \u0027fake\u0027, \u0027uuid\u0027: uuidsentinel.fake_host,\n            \u0027failover_segment\u0027: FAILOVER_SEGMENT,\n            \u0027created_at\u0027: datetime.datetime(2019, 8, 8, 0, 0, 0,\n                tzinfo\u003diso8601.UTC),\n            \u0027updated_at\u0027: None, \u0027deleted_at\u0027: None, \u0027deleted\u0027: False\n    }\n    if updates:\n        host.update(updates)\n    return objects.Host(**host)","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"12d8c1b317fd834c4000e351ee2a5b536d7cce7e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_3b8fce75","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_5b53a217","updated":"2020-05-19 08:03:50.000000000","message":"This is because i have newly added file [1] where host details expecting these parameters.\nSo IMO i should remove from here. Please confirm.\n\n[1]: masakari/api/openstack/ha/views/hosts.py@42-45","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"5fd292983ba7cd7bb41d1c0eb9187328f576483e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_344182aa","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_74be5aff","updated":"2020-05-20 05:59:03.000000000","message":"Thanks, done","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"aec996d46f664e089f8b2240215cb17138b1d9a0","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e96aaf17","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_8e0699cd","updated":"2020-05-19 07:33:39.000000000","message":"\u003e should remove from view builder?\n\nThere is no change in the API response. So not sure, why these parameters are needed?\n\nCan you point out in which unit tests you are passing these parameters?","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"0c5c663bbaaa19d35c1c2883b88910230e6b7c60","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_8e0699cd","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_bdec798f","updated":"2020-05-19 06:14:11.000000000","message":"Thank you for review.\nI have added these highlighted fields into view builder [1] so needed during host api response [2]\n\nDo let me know, should i keep as is or should remove from view builder?\n\n[1]: https://review.opendev.org/#/c/726761/2/masakari/api/openstack/ha/views/hosts.py@42\n[2]: https://review.opendev.org/#/c/726761/2/masakari/api/openstack/ha/hosts.py@98","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"3c7677e8ee5782ef226578a49d7b2ff1caaaeeed","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                     on_maintenance\u003dFalse, type\u003d\u0027SSH\u0027,"},{"line_number":191,"context_line":"                     control_attributes\u003d\u0027fake\u0027,"},{"line_number":192,"context_line":"                     uuid\u003duuidsentinel.fake_host,"},{"line_number":193,"context_line":"                     created_at\u003ddatetime.datetime("},{"line_number":194,"context_line":"                         2019, 8, 8, 0, 0, 0, tzinfo\u003diso8601.UTC),"},{"line_number":195,"context_line":"                     updated_at\u003dNone, deleted_at\u003dNone, deleted\u003dFalse,"},{"line_number":196,"context_line":"                     failover_segment\u003dFAILOVER_SEGMENT):"},{"line_number":197,"context_line":"    return objects.Host("},{"line_number":198,"context_line":"        name\u003dname, id\u003did, reserved\u003dreserved, on_maintenance\u003don_maintenance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_3b334ef8","line":195,"range":{"start_line":193,"start_character":21,"end_line":195,"end_character":53},"in_reply_to":"ff570b3c_e96aaf17","updated":"2020-05-19 07:56:09.000000000","message":"Below test cases needed these parameters since during test execution giving \u0027NotImplementedError: Cannot load \u0027created_at\u0027 in the base class\u0027 at [1] controller call:\n\n1. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_create\n2. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_index\n3. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_index_valid_on_maintenance\n4. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_show\n5. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_update_1\n6. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_index_valid_reserved\n7. masakari.tests.unit.api.openstack.ha.test_hosts.HostTestCase.test_update_2\n\n\n[1]: https://review.opendev.org/#/c/726761/2/masakari/tests/unit/api/openstack/ha/test_hosts.py@96","commit_id":"2eb134fb2679ecc6c18bb0d673940b6a17c934a0"}],"masakari/tests/unit/objects/test_hosts.py":[{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                      phase\u003dphase_start)]"},{"line_number":315,"context_line":"        mock_notify_about_host_api.assert_has_calls(notify_calls)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def _host_create_attributes2(self):"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        failover_segment \u003d fakes_data.create_fake_failover_segment("},{"line_number":320,"context_line":"            name\u003d\"fake_segment\", id\u003d123, description\u003d\"fakefake\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_d3e215a0","line":317,"range":{"start_line":317,"start_character":8,"end_line":317,"end_character":32},"updated":"2020-05-18 04:10:35.000000000","message":"It\u0027s not used anywhere in the code. I think you want to use this method in test_obj_make_compatible unit test.","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"4ccf8c1cea68ad435a6fc110ddf5e425b21ce0e4","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                      phase\u003dphase_start)]"},{"line_number":315,"context_line":"        mock_notify_about_host_api.assert_has_calls(notify_calls)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def _host_create_attributes2(self):"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        failover_segment \u003d fakes_data.create_fake_failover_segment("},{"line_number":320,"context_line":"            name\u003d\"fake_segment\", id\u003d123, description\u003d\"fakefake\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_417a9df0","line":317,"range":{"start_line":317,"start_character":8,"end_line":317,"end_character":32},"in_reply_to":"ff570b3c_d3e215a0","updated":"2020-05-18 17:40:25.000000000","message":"Done","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"change_message_id":"acf4b4b2d9b9a02750b0e09f7ed5be3dd1d3db85","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def _host_create_attributes2(self):"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        failover_segment \u003d fakes_data.create_fake_failover_segment("},{"line_number":320,"context_line":"            name\u003d\"fake_segment\", id\u003d123, description\u003d\"fakefake\","},{"line_number":321,"context_line":"            service_type\u003d\"COMPUTE\", recovery_method\u003d\"auto\","},{"line_number":322,"context_line":"            uuid\u003duuidsentinel.fake_segment"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        host_obj \u003d host.Host(context\u003dself.context)"},{"line_number":326,"context_line":"        host_obj.name \u003d \u0027foo-host\u0027"},{"line_number":327,"context_line":"        host_obj.failover_segment_id \u003d uuidsentinel.fake_segment"},{"line_number":328,"context_line":"        host_obj.failover_segment \u003d failover_segment"},{"line_number":329,"context_line":"        host_obj.type \u003d \u0027fake-type\u0027"},{"line_number":330,"context_line":"        host_obj.reserved \u003d False"},{"line_number":331,"context_line":"        host_obj.on_maintenance \u003d False"},{"line_number":332,"context_line":"        host_obj.control_attributes \u003d \u0027fake_attributes\u0027"},{"line_number":333,"context_line":"        host_obj.uuid \u003d uuidsentinel.fake_host"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return host_obj"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def test_obj_make_compatible(self):"},{"line_number":338,"context_line":"        host_obj \u003d self._host_create_attributes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f3f63963","line":335,"range":{"start_line":319,"start_character":8,"end_line":335,"end_character":23},"updated":"2020-05-18 04:10:35.000000000","message":"Re-use _host_create_attributes method to avoid code duplication.\n\nhost_obj \u003dself._host_create_attributes()\nhost_obj.failover_segment_id \u003d failover_segment.uuid\nreturn host_obj","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"4ccf8c1cea68ad435a6fc110ddf5e425b21ce0e4","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def _host_create_attributes2(self):"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        failover_segment \u003d fakes_data.create_fake_failover_segment("},{"line_number":320,"context_line":"            name\u003d\"fake_segment\", id\u003d123, description\u003d\"fakefake\","},{"line_number":321,"context_line":"            service_type\u003d\"COMPUTE\", recovery_method\u003d\"auto\","},{"line_number":322,"context_line":"            uuid\u003duuidsentinel.fake_segment"},{"line_number":323,"context_line":"        )"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        host_obj \u003d host.Host(context\u003dself.context)"},{"line_number":326,"context_line":"        host_obj.name \u003d \u0027foo-host\u0027"},{"line_number":327,"context_line":"        host_obj.failover_segment_id \u003d uuidsentinel.fake_segment"},{"line_number":328,"context_line":"        host_obj.failover_segment \u003d failover_segment"},{"line_number":329,"context_line":"        host_obj.type \u003d \u0027fake-type\u0027"},{"line_number":330,"context_line":"        host_obj.reserved \u003d False"},{"line_number":331,"context_line":"        host_obj.on_maintenance \u003d False"},{"line_number":332,"context_line":"        host_obj.control_attributes \u003d \u0027fake_attributes\u0027"},{"line_number":333,"context_line":"        host_obj.uuid \u003d uuidsentinel.fake_host"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        return host_obj"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def test_obj_make_compatible(self):"},{"line_number":338,"context_line":"        host_obj \u003d self._host_create_attributes()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_818035c1","line":335,"range":{"start_line":319,"start_character":8,"end_line":335,"end_character":23},"in_reply_to":"ff570b3c_f3f63963","updated":"2020-05-18 17:40:25.000000000","message":"thanks, done","commit_id":"5e087c48aad77e0faebdd0140bc01b1745c644fa"}]}