)]}'
{"masakari/engine/drivers/taskflow/host_failure.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f0c5900c45f904e92fac1279300cb961a8b64dcb","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                LOG.warning(str(e))"},{"line_number":228,"context_line":"                failed_evacuation_instances.append(instance.id)"},{"line_number":229,"context_line":"            except etimeout.Timeout:"},{"line_number":230,"context_line":"                # Instance is not evacuated in the expected time_limit."},{"line_number":231,"context_line":"                failed_evacuation_instances.append(instance.id)"},{"line_number":232,"context_line":"            finally:"},{"line_number":233,"context_line":"                # stop the periodic call, in case of exceptions or"},{"line_number":234,"context_line":"                # Timeout."}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_a8032310","line":231,"range":{"start_line":230,"start_character":0,"end_line":231,"end_character":63},"updated":"2020-09-30 13:59:32.000000000","message":"It really needs a with excutils.save_and_reraise_exception() as is done above. That would cause it to stop executing and drop to the exception handler below which also does failed_evacuation_instances.append(instance.id).\n\nI haven\u0027t seen that in the real world though.","commit_id":"3dba937f05a992748cf01e98cf4872d20a211b20"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"cabda051dadd15894276369b10a98176c07b9190","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                LOG.warning(str(e))"},{"line_number":228,"context_line":"                failed_evacuation_instances.append(instance.id)"},{"line_number":229,"context_line":"            except etimeout.Timeout:"},{"line_number":230,"context_line":"                # Instance is not evacuated in the expected time_limit."},{"line_number":231,"context_line":"                failed_evacuation_instances.append(instance.id)"},{"line_number":232,"context_line":"            finally:"},{"line_number":233,"context_line":"                # stop the periodic call, in case of exceptions or"},{"line_number":234,"context_line":"                # Timeout."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f6b1bfe_c20e4f31","line":231,"range":{"start_line":230,"start_character":0,"end_line":231,"end_character":63},"in_reply_to":"9f560f44_a8032310","updated":"2020-10-14 06:57:29.000000000","message":"Refer to function(_stop_after_evacuation), here we can just log necessary meesage and reraise it to upper function(_evacuate_and_confirm).","commit_id":"3dba937f05a992748cf01e98cf4872d20a211b20"}]}