)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"e1309d288cd713bb58c295a88f223c9e5d97c864","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9d659ca0_02e6efde","updated":"2023-09-19 14:44:31.000000000","message":"Hey Jay, your patch fixed my Debian package build with all the latest oslo libs. Thanks for the patch!\n\nPlease merge this...","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"096a42e1207ce33ed9ebe2bca04179c223e4dab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8372f13e_54d0a130","updated":"2023-09-19 22:15:09.000000000","message":"Suzhengwei, please re-evaluate your -1 vote on this patchset. If you are happy with it with the reported breakage fixed by this change; please also ensure to approve the backports.\n\nThanks!","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"31acf214acccc7b7f3a7330782287e0086333c4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"924b6274_2c18cd5d","updated":"2023-09-19 14:04:49.000000000","message":"https://paste.opendev.org/show/btm0NRnJMsPDS68NcPgI/\n\nWe had a report from upstream debian that there was an issue that this patch would fix. Please land it.","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2531bd266da1ffacad0fdc5c18b8e2a1c88d8ef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"476e87bd_43130195","updated":"2023-09-09 01:06:59.000000000","message":"thanks, lgtm, hopefully we will get review on these and merge soon @suzengwei","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"}],"masakari/context.py":[{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"0d00819127a066c5a20c0f507bf0a993e6dad59d","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            LOG.debug(\u0027Arguments dropped when creating context: %s\u0027,"},{"line_number":118,"context_line":"                      str(kwargs))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if read_deleted is None:"},{"line_number":121,"context_line":"            # If we did not get a value for read_deleted, ensure we default"},{"line_number":122,"context_line":"            # it to \"no\" as code expects it to be a string."},{"line_number":123,"context_line":"            self.read_deleted \u003d \u0027no\u0027"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            self.read_deleted \u003d read_deleted"},{"line_number":126,"context_line":"        self.remote_address \u003d remote_address"}],"source_content_type":"text/x-python","patch_set":3,"id":"3590f201_846b3e3e","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":36},"updated":"2023-09-11 02:55:16.000000000","message":"I didn\u0027t find the call of RequestContext with read_deleted a None value across the Masakari project. Moreover, it could check the value when _set_read_deleted property L150 in this file.\n\nCould you please provide any details to reproduce the bug in Masakari?","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"ac78326dfc48d151cdfd0628ea43bb5e44aea96e","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            LOG.debug(\u0027Arguments dropped when creating context: %s\u0027,"},{"line_number":118,"context_line":"                      str(kwargs))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if read_deleted is None:"},{"line_number":121,"context_line":"            # If we did not get a value for read_deleted, ensure we default"},{"line_number":122,"context_line":"            # it to \"no\" as code expects it to be a string."},{"line_number":123,"context_line":"            self.read_deleted \u003d \u0027no\u0027"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            self.read_deleted \u003d read_deleted"},{"line_number":126,"context_line":"        self.remote_address \u003d remote_address"}],"source_content_type":"text/x-python","patch_set":3,"id":"019b3519_830a9f49","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":36},"in_reply_to":"30098b21_e45eef68","updated":"2023-09-19 14:05:25.000000000","message":"Please see logs posted into main feedback demonstrating need for this patch.","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"f93c1f65aac82fb0a510d8c4647e98e9db292c86","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            LOG.debug(\u0027Arguments dropped when creating context: %s\u0027,"},{"line_number":118,"context_line":"                      str(kwargs))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if read_deleted is None:"},{"line_number":121,"context_line":"            # If we did not get a value for read_deleted, ensure we default"},{"line_number":122,"context_line":"            # it to \"no\" as code expects it to be a string."},{"line_number":123,"context_line":"            self.read_deleted \u003d \u0027no\u0027"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            self.read_deleted \u003d read_deleted"},{"line_number":126,"context_line":"        self.remote_address \u003d remote_address"}],"source_content_type":"text/x-python","patch_set":3,"id":"bb4e392e_0b367c1f","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":36},"in_reply_to":"3590f201_846b3e3e","updated":"2023-09-11 14:43:09.000000000","message":"This change to oslo.messaging to fix a security bug in notifications: https://github.com/openstack/oslo.messaging/commit/3485301b1838353c16c6dd1c1cfbcab866df2e5d uses from_dict() to create a new, redacted copy of context. That copy will not have read_deleted set. This broke several projects that use read_deleted that had a built-in assumption aroudn the contents of read_deleted.\n\nI have not run masakari personally; but am trying to ensure the blast radius of that change doesn\u0027t break anything. If masakari isn\u0027t impacted; awesome.","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"},{"author":{"_account_id":30623,"name":"suzhengwei","email":"suzhengwei@inspur.com","username":"SuZhengwei"},"change_message_id":"71dcff0cc3039a340b0c2ab04c764a75e89f4df5","unresolved":true,"context_lines":[{"line_number":117,"context_line":"            LOG.debug(\u0027Arguments dropped when creating context: %s\u0027,"},{"line_number":118,"context_line":"                      str(kwargs))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if read_deleted is None:"},{"line_number":121,"context_line":"            # If we did not get a value for read_deleted, ensure we default"},{"line_number":122,"context_line":"            # it to \"no\" as code expects it to be a string."},{"line_number":123,"context_line":"            self.read_deleted \u003d \u0027no\u0027"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            self.read_deleted \u003d read_deleted"},{"line_number":126,"context_line":"        self.remote_address \u003d remote_address"}],"source_content_type":"text/x-python","patch_set":3,"id":"30098b21_e45eef68","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":36},"in_reply_to":"bb4e392e_0b367c1f","updated":"2023-09-12 01:15:10.000000000","message":"If it didn\u0027t get a value for read_deleted, it will use \u0027no\u0027 default value in the __init__ function. \nPlease refer to L75 in this file.","commit_id":"636df8898393acccfaa505ec71b67081ab1c07b5"}]}