)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"902560b77a703c1e0e63e82214b0f9d7c383c179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00865f27_faaf7872","updated":"2026-03-02 18:38:48.000000000","message":"Adding Dmitriy to the review as well - much appreciate the feedback.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"3976aa16c95e5c58e199aa3c1f4d69575bc8c105","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"600096da_d624fa5e","updated":"2026-03-01 15:07:15.000000000","message":"Hello Ivan \u0026 Takashi! I came across this bug which apparently has been reported by others and proposed patch. The LP bug page (https://bugs.launchpad.net/masakari/+bug/2028450) includes a reproducer script to test and validate the fix. \n\nMuch appreciate the help!","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7cb49b2e61bc6a1ff438d478285128fbdd96b6f2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c7f294b_399705ad","updated":"2026-03-01 15:23:59.000000000","message":"I don\u0027t reject this but technically this is not a complete solution. I\u0027d rather suggest recommending (or even requiring) appropriate coordination backend instead of adding 90% solution, based on the impact described in the linked bug.\n\nAn alternative approach may be to take full table lock before inserting a notification record, but this likely causes performance impact and may require some refactoring of the current logics.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"5fb734a9db3c57eece92637430a3c9682fbe3ad9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76d30b98_a6a00c67","in_reply_to":"2c7f294b_399705ad","updated":"2026-03-01 16:20:00.000000000","message":"Thank you so much for the review. \n\nI 100% agree that requiring the coordination backend is the most viable choice. Many unforeseen issues can arise from database locking and as you said that approach may require a considerable amount of refactoring.\n\nWith that being said, my ultimate goal is to apply a similar patch to the older and LTS (from a vendor\u0027s perspective) releases which do not even support coordination. \n\nThis fix for the time being works and avoids duplicated records that can potentially lead to catastrophic effects.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"a44e505116caf9bcf91feb5314d8ecbe2aad08cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3d72abd_ab6f6137","in_reply_to":"76d30b98_a6a00c67","updated":"2026-03-01 16:22:56.000000000","message":"Essentially look at this as a fail safe mechanism or a fallback switch.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"7157db180165d930302165f2e88068a6badf510e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2f8fb2f_8ad62c69","in_reply_to":"93c5da5f_2bd10a86","updated":"2026-03-03 15:17:13.000000000","message":"Hi Ivan! Thank you so much for the review. Sure thing, I can work on adding tests.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"3feeb4aca9d22e226d45cfd3c19161de9c1b9e95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aaa42390_3ffce48e","in_reply_to":"b2f8fb2f_8ad62c69","updated":"2026-03-04 21:18:40.000000000","message":"Hello Ivan! I added a new test for the added functionality.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"426010d87d7cdfb281194f94cf9d7068cc2610a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93c5da5f_2bd10a86","in_reply_to":"b3d72abd_ab6f6137","updated":"2026-03-03 08:48:07.000000000","message":"Hello,\n\nIn this case I agree with @kajinamit@oss.nttdata.com, but we need to consider the overall situation with Masakari. It\u0027s been a while since people received a release where everything works correctly, and a lot of bugs have been open for several years. So I think this fix is ​​acceptable, but perhaps automated tests should be added.","commit_id":"2f19eb8b9eb71951b039a5ebcd5222c6e46357d9"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"2b8832adbe4fac472ef722c9d5d573788bee5ed1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"05044b7a_a4075f49","updated":"2026-03-08 21:40:08.000000000","message":"@say3no@gmail.com \u0026 @kajinamit@oss.nttdata.com May I kindly request another set of review? I added a test as well as the release notes. Thank you so much!","commit_id":"12b51b5f4af54cf41fdbf977a564ec37044da389"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"be0e2df6962bd8adf528a5754c331b6b578c388c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c8066f90_5c5ecee7","updated":"2026-03-23 15:16:39.000000000","message":"Hello Sei \u0026 Takashi! May I kindly ask for another review? Much appreciated!","commit_id":"12b51b5f4af54cf41fdbf977a564ec37044da389"},{"author":{"_account_id":38176,"name":"Sei Sano","display_name":"say3no","email":"sei.sano@ntt.com","username":"say3no"},"change_message_id":"6b3049f80ddc89cf3e2d8abe7cc2f97f0a7770df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"798712ba_41451fcf","updated":"2026-04-13 07:24:27.000000000","message":"If we go the route of accepting this as an interim workaround upstream, I\u0027d like to suggest the following conditions so that the intent and the limitations are explicit to future readers and operators:\n\nInline comment: Clearly state in the code that this is a workaround that only takes effect when the coordination engine is not configured, and that the proper fix is to enable coordination.\nConfigurable sleep range: Instead of hardcoding random.uniform(1, 5), expose the range (or at least the upper bound) as a config option so operators can tune or disable it.\nGuaranteed skip when coordination is enabled: Make sure the sleep path is reliably bypassed when CONF.coordination.backend_url is set, so deployments with coordination pay no latency cost.\nRelease notes \u0026 DocImpact: Document this as a known limitation / workaround in the release notes, and add a DocImpact tag so the behavior is visible to operators.","commit_id":"12b51b5f4af54cf41fdbf977a564ec37044da389"},{"author":{"_account_id":35648,"name":"Alan Baghumian","display_name":"Alan Baghumian","email":"alan.baghumian@canonical.com","username":"alanbach"},"change_message_id":"d48db0b5aa07fe6588471c6cbf2d027d602826b5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e3a1874_c16401f0","in_reply_to":"798712ba_41451fcf","updated":"2026-04-13 22:08:31.000000000","message":"Hello say3no! Thank you again for the discussions last night. I implemented the requested changes. If you can kindly review and let me know your thoughts.","commit_id":"12b51b5f4af54cf41fdbf977a564ec37044da389"}]}