)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6cc72cafffd62d1a5e0e46e869b49ddebc812f75","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch updates the Fault wrapper to conditionally suppress the"},{"line_number":17,"context_line":"OpenStack-API-Version header when the response code is 406"},{"line_number":18,"context_line":"(HTTPStatus.NOT_ACCEPTABLE). It also corrects the service name string"},{"line_number":19,"context_line":"from \u0027instance-ha \u0027 to \u0027masakari \u0027 for all other valid error responses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1646357"},{"line_number":22,"context_line":"Co-authored-by: Sanjay Balaji K \u003csanjaybalajik12@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"461e72af_73928794","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":71},"updated":"2026-07-01 14:16:11.000000000","message":"AFAIK OpenStack-API-Version header should include official service type, not internal code name so this update looks incorrect.","commit_id":"514881353196a60674932647e14863c4f5f0c0bf"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"b7e1c30ec34ae11c21d3f9478c21cf41d6cb7a3d","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch updates the Fault wrapper to conditionally suppress the"},{"line_number":17,"context_line":"OpenStack-API-Version header when the response code is 406"},{"line_number":18,"context_line":"(HTTPStatus.NOT_ACCEPTABLE). It also corrects the service name string"},{"line_number":19,"context_line":"from \u0027instance-ha \u0027 to \u0027masakari \u0027 for all other valid error responses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1646357"},{"line_number":22,"context_line":"Co-authored-by: Sanjay Balaji K \u003csanjaybalajik12@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c1ee3c1d_5f11309f","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":71},"in_reply_to":"461e72af_73928794","updated":"2026-07-02 17:57:30.000000000","message":"I can change the Version header from internal code name to service type and submit the patch, and also can you clarify me that whether should i keep the tests in separate file (test_bug_1646357.py) or put them in test_wsgi.py","commit_id":"514881353196a60674932647e14863c4f5f0c0bf"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"91e4290e4c37dfb04e527dd1c62c6bdc1bee812e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch updates the Fault wrapper to conditionally suppress the"},{"line_number":17,"context_line":"OpenStack-API-Version header when the response code is 406"},{"line_number":18,"context_line":"(HTTPStatus.NOT_ACCEPTABLE). It also corrects the service name string"},{"line_number":19,"context_line":"from \u0027instance-ha \u0027 to \u0027masakari \u0027 for all other valid error responses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1646357"},{"line_number":22,"context_line":"Co-authored-by: Sanjay Balaji K \u003csanjaybalajik12@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"be9b8b95_4172adf9","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":71},"in_reply_to":"acb58ac7_9d033f06","updated":"2026-07-03 07:01:08.000000000","message":"I Fixed the issue you mentioned, and also the Resource class success path also consists the issue you mentioned that is, it contains internal code name in the success response header, so i fixed it too","commit_id":"514881353196a60674932647e14863c4f5f0c0bf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8e31ae90652799009b43dd0a870e003e883cca4","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch updates the Fault wrapper to conditionally suppress the"},{"line_number":17,"context_line":"OpenStack-API-Version header when the response code is 406"},{"line_number":18,"context_line":"(HTTPStatus.NOT_ACCEPTABLE). It also corrects the service name string"},{"line_number":19,"context_line":"from \u0027instance-ha \u0027 to \u0027masakari \u0027 for all other valid error responses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1646357"},{"line_number":22,"context_line":"Co-authored-by: Sanjay Balaji K \u003csanjaybalajik12@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fcdb06f0_7acbcf26","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":71},"in_reply_to":"be9b8b95_4172adf9","updated":"2026-07-05 15:28:09.000000000","message":"I think test_wsgi.py is the appropriate place.","commit_id":"514881353196a60674932647e14863c4f5f0c0bf"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"4918aec5b501647ba40b8d0247bf8cb22ce19379","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch updates the Fault wrapper to conditionally suppress the"},{"line_number":17,"context_line":"OpenStack-API-Version header when the response code is 406"},{"line_number":18,"context_line":"(HTTPStatus.NOT_ACCEPTABLE). It also corrects the service name string"},{"line_number":19,"context_line":"from \u0027instance-ha \u0027 to \u0027masakari \u0027 for all other valid error responses."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1646357"},{"line_number":22,"context_line":"Co-authored-by: Sanjay Balaji K \u003csanjaybalajik12@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"acb58ac7_9d033f06","line":19,"range":{"start_line":18,"start_character":29,"end_line":19,"end_character":71},"in_reply_to":"c1ee3c1d_5f11309f","updated":"2026-07-02 17:58:09.000000000","message":"Acknowledged","commit_id":"514881353196a60674932647e14863c4f5f0c0bf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a8e31ae90652799009b43dd0a870e003e883cca4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5fad20c_1d3946b8","updated":"2026-07-05 15:28:09.000000000","message":"Thanks for the update. Now the logic update looks good to me.\n\nCould you please add a release note to describe the fix, because this affects user-facing behaviors ?","commit_id":"a6589493d54491062c20c1ecd4da31fccac40286"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"a3c86d614d909a515e1cbba18cbafdb3e072b6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"44789a35_cdc5179c","in_reply_to":"e5fad20c_1d3946b8","updated":"2026-07-05 19:57:35.000000000","message":"Acknowledged","commit_id":"a6589493d54491062c20c1ecd4da31fccac40286"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"88faad8289a304a63aa253888feccf2e0d3943ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ca9651b1_4a9dd2e3","updated":"2026-07-06 00:58:54.000000000","message":"Thanks","commit_id":"07896e6c458477e2ffe77411d6c2281200bfa856"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4095baea1787b561baf88268a847629089dfbeb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee8d1654_f001e41e","in_reply_to":"76698296_01700c28","updated":"2026-07-06 06:58:56.000000000","message":"I intentionally avoided +A now to let other cores review this because this has API impact. In case this gets stuck for long time, I\u0027ll vote +A from my end then.","commit_id":"07896e6c458477e2ffe77411d6c2281200bfa856"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"cadabf762968fc8446ea9e8e8d970b2dd7ec230f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"76698296_01700c28","in_reply_to":"ca9651b1_4a9dd2e3","updated":"2026-07-06 03:46:26.000000000","message":"Thanks so much for the review and the help getting this patch into shape! I noticed we have the Code-Review +2 but are still waiting on the Workflow +1 to enter the gate. Just wanted to double-check if there is anything else I need to adjust on my end.","commit_id":"07896e6c458477e2ffe77411d6c2281200bfa856"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"ed055a655f43ce271dde27f98dc44d9db2d13908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"57304b71_f5994322","in_reply_to":"ee8d1654_f001e41e","updated":"2026-07-06 18:10:14.000000000","message":"Understood, that makes perfect sense! Thanks for the explanation and all your help.","commit_id":"07896e6c458477e2ffe77411d6c2281200bfa856"}]}
