)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87bc11e13ac485b7258a01f5d7149fd0d20b9451","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent duplicate notification race during creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The duplicate notification detection is vulnerable to a race"},{"line_number":10,"context_line":"condition. Multiple API workers can pass the duplicate check"},{"line_number":11,"context_line":"before either notification is committed, resulting in duplicate"},{"line_number":12,"context_line":"notifications being processed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Protect notification creation by using the synchronized"},{"line_number":15,"context_line":"notification creation path for all notification types. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"419671f2_264b339f","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"updated":"2026-07-14 16:42:29.000000000","message":"API already implements coordination mechanism for such purpose. I guess the point is not lack of the mechanism but is an incomplete isolation about the same host. Please describe that point more specifically.","commit_id":"7ac1e5ccdc7dd38f33fe9a68509e68dfa7723a45"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87bc11e13ac485b7258a01f5d7149fd0d20b9451","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ensures that duplicate detection and notification creation are"},{"line_number":17,"context_line":"performed atomically for the same host."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also re-raise DuplicateNotification explicitly so it is not"},{"line_number":20,"context_line":"handled by the generic exception handler."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Add unit tests covering the synchronized notification path"},{"line_number":23,"context_line":"and duplicate notification handling."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"91204cd0_9e3ae52e","line":20,"range":{"start_line":19,"start_character":50,"end_line":20,"end_character":41},"updated":"2026-07-14 16:42:29.000000000","message":"for what purpose ? (I assume it\u0027s to avoid sending notification)","commit_id":"7ac1e5ccdc7dd38f33fe9a68509e68dfa7723a45"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87bc11e13ac485b7258a01f5d7149fd0d20b9451","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5318b34c_72153b9a","updated":"2026-07-14 16:42:29.000000000","message":"Because this caused client impact I wonder if we should add a new microversion for it. At least a release note should be added to document the API behavior change and notification change.","commit_id":"7ac1e5ccdc7dd38f33fe9a68509e68dfa7723a45"}],"masakari/ha/api.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"87bc11e13ac485b7258a01f5d7149fd0d20b9451","unresolved":true,"context_lines":[{"line_number":341,"context_line":"                    tb\u003dtb)"},{"line_number":342,"context_line":"        return notification"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    @synchronized(\u0027create_host_notification-{notification_data[hostname]}\u0027)"},{"line_number":345,"context_line":"    def _create_host_type_notification(self, context, notification_data):"},{"line_number":346,"context_line":"        return self._create_notification(context, notification_data)"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fd017e2_cd72e081","side":"PARENT","line":344,"range":{"start_line":344,"start_character":19,"end_line":344,"end_character":43},"updated":"2026-07-14 16:42:29.000000000","message":"maybe we could keep the existing lock space name so that this works durung rolling upgrade ?","commit_id":"b6364924009e7ef45653fcc49ff896816fc21751"}]}