)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"45f5f589348984144d5ab85c6d9ad4b3b5522144","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gomathi \u003cgomathig@cdac.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-07-17 19:25:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix:NoAuth Middleware Grants Unconditional Admin Access"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Description: When auth_strategy\u003dnoauth2, NoAuthMiddleware creates a RequestContext with is_admin\u003dTrue unconditionally. Any"},{"line_number":10,"context_line":"request becomes admin without credentials."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"544cf00a_c772b03a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2026-07-17 14:20:37.000000000","message":"This doesn\u0027t \"fix\" the described behavior and needs to be adjusted.","commit_id":"89e7e5ce67fca5d8077df376977f757425cdf24b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"45f5f589348984144d5ab85c6d9ad4b3b5522144","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix:NoAuth Middleware Grants Unconditional Admin Access"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Description: When auth_strategy\u003dnoauth2, NoAuthMiddleware creates a RequestContext with is_admin\u003dTrue unconditionally. Any"},{"line_number":10,"context_line":"request becomes admin without credentials."},{"line_number":11,"context_line":"Impact: If accidentally deployed with noauth2, any network-reachable client gets full admin control of the HA service"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added a prominent LOG.warning on every request through NoAuthMiddleware, clearly stating it must NEVER be used in"},{"line_number":14,"context_line":"production. This ensures operators see the warning in logs immediately if misconfigured."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7172150c064d80915ca0218073263d2a4bf2d913"},{"line_number":17,"context_line":"Signed-off-by: Gomathi G \u003cgomathig@cdac.in\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a9eab252_cfc85757","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":88},"updated":"2026-07-17 14:20:37.000000000","message":"Wrap lines. This is also seen in multiple commits you proposed. Please fix these all.","commit_id":"89e7e5ce67fca5d8077df376977f757425cdf24b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5386bb343657818055271bffc51e0467891702f8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"abbedd02_f5cbd252","updated":"2026-07-14 16:17:25.000000000","message":"I don\u0027t see much benefit from this change because noauth is designed to provide full access without any authentication. auth_strategy defaults to keystone so users should explicit set the option to noauth to use this feature so I don\u0027t think it\u0027s reasonable to guess someone may \"accidentally\" use it.","commit_id":"156a9f7020584edd1dc20ef272f3a5d8666da63e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"45f5f589348984144d5ab85c6d9ad4b3b5522144","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"364d4aaf_009ef376","in_reply_to":"abbedd02_f5cbd252","updated":"2026-07-17 14:20:37.000000000","message":"I still keep my stance I explained above. I won\u0027t block this if any other core think it\u0027s useful but I myself may not vote my +2.","commit_id":"156a9f7020584edd1dc20ef272f3a5d8666da63e"}],"masakari/api/auth.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5386bb343657818055271bffc51e0467891702f8","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"},{"line_number":65,"context_line":"    def __call__(self, req):"},{"line_number":66,"context_line":"        remote_address \u003d req.remote_addr"},{"line_number":67,"context_line":"        if CONF.use_forwarded_for:"},{"line_number":68,"context_line":"            forwarded_for \u003d req.headers.get(\u0027X-Forwarded-For\u0027)"},{"line_number":69,"context_line":"            if forwarded_for:"},{"line_number":70,"context_line":"                remote_address \u003d forwarded_for.split(\u0027,\u0027)[0].strip()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        service_catalog \u003d None"},{"line_number":73,"context_line":"        if req.headers.get(\u0027X_SERVICE_CATALOG\u0027) is not None:"},{"line_number":74,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f978621_7ec69156","line":71,"range":{"start_line":67,"start_character":34,"end_line":71,"end_character":2},"updated":"2026-07-14 16:17:25.000000000","message":"This isn\u0027t related","commit_id":"156a9f7020584edd1dc20ef272f3a5d8666da63e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"45f5f589348984144d5ab85c6d9ad4b3b5522144","unresolved":true,"context_lines":[{"line_number":64,"context_line":"    @webob.dec.wsgify(RequestClass\u003dwsgi.Request)"},{"line_number":65,"context_line":"    def __call__(self, req):"},{"line_number":66,"context_line":"        remote_address \u003d req.remote_addr"},{"line_number":67,"context_line":"        if CONF.use_forwarded_for:"},{"line_number":68,"context_line":"            forwarded_for \u003d req.headers.get(\u0027X-Forwarded-For\u0027)"},{"line_number":69,"context_line":"            if forwarded_for:"},{"line_number":70,"context_line":"                remote_address \u003d forwarded_for.split(\u0027,\u0027)[0].strip()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        service_catalog \u003d None"},{"line_number":73,"context_line":"        if req.headers.get(\u0027X_SERVICE_CATALOG\u0027) is not None:"},{"line_number":74,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4c5f8a2_b5848a1b","line":71,"range":{"start_line":67,"start_character":34,"end_line":71,"end_character":2},"in_reply_to":"6f978621_7ec69156","updated":"2026-07-17 14:20:37.000000000","message":"There are also multiple comments you should restore. The same problem is found in muitple places in the patches you proposed, in addition to unrelated changes which I also pointed out.. Please review these points, before you actually submit your updates to gerrit.","commit_id":"156a9f7020584edd1dc20ef272f3a5d8666da63e"}]}