)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c247670d2a662132fc21081d29306a3312ad9f46","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert notification status filter parameter to list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When querying notifications by status (e.g., GET /v1/notifications?status\u003dfinished,failed,error),"},{"line_number":10,"context_line":"the status parameter is received as a comma-separated string from the API request."},{"line_number":11,"context_line":"However, the database layer expects a list of status strings for proper filtering."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change converts the comma-separated status string into a list before querying"},{"line_number":14,"context_line":"the database to ensure accurate filtering and prevent null query results."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1953707"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaaff1617025ea90726483a687d23c50f0fc103db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"72da8f7b_0b0a8d5c","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":1},"updated":"2026-08-30 19:06:17.000000000","message":"Please wrap lines at 79 characters.","commit_id":"68e5a5508b1f5223d4b5a92d5dd04fd9b4aba679"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"3b74c05858e27ae753d7e1f577fa247aadaf1aa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Convert notification status filter parameter to list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When querying notifications by status (e.g., GET /v1/notifications?status\u003dfinished,failed,error),"},{"line_number":10,"context_line":"the status parameter is received as a comma-separated string from the API request."},{"line_number":11,"context_line":"However, the database layer expects a list of status strings for proper filtering."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change converts the comma-separated status string into a list before querying"},{"line_number":14,"context_line":"the database to ensure accurate filtering and prevent null query results."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1953707"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Iaaff1617025ea90726483a687d23c50f0fc103db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bc65eca1_d4583963","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":1},"in_reply_to":"72da8f7b_0b0a8d5c","updated":"2026-08-31 09:56:19.000000000","message":"Done","commit_id":"68e5a5508b1f5223d4b5a92d5dd04fd9b4aba679"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c247670d2a662132fc21081d29306a3312ad9f46","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09cc9705_5b49e365","updated":"2026-08-30 19:06:17.000000000","message":"This changes the behavior of API so at least requires release note. Also I\u0027m wondering if this requires a new api microversion so that clients can discover it.\n\nFinally, as I explained in my note in that bug, I\u0027m unsure if this is classified as a bug. Masakari was implemented based on a bit old nova code base and unless nova supports such multi-filter function then I\u0027d rather classify this as a new feature.","commit_id":"68e5a5508b1f5223d4b5a92d5dd04fd9b4aba679"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"3b74c05858e27ae753d7e1f577fa247aadaf1aa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2ee8419c_af7d4dde","in_reply_to":"09cc9705_5b49e365","updated":"2026-08-31 09:56:19.000000000","message":"Thanks for the review Takashi! Updated patch set 2 with wrapped commit message lines (\u003c 79 characters) and added a release note for the status filter behavior fix","commit_id":"68e5a5508b1f5223d4b5a92d5dd04fd9b4aba679"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"624db152e115a61c08573c31d4bb357b2f411dca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1da243b3_20f95588","updated":"2026-08-31 10:20:54.000000000","message":"Hmm I\u0027m unsure if you understood my points. Please find my comments inline.","commit_id":"399112b494941b513a9fc0f70e7cbf5dec8a1c09"}],"masakari/tests/unit/ha/test_api.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"624db152e115a61c08573c31d4bb357b2f411dca","unresolved":true,"context_lines":[{"line_number":980,"context_line":"        mock_get_all.assert_called_once_with(self.context, {\u0027status\u0027: [\u0027new\u0027]},"},{"line_number":981,"context_line":"                                             \u0027generated_time\u0027, \u0027asc\u0027,"},{"line_number":982,"context_line":"                                             1000, None)"},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    @mock.patch.object(notification_obj.NotificationList, \u0027get_all\u0027)"},{"line_number":985,"context_line":"    def test_get_all_invalid_sort_dir(self, mock_get_all):"},{"line_number":986,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"18d31d13_fec05e2d","line":983,"updated":"2026-08-31 10:20:54.000000000","message":"Please add actual test case to verify behavior for query with a list value.","commit_id":"399112b494941b513a9fc0f70e7cbf5dec8a1c09"}],"masakari/tests/unit/ha/test_notification_api_status_filter.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c3267112094867839ad89745a67a05e7b86516b5","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from masakari.tests.unit import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class NotificationAPIStatusFilterTest(base.NoDBTestCase):"},{"line_number":22,"context_line":"    \"\"\"Test that status filter is properly converted from string to list\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_status_filter_string_to_list_conversion(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7eb2746_fca01a97","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":37},"updated":"2026-08-30 19:07:59.000000000","message":"Please do add real behavior tests. The test cases added by this change are just useless and pointless.\nAlso please do not create a separate file but update existing api unit test cases.","commit_id":"68e5a5508b1f5223d4b5a92d5dd04fd9b4aba679"},{"author":{"_account_id":39222,"name":"Gomathi G","display_name":"gomathi","email":"gomathig@cdac.in","username":"gomathi"},"change_message_id":"7bdb101b645d1d5dab0f28b2532a1a5a2338300d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from masakari.tests.unit import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class NotificationAPIStatusFilterTest(base.NoDBTestCase):"},{"line_number":22,"context_line":"    \"\"\"Test that status filter is properly converted from string to list\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_status_filter_string_to_list_conversion(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2abae48_02bdf8f2","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":37},"in_reply_to":"a7eb2746_fca01a97","updated":"2026-08-31 09:56:35.000000000","message":"Done","commit_id":"68e5a5508b1f5223d4b5a92d5dd04fd9b4aba679"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"624db152e115a61c08573c31d4bb357b2f411dca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2024"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a819a14_cc3cb123","line":1,"updated":"2026-08-31 10:20:54.000000000","message":"Remove this useless test file.","commit_id":"399112b494941b513a9fc0f70e7cbf5dec8a1c09"}]}