)]}'
{"id":"openstack%2Fmetalsmith~659784","triplet_id":"openstack%2Fmetalsmith~stable%2Fstein~I52a85620d9ac2f471bca6498294871f3bb16d47f","project":"openstack/metalsmith","branch":"stable/stein","hashtags":[],"change_id":"I52a85620d9ac2f471bca6498294871f3bb16d47f","subject":"Ensure instance_info is clean before deploy and after failure","status":"MERGED","created":"2019-05-17 12:15:53.000000000","updated":"2019-08-09 12:12:38.000000000","submitted":"2019-08-09 12:12:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659784-1565352758442-92a0a85e","meta_rev_id":"01650a6e37c2d217102c6e7a948844fa9658c52c","_number":659784,"virtual_id_number":659784,"owner":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":2,"date":"2019-08-09 12:12:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":2,"date":"2019-08-09 10:54:21.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-22 02:56:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"all":[{"value":1,"date":"2019-08-09 10:54:21.000000000","_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-22 02:56:43.000000000","updated_by":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"reviewer":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"state":"REVIEWER"},{"updated":"2019-08-09 10:54:21.000000000","updated_by":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"reviewer":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"state":"REVIEWER"},{"updated":"2019-08-09 12:12:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"48de11484d2e6eb014611998986efd502453eee0","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2019-05-17 12:15:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a52debd42d0ef806cc976ac4e4a9a610e6dc7dbc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 13:35:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/84/659784/1/check/openstack-tox-pep8/9af625f/ : SUCCESS in 4m 45s\n- openstack-tox-py27 http://logs.openstack.org/84/659784/1/check/openstack-tox-py27/ad7a55b/ : SUCCESS in 3m 31s\n- openstack-tox-py36 http://logs.openstack.org/84/659784/1/check/openstack-tox-py36/7fdbcb7/ : SUCCESS in 4m 29s\n- openstack-tox-py37 http://logs.openstack.org/84/659784/1/check/openstack-tox-py37/b15db20/ : SUCCESS in 5m 10s\n- openstack-tox-lower-constraints http://logs.openstack.org/84/659784/1/check/openstack-tox-lower-constraints/bcc7aee/ : SUCCESS in 4m 16s\n- openstack-tox-cover http://logs.openstack.org/84/659784/1/check/openstack-tox-cover/cf7eef4/cover/ : SUCCESS in 4m 08s\n- openstack-tox-docs http://logs.openstack.org/84/659784/1/check/openstack-tox-docs/74aa367/html/ : SUCCESS in 5m 01s\n- build-openstack-releasenotes http://logs.openstack.org/84/659784/1/check/build-openstack-releasenotes/7b559a0/html/ : SUCCESS in 3m 48s\n- metalsmith-integration-glance-localboot-centos7 http://logs.openstack.org/84/659784/1/check/metalsmith-integration-glance-localboot-centos7/161f141/ : SUCCESS in 1h 14m 16s\n- metalsmith-integration-glance-netboot-cirros-iscsi-py3 http://logs.openstack.org/84/659784/1/check/metalsmith-integration-glance-netboot-cirros-iscsi-py3/b7b11bb/ : SUCCESS in 51m 14s\n- metalsmith-integration-glance-netboot-cirros-direct http://logs.openstack.org/84/659784/1/check/metalsmith-integration-glance-netboot-cirros-direct/bba5872/ : SUCCESS in 41m 23s\n- metalsmith-integration-http-netboot-cirros-direct-py3 http://logs.openstack.org/84/659784/1/check/metalsmith-integration-http-netboot-cirros-direct-py3/6612762/ : SUCCESS in 42m 31s","accounts_in_message":[],"_revision_number":1},{"id":"ad8ca132cb8e6b44f16db5e938a48942feb070cc","author":{"_account_id":30381,"name":"Jean-Pierre REN","email":"renzp@awcloud.com","username":"jpren"},"date":"2019-05-22 02:56:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"aef5748d5825c398cd5cada10b39bf810a3e0e2a","author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"date":"2019-08-09 10:54:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a2c2e25e760607005a5a88d9aec1f9b8d2d42b59","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 10:56:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ba99a6f2ebf93c6a78f298eed9865f6a832b1aed","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 12:12:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"01650a6e37c2d217102c6e7a948844fa9658c52c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 12:12:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/84/659784/1/gate/openstack-tox-pep8/9115bda/ : SUCCESS in 3m 23s\n- openstack-tox-py27 https://logs.opendev.org/84/659784/1/gate/openstack-tox-py27/262c1c7/ : SUCCESS in 3m 02s\n- openstack-tox-py36 https://logs.opendev.org/84/659784/1/gate/openstack-tox-py36/a693737/ : SUCCESS in 5m 53s\n- openstack-tox-py37 https://logs.opendev.org/84/659784/1/gate/openstack-tox-py37/fd8752e/ : SUCCESS in 4m 59s\n- openstack-tox-lower-constraints https://logs.opendev.org/84/659784/1/gate/openstack-tox-lower-constraints/f57ada4/ : SUCCESS in 3m 48s\n- openstack-tox-docs https://logs.opendev.org/84/659784/1/gate/openstack-tox-docs/ae5fcf2/html/ : SUCCESS in 4m 31s\n- build-openstack-releasenotes https://logs.opendev.org/84/659784/1/gate/build-openstack-releasenotes/ba63d1d/html/ : SUCCESS in 4m 03s\n- metalsmith-integration-glance-localboot-centos7 https://logs.opendev.org/84/659784/1/gate/metalsmith-integration-glance-localboot-centos7/1580967/ : SUCCESS in 1h 13m 18s\n- metalsmith-integration-glance-netboot-cirros-iscsi-py3 https://logs.opendev.org/84/659784/1/gate/metalsmith-integration-glance-netboot-cirros-iscsi-py3/407c77f/ : SUCCESS in 48m 53s\n- metalsmith-integration-glance-netboot-cirros-direct https://logs.opendev.org/84/659784/1/gate/metalsmith-integration-glance-netboot-cirros-direct/fa7e2ee/ : SUCCESS in 46m 12s\n- metalsmith-integration-http-netboot-cirros-direct-py3 https://logs.opendev.org/84/659784/1/gate/metalsmith-integration-http-netboot-cirros-direct-py3/3ef0c26/ : SUCCESS in 49m 36s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b941aaa48e977b02101d271598643cf3258a6e3c","revisions":{"b941aaa48e977b02101d271598643cf3258a6e3c":{"kind":"REWORK","_number":1,"created":"2019-05-17 12:15:53.000000000","uploader":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"ref":"refs/changes/84/659784/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/metalsmith","ref":"refs/changes/84/659784/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/84/659784/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/84/659784/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/84/659784/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/metalsmith refs/changes/84/659784/1"}}},"commit":{"parents":[{"commit":"e7f7ca73a2b0ec68c2abca0c109350b5306835ea","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/e7f7ca73a2b0ec68c2abca0c109350b5306835ea"}]}],"author":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-03-08 13:29:45.000000000","tz":60},"committer":{"name":"Dmitry Tantsur","email":"divius.inside@gmail.com","date":"2019-05-17 12:15:33.000000000","tz":120},"subject":"Ensure instance_info is clean before deploy and after failure","message":"Ensure instance_info is clean before deploy and after failure\n\nCurrently stale values can be left in instance_info (and reused next time)\nif a deployment attempts fails. This change ensures that we:\n1) Purge instance_info completely on failures\n2) Only keep traits and capabilities in instance_info on deploy.\n\nChange-Id: I52a85620d9ac2f471bca6498294871f3bb16d47f\n(cherry picked from commit 8e7b8d3f398fd206af74708d53857154f9e8e6a1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/b941aaa48e977b02101d271598643cf3258a6e3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/b941aaa48e977b02101d271598643cf3258a6e3c"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
