)]}'
{"metalsmith_ansible/ansible_plugins/modules/metalsmith_deployment_defaults.py":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4fc6ca05791f408b241770d06000f731e07a047b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        value(i, \u0027swap_size\u0027, j, \u0027swap_size_mb\u0027)"},{"line_number":76,"context_line":"        value(i, \u0027capabilities\u0027, j)"},{"line_number":77,"context_line":"        value(i, \u0027traits\u0027, j)"},{"line_number":78,"context_line":"        value(i, \u0027ssh_public_keys\u0027, j)"},{"line_number":79,"context_line":"        value(i, \u0027resource_class\u0027, j)"},{"line_number":80,"context_line":"        value(i, \u0027conductor_group\u0027, j)"},{"line_number":81,"context_line":"        value(i, \u0027user_name\u0027, j)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f560f44_4b81c54d","line":78,"updated":"2020-08-28 05:19:27.000000000","message":"It looks like the role is providing a path to a public key file, but the module expects the public key contents. The file-\u003ekey expansion is probably best done here.","commit_id":"039d4736db77934660ddc1dce0114b9690a911af"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2dc8fc5141e8d9b1f8b1aa9a35704298e0d684f1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                msg\u003d\"Per-instance state is no longer supported, \""},{"line_number":96,"context_line":"                    \"use variable metalsmith_state\""},{"line_number":97,"context_line":"            )"},{"line_number":98,"context_line":"        "},{"line_number":99,"context_line":"        # source keys could be a string or a list of strings"},{"line_number":100,"context_line":"        # and the strings could be a path to a public key or the key contents."},{"line_number":101,"context_line":"        # Normalize this to a list of key contents"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_7f2fe7a6","line":98,"updated":"2020-09-01 18:43:11.000000000","message":"nit: whitespace","commit_id":"d9fe8c96601554c4c300b37d2935908323db30ff"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2f6c9aecbaada1d53b73a5f12ffc054ded01d244","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                msg\u003d\"Per-instance state is no longer supported, \""},{"line_number":96,"context_line":"                    \"use variable metalsmith_state\""},{"line_number":97,"context_line":"            )"},{"line_number":98,"context_line":"        "},{"line_number":99,"context_line":"        # source keys could be a string or a list of strings"},{"line_number":100,"context_line":"        # and the strings could be a path to a public key or the key contents."},{"line_number":101,"context_line":"        # Normalize this to a list of key contents"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f560f44_f32050fb","line":98,"in_reply_to":"9f560f44_7f2fe7a6","updated":"2020-09-01 23:28:32.000000000","message":"Done","commit_id":"d9fe8c96601554c4c300b37d2935908323db30ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aecf29661148100358df19447753209885ff54c0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def transform(module, instances, defaults):"},{"line_number":49,"context_line":"    mi \u003d []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def value(i, key, j, to_key\u003dNone):"},{"line_number":52,"context_line":"        if not to_key:"},{"line_number":53,"context_line":"            to_key \u003d key"},{"line_number":54,"context_line":"        value \u003d i.get(key, defaults.get(key))"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_7fa6a811","line":51,"updated":"2020-09-03 09:25:39.000000000","message":"Meaningful variable names please","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"af0aa8bbdbc83f96a9abd19567d64d69456970a9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"def transform(module, instances, defaults):"},{"line_number":49,"context_line":"    mi \u003d []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def value(i, key, j, to_key\u003dNone):"},{"line_number":52,"context_line":"        if not to_key:"},{"line_number":53,"context_line":"            to_key \u003d key"},{"line_number":54,"context_line":"        value \u003d i.get(key, defaults.get(key))"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_cefc5a40","line":51,"in_reply_to":"9f560f44_7fa6a811","updated":"2020-09-03 22:25:07.000000000","message":"Done","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aecf29661148100358df19447753209885ff54c0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        mi.append(j)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    module.exit_json("},{"line_number":118,"context_line":"        changed\u003dFalse,"},{"line_number":119,"context_line":"        msg\u003d\"{} instances transformed\".format(len(mi)),"},{"line_number":120,"context_line":"        instances\u003dmi"},{"line_number":121,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_dfac14f0","line":118,"updated":"2020-09-03 09:25:39.000000000","message":"This does not look right to me. I suggest returning True if any value has been changed.","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9aaf93b5d3a26711ace6404eee5899c65084140e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        mi.append(j)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    module.exit_json("},{"line_number":118,"context_line":"        changed\u003dFalse,"},{"line_number":119,"context_line":"        msg\u003d\"{} instances transformed\".format(len(mi)),"},{"line_number":120,"context_line":"        instances\u003dmi"},{"line_number":121,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_105e6c75","line":118,"in_reply_to":"9f560f44_6e442e1a","updated":"2020-09-04 03:34:15.000000000","message":"Looking now at tripleo-ansible modules its not consistent whether transformation or read-only modules set changed\u003dTrue","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"93d70ce895503fd367d3535b08271f08049a7dc9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        mi.append(j)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    module.exit_json("},{"line_number":118,"context_line":"        changed\u003dFalse,"},{"line_number":119,"context_line":"        msg\u003d\"{} instances transformed\".format(len(mi)),"},{"line_number":120,"context_line":"        instances\u003dmi"},{"line_number":121,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":17,"id":"9f560f44_6e442e1a","line":118,"in_reply_to":"9f560f44_dfac14f0","updated":"2020-09-03 21:36:01.000000000","message":"I used to do this for data transformation modules like this, but during tripleo-ansible development it was pointed out that \u0027changed\u0027 should really be for changes in the real world (state, modifying API calls, whatever)","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"}],"metalsmith_ansible/roles/metalsmith_deployment/tasks/main.yml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"2dc8fc5141e8d9b1f8b1aa9a35704298e0d684f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- name: Build instance defaults"},{"line_number":4,"context_line":"  metalsmith_deployment_defaults:"},{"line_number":5,"context_line":"    instances: \"{{ metalsmith_instances }}\""},{"line_number":6,"context_line":"    defaults: "},{"line_number":7,"context_line":"      candidates: \"{{ metalsmith_candidates }}\""},{"line_number":8,"context_line":"      capabilities: \"{{ metalsmith_capabilities }}\""},{"line_number":9,"context_line":"      conductor_group: \"{{ metalsmith_conductor_group }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_bf397ff3","line":6,"updated":"2020-09-01 18:43:11.000000000","message":"nit: whitespace","commit_id":"d9fe8c96601554c4c300b37d2935908323db30ff"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"2f6c9aecbaada1d53b73a5f12ffc054ded01d244","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- name: Build instance defaults"},{"line_number":4,"context_line":"  metalsmith_deployment_defaults:"},{"line_number":5,"context_line":"    instances: \"{{ metalsmith_instances }}\""},{"line_number":6,"context_line":"    defaults: "},{"line_number":7,"context_line":"      candidates: \"{{ metalsmith_candidates }}\""},{"line_number":8,"context_line":"      capabilities: \"{{ metalsmith_capabilities }}\""},{"line_number":9,"context_line":"      conductor_group: \"{{ metalsmith_conductor_group }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_53201cf8","line":6,"in_reply_to":"9f560f44_bf397ff3","updated":"2020-09-01 23:28:32.000000000","message":"Done","commit_id":"d9fe8c96601554c4c300b37d2935908323db30ff"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aecf29661148100358df19447753209885ff54c0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Show instances data"},{"line_number":26,"context_line":"  debug:"},{"line_number":27,"context_line":"    msg: \"{{ instances.instances | to_yaml }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Provision instances"},{"line_number":30,"context_line":"  metalsmith_instances:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_bfa7a009","line":27,"updated":"2020-09-03 09:25:39.000000000","message":"Should be removed?","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"93d70ce895503fd367d3535b08271f08049a7dc9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Show instances data"},{"line_number":26,"context_line":"  debug:"},{"line_number":27,"context_line":"    msg: \"{{ instances.instances | to_yaml }}\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Provision instances"},{"line_number":30,"context_line":"  metalsmith_instances:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_ee615eaa","line":27,"in_reply_to":"9f560f44_bfa7a009","updated":"2020-09-03 21:36:01.000000000","message":"Maybe it could be conditional on metalsmith_debug\u003dtrue","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aecf29661148100358df19447753209885ff54c0","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Metalsmith log for reserve instances"},{"line_number":39,"context_line":"  debug:"},{"line_number":40,"context_line":"    var: baremetal_reserved.logging"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_1fb7ac3c","line":40,"updated":"2020-09-03 09:25:39.000000000","message":"Is it possible to only show logging if deployment fails?","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"93d70ce895503fd367d3535b08271f08049a7dc9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Metalsmith log for reserve instances"},{"line_number":39,"context_line":"  debug:"},{"line_number":40,"context_line":"    var: baremetal_reserved.logging"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_8e72627b","line":40,"in_reply_to":"9f560f44_1fb7ac3c","updated":"2020-09-03 21:36:01.000000000","message":"By default you get the full task output when it fails, so this task can be conditional on metalsmith_debug\u003dtrue","commit_id":"88e6a480ef2413eaf8839bbe3e0bfb6360513a73"}],"playbooks/integration/exercise.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"aecf29661148100358df19447753209885ff54c0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  include_role:"},{"line_number":20,"context_line":"    name: metalsmith_deployment"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    metalsmith_extra_args: --debug"},{"line_number":23,"context_line":"    metalsmith_resource_class: baremetal"},{"line_number":24,"context_line":"    metalsmith_instances:"},{"line_number":25,"context_line":"      - hostname: test"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_ffb11846","side":"PARENT","line":22,"updated":"2020-09-03 09:25:39.000000000","message":"We need an alternative to debug here otherwise debugging the CI will be problematic","commit_id":"56066a20a476d33c8732279bed74cd8514b198e7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"93d70ce895503fd367d3535b08271f08049a7dc9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  include_role:"},{"line_number":20,"context_line":"    name: metalsmith_deployment"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    metalsmith_extra_args: --debug"},{"line_number":23,"context_line":"    metalsmith_resource_class: baremetal"},{"line_number":24,"context_line":"    metalsmith_instances:"},{"line_number":25,"context_line":"      - hostname: test"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9f560f44_4edcca45","side":"PARENT","line":22,"in_reply_to":"9f560f44_ffb11846","updated":"2020-09-03 21:36:01.000000000","message":"I\u0027ll create a metalsmith_debug boolean variable","commit_id":"56066a20a476d33c8732279bed74cd8514b198e7"}]}