)]}'
{"id":"openstack%2Fmetalsmith~847099","triplet_id":"openstack%2Fmetalsmith~stable%2Fyoga~Ie6b989f8d67c03606be37310777175cfb8d9303e","project":"openstack/metalsmith","branch":"stable/yoga","topic":"yoga/missing_port","attention_set":{},"removed_from_attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2022-06-24 19:27:46.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie6b989f8d67c03606be37310777175cfb8d9303e","subject":"metalsmith_instances module, unprovision by hostname","status":"MERGED","created":"2022-06-21 21:43:27.000000000","updated":"2022-06-24 19:30:01.000000000","submitted":"2022-06-24 19:27:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"847099-yoga/missing_port","meta_rev_id":"96d72aea0a5478dedb52e5f3ec0f6a1ba4770537","_number":847099,"virtual_id_number":847099,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-24 19:27:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2022-06-24 17:45:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2022-06-24 17:45:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-21 23:11:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-24 17:45:41.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"7a40d318447a15f7ad70b821a1ca47c8acf88924","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-06-21 21:43:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"52f56c6f147f17c5e38770116cb5fcfcca541412","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-21 23:11:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/db9c0ad176dc4524a0af14165e5a3501 : SUCCESS in 2m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/888d9a0c4006416fb59369498a1f7db0 : SUCCESS in 5m 01s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/869788b369a843dbbdbf8a1be171c44e : SUCCESS in 3m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/986d7e875b4f41d3bac89f431c9e1e70 : SUCCESS in 4m 14s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f658307bdebe4a9ab4f5a5efbcd81fbf : SUCCESS in 7m 31s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/7800926cce2243709548c2ab1a1691e4 : SUCCESS in 1h 23m 38s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/5629c8accaf64804a1fc4013ec39502f : SUCCESS in 45m 12s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/e140b44676714fc9a91228401bcede65 : SUCCESS in 44m 15s","accounts_in_message":[],"_revision_number":1},{"id":"3ee732cc25a5a7ffc446c1ab766e9b0063658fe5","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2022-06-24 17:45:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8e9cccd64db07369e386f0f9eea6abe39e186186","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 17:46:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5e7c6db9fcf4b28c8059abf268c24ffdf5734d97","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 19:27:46.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4da9596b1dc04633b1da6133fbb52a5f : SUCCESS in 4m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b1b3b75abf2648b4963cb73085ddc3b3 : SUCCESS in 5m 42s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/178498aacbe54c0c9af277b0a4b6dcda : SUCCESS in 4m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dc471eac37ce4125b2da2d703c9d1b90 : SUCCESS in 6m 57s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/5cd815fa289b4546b2055cfece253080 : SUCCESS in 1h 21m 34s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/c4a19ef2851e4044ab2ba2c58849879a : SUCCESS in 50m 12s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/5c65c0a60989421c93f8a0594b6d6dbe : SUCCESS in 42m 09s","accounts_in_message":[],"_revision_number":1},{"id":"a551e967141936ca1efee33bd5b3d01ffbd926fa","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 19:27:46.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"96d72aea0a5478dedb52e5f3ec0f6a1ba4770537","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 19:30:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a49d2b113f9f4a2196c4f0d7b75cbbe8 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c08d5c20759696a70cf4f7909d15f289782ceec2","revisions":{"c08d5c20759696a70cf4f7909d15f289782ceec2":{"kind":"REWORK","_number":1,"created":"2022-06-21 21:43:27.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/99/847099/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/metalsmith","ref":"refs/changes/99/847099/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/99/847099/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/99/847099/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/99/847099/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/metalsmith refs/changes/99/847099/1"}}},"commit":{"parents":[{"commit":"3e074d93bf17d89675347acd2db5cd505039857a","subject":"metalsmith_instances module, pass hostname in reserve","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/3e074d93bf17d89675347acd2db5cd505039857a"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-06-19 21:52:44.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-06-21 21:43:15.000000000","tz":720},"subject":"metalsmith_instances module, unprovision by hostname","message":"metalsmith_instances module, unprovision by hostname\n\nThe node lookup for unprovision first attempts the allocation name\n(hostname)[1] but the metalsmith_instances unprovision passes the node\nname.\n\nThis means in cases where the node naming scheme and the allocation\nnaming scheme are the same, the wrong node may be unprovisioned.\n\nThis change switches to passing the hostname for unprovision, only\npassing the node name if the hostname is missing from the instances\nentry.\n\n[1] https://opendev.org/openstack/metalsmith/src/branch/master/metalsmith/_provisioner.py#L653\n\nChange-Id: Ie6b989f8d67c03606be37310777175cfb8d9303e\nResolves: rhbz#2092444\n(cherry picked from commit 5459c30ed4eaea7983533e3a2ad3d207f5895dfe)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/c08d5c20759696a70cf4f7909d15f289782ceec2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/c08d5c20759696a70cf4f7909d15f289782ceec2"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}}]}],"submit_requirements":[]}
