)]}'
{"id":"openstack%2Fmetalsmith~847105","triplet_id":"openstack%2Fmetalsmith~stable%2Fwallaby~Ie6b989f8d67c03606be37310777175cfb8d9303e","project":"openstack/metalsmith","branch":"stable/wallaby","topic":"wallaby/missing_port","attention_set":{},"removed_from_attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2022-06-24 23:44:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie6b989f8d67c03606be37310777175cfb8d9303e","subject":"metalsmith_instances module, unprovision by hostname","status":"MERGED","created":"2022-06-21 21:47:19.000000000","updated":"2022-06-24 23:46:47.000000000","submitted":"2022-06-24 23:44:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"847105-wallaby/missing_port","meta_rev_id":"8dd4c7e968e557a7580d18a89259d177fad812db","_number":847105,"virtual_id_number":847105,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-06-24 23:44:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":2,"date":"2022-06-24 19:50:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"all":[{"value":1,"date":"2022-06-24 19:50:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-06-21 23:55:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-06-24 19:49:54.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"CC"},{"updated":"2022-06-24 19:50:04.000000000","updated_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"reviewer":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"state":"REVIEWER"}],"messages":[{"id":"a3c8cf08f0d401d2279a201b4b430536760007cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-06-21 21:47:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc1cb6039a68e4cf24fc780fea6c40bbd5035216","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-21 23:55:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b9dcd1f1c1ff454db0da5b657337b0c3 : SUCCESS in 2m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9f43361159924acbbc1aba654ce358f9 : SUCCESS in 4m 47s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/82c006727dce4d10b5c67a9e9ae438cd : SUCCESS in 5m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0e355a069cee426daa9ec1421f491add : SUCCESS in 4m 42s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a98417afc1c44c2491997f408c62000e : SUCCESS in 5m 48s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/67e744cfe93b416caf52e8a06e087859 : SUCCESS in 7m 46s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/d591792170ab40f7bc96499b6ecf9ae0 : TIMED_OUT in 2h 02m 35s\n- metalsmith-integration-glance-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/b2ddf3dab0164ce4998fa1514aadedad : SUCCESS in 41m 07s\n- metalsmith-integration-http-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/c124f2e8fbdb46e2afbf6ab41bd03541 : SUCCESS in 1h 07m 41s\n- metalsmith-integration-glance-netboot-cirros-iscsi https://zuul.opendev.org/t/openstack/build/338db2f809834aeda3105a88dd137e25 : SUCCESS in 40m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6d1022700701fce43a628d86c1e39e4d76402969","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2022-06-24 19:49:54.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"895c195e33ae67cf7942bfa91025280b1401f2cd","author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"date":"2022-06-24 19:50:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ecfa5ed6ae4ae9654b463dffdeff146d6aec3b99","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 21:14:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d46472a601fa45bda065a01ad44dc60c : SUCCESS in 3m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b11205c52e344576928a907b2a891fc2 : SUCCESS in 6m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c32581ef527e48618ac2ce912c9c1333 : SUCCESS in 5m 35s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8b415cc3f74d4efca17e3d07750a72e6 : SUCCESS in 6m 11s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6860c9df407940a59ef750f5a24602d5 : SUCCESS in 5m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c1bd036593904eeb959806018eb55f28 : SUCCESS in 8m 18s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/0110db58192d4cf196b84e808bf88597 : SUCCESS in 1h 21m 12s\n- metalsmith-integration-glance-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/06c023331c5f4a308b8de07941cdffeb : SUCCESS in 1h 15m 09s\n- metalsmith-integration-http-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/d49487584aa745e4a42d6ae1ab4fcaca : SUCCESS in 1h 03m 05s\n- metalsmith-integration-glance-netboot-cirros-iscsi https://zuul.opendev.org/t/openstack/build/da5183e48fc74a44bf5a2a92444273e1 : SUCCESS in 46m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7ec88c2efb6afc45205ff3b4aecc8eb4faff0263","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 21:45:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6536632bb73a7d6a5cf0ac346c578c653f0bae86","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 23:44:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/50f4233f97b941db9a17d8eb10f7f40b : SUCCESS in 2m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a08b3c26484a40e38c924934ad157df4 : SUCCESS in 5m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/78814c4529c64073852f285916ef36d3 : SUCCESS in 5m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/de7e514e56f44021a8b16e9c8e5dfc4f : SUCCESS in 8m 43s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/3292f1a15bd34180ad05f50dd4de1454 : SUCCESS in 1h 22m 11s\n- metalsmith-integration-glance-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/eada461e428647c0bd2d7a2ff1677e69 : SUCCESS in 50m 17s\n- metalsmith-integration-http-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/291b181a9c9e44fda3847eb4b82badab : SUCCESS in 51m 11s","accounts_in_message":[],"_revision_number":1},{"id":"89984099a9daba25da4c50d52ff3224338ac2d49","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 23:44:54.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"8dd4c7e968e557a7580d18a89259d177fad812db","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-06-24 23:46:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/96abf1f98aad4903a2d97f8bd7fbe235 : SUCCESS in 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1ba2507d8c8589d10a108d5495ae51a7e9064ebf","revisions":{"1ba2507d8c8589d10a108d5495ae51a7e9064ebf":{"kind":"REWORK","_number":1,"created":"2022-06-21 21:47:19.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/05/847105/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/metalsmith","ref":"refs/changes/05/847105/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/05/847105/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/05/847105/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/05/847105/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/metalsmith refs/changes/05/847105/1"}}},"commit":{"parents":[{"commit":"5873507a921c913ea8291e87a5e93d12cf7c9996","subject":"metalsmith_instances module, pass hostname in reserve","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/5873507a921c913ea8291e87a5e93d12cf7c9996"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-06-19 21:52:44.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-06-21 21:47:04.000000000","tz":720},"subject":"metalsmith_instances module, unprovision by hostname","message":"metalsmith_instances module, unprovision by hostname\n\nThe node lookup for unprovision first attempts the allocation name\n(hostname)[1] but the metalsmith_instances unprovision passes the node\nname.\n\nThis means in cases where the node naming scheme and the allocation\nnaming scheme are the same, the wrong node may be unprovisioned.\n\nThis change switches to passing the hostname for unprovision, only\npassing the node name if the hostname is missing from the instances\nentry.\n\n[1] https://opendev.org/openstack/metalsmith/src/branch/master/metalsmith/_provisioner.py#L653\n\nChange-Id: Ie6b989f8d67c03606be37310777175cfb8d9303e\nResolves: rhbz#2092444\n(cherry picked from commit 5459c30ed4eaea7983533e3a2ad3d207f5895dfe)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/1ba2507d8c8589d10a108d5495ae51a7e9064ebf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/1ba2507d8c8589d10a108d5495ae51a7e9064ebf"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"}}]}],"submit_requirements":[]}