)]}'
{"id":"openstack%2Fmetalsmith~849585","triplet_id":"openstack%2Fmetalsmith~stable%2Fxena~I9507f8d30c871ae62a250148789393695d59183a","project":"openstack/metalsmith","branch":"stable/xena","topic":"xena/unprovision_lookup","attention_set":{},"removed_from_attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2022-07-26 22:07:46.000000000","reason":"\u003cGERRIT_ACCOUNT_4571\u003e replied on the change","reason_account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"}}},"hashtags":[],"change_id":"I9507f8d30c871ae62a250148789393695d59183a","subject":"Do a precise node lookup for unprovision","status":"MERGED","created":"2022-07-12 22:22:35.000000000","updated":"2022-07-27 01:46:55.000000000","submitted":"2022-07-27 01:45:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"849585-xena/unprovision_lookup","meta_rev_id":"e7b4fa2723d7578c0485d13426d1c5008f45a76e","_number":849585,"virtual_id_number":849585,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-27 01:45:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-07-26 13:09:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-07-26 13:09:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-12 22:38:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-26 13:09:33.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"}],"messages":[{"id":"cda209b7d3591b14e3ac5e4fc0da0d97ee371be7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-07-12 22:22:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2cbd968c28c0379c60715bb51b83e0909dc0fc41","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-12 22:38:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/eb61c6b0610e45a1a1e273fed68c00cb\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d66fdf49c6344ad39c674ef49cd7251c : SUCCESS in 3m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e5030732f4c94320909356216982d7b9 : SUCCESS in 7m 16s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/51359e0333a240699a6e7ab22f5178f5 : SUCCESS in 4m 07s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/48fbc8522fae41178ec3f57531700c6e : SUCCESS in 4m 23s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/134004a4ed3344049f63332679cdc88c : SUCCESS in 6m 47s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4ef561e90a6c440081d45b79eb8bd467 : SUCCESS in 7m 13s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/d0640a795c8746259d2eea26fc5aa0ab : FAILURE in 7m 11s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/9b2707b82276495a8e8b426399e62721 : FAILURE in 8m 06s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/ef8916a1548d44729df2600ff8b561d8 : FAILURE in 14m 26s","accounts_in_message":[],"_revision_number":1},{"id":"c239e128c230b3db1000a7e34bc92a3d78853879","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-07-13 04:21:34.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"39272732f3029fb3798ab88dadbd075ca13f1837","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-13 06:20:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1b1814e652884b5283e3f993eec8cbdf\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bb26be881cbb459ca67fd57bb9edd5ae : SUCCESS in 3m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e44d5bf250174568a2dac3db45bdd92e : SUCCESS in 5m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bab9cf32d11a4463a9af866ae92babfe : SUCCESS in 4m 17s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c1ee63d2736e4006a47ca6a5b646d9d8 : SUCCESS in 4m 18s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/592ac954e79143349f0fcebcb7e9d691 : SUCCESS in 4m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cdba0d4ca5384afca40ef06bfb201eb7 : SUCCESS in 6m 45s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/ce82718ddfc540198d09b7ec86a3e703 : SUCCESS in 1h 53m 23s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/bad13b5a31d64d6bb3e4ea8f7f6f7bcc : SUCCESS in 1h 09m 36s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/3b9d298d6b49408d8b23500876f9ddf9 : SUCCESS in 1h 07m 16s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/980dedabd2444cb1a3a1f1f09b586a7c : SUCCESS in 6m 33s","accounts_in_message":[],"_revision_number":1},{"id":"fc713c10409b3ff6a5dd213869928909f595ed45","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2022-07-26 13:09:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0e244e9804ee948be3702140b8b0861af19ba8ff","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-26 13:10:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0796abc79809a023024ce241ef78ed356f529e9b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-26 15:25:21.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/5e4e567e473b4d2489c2fb5c4ac58926\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ae757bd4de7b40cfbb235d3afb2697c5 : SUCCESS in 3m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/628328bc08974800a3789fe119606c17 : SUCCESS in 7m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/02fe04b6f82e407b863fe100e87dc49b : SUCCESS in 4m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6d5bb3bdf6ef483eb473bbff628882b7 : SUCCESS in 7m 08s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/f89c028ce1ad4a4c9c6d7a744f490f94 : FAILURE in 36m 25s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/4940ed8bb30a41cebe68aa21ca7c17eb : SUCCESS in 1h 08m 12s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/0b3fe90f5ecd4609962b466e7ec8ca20 : SUCCESS in 1h 08m 32s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/c8e8c79e1f1841a09b8bbdaa30e5fc9c : SUCCESS in 5m 51s","accounts_in_message":[],"_revision_number":1},{"id":"9681677defba3bae4f91e81aa9618709b0610cf0","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-07-26 22:07:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"de87e81a5e7592ccf11753f44df6f3f1f3d665b5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-27 00:11:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/dcdfd8362d274ce98fd6851a628d95c5\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2b1a29a53a284b1e8ae540251dd14e30 : SUCCESS in 3m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/adbb0b26ed194793aff3d4872ed3b3f3 : SUCCESS in 6m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2e5cbc0246584fd589d10e09d00ec7a3 : SUCCESS in 3m 55s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0395ae1b28da4c7792132ebbc395060a : SUCCESS in 4m 09s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6580a7102c384a70ba13ae38f3dfee1d : SUCCESS in 4m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e48de8a1b3cb422fad9bf228dac6d499 : SUCCESS in 6m 51s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/07958e834c4742559939a5b9e8fcc5fc : SUCCESS in 1h 56m 54s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/7189470b3b4547349dc1086483c2ded6 : SUCCESS in 1h 12m 35s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/bc6eed4d69b645f09d50e3a2618633e8 : SUCCESS in 1h 05m 41s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/7930892ce05e46b3b26e47bb25e7f766 : SUCCESS in 6m 08s","accounts_in_message":[],"_revision_number":1},{"id":"a75b59e67488cff4a4728f1b5acc6ea90db53012","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-27 00:12:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"28fdbf53a6d890b370086bde75f1be41037bbe6c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-27 01:45:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/49bade8a01974175867e3412fe528d27\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d7d2998a144a4536926ebee1b5fd427f : SUCCESS in 2m 51s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e6667641b6f04eae8d7f09240f388db7 : SUCCESS in 8m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/87faa4b0cb87415d801c54aca1948eaa : SUCCESS in 4m 13s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b113ec35bf6140a99ec991c1db05a36b : SUCCESS in 5m 41s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/d4fa379d0c774415a31f45b89a9ac9ec : SUCCESS in 1h 33m 47s\n- metalsmith-integration-glance-netboot-cirros https://zuul.opendev.org/t/openstack/build/c16c4eec76f3437b8a1cc42fce2b56e7 : SUCCESS in 47m 09s\n- metalsmith-integration-http-netboot-cirros https://zuul.opendev.org/t/openstack/build/03ed24c9a8b9442385c3363c644345e9 : SUCCESS in 44m 38s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/7c0e78a8610a4715b37fd57ba4c1cb0c : SUCCESS in 7m 52s","accounts_in_message":[],"_revision_number":1},{"id":"f943501f281d41f6b8fa742e846168a78f124555","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-27 01:45:57.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"e7b4fa2723d7578c0485d13426d1c5008f45a76e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-27 01:46:55.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fafe6afb0c4e4164a2463bab196e2e46\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c475e02a48674ccb84cbae86ea2fef2b : SUCCESS in 38s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d494746b65e084c8ef4231c86f9d17497714f173","revisions":{"d494746b65e084c8ef4231c86f9d17497714f173":{"kind":"REWORK","_number":1,"created":"2022-07-12 22:22:35.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/85/849585/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/metalsmith","ref":"refs/changes/85/849585/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/85/849585/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/85/849585/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/85/849585/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/metalsmith refs/changes/85/849585/1"}}},"commit":{"parents":[{"commit":"205a247d6b3cd93a1e20431b21a8e78db8aa07ba","subject":"metalsmith_instances module, unprovision by hostname","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/205a247d6b3cd93a1e20431b21a8e78db8aa07ba"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-07-07 23:08:36.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-07-12 22:22:24.000000000","tz":720},"subject":"Do a precise node lookup for unprovision","message":"Do a precise node lookup for unprovision\n\nA hostname or name is passed to the unprovision call, and the node is\nlooked up by allocation name (hostname), falling back to node name.\n\nThis can result in the wrong node being unprovisioned in the following\nscenario:\n* node and hostname naming scheme are identical\n* node and hostname names are mixed because allocation placement\n  doesn\u0027t take the node name into account\n* a node has already been unprovisioned by hostname (allocation)\n  lookup\n* unprovision is performed a second time, this time matching the\n  hostname with a different node\u0027s name\n* the wrong node is unprovisioned\n\nThe unprovision_node method can also take a node object instead of a\nstring identifier, so this change does a precise node lookup before\ncalling it. This means only hostnames are used for allocation lookups,\nand node names for node lookups.\n\nChange-Id: I9507f8d30c871ae62a250148789393695d59183a\nResolves: rhbz#2092444\n(cherry picked from commit e8ad0c894ba70c2f5d3c103d387bc792e5e1ab9a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/d494746b65e084c8ef4231c86f9d17497714f173"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/d494746b65e084c8ef4231c86f9d17497714f173"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}}]}],"submit_requirements":[]}