)]}'
{"id":"openstack%2Fmetalsmith~849586","triplet_id":"openstack%2Fmetalsmith~stable%2Fwallaby~I9507f8d30c871ae62a250148789393695d59183a","project":"openstack/metalsmith","branch":"stable/wallaby","topic":"wallaby/unprovision_lookup","attention_set":{},"removed_from_attention_set":{"4571":{"account":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"last_update":"2022-07-26 14:28:01.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9507f8d30c871ae62a250148789393695d59183a","subject":"Do a precise node lookup for unprovision","status":"MERGED","created":"2022-07-12 22:24:04.000000000","updated":"2022-07-26 14:29:07.000000000","submitted":"2022-07-26 14:28:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"849586-wallaby/unprovision_lookup","meta_rev_id":"7687a423bd5bc8ab254b587aec740067a71020d7","_number":849586,"virtual_id_number":849586,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-07-26 14:28:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-07-26 12:45:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2022-07-26 12:45:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-12 22:40:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-07-26 12:45:36.000000000","updated_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"reviewer":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"state":"REVIEWER"}],"messages":[{"id":"58ea8b288579f567d92f7fa431ab2a9cc1362a9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-07-12 22:24:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0b515f623b534f251007bf191284207448b83bac","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-12 22:40:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/ff837790a0524f35942282f105a95bd0\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5e2fd189fa184783980ef5d46190d34c : SUCCESS in 3m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0a94ee87e64d45c38591aeff3d047195 : SUCCESS in 4m 58s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2f2ba17c1cbf427b81dbf4044c6dc1ca : SUCCESS in 7m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2d3b3d69cb16451287478c46dddc6d8d : SUCCESS in 6m 09s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/c6fcdcc10c83406d9b23c049ca7c9961 : SUCCESS in 8m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bbe9d59745d64be98fcc8a36d21e7226 : SUCCESS in 8m 19s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/1842a061544d4bc2ba81121a7dd66949 : FAILURE in 14m 35s\n- metalsmith-integration-glance-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/a545fa5973b24d0e964b0eb991da3314 : FAILURE in 7m 59s\n- metalsmith-integration-http-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/377e46ead3cc41bd81af3bee5b8854a5 : FAILURE in 7m 15s\n- metalsmith-integration-glance-netboot-cirros-iscsi https://zuul.opendev.org/t/openstack/build/bba5e63094014e1e81b205e1d0bbb93b : FAILURE in 7m 54s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b239e0dec31ec5467819bef2ae0e988c70c31b47","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2022-07-13 04:21:50.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7fe476892b8260950195c591991705fd9551de6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-13 06:18:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bb9a2ca042424c35afd88d8524981022\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9514a2e9949545eb812d28c462bce444 : SUCCESS in 3m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/818db813c08441338a1f42f8ff76925d : SUCCESS in 5m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e05eabfeafcb41188e590c94cccdce2d : SUCCESS in 6m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7472c6f561df430b8349360da53b8bc5 : SUCCESS in 7m 55s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b9a81c8c3ab64d5290a3ef415fbab84b : SUCCESS in 7m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7f900b22652b4180b8a1a15d3d060229 : SUCCESS in 10m 22s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/d5a89b23d0d6409692c58cf6307145ff : SUCCESS in 1h 50m 18s\n- metalsmith-integration-glance-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/063f789f2cdd477e8ea2d7a6b1ceb13c : SUCCESS in 1h 02m 35s\n- metalsmith-integration-http-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/8bc5f61932064adabf57c2fa0f911bd3 : SUCCESS in 1h 10m 09s\n- metalsmith-integration-glance-netboot-cirros-iscsi https://zuul.opendev.org/t/openstack/build/738cf23db0ee4a0fbbfbbd5254f633a4 : SUCCESS in 1h 05m 18s (non-voting)\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/876031acbfa142028746effdc751ce61 : SUCCESS in 6m 32s","accounts_in_message":[],"_revision_number":1},{"id":"2bd416e4813541a21f406a31513ece2dfbf25d60","author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"date":"2022-07-26 12:45:36.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7a724635e699d8035674c6741a65edfb500fd490","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-26 12:46:09.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"146186da4084b57977b9aee45568b2f1a2a9c4cd","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-26 14:28:01.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6df55178d0694b31af4a2f613b231fc5\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c6570c7c689a463ab093fda1a23d4cab : SUCCESS in 3m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0e1f86ebaa24497aa881fa679d226607 : SUCCESS in 6m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2b4941ddace642c6a086da4f20d657b5 : SUCCESS in 6m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2ecbd79b206740b1aa99e11e5e8a02c3 : SUCCESS in 9m 30s\n- metalsmith-integration-glance-localboot-centos8-uefi https://zuul.opendev.org/t/openstack/build/5fbcbf23cb1f4f229ab09d3e284c6b31 : SUCCESS in 1h 41m 04s\n- metalsmith-integration-glance-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/cd18982dc2fc40a6819ee4274ecee155 : SUCCESS in 59m 41s\n- metalsmith-integration-http-netboot-cirros-direct https://zuul.opendev.org/t/openstack/build/b0f72304bcdc4ca5865eb07ce65b69c7 : SUCCESS in 58m 39s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/f8fd827698494831bd04fbbe68d9ee2d : SUCCESS in 6m 10s","accounts_in_message":[],"_revision_number":1},{"id":"cf480b0f8f3714d45a51b2f4543aeb52671fe6df","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-26 14:28:01.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"7687a423bd5bc8ab254b587aec740067a71020d7","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-26 14:29:07.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9c3830646bf147e5b6b6f60fe5912dd3\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4495f326d302416f97326c6bb51c0199 : SUCCESS in 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8da3eff222eef8cf14873c934116d951e0fc3a9c","revisions":{"8da3eff222eef8cf14873c934116d951e0fc3a9c":{"kind":"REWORK","_number":1,"created":"2022-07-12 22:24:04.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/86/849586/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/metalsmith","ref":"refs/changes/86/849586/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/86/849586/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/86/849586/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/metalsmith refs/changes/86/849586/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/metalsmith refs/changes/86/849586/1"}}},"commit":{"parents":[{"commit":"1ba2507d8c8589d10a108d5495ae51a7e9064ebf","subject":"metalsmith_instances module, unprovision by hostname","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/1ba2507d8c8589d10a108d5495ae51a7e9064ebf"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-07-07 23:08:36.000000000","tz":720},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2022-07-12 22:23:54.000000000","tz":720},"subject":"Do a precise node lookup for unprovision","message":"Do a precise node lookup for unprovision\n\nA hostname or name is passed to the unprovision call, and the node is\nlooked up by allocation name (hostname), falling back to node name.\n\nThis can result in the wrong node being unprovisioned in the following\nscenario:\n* node and hostname naming scheme are identical\n* node and hostname names are mixed because allocation placement\n  doesn\u0027t take the node name into account\n* a node has already been unprovisioned by hostname (allocation)\n  lookup\n* unprovision is performed a second time, this time matching the\n  hostname with a different node\u0027s name\n* the wrong node is unprovisioned\n\nThe unprovision_node method can also take a node object instead of a\nstring identifier, so this change does a precise node lookup before\ncalling it. This means only hostnames are used for allocation lookups,\nand node names for node lookups.\n\nChange-Id: I9507f8d30c871ae62a250148789393695d59183a\nResolves: rhbz#2092444\n(cherry picked from commit e8ad0c894ba70c2f5d3c103d387bc792e5e1ab9a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/8da3eff222eef8cf14873c934116d951e0fc3a9c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/metalsmith/commit/8da3eff222eef8cf14873c934116d951e0fc3a9c"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"}}]}],"submit_requirements":[]}
