)]}'
{"metalsmith/_cmd.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4ea366a6b13bd297f4d3bd5aa4a07cd204708ffb","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ddc56869_94c2cd31","line":250,"updated":"2023-07-05 14:45:34.000000000","message":"*ideally* It should work with OS_CLOUD or OS_AUTH_URL, where as OS_AUTH_URL is not required. Could we get some more background on this issue to understand why your proposing this change.","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"4562505c9b4c1526167ce6177f28471507722cd4","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e7a17208_f90daea2","line":250,"in_reply_to":"52b1ec3a_bc5b0cd0","updated":"2023-07-05 21:05:32.000000000","message":"Can I suggest that we catch the specific exception and print it differently? Chances are the string for that exception can be printed, but with something other than LOG.critical, and maybe with further suggestion to source some credentials.","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"33c7cb4db1c638365c0b51492c4b1e58a764b035","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"52b1ec3a_bc5b0cd0","line":250,"in_reply_to":"ddc56869_94c2cd31","updated":"2023-07-05 15:23:01.000000000","message":"I think it\u0027s always better to display an message instead to get an exception. It\u0027s why I propose this change.","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"72e9dbf553d26cec435066ed5fe917c7eba58046","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fc17875f_65a3698b","line":250,"in_reply_to":"e7a17208_f90daea2","updated":"2023-07-06 12:06:12.000000000","message":"Hi Steve,\n\nYes sure we can. I have use the critical because the project use already it to display other message when we get an exception error, but I can change it.","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da26faa3b15f8d69a0e34f48e79c1e96494925a3","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4b54855d_596714a1","line":250,"in_reply_to":"fc17875f_65a3698b","updated":"2023-07-19 20:09:00.000000000","message":"realistically:\n\nif not os.environ.get(\u0027OS_AUTH_URL\u0027) and not os.environ.get(\u0027OS_CLOUD\u0027)\n\nwould at least allow for both cases.\n\nAs for the error message, perhaps \"Please provide an OS_CLOUD environment variable *or* appropriate environment variables for authentication.. As it stands today, I\u0027m very -1 against saying \"undercloudrc\" file since it is a TripleO-ism specific file name.","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4ea366a6b13bd297f4d3bd5aa4a07cd204708ffb","unresolved":true,"context_lines":[{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    config \u003d os_config.OpenStackConfig()"}],"source_content_type":"text/x-python","patch_set":1,"id":"52bd44cd_924493ea","line":251,"updated":"2023-07-05 14:45:34.000000000","message":"So this is a TripleO specific file. Perhaps \"Unable to locate credentials.\" Any other ideas?","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"33c7cb4db1c638365c0b51492c4b1e58a764b035","unresolved":true,"context_lines":[{"line_number":248,"context_line":"def main(args\u003dsys.argv[1:]):"},{"line_number":249,"context_line":"    # To display a message if the undercloudrc file was not source"},{"line_number":250,"context_line":"    if not os.environ.get(\u0027OS_AUTH_URL\u0027, \u0027\u0027):"},{"line_number":251,"context_line":"        LOG.critical(\u0027Please source the undercloudrc file\u0027)"},{"line_number":252,"context_line":"        sys.exit(1)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    config \u003d os_config.OpenStackConfig()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f03a8f06_dcb18a23","line":251,"in_reply_to":"52bd44cd_924493ea","updated":"2023-07-05 15:23:01.000000000","message":"Right that sounds better.","commit_id":"9fd2041b4f92166561a40a4cda2c2116d959be20"}]}
