)]}'
{"id":"openstack%2Fmicroversion-parse~303404","triplet_id":"openstack%2Fmicroversion-parse~master~I9775c5d87890c8ff4a6072c600d54fa47264fa9f","project":"openstack/microversion-parse","branch":"master","topic":"remove-keyword-service_type","hashtags":[],"change_id":"I9775c5d87890c8ff4a6072c600d54fa47264fa9f","subject":"Make service_type a positional argument","status":"MERGED","created":"2016-04-08 13:03:09.000000000","updated":"2016-04-08 16:35:05.000000000","submitted":"2016-04-08 16:35:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ad3ccbed03089163e2de4f5a931f01e40c1c1ade","_number":303404,"virtual_id_number":303404,"owner":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-04-08 16:35:05.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-08 13:05:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":2,"date":"2016-04-08 16:31:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"value":1,"date":"2016-04-08 16:31:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-08 13:05:44.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"},{"updated":"2016-04-08 16:31:37.000000000","updated_by":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"reviewer":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"state":"REVIEWER"},{"updated":"2016-04-08 16:35:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c20d12cef239a98c267cf93e8d544dcd2d7de4dc","author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"date":"2016-04-08 13:03:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd8b128dabe3833c8e454e9749d7b79cbf97bd11","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2016-04-08 13:05:44.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks, I think that assert is a holdover from a previous iteration, when there was still indecision over whether service_type would or would not be required. Basically left over cruft.","accounts_in_message":[],"_revision_number":1},{"id":"993b775c495b25ec828fea435f9e3576a5fea623","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-08 13:19:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-microversion-parse-docs http://docs-draft.openstack.org/04/303404/1/check/gate-microversion-parse-docs/8889519//doc/build/html/ : SUCCESS in 3m 09s\n- gate-microversion-parse-pep8 http://logs.openstack.org/04/303404/1/check/gate-microversion-parse-pep8/b8a2033/ : SUCCESS in 1m 21s\n- gate-microversion-parse-python27 http://logs.openstack.org/04/303404/1/check/gate-microversion-parse-python27/6e4aa81/ : SUCCESS in 2m 26s\n- gate-microversion-parse-python34 http://logs.openstack.org/04/303404/1/check/gate-microversion-parse-python34/a86970a/ : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":1},{"id":"c4a788d1df40aae7c820f1e17d8a71d2ce7ea5dd","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-08 16:31:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f66fedf80648dbdf6d0433b0e883924604d2a5a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-08 16:31:42.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c6d0e04c1fdbb632321628e516a51de69feb2092","date":"2016-04-08 16:35:05.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"717f17cacce4900e23f6ff0e51df3e9dd02a07ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-08 16:35:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-microversion-parse-docs http://docs-draft.openstack.org/04/303404/1/gate/gate-microversion-parse-docs/5c0a216//doc/build/html/ : SUCCESS in 2m 55s\n- gate-microversion-parse-pep8 http://logs.openstack.org/04/303404/1/gate/gate-microversion-parse-pep8/1d0ee52/ : SUCCESS in 1m 17s\n- gate-microversion-parse-python27 http://logs.openstack.org/04/303404/1/gate/gate-microversion-parse-python27/b807116/ : SUCCESS in 2m 26s\n- gate-microversion-parse-python34 http://logs.openstack.org/04/303404/1/gate/gate-microversion-parse-python34/d7583e7/ : SUCCESS in 1m 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4b04aaf3b235821e97829379c460ca74437f5dec","revisions":{"4b04aaf3b235821e97829379c460ca74437f5dec":{"kind":"REWORK","_number":1,"created":"2016-04-08 13:03:09.000000000","uploader":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"ref":"refs/changes/04/303404/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/microversion-parse","ref":"refs/changes/04/303404/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/04/303404/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/04/303404/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/microversion-parse refs/changes/04/303404/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/microversion-parse refs/changes/04/303404/1"}}},"commit":{"parents":[{"commit":"2f044aae4e48527a7afb94941643c3446197076f","subject":"Include README.rst content on doc index","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/2f044aae4e48527a7afb94941643c3446197076f"}]}],"author":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2016-04-08 12:31:04.000000000","tz":60},"committer":{"name":"Louis Taylor","email":"louis@kragniz.eu","date":"2016-04-08 13:03:08.000000000","tz":60},"subject":"Make service_type a positional argument","message":"Make service_type a positional argument\n\nThis removes the assert to ensure a value for service_type is set. The\nkeyword style of calling can still be used, so\n\n    microversion_parse.get_version(headers, service_type\u003d\u0027compute\u0027)\n\nwill remain working.\n\nUsing an assert for this is probably inadvisable, since it will be\nstripped away if python is run with -O.\n\nChange-Id: I9775c5d87890c8ff4a6072c600d54fa47264fa9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/4b04aaf3b235821e97829379c460ca74437f5dec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/microversion-parse/commit/4b04aaf3b235821e97829379c460ca74437f5dec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}